18041 2008-03-24 00:51:05 -0700 DOMNodeRemoved events are sent twice 2008-06-08 12:42:31 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P2 Normal --- 6590 1 illenberger webkit-unassigned ap aroben oldest_to_newest 74951 0 illenberger 2008-03-24 00:51:05 -0700 When a node is removed from a DOMDocument, observers of the DOMNodeRemoved event are notified twice for each change when they should only be notified once. I could track down the reason for this behavior to ContainerNode.cpp where the same event is fired explicitly in line 390 and directly afterwards via willRemoveChild/dispatchChildRemovalEvents. Most probably, the explicit sending of the event in line 390 has to be removed. 75524 1 20137 ap 2008-03-27 14:58:11 -0700 Created attachment 20137 test case 75526 2 ap 2008-03-27 15:00:56 -0700 Confirmed with r31309. 80540 3 21174 magic 2008-05-15 13:16:00 -0700 Created attachment 21174 Patch As mentioned in the report, remove the dispatchEvent line 390 fix the bug. 81403 4 21174 darin 2008-05-24 22:47:19 -0700 Comment on attachment 21174 Patch Code change looks perfect. Oops! The patch needs to include the results of the regression test. That's the DOMNodeRemovedEvent -expected.txt file. The regression test should be turned into a text-only test so it doesn't dump the layout of the elements. That can be done by adding this code: if (window.layoutTestController) layoutTestController.dumpAsText(); to the test. By doing this, you'll make the test work as-is cross-platform and also eliminate the need to check in "pixel test results". Please resubmit the patch with a corrected regression test, and we'll get this checked in. 81473 5 21340 magic 2008-05-25 13:49:23 -0700 Created attachment 21340 Patch + expected file I rewrote the test case to use the shouldBe methods (and added the expected file). 81475 6 21340 darin 2008-05-25 13:50:30 -0700 Comment on attachment 21340 Patch + expected file Looks fine. r=me 82638 7 darin 2008-06-08 12:42:31 -0700 Committed revision 34450. 20137 2008-03-27 14:58:11 -0700 2008-03-27 14:58:11 -0700 test case DOMNodeRemoved.html text/html 297 ap PGJvZHk+CjxwPkRPTU5vZGVSZW1vdmVkIHNob3VsZCBiZSBwcmludGVkIG9uY2U6PC9wPgo8ZGl2 PjxkaXY+PC9kaXY+PC9kaXY+CjxzY3JpcHQ+CiAgdmFyIGRpdjEgPSBkb2N1bWVudC5nZXRFbGVt ZW50c0J5VGFnTmFtZSgiZGl2IilbMF07CiAgZGl2MS5hZGRFdmVudExpc3RlbmVyKCJET01Ob2Rl UmVtb3ZlZCIsIGZ1bmN0aW9uKCkgeyBkb2N1bWVudC53cml0ZSgiRE9NTm9kZVJlbW92ZWQ8cD4i KTsgfSwgZmFsc2UpOwogIGRpdjEucmVtb3ZlQ2hpbGQoZGl2MS5maXJzdENoaWxkKTsKPC9zY3Jp cHQ+CjwvYm9keT4K 21174 2008-05-15 13:16:00 -0700 2008-05-25 13:49:23 -0700 Patch 18041.diff text/plain 2382 magic SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMzQ5MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDUtMTUgIFZpbmNlbnQgUmljYXJkICA8bWFnaWNAbWFnaWNu aW5qYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQnVnIDE4MDQxOiBET01Ob2RlUmVtb3ZlZCBldmVudHMgYXJlIHNlbnQgdHdpY2UKKworICAg ICAgICBUZXN0OiBmYXN0L2RvbS9Ob2RlL0RPTU5vZGVSZW1vdmVkRXZlbnQuaHRtbAorCisgICAg ICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGFpbmVy Tm9kZTo6cmVtb3ZlQ2hpbGQpOgorCiAyMDA4LTA1LTE1ICBKdWxpZW4gQ2hhZmZyYWl4ICA8amNo YWZmcmFpeEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluLgpJbmRleDog V2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20v Q29udGFpbmVyTm9kZS5jcHAJKHJldmlzaW9uIDMzNDkxKQorKysgV2ViQ29yZS9kb20vQ29udGFp bmVyTm9kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4NCwxNCArMzg0LDYgQEAgYm9vbCBDb250 YWluZXJOb2RlOjpyZW1vdmVDaGlsZChOb2RlKiBvbAogICAgIH0KIAogICAgIFJlZlB0cjxOb2Rl PiBjaGlsZCA9IG9sZENoaWxkOwotICAgIAotICAgIC8vIGRpc3BhdGNoIHByZS1yZW1vdmFsIG11 dGF0aW9uIGV2ZW50cwotICAgIGlmIChkb2N1bWVudCgpLT5oYXNMaXN0ZW5lclR5cGUoRG9jdW1l bnQ6OkRPTU5PREVSRU1PVkVEX0xJU1RFTkVSKSkgewotICAgICAgICBFdmVudFRhcmdldE5vZGVD YXN0KGNoaWxkLmdldCgpKS0+ZGlzcGF0Y2hFdmVudChuZXcgTXV0YXRpb25FdmVudChET01Ob2Rl UmVtb3ZlZEV2ZW50LCB0cnVlLCBmYWxzZSwKLSAgICAgICAgICAgIHRoaXMsIFN0cmluZygpLCBT dHJpbmcoKSwgU3RyaW5nKCksIDApLCBlYywgdHJ1ZSk7Ci0gICAgICAgIGlmIChlYykKLSAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9CiAKICAgICBlYyA9IHdpbGxSZW1vdmVDaGlsZChj aGlsZC5nZXQoKSk7CiAgICAgaWYgKGVjKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMzM0OTMpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAw OC0wNS0xNSAgVmluY2VudCBSaWNhcmQgIDxtYWdpY0BtYWdpY25pbmphLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IGNhc2UgZm9yCisg ICAgICAgIEJ1ZyAxODA0MTogRE9NTm9kZVJlbW92ZWQgZXZlbnRzIGFyZSBzZW50IHR3aWNlCisK KyAgICAgICAgKiBmYXN0L2RvbS9Ob2RlL0RPTU5vZGVSZW1vdmVkRXZlbnQuaHRtbDogQWRkZWQu CisKIDIwMDgtMDUtMTUgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9Ob2RlL0RPTU5vZGVSZW1vdmVkRXZlbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2RvbS9Ob2RlL0RPTU5vZGVSZW1vdmVkRXZlbnQuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvRE9NTm9kZVJlbW92ZWRFdmVudC5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKKzxib2R5PgorPHA+RE9NTm9kZVJlbW92ZWQgc2hvdWxk IGJlIHByaW50ZWQgb25jZTo8L3A+Cis8ZGl2PjxkaXY+PC9kaXY+PC9kaXY+Cis8c2NyaXB0Pgor ICB2YXIgZGl2MSA9IGRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJkaXYiKVswXTsKKyAg ZGl2MS5hZGRFdmVudExpc3RlbmVyKCJET01Ob2RlUmVtb3ZlZCIsIGZ1bmN0aW9uKCkgeyBkb2N1 bWVudC53cml0ZSgiRE9NTm9kZVJlbW92ZWQ8cD4iKTsgfSwgZmFsc2UpOworICBkaXYxLnJlbW92 ZUNoaWxkKGRpdjEuZmlyc3RDaGlsZCk7Cis8L3NjcmlwdD4KKzwvYm9keT4K 21340 2008-05-25 13:49:23 -0700 2008-05-25 13:50:30 -0700 Patch + expected file 18041.diff text/plain 3804 magic SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNDEyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDUtMjUgIFZpbmNlbnQgUmljYXJkICA8bWFnaWNAbWFnaWNu aW5qYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQnVnIDE4MDQxOiBET01Ob2RlUmVtb3ZlZCBldmVudHMgYXJlIHNlbnQgdHdpY2UKKworICAg ICAgICBUZXN0OiBmYXN0L2RvbS9Ob2RlL0RPTU5vZGVSZW1vdmVkRXZlbnQuaHRtbAorCisgICAg ICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGFpbmVy Tm9kZTo6cmVtb3ZlQ2hpbGQpOgorCiAyMDA4LTA1LTI1ICBEYW4gQmVybnN0ZWluICA8bWl0ekBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJD b3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Db250 YWluZXJOb2RlLmNwcAkocmV2aXNpb24gMzQxMjYpCisrKyBXZWJDb3JlL2RvbS9Db250YWluZXJO b2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzg0LDE0ICszODQsNiBAQCBib29sIENvbnRhaW5l ck5vZGU6OnJlbW92ZUNoaWxkKE5vZGUqIG9sCiAgICAgfQogCiAgICAgUmVmUHRyPE5vZGU+IGNo aWxkID0gb2xkQ2hpbGQ7Ci0gICAgCi0gICAgLy8gZGlzcGF0Y2ggcHJlLXJlbW92YWwgbXV0YXRp b24gZXZlbnRzCi0gICAgaWYgKGRvY3VtZW50KCktPmhhc0xpc3RlbmVyVHlwZShEb2N1bWVudDo6 RE9NTk9ERVJFTU9WRURfTElTVEVORVIpKSB7Ci0gICAgICAgIEV2ZW50VGFyZ2V0Tm9kZUNhc3Qo Y2hpbGQuZ2V0KCkpLT5kaXNwYXRjaEV2ZW50KG5ldyBNdXRhdGlvbkV2ZW50KERPTU5vZGVSZW1v dmVkRXZlbnQsIHRydWUsIGZhbHNlLAotICAgICAgICAgICAgdGhpcywgU3RyaW5nKCksIFN0cmlu ZygpLCBTdHJpbmcoKSwgMCksIGVjLCB0cnVlKTsKLSAgICAgICAgaWYgKGVjKQotICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwotICAgIH0KIAogICAgIGVjID0gd2lsbFJlbW92ZUNoaWxkKGNoaWxk LmdldCgpKTsKICAgICBpZiAoZWMpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzNDEyNykKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDA4LTA1 LTI1ICBWaW5jZW50IFJpY2FyZCAgPG1hZ2ljQG1hZ2ljbmluamEub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgY2FzZSBmb3IKKyAgICAg ICAgQnVnIDE4MDQxOiBET01Ob2RlUmVtb3ZlZCBldmVudHMgYXJlIHNlbnQgdHdpY2UKKworICAg ICAgICAqIGZhc3QvZG9tL05vZGUvRE9NTm9kZVJlbW92ZWRFdmVudC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvZG9tL05vZGUvRE9NTm9kZVJlbW92ZWRFdmVudC5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9Ob2RlL3Jlc291cmNlcy9ET01Ob2RlUmVtb3ZlZEV2 ZW50LmpzOiBBZGRlZC4KKwogMjAwOC0wNS0yNSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9kb20vTm9kZS9ET01Ob2RlUmVtb3ZlZEV2ZW50LWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL0RPTU5vZGVSZW1vdmVkRXZlbnQtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vTm9kZS9ET01O b2RlUmVtb3ZlZEV2ZW50LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBA QAorVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IERPTU5vZGVSZW1vdmVkRXZlbnQgaXMgZW1pdHRlZCBv bmNlIChhbmQgb25seSBvbmNlKS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BB U1MgY291bnQgaXMgMQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENP TVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvRE9NTm9kZVJlbW92ZWRF dmVudC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvRE9NTm9k ZVJlbW92ZWRFdmVudC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20v Tm9kZS9ET01Ob2RlUmVtb3ZlZEV2ZW50Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMg QEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1s PgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzL3Jlc291cmNl cy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pz LXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0 aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJj ZXMvRE9NTm9kZVJlbW92ZWRFdmVudC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9Ob2RlL3Jlc291cmNlcy9ET01Ob2RlUmVtb3Zl ZEV2ZW50LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL05vZGUvcmVzb3Vy Y2VzL0RPTU5vZGVSZW1vdmVkRXZlbnQuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2RvbS9Ob2RlL3Jlc291cmNlcy9ET01Ob2RlUmVtb3ZlZEV2ZW50LmpzCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDEyIEBACitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0IGNoZWNrcyB0aGF0IERP TU5vZGVSZW1vdmVkRXZlbnQgaXMgZW1pdHRlZCBvbmNlIChhbmQgb25seSBvbmNlKS4iKTsKKwor dmFyIGRpdiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworZG9jdW1lbnQuYm9keS5h cHBlbmRDaGlsZChkaXYpOworCit2YXIgY291bnQgPSAwOworZG9jdW1lbnQuYm9keS5hZGRFdmVu dExpc3RlbmVyKCJET01Ob2RlUmVtb3ZlZCIsIGZ1bmN0aW9uICgpIHsgY291bnQrKzsgfSwgZmFs c2UpOworZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChkaXYpOworCitzaG91bGRCZSgiY291bnQi LCAiMSIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK