180346 2017-12-04 03:12:58 -0800 Improve downcast of MathML element classes 2017-12-04 03:12:58 -0800 1 1 1 Unclassified WebKit MathML WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 161300 1 fred.wang webkit-unassigned darin lambda oldest_to_newest 1377638 0 fred.wang 2017-12-04 03:12:58 -0800 See bug 161300 comment 3. Currently we only have a SPECIALIZE_TYPE_TRAITS macro for the base MathMLElement class and we use static_cast in renderer classes: fred@igalia-fwang:~/src-obj/webkit/WebKit$ grep MathML Source/WebCore/rendering/mathml/* | grep 'nodeForNonAnonymous' Source/WebCore/rendering/mathml/RenderMathMLFraction.h: MathMLFractionElement& element() const { return static_cast<MathMLFractionElement&>(nodeForNonAnonymous()); } Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp: return static_cast<MathMLOperatorElement&>(nodeForNonAnonymous()); Source/WebCore/rendering/mathml/RenderMathMLPadded.h: MathMLPaddedElement& element() const { return static_cast<MathMLPaddedElement&>(nodeForNonAnonymous()); } Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp: return static_cast<MathMLRootElement&>(nodeForNonAnonymous()); Source/WebCore/rendering/mathml/RenderMathMLRow.cpp: return static_cast<MathMLRowElement&>(nodeForNonAnonymous()); Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp: return static_cast<MathMLScriptsElement&>(nodeForNonAnonymous()); Source/WebCore/rendering/mathml/RenderMathMLSpace.h: MathMLSpaceElement& element() const { return static_cast<MathMLSpaceElement&>(nodeForNonAnonymous()); } Source/WebCore/rendering/mathml/RenderMathMLToken.cpp: return static_cast<MathMLTokenElement&>(nodeForNonAnonymous()); Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp: return static_cast<MathMLUnderOverElement&>(nodeForNonAnonymous());