180302 2017-12-01 17:59:12 -0800 webkitpy EWS keeps retrying a failing patch 2017-12-03 16:58:07 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=178480 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates ews-watchlist glenn lforschler webkit-bug-importer oldest_to_newest 1377203 0 aakash_jain 2017-12-01 17:59:12 -0800 If a patch fails webkipy-tests, webkitpy-ews keeps retrying it indefinitely. e.g.: https://webkit-queues.webkit.org/patch/326588/webkitpy-ews 1377204 1 328200 aakash_jain 2017-12-01 18:04:49 -0800 Created attachment 328200 Proposed patch 1377551 2 328200 commit-queue 2017-12-03 16:28:15 -0800 Comment on attachment 328200 Proposed patch Clearing flags on attachment: 328200 Committed r225466: <https://trac.webkit.org/changeset/225466> 1377552 3 commit-queue 2017-12-03 16:28:17 -0800 All reviewed patches have been landed. Closing bug. 1377553 4 webkit-bug-importer 2017-12-03 16:29:42 -0800 <rdar://problem/35820856> 1377556 5 aakash_jain 2017-12-03 16:58:07 -0800 This change seems to work fine. Tested in https://webkit-queues.webkit.org/patch/328315/webkitpy-ews 328200 2017-12-01 18:04:49 -0800 2017-12-03 16:28:15 -0800 Proposed patch webkipy_ews_retry.patch text/plain 1558 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNTQ0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTEyLTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweSBFV1Mga2VlcHMgcmV0cnlpbmcgYSBmYWlsaW5nIHBhdGNo CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODAzMDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvdG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHk6CisgICAgICAgIChQYXRj aEFuYWx5c2lzVGFzay5fdGVzdF9wYXRjaCk6IEluc3RlYWQgb2YgcmV0dXJuaW5nIGZhbHNlLCBj YWxsIHJlcG9ydF9mYWlsdXJlKCkgCisgICAgICAgIHdoaWNoIHJhaXNlcyBhbiBleGNlcHRpb24s IHRoaXMgZXhjZXB0aW9uIGlzIGNhdGNoZWQgYnkgZWFybHl3YXJuaW5nc3lzdGVtLnB5IGFuZAor ICAgICAgICBpdCBwb3N0cyBhIGNvbW1lbnQgb24gYnVnemlsbGEuIFJldHVybmluZyBmYWxzZSBz aW1wbHkgdW5sb2NrcyB0aGUgcGF0Y2ggYW5kIHJldHVybnMKKyAgICAgICAgaXQgdG8gdGhlIHF1 ZXVlLgorCiAyMDE3LTEyLTAxICBEZXdlaSBaaHUgIDxkZXdlaV96aHVAYXBwbGUuY29tPgogCiAg ICAgICAgIEhhcmRjb2RlZCBweXRob24gcGF0aCBpcyBub3QgY29tcGF0aWJsZSB3aXRoIHZpcnR1 YWwgZW52aXJvbm1lbnQuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3Bh dGNoYW5hbHlzaXN0YXNrLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHkJKHJldmlzaW9uIDIyNTQ0MCkKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvcGF0Y2hhbmFseXNpc3Rhc2sucHkJKHdvcmtpbmcg Y29weSkKQEAgLTM2OSw3ICszNjksNyBAQCBjbGFzcyBQYXRjaEFuYWx5c2lzVGFzayhvYmplY3Qp OgogICAgICAgICBlbGlmIGhhc2F0dHIoc2VsZi5fZGVsZWdhdGUsICdncm91cCcpIGFuZCBzZWxm Ll9kZWxlZ2F0ZS5ncm91cCgpID09ICJiaW5kaW5ncyI6CiAgICAgICAgICAgICByZXR1cm4gc2Vs Zi5fcmV0cnlfYmluZGluZ3NfdGVzdHMoKQogICAgICAgICBlbGlmIGhhc2F0dHIoc2VsZi5fZGVs ZWdhdGUsICdncm91cCcpIGFuZCBzZWxmLl9kZWxlZ2F0ZS5ncm91cCgpID09ICJ3ZWJraXRweSI6 Ci0gICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAgICAgIHJldHVybiBzZWxmLnJlcG9y dF9mYWlsdXJlKCkKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9yZXRy eV9sYXlvdXRfdGVzdHMoKQogCg==