180233 2017-11-30 19:39:54 -0800 [GTK] Turn on ENABLE_MEDIA_SOURCE 2017-12-04 04:32:29 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED DUPLICATE 167107 P2 Normal --- 1 mcatanzaro mcatanzaro aboya bugs-noreply clopez mcatanzaro oldest_to_newest 1376692 0 mcatanzaro 2017-11-30 19:39:54 -0800 Turn on ENABLE_MEDIA_SOURCE It's still disabled at runtime. We had previously agreed to enable media source ASAP so that it can get as much testing as possible during the development cycle, but this stalled due to $CONCERNS. Now, after discussing with Alicia, I think we are close to being able to toggle the runtime default, but not quite yet as there are a few essential patches that are not yet upstream. So we can consider the runtime flag in a separate bug. But there is no reason to leave the build flag turned off. The build flag does not seem to break anything. This will make it possible to test MSE in MiniBrowser without having to rebuild WebKit. 1376693 1 328067 mcatanzaro 2017-11-30 19:40:28 -0800 Created attachment 328067 Patch 1376694 2 mcatanzaro 2017-11-30 19:43:11 -0800 Note: this will break the Debian stable bot again, since its GStreamer is not new enough. It will need to be taught to build with -DENABLE_MEDIA_SOURCE=OFF. I don't know how to do that. That reminds me, this is not ready for cq+ because the GStreamer dependency is not defined anywhere in CMake. The build needs to fail at the CMake stage if GStreamer is not new enough for MSE. I don't know what version of GStreamer is required; we'll need Alicia or Enrique to comment on that. 1376779 3 clopez 2017-12-01 04:18:50 -0800 (In reply to Michael Catanzaro from comment #2) > Note: this will break the Debian stable bot again, since its GStreamer is > not new enough. It will need to be taught to build with > -DENABLE_MEDIA_SOURCE=OFF. I don't know how to do that. > I will do that > That reminds me, this is not ready for cq+ because the GStreamer dependency > is not defined anywhere in CMake. The build needs to fail at the CMake stage > if GStreamer is not new enough for MSE. I don't know what version of > GStreamer is required; we'll need Alicia or Enrique to comment on that. "Thanks" to the slow restart of the master in https://bugs.webkit.org/show_bug.cgi?id=177338#c45 we know that this feature built fine on Ubuntu 16.04 but not on Debian jessie (oldstable). Debian jessie has gstreamer 1.4 and Ubuntu LTS has 1.8. Therefore the minimum version is either 1.6 or 1.8 But from the above link we know also that this depends on GST_BUFFER_DTS_OR_PTS definition that appeared on GStreamer 1.8. Therefore: this is your number: 1.8 is the minimum version, please upload a new patch making this depend on gst >= 1.8 1376780 4 328067 clopez 2017-12-01 04:19:15 -0800 Comment on attachment 328067 Patch This feature should depend on gst => 1.8 1376784 5 clopez 2017-12-01 04:26:32 -0800 (In reply to Carlos Alberto Lopez Perez from comment #3) > (In reply to Michael Catanzaro from comment #2) > > Note: this will break the Debian stable bot again, since its GStreamer is > > not new enough. It will need to be taught to build with > > -DENABLE_MEDIA_SOURCE=OFF. I don't know how to do that. > > > > I will do that > Done: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/7950/steps/compile-webkit/logs/stdio This was done by simply setting on the machine: export BUILD_WEBKIT_ARGS="--cmakeargs=-DENABLE_MEDIA_SOURCE=OFF --cmakeargs=-DUSE_WOFF2=OFF" 1376794 6 clopez 2017-12-01 05:30:37 -0800 Also please use the previous bug for this *** This bug has been marked as a duplicate of bug 167107 *** 1376803 7 mcatanzaro 2017-12-01 07:23:32 -0800 Maybe we should use this bug for enabling the build option, but keep the previous bug around for enabling the runtime option? Because I am not turning on MSE by default: it will still be off at runtime. 1377659 8 aboya 2017-12-04 04:32:29 -0800 (In reply to Carlos Alberto Lopez Perez from comment #3) > But from the above link we know also that this depends on > GST_BUFFER_DTS_OR_PTS definition that appeared on GStreamer 1.8. GST_BUFFER_DTS_OR_PTS() is a trivial utility macro, it could be recreated in WebKit easily. I'm more worried about matroskademux patches. 328067 2017-11-30 19:40:28 -0800 2017-12-01 04:19:15 -0800 Patch bug-180233-20171130214027.patch text/plain 1411 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDY5ODQ1 ZWRjYzBhN2ZhODU0MTdmZTdjMWJiZDNmZTY1MjU3YTZiYmYuLjA3M2UzMDk0NzQwYjE3N2M1NTgz ODdkMzM2OTIxZjIyMjI5ODA3MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNDIsNyArMTQy LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0RPV05MT0FEX0FU VFJJQlVURSBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX0ZUUERJUiBQUklWQVRFIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9JTlBVVF9UWVBFX0NPTE9SIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFV TFRfUE9SVF9WQUxVRShFTkFCTEVfTUhUTUwgUFJJVkFURSBPTikKLVdFQktJVF9PUFRJT05fREVG QVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRURJQV9TT1VSQ0UgUFJJVkFURSAke0VOQUJMRV9FWFBF UklNRU5UQUxfRkVBVFVSRVN9KQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX01FRElBX1NPVVJDRSBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRf VkFMVUUoRU5BQkxFX01FRElBX1NUUkVBTSBQUklWQVRFICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9G RUFUVVJFU30pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfV0VCX1JU QyBQUklWQVRFICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9GRUFUVVJFU30pCiAKZGlmZiAtLWdpdCBh L0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyNWZhNDc5YTQ2Y2MzZGMxYmFiNTA3YjRjNzRi NWMxN2FkMTZiYzU3Li4zZTE3ZGRjOTU3ZjYwNmQzMzBlZTM3MWJmYmMwYmZmNGU1OGExM2FlIDEw MDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIw MTctMTEtMzAgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIFR1cm4gb24gRU5BQkxFX01FRElBX1NPVVJDRQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgwMjMzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dU Sy5jbWFrZToKKwogMjAxNy0xMS0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBNYWMgQ01ha2UgYnVpbGQuCg==