179989 2017-11-23 17:10:33 -0800 [GTK] Some features have changed of value (13 new failures) 2018-02-20 14:05:45 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=180004 P2 Normal --- 177338 1 clopez rego bugs-noreply cgarcia jfernandez mcatanzaro rego svillar oldest_to_newest 1374496 0 clopez 2017-11-23 17:10:33 -0800 Meanwhile doing gardening I noticed that r225098 <https://trac.webkit.org/r225098> has caused 12 new failures on the GTK+ port: The new failures: http/tests/misc/prefetch-purpose.html [ Timeout ] http/tests/misc/link-rel-prefetch-and-subresource.html [ Timeout ] fast/dom/HTMLLinkElement/subresource.html [ Timeout ] fast/dom/HTMLLinkElement/prefetch-onload.html [ Timeout ] fast/dom/HTMLLinkElement/prefetch-onerror.html [ Timeout ] fast/dom/HTMLLinkElement/prefetch.html [ Timeout ] fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ Timeout ] fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Timeout ] fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html [ Failure ] fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html [ Failure ] fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html [ Failure ] fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html [ Failure ] Before: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4336 After: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4335 1374499 1 clopez 2017-11-23 17:15:39 -0800 This is the diff of the generated CMakeCache.txt file for the Release build (before and after) http://sprunge.us/NNVV?diff 1374500 2 clopez 2017-11-23 17:18:43 -0800 (In reply to Carlos Alberto Lopez Perez from comment #1) > This is the diff of the generated CMakeCache.txt file for the Release build > (before and after) http://sprunge.us/NNVV?diff Ups, i got it inverted.. this is the good one: http://sprunge.us/KOOc?diff 1374501 3 clopez 2017-11-23 17:26:04 -0800 Committed r225126: <https://trac.webkit.org/changeset/225126> 1374562 4 mcatanzaro 2017-11-24 03:57:18 -0800 I'm not surprised that the feature set we were testing is so arbitrarily different than the feature set that we release. I'm relieved we've finally gotten rid of the second set of feature defaults. > The new failures: > http/tests/misc/prefetch-purpose.html [ Timeout ] > http/tests/misc/link-rel-prefetch-and-subresource.html [ Timeout ] > fast/dom/HTMLLinkElement/subresource.html [ Timeout ] > fast/dom/HTMLLinkElement/prefetch-onload.html [ Timeout ] > fast/dom/HTMLLinkElement/prefetch-onerror.html [ Timeout ] > fast/dom/HTMLLinkElement/prefetch.html [ Timeout ] > fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ > Timeout ] > fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Timeout ] These tests should all be skipped, because they require ENABLE_LINK_PREFETCH, which we have never supported. > fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text- > justify-inherited.html [ Failure ] > fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text- > justify.html [ Failure ] > fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text- > align-last-inherited.html [ Failure ] > fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text- > align-last.html [ Failure ] And these tests should all be skipped because they rely on ENABLE_CSS3_TEXT, which we have never supported. It would be interesting for someone familiar with web standards to review our feature list. I suspect there are many other low-hanging features besides these two that are probably disabled for no reason. 1374563 5 clopez 2017-11-24 04:02:42 -0800 (In reply to Michael Catanzaro from comment #4) > I'm not surprised that the feature set we were testing is so arbitrarily > different than the feature set that we release. I'm relieved we've finally > gotten rid of the second set of feature defaults. > > > The new failures: > > http/tests/misc/prefetch-purpose.html [ Timeout ] > > http/tests/misc/link-rel-prefetch-and-subresource.html [ Timeout ] > > fast/dom/HTMLLinkElement/subresource.html [ Timeout ] > > fast/dom/HTMLLinkElement/prefetch-onload.html [ Timeout ] > > fast/dom/HTMLLinkElement/prefetch-onerror.html [ Timeout ] > > fast/dom/HTMLLinkElement/prefetch.html [ Timeout ] > > fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html [ > > Timeout ] > > fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Timeout ] > > These tests should all be skipped, because they require > ENABLE_LINK_PREFETCH, which we have never supported. > > > fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text- > > justify-inherited.html [ Failure ] > > fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text- > > justify.html [ Failure ] > > fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text- > > align-last-inherited.html [ Failure ] > > fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text- > > align-last.html [ Failure ] > > And these tests should all be skipped because they rely on ENABLE_CSS3_TEXT, > which we have never supported. > Really? Then how where this test passing before? I think either we (partially or without knowing?) supported that or the tests are broken 1374568 6 mcatanzaro 2017-11-24 04:23:07 -0800 The tests were passing before because the bots previously used the features defined in FeatureList.pm. Your diff shows that FeatureList.pm was enabling many unsupported features -- features that are both PRIVATE and OFF in WebKitFeatures.cmake and/or OptionsGTK.cmake -- and so tests that depended on those features were passing. But nobody is going to notice the difference except for our test bots and developers using build-webkit. This is exactly why we wanted to remove the list of feature defaults from FeatureList.pm. Nobody was even attempting to keep it in sync with WebKitFeatures.cmake. 1374569 7 cgarcia 2017-11-24 04:25:35 -0800 Then I guess you mean that those features were never enabled in production builds, not that they were never supported, because tests were passing when enabled. 1374570 8 mcatanzaro 2017-11-24 04:26:17 -0800 BTW this is not to say that we *should* have link prefetch and CSS3 text disabled... just that we have always had them disabled in releases, and it's wrong for us to have been testing a different set of features than what we released with. (Except, of course, in cases where we intentionally want to test specific features that we know about. That's now solved by ENABLE_EXPERIMENTAL_FEATURES instead of FeatureList.pm.) 1374571 9 mcatanzaro 2017-11-24 04:28:32 -0800 (In reply to Carlos Garcia Campos from comment #7) > Then I guess you mean that those features were never enabled in production > builds, not that they were never supported, because tests were passing when > enabled. Well that's just semantics... I would say that the definition of a supported feature is one that is either ON or PUBLIC, and all PRIVATE OFF features are "unsupported." But yes, clearly the tests had been passing before. 1374580 10 clopez 2017-11-24 05:25:10 -0800 (In reply to Carlos Garcia Campos from comment #7) > Then I guess you mean that those features were never enabled in production > builds, not that they were never supported, because tests were passing when > enabled. Right.. I think we should look forward to enable this features in production builds if it turns out we support them. Certainly is shocking that we have been all this time testing a very different thing than we ship. Glad that we finally got rid of that FeatureList.pm mess 1374593 11 mcatanzaro 2017-11-24 06:47:05 -0800 I'll just repeat what I said here: (In reply to Michael Catanzaro from comment #4) > It would be interesting for someone familiar with web standards to review > our feature list. I suspect there are many other low-hanging features > besides these two that are probably disabled for no reason. 1374941 12 mcatanzaro 2017-11-27 08:35:04 -0800 I'm going to remove the regression tag here, since I consider this a progression rather than a regression -- we are now testing the set of features that we have been releasing -- and since I don't plan any further changes here. 1377845 13 mcatanzaro 2017-12-04 13:11:51 -0800 I'm also changing the Timeout expectations to Skips, since it doesn't make sense for us to wait for all the tests to time out when they are not supposed to be passing anyway. 1398931 14 mcatanzaro 2018-02-13 20:27:50 -0800 Hi WebCore experts, any idea what ENABLE_CSS3_TEXT does? Should we be enabling it? Looks like Mac does? Regarding ENABLE_LINK_PREFETCH... I'd say we should probably turn it on, if it's working properly. Should make the web seem a bit faster. 1400319 15 rego 2018-02-19 03:48:21 -0800 (In reply to Michael Catanzaro from comment #14) > Hi WebCore experts, any idea what ENABLE_CSS3_TEXT does? Should we be > enabling it? Looks like Mac does? On a quick look this adds support for 2 CSS properties: "text-align-last" (https://www.w3.org/TR/css-text-3/#text-align-last-property) and "text-justify" (https://www.w3.org/TR/css-text-3/#text-justify-property). And some extra keywords for "text-indent" property (https://www.w3.org/TR/css-text-3/#text-indent-property). So I'd enable it, as they seem useful for GTK+ too. > Regarding ENABLE_LINK_PREFETCH... I'd say we should probably turn it on, if > it's working properly. Should make the web seem a bit faster. Yeah I guess we should enable it too. 1400330 16 334154 rego 2018-02-19 05:13:03 -0800 Created attachment 334154 Patch 1400334 17 334154 clopez 2018-02-19 05:21:32 -0800 Comment on attachment 334154 Patch I think it's enough with setting WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT ON) rather than re-defining the text with WEBKIT_OPTION_DEFINE() 1400335 18 rego 2018-02-19 05:25:36 -0800 (In reply to Carlos Alberto Lopez Perez from comment #17) > Comment on attachment 334154 [details] > Patch > > I think it's enough with setting > WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS3_TEXT ON) rather than > re-defining the text with WEBKIT_OPTION_DEFINE() Indeed, sorry for the mistake. Uploading a new version. 1400336 19 334155 rego 2018-02-19 05:28:03 -0800 Created attachment 334155 Patch 1400340 20 334155 clopez 2018-02-19 05:42:21 -0800 Comment on attachment 334155 Patch thanks! 1400344 21 334155 mcatanzaro 2018-02-19 06:06:41 -0800 Comment on attachment 334155 Patch I'm confused why these should be GTK-specific, though. *Maybe* some ports would want to leave link prefetch off, but surely CSS3 text should be enabled for everyone? I would change the defaults in WebKitFeatures.cmake instead. 1400345 22 mcatanzaro 2018-02-19 06:08:31 -0800 (For bonus points: getting rid of the ENABLE_CSS3_TEXT build option would probably be good. But I suppose there are many build options that would be good to get rid of.) 1400350 23 334155 rego 2018-02-19 06:32:46 -0800 Comment on attachment 334155 Patch After taking a deeper look, I feel like we shouldn't enable them. At least css3-text, the implementation was only the parser. So "-webkit-text-align-last: center" is valid with the flag enabled, but it doesn't do anything. I believe it'd be better to keep it disabled in that case. The tests are not really useful as nobody is running them it seems though. The parsing was implemented in 2012 (see bug #99439), but the tests are skipped since then in all ports. Regarding link prefetch I have no idea, but for Mac it has been disabled also since the beginning in 2010 (see bug #3652). I don't know that feature, so I didn't investigate anything deeper but it seems we shouldn't enable it either. A code that has been untested by Mac since 2010 doesn't sound really safe to enable. Reopen if you think we should do something different. And sorry for the noise with the patch. 1400354 24 mcatanzaro 2018-02-19 06:53:19 -0800 Thanks for investigating, Rego! Some remaining work we should do here: * The timeouts and layout test failures should probably be moved to the global TestExpectations * Looks like ENABLE_CSS3_TEXT and maybe also ENABLE_LINK_PREFETCH should be removed * Then the corresponding tests should be removed as well 1400723 25 rego 2018-02-20 04:46:17 -0800 (In reply to Michael Catanzaro from comment #24) > Some remaining work we should do here: > > * The timeouts and layout test failures should probably be moved to the > global TestExpectations > * Looks like ENABLE_CSS3_TEXT and maybe also ENABLE_LINK_PREFETCH should be > removed > * Then the corresponding tests should be removed as well I believe that should be part of different bugs and not here, that's why I closed this. But I agree it'd be nice to do that work. So far I've moved the test failures to the generic TestExpectations file in bug #182963. It'd be nice to check ENABLE_LINK_PREFETCH too. Probably the discussion about removing the compilation flags, the code and related tests should be done in webkit-dev. 1400853 26 mcatanzaro 2018-02-20 11:31:02 -0800 I created a mailing list topic: https://lists.webkit.org/pipermail/webkit-dev/2018-February/029881.html And you moved the test expectations. I think further work can be done in new bugs. Thanks for the help, Rego! 1400901 27 rego 2018-02-20 14:05:45 -0800 JFTR, I moved the LINK_PREFETCH tests to the global TestExpectations in bug #182981. 334154 2018-02-19 05:13:03 -0800 2018-02-19 05:27:59 -0800 Patch bug-179989-20180219141301.patch text/plain 4571 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDdjZDhj YzI5YjAzNjU2NDVjODJmYmZkM2EyOTdmMmJiOWI3ODE3ZTQuLmU5ZGFhNGU4YjkzZDJhMDg0YTY2 MDA3MTIyYzg1YTE3ZTcwOTFiNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzYsOSArMTM2 LDExIEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKFVTRV9TWVNURU1fTUFMTE9D IFBVQkxJQyBPRkYpCiAjIHdlIG5lZWQgYSB2YWx1ZSBkaWZmZXJlbnQgZnJvbSB0aGUgZGVmYXVs dCBkZWZpbmVkIGluIFdlYktpdEZlYXR1cmVzLmNtYWtlLgogIyBDaGFuZ2luZyB0aGVzZSBvcHRp b25zIGlzIGNvbXBsZXRlbHkgdW5zdXBwb3J0ZWQuCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S VF9WQUxVRShFTkFCTEVfQUNDRVNTSUJJTElUWSBQUklWQVRFIE9OKQorV0VCS0lUX09QVElPTl9E RUZJTkUoRU5BQkxFX0NTUzNfVEVYVCAiVG9nZ2xlIENTUzMgVGV4dCBzdXBwb3J0IiBQUklWQVRF IE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0RPV05MT0FEX0FU VFJJQlVURSBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX0ZUUERJUiBQUklWQVRFIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9JTlBVVF9UWVBFX0NPTE9SIFBSSVZBVEUgT04pCitXRUJLSVRfT1BUSU9OX0RFRklO RShFTkFCTEVfTElOS19QUkVGRVRDSCAiVG9nZ2xlIHByZSBmZXRjaGluZyBzdXBwb3J0IiBQUklW QVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01IVE1MIFBS SVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUVESUFf U1RSRUFNIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKIFdFQktJVF9P UFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJfUlRDIFBSSVZBVEUgJHtFTkFCTEVf RVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZDE1NGQ0M2YyZDlhNjE5ODYxYzMzYzU0 MTIxMTZlY2M4NGFhNDI5Li4wM2Y2MDU2MjAyMTUyYmExZmFlYzdhOTRmNTNiZDBmYmZjNDJlNzZk IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDItMTkgIE1hbnVlbCBSZWdvIENhc2Fzbm92 YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVHVybiBvbiBieSBkZWZhdWx0 IEVOQUJMRV9MSU5LX1BSRUZFVENIIGFuZCBFTkFCTEVfQ1NTM19URVhUCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk5ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGZldyB0ZXN0cyB3aWxsIGJlIHBh c3NpbmcgYWdhaW4gdGhhbmtzIHRvIHRoaXMgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTgtMDItMTkgIENsYXVkaW8gU2FhdmVkcmEgIDxj c2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVcGRhdGUgdGVzdCBleHBlY3Rh dGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRp b25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZmI3 Njg2NmIzMjcwODZjYWMwNDNkZjE0NWM4MDNjYjZhMmQ5Nzk0NC4uMTM0NDlmZTM0NTIyMDdmZGE2 ODA0NDZmMmJjNDg4ZjRhNjMwNzY1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnMKQEAgLTEyMDUsMjAgKzEyMDUsNiBAQCB3ZWJraXQub3JnL2IvMTc3NjMzIGh0 dHAvdGVzdHMvc2VjdXJpdHkvY2xpcGJvYXJkL2NvcHktcGFzdGUtaHRtbC1hY3Jvc3Mtb3JpZ2lu LQogd2Via2l0Lm9yZy9iLzE3NzYzMyBodHRwL3Rlc3RzL3NlY3VyaXR5L2NsaXBib2FyZC9jb3B5 LXBhc3RlLXVybC1hY3Jvc3Mtb3JpZ2luLXNhbml0aXplcy11cmwuaHRtbCBbIEZhaWx1cmUgXQog d2Via2l0Lm9yZy9iLzE3NzYzMyBodHRwL3Rlc3RzL3NlY3VyaXR5L2NsaXBib2FyZC9jb3B5LXBh c3RlLWh0bWwtYWNyb3NzLW9yaWdpbi1zdHJpcHMtbXNvLWxpc3QuaHRtbCBbIEZhaWx1cmUgXQog Ci0jIFdlIHNob3VsZCBjb25zaWRlciBlbmFibGluZyBFTkFCTEVfTElOS19QUkVGRVRDSCBhbmQg RU5BQkxFX0NTUzNfVEVYVAotd2Via2l0Lm9yZy9iLzE3OTk4OSBodHRwL3Rlc3RzL21pc2MvcHJl ZmV0Y2gtcHVycG9zZS5odG1sIFsgU2tpcCBdCi13ZWJraXQub3JnL2IvMTc5OTg5IGh0dHAvdGVz dHMvbWlzYy9saW5rLXJlbC1wcmVmZXRjaC1hbmQtc3VicmVzb3VyY2UuaHRtbCBbIFNraXAgXQot d2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2RvbS9IVE1MTGlua0VsZW1lbnQvc3VicmVzb3VyY2Uu aHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2RvbS9IVE1MTGlua0VsZW1l bnQvcHJlZmV0Y2gtb25sb2FkLmh0bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcvYi8xNzk5ODkgZmFz dC9kb20vSFRNTExpbmtFbGVtZW50L3ByZWZldGNoLW9uZXJyb3IuaHRtbCBbIFNraXAgXQotd2Vi a2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2RvbS9IVE1MTGlua0VsZW1lbnQvcHJlZmV0Y2guaHRtbCBb IFNraXAgXQotd2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2RvbS9IVE1MTGlua0VsZW1lbnQvbGlu ay1hbmQtc3VicmVzb3VyY2UtdGVzdC1ub25leGlzdGVudC5odG1sIFsgU2tpcCBdCi13ZWJraXQu b3JnL2IvMTc5OTg5IGZhc3QvZG9tL0hUTUxMaW5rRWxlbWVudC9saW5rLWFuZC1zdWJyZXNvdXJj ZS10ZXN0Lmh0bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcvYi8xNzk5ODkgZmFzdC9jc3MzLXRleHQv Y3NzMy10ZXh0LWp1c3RpZnkvZ2V0Q29tcHV0ZWRTdHlsZS9nZXRDb21wdXRlZFN0eWxlLXRleHQt anVzdGlmeS1pbmhlcml0ZWQuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE3OTk4OSBm YXN0L2NzczMtdGV4dC9jc3MzLXRleHQtanVzdGlmeS9nZXRDb21wdXRlZFN0eWxlL2dldENvbXB1 dGVkU3R5bGUtdGV4dC1qdXN0aWZ5Lmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNzk5 ODkgZmFzdC9jc3MzLXRleHQvY3NzMy10ZXh0LWFsaWduLWxhc3QvZ2V0Q29tcHV0ZWRTdHlsZS9n ZXRDb21wdXRlZFN0eWxlLXRleHQtYWxpZ24tbGFzdC1pbmhlcml0ZWQuaHRtbCBbIEZhaWx1cmUg XQotd2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtYWxpZ24tbGFz dC9nZXRDb21wdXRlZFN0eWxlL2dldENvbXB1dGVkU3R5bGUtdGV4dC1hbGlnbi1sYXN0Lmh0bWwg WyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE4MDA2MiBmYXN0L3RleHQvdXNlci1pbnN0YWxs ZWQtZm9udHMgWyBTa2lwIF0KIAogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1NmY5YjZkMTQzNThhMTExZmQ5 ZGQwYjE5ZDQ2NzY2YjJmNjQ3Njc3Li40OTA2MjkwZGM1ODRhODRjNTdiYTllMGY0ZjkyOTNjYTdl YjIxZjI5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTgtMDItMTkgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gVHVybiBvbiBieSBkZWZhdWx0IEVOQUJMRV9MSU5LX1BSRUZF VENIIGFuZCBFTkFCTEVfQ1NTM19URVhUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzk5ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBcyBkaXNjdXNzZWQgb24gdGhlIGJ1ZyBpdCBzZWVtcyBhIGdvb2Qg aWRlYSB0byBlbmFibGUgdGhlc2UgZmVhdHVyZXMuCisgICAgICAgIFRoZXkgd2VyZSB3b3JraW5n IGZvciBhIHdoaWxlIGluIGRldmVsb3BtZW50IGJ1aWxkcyBhbmQgd2Ugc2VlIG5vIHJlYXNvbgor ICAgICAgICB0byBhdm9pZCBlbmFibGluZyB0aGVtIGJ5IGRlZmF1bHQuCisKKyAgICAgICAgKiBT b3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKwogMjAxOC0wMi0xOSAgUGhpbGlwcGUgTm9y bWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gUGxheWJp bjMgc3VwcG9ydAo= 334155 2018-02-19 05:28:03 -0800 2018-02-19 06:32:46 -0800 Patch bug-179989-20180219142802.patch text/plain 4538 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjI4NjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDdjZDhj YzI5YjAzNjU2NDVjODJmYmZkM2EyOTdmMmJiOWI3ODE3ZTQuLjE0NGIyZTJiZDY3ZmE4MTNmYjVh NDc0Y2VhODBlYzlmYjAwMTdlYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzYsOSArMTM2 LDExIEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKFVTRV9TWVNURU1fTUFMTE9D IFBVQkxJQyBPRkYpCiAjIHdlIG5lZWQgYSB2YWx1ZSBkaWZmZXJlbnQgZnJvbSB0aGUgZGVmYXVs dCBkZWZpbmVkIGluIFdlYktpdEZlYXR1cmVzLmNtYWtlLgogIyBDaGFuZ2luZyB0aGVzZSBvcHRp b25zIGlzIGNvbXBsZXRlbHkgdW5zdXBwb3J0ZWQuCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9S VF9WQUxVRShFTkFCTEVfQUNDRVNTSUJJTElUWSBQUklWQVRFIE9OKQorV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NTUzNfVEVYVCBQUklWQVRFIE9OKQogV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0RPV05MT0FEX0FUVFJJQlVURSBQUklWQVRF IE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZUUERJUiBQUklW QVRFIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9JTlBVVF9U WVBFX0NPTE9SIFBSSVZBVEUgT04pCitXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShF TkFCTEVfTElOS19QUkVGRVRDSCBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX01IVE1MIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRf UE9SVF9WQUxVRShFTkFCTEVfTUVESUFfU1RSRUFNIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVO VEFMX0ZFQVRVUkVTfSkKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9X RUJfUlRDIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTfSkKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4 ZDE1NGQ0M2YyZDlhNjE5ODYxYzMzYzU0MTIxMTZlY2M4NGFhNDI5Li4wM2Y2MDU2MjAyMTUyYmEx ZmFlYzdhOTRmNTNiZDBmYmZjNDJlNzZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDIt MTkgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS10gVHVybiBvbiBieSBkZWZhdWx0IEVOQUJMRV9MSU5LX1BSRUZFVENIIGFuZCBFTkFCTEVf Q1NTM19URVhUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzk5ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBIGZldyB0ZXN0cyB3aWxsIGJlIHBhc3NpbmcgYWdhaW4gdGhhbmtzIHRvIHRoaXMgY2hhbmdl LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTgtMDIt MTkgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1RLXSBVcGRhdGUgdGVzdCBleHBlY3RhdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMKaW5kZXggZmI3Njg2NmIzMjcwODZjYWMwNDNkZjE0NWM4MDNjYjZhMmQ5 Nzk0NC4uMTM0NDlmZTM0NTIyMDdmZGE2ODA0NDZmMmJjNDg4ZjRhNjMwNzY1NiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEyMDUsMjAgKzEyMDUsNiBA QCB3ZWJraXQub3JnL2IvMTc3NjMzIGh0dHAvdGVzdHMvc2VjdXJpdHkvY2xpcGJvYXJkL2NvcHkt cGFzdGUtaHRtbC1hY3Jvc3Mtb3JpZ2luLQogd2Via2l0Lm9yZy9iLzE3NzYzMyBodHRwL3Rlc3Rz L3NlY3VyaXR5L2NsaXBib2FyZC9jb3B5LXBhc3RlLXVybC1hY3Jvc3Mtb3JpZ2luLXNhbml0aXpl cy11cmwuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE3NzYzMyBodHRwL3Rlc3RzL3Nl Y3VyaXR5L2NsaXBib2FyZC9jb3B5LXBhc3RlLWh0bWwtYWNyb3NzLW9yaWdpbi1zdHJpcHMtbXNv LWxpc3QuaHRtbCBbIEZhaWx1cmUgXQogCi0jIFdlIHNob3VsZCBjb25zaWRlciBlbmFibGluZyBF TkFCTEVfTElOS19QUkVGRVRDSCBhbmQgRU5BQkxFX0NTUzNfVEVYVAotd2Via2l0Lm9yZy9iLzE3 OTk4OSBodHRwL3Rlc3RzL21pc2MvcHJlZmV0Y2gtcHVycG9zZS5odG1sIFsgU2tpcCBdCi13ZWJr aXQub3JnL2IvMTc5OTg5IGh0dHAvdGVzdHMvbWlzYy9saW5rLXJlbC1wcmVmZXRjaC1hbmQtc3Vi cmVzb3VyY2UuaHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2RvbS9IVE1M TGlua0VsZW1lbnQvc3VicmVzb3VyY2UuaHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzE3OTk4 OSBmYXN0L2RvbS9IVE1MTGlua0VsZW1lbnQvcHJlZmV0Y2gtb25sb2FkLmh0bWwgWyBTa2lwIF0K LXdlYmtpdC5vcmcvYi8xNzk5ODkgZmFzdC9kb20vSFRNTExpbmtFbGVtZW50L3ByZWZldGNoLW9u ZXJyb3IuaHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2RvbS9IVE1MTGlu a0VsZW1lbnQvcHJlZmV0Y2guaHRtbCBbIFNraXAgXQotd2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0 L2RvbS9IVE1MTGlua0VsZW1lbnQvbGluay1hbmQtc3VicmVzb3VyY2UtdGVzdC1ub25leGlzdGVu dC5odG1sIFsgU2tpcCBdCi13ZWJraXQub3JnL2IvMTc5OTg5IGZhc3QvZG9tL0hUTUxMaW5rRWxl bWVudC9saW5rLWFuZC1zdWJyZXNvdXJjZS10ZXN0Lmh0bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcv Yi8xNzk5ODkgZmFzdC9jc3MzLXRleHQvY3NzMy10ZXh0LWp1c3RpZnkvZ2V0Q29tcHV0ZWRTdHls ZS9nZXRDb21wdXRlZFN0eWxlLXRleHQtanVzdGlmeS1pbmhlcml0ZWQuaHRtbCBbIEZhaWx1cmUg XQotd2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtanVzdGlmeS9n ZXRDb21wdXRlZFN0eWxlL2dldENvbXB1dGVkU3R5bGUtdGV4dC1qdXN0aWZ5Lmh0bWwgWyBGYWls dXJlIF0KLXdlYmtpdC5vcmcvYi8xNzk5ODkgZmFzdC9jc3MzLXRleHQvY3NzMy10ZXh0LWFsaWdu LWxhc3QvZ2V0Q29tcHV0ZWRTdHlsZS9nZXRDb21wdXRlZFN0eWxlLXRleHQtYWxpZ24tbGFzdC1p bmhlcml0ZWQuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE3OTk4OSBmYXN0L2NzczMt dGV4dC9jc3MzLXRleHQtYWxpZ24tbGFzdC9nZXRDb21wdXRlZFN0eWxlL2dldENvbXB1dGVkU3R5 bGUtdGV4dC1hbGlnbi1sYXN0Lmh0bWwgWyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE4MDA2 MiBmYXN0L3RleHQvdXNlci1pbnN0YWxsZWQtZm9udHMgWyBTa2lwIF0KIAogIy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwpp bmRleCA1NmY5YjZkMTQzNThhMTExZmQ5ZGQwYjE5ZDQ2NzY2YjJmNjQ3Njc3Li40OTA2MjkwZGM1 ODRhODRjNTdiYTllMGY0ZjkyOTNjYTdlYjIxZjI5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysr IGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDItMTkgIE1hbnVlbCBSZWdvIENh c2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVHVybiBvbiBieSBk ZWZhdWx0IEVOQUJMRV9MSU5LX1BSRUZFVENIIGFuZCBFTkFCTEVfQ1NTM19URVhUCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk5ODkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBkaXNjdXNzZWQgb24g dGhlIGJ1ZyBpdCBzZWVtcyBhIGdvb2QgaWRlYSB0byBlbmFibGUgdGhlc2UgZmVhdHVyZXMuCisg ICAgICAgIFRoZXkgd2VyZSB3b3JraW5nIGZvciBhIHdoaWxlIGluIGRldmVsb3BtZW50IGJ1aWxk cyBhbmQgd2Ugc2VlIG5vIHJlYXNvbgorICAgICAgICB0byBhdm9pZCBlbmFibGluZyB0aGVtIGJ5 IGRlZmF1bHQuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKwog MjAxOC0wMi0xOSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dTdHJlYW1lcl0gUGxheWJpbjMgc3VwcG9ydAo=