179616 2017-11-13 10:16:13 -0800 REGRESSION(r224658): check-webkit-style cannot construct valid iOS version without an iOS SDK 2017-11-13 21:55:59 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179534 InRadar, Regression P2 Normal --- 1 jbedard jbedard aakash_jain ap buildbot commit-queue dbates ddkilzer glenn lforschler simon.fraser webkit-bug-importer oldest_to_newest 1370936 0 jbedard 2017-11-13 10:16:13 -0800 After <https://trac.webkit.org/changeset/224658>, when running check-webkit-style on a Mac without an iOS SDK, an exception is thrown. This is quite related to <https://bugs.webkit.org/show_bug.cgi?id=179534>, but the fix for this problem is much smaller and a subset of the fixed for the larger issue. 1370937 1 webkit-bug-importer 2017-11-13 10:16:35 -0800 <rdar://problem/35507018> 1370938 2 326769 jbedard 2017-11-13 10:22:22 -0800 Created attachment 326769 Patch 1370942 3 326769 simon.fraser 2017-11-13 10:33:28 -0800 Comment on attachment 326769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326769&action=review > Tools/ChangeLog:10 > + Instead of throwing an exception when we ask for an unavailable SDK on Mac, > + we should return None. But the problem is related to iOS SDKs, not mac. 1370955 4 326769 jbedard 2017-11-13 11:00:25 -0800 Comment on attachment 326769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326769&action=review >> Tools/ChangeLog:10 >> + we should return None. > > But the problem is related to iOS SDKs, not mac. It only happens on Mac when we ask for an SDK (which could be iOS, watchOS or tvOS, in our case, it's iOS that's causing the problem) which is unavailable. This change has implications beyond just the iOS SDK, although at the moment, that is the only SDK that uses this codepath. 1370963 5 326769 ddkilzer 2017-11-13 11:17:40 -0800 Comment on attachment 326769 Patch r=me Please check the Win EWS (it's orange) before landing. 1370973 6 jbedard 2017-11-13 11:36:32 -0800 (In reply to David Kilzer (:ddkilzer) from comment #5) > Comment on attachment 326769 [details] > Patch > > r=me > > Please check the Win EWS (it's orange) before landing. It was test failures for mac and a borked SVN for Windows, everything is green now. 1370985 7 326769 commit-queue 2017-11-13 11:55:21 -0800 Comment on attachment 326769 Patch Clearing flags on attachment: 326769 Committed r224765: <https://trac.webkit.org/changeset/224765> 1370986 8 commit-queue 2017-11-13 11:55:22 -0800 All reviewed patches have been landed. Closing bug. 326769 2017-11-13 10:22:22 -0800 2017-11-13 11:55:21 -0800 Patch bug-179616-20171113102221.patch text/plain 1884 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNDc1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTExLTEzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgY2Fubm90IGNvbnN0cnVjdCB2YWxpZCBp T1MgdmVyc2lvbiB3aXRob3V0IGFuIGlPUyBTREsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTYxNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzU1 MDcwMTg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW5zdGVhZCBvZiB0aHJvd2luZyBhbiBleGNlcHRpb24gd2hlbiB3ZSBhc2sgZm9yIGFuIHVuYXZh aWxhYmxlIFNESyBvbiBNYWMsCisgICAgICAgIHdlIHNob3VsZCByZXR1cm4gTm9uZS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8ucHk6Cisg ICAgICAgIChQbGF0Zm9ybUluZm8ueGNvZGVfc2RrX3ZlcnNpb24pOiBSZXR1cm4gJ05vbmUnIHZl cnNpb24gaWYgdGhlIG1hY2hpbmUgZG9lcyBub3QKKyAgICAgICAgaGF2ZSB0aGUgcmVxdWVzdGVk IFNESy4KKwogMjAxNy0xMS0xMyAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBbQXR0YWNobWVudCBTdXBwb3J0XSBJbXBsZW1lbnQgU1BJIGZvciBjbGll bnRzIHRvIHJlcXVlc3QgZGF0YSBmb3IgYSBnaXZlbiBhdHRhY2htZW50CkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkJ KHJldmlzaW9uIDIyNDc1NikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl bS9wbGF0Zm9ybWluZm8ucHkJKHdvcmtpbmcgY29weSkKQEAgLTEyOCw3ICsxMjgsOSBAQCBjbGFz cyBQbGF0Zm9ybUluZm8ob2JqZWN0KToKICAgICBkZWYgeGNvZGVfc2RrX3ZlcnNpb24oc2VsZiwg c2RrX25hbWUpOgogICAgICAgICBpZiBzZWxmLmlzX21hYygpOgogICAgICAgICAgICAgIyBBc3N1 bWVzIHRoYXQgeGNydW4gZG9lcyBub3Qgd3JpdGUgdG8gc3RhbmRhcmQgb3V0cHV0IG9uIGZhaWx1 cmUgKGUuZy4gU0RLIGRvZXMgbm90IGV4aXN0KS4KLSAgICAgICAgICAgIHJldHVybiBWZXJzaW9u KHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbInhjcnVuIiwgIi0tc2RrIiwgc2RrX25hbWUs ICItLXNob3ctc2RrLXZlcnNpb24iXSwgcmV0dXJuX3N0ZGVycj1GYWxzZSwgZXJyb3JfaGFuZGxl cj1FeGVjdXRpdmUuaWdub3JlX2Vycm9yKS5yc3RyaXAoKSkKKyAgICAgICAgICAgIHhjcnVuX291 dHB1dCA9IHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3hjcnVuJywgJy0tc2RrJywgc2Rr X25hbWUsICctLXNob3ctc2RrLXZlcnNpb24nXSwgcmV0dXJuX3N0ZGVycj1GYWxzZSwgZXJyb3Jf aGFuZGxlcj1FeGVjdXRpdmUuaWdub3JlX2Vycm9yKS5yc3RyaXAoKQorICAgICAgICAgICAgaWYg eGNydW5fb3V0cHV0OgorICAgICAgICAgICAgICAgIHJldHVybiBWZXJzaW9uKHhjcnVuX291dHB1 dCkKICAgICAgICAgcmV0dXJuIE5vbmUKIAogICAgIGRlZiB4Y29kZV9zaW1jdGxfbGlzdChzZWxm KToK