179522 2017-11-09 22:28:02 -0800 check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major' 2017-11-15 09:37:31 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179534 InRadar P2 Normal --- 1 fujii fujii aakash_jain buildbot commit-queue glenn jbedard lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1370231 0 fujii 2017-11-09 22:28:02 -0800 check-webkit-style is broken since Bug 179426. > $ ./Tools/Scripts/check-webkit-style > Traceback (most recent call last): > File "./Tools/Scripts/check-webkit-style", line 48, in <module> > sys.exit(CheckWebKitStyle().main()) > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/style/main.py", line 155, in main > patch_checker.check(patch) > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/style/patchreader.py", line 84, in check > self._text_file_reader.do_association_check(fs.getcwd()) > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/style/filereader.py", line 152, in do_association_check > self._processor.do_association_check(self._files, cwd, host=host) > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/style/checker.py", line 963, in do_association_check > TestExpectationsChecker.lint_test_expectations(files, self._configuration, cwd, self._increment_error_count, host=host) > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 129, in lint_test_expectations > for expectations_file in port.expectations_dict().keys(): > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/port/base.py", line 1124, in expectations_dict > for path in self.expectations_files(): > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/port/base.py", line 1156, in expectations_files > return [self.path_to_generic_test_expectations_file()] + self._port_specific_expectations_files() > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/port/darwin.py", line 56, in _port_specific_expectations_files > return list(reversed([self._filesystem.join(self._webkit_baseline_path(p), 'TestExpectations') for p in self.baseline_search_path()])) > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/port/base.py", line 204, in baseline_search_path > return self.get_option('additional_platform_directory', []) + self._compare_baseline() + self.default_baseline_search_path() > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/common/memoized.py", line 45, in __call__ > result = self._function(*args) > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/port/ios.py", line 113, in default_baseline_search_path > '{}-{}-{}'.format(self.port_name, self.ios_version().major, wk_string), > AttributeError: 'NoneType' object has no attribute 'major' > $ 1370236 1 326558 fujii 2017-11-09 22:37:21 -0800 Created attachment 326558 Patch 1370297 2 jbedard 2017-11-10 07:24:50 -0800 I suspect this is on a machine without an iOS SDK installed, correct? 1370347 3 326558 aakash_jain 2017-11-10 08:53:23 -0800 Comment on attachment 326558 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326558&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:118 > + return Version(self.host.platform.xcode_sdk_version('iphonesimulator')) This might pass None to Version(). We should have a log statement at https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/version.py#L44 That can be done either in this patch or separate patch. 1370363 4 jbedard 2017-11-10 09:20:35 -0800 (In reply to Aakash Jain from comment #3) > Comment on attachment 326558 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326558&action=review > > > Tools/Scripts/webkitpy/port/ios_simulator.py:118 > > + return Version(self.host.platform.xcode_sdk_version('iphonesimulator')) > > This might pass None to Version(). We should have a log statement at > https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/ > version.py#L44 > > That can be done either in this patch or separate patch. I am of the opinion this should be done in another patch. This is also a side-effect of a long-standing issue which I've just filed a bug for <https://bugs.webkit.org/show_bug.cgi?id=179534>. Maybe just a FIXME and ultimately, we address the root cause? 1370643 5 jbedard 2017-11-10 20:13:04 -0800 I'm going to land this patch so that our trees don't spend the weekend red. 1370646 6 326558 commit-queue 2017-11-10 20:32:45 -0800 Comment on attachment 326558 Patch Clearing flags on attachment: 326558 Committed r224722: <https://trac.webkit.org/changeset/224722> 1370647 7 commit-queue 2017-11-10 20:32:46 -0800 All reviewed patches have been landed. Closing bug. 1371916 8 webkit-bug-importer 2017-11-15 09:37:31 -0800 <rdar://problem/35562086> 326558 2017-11-09 22:37:21 -0800 2017-11-10 20:32:45 -0800 Patch bug-179522-20171109223718.patch text/plain 1684 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NjYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzFjZDdmODdlMGZjMzQ1NzUyZGQ1OWE1ZGQ2NWQwMmZl Y2Y4YWM4Ni4uZjM2NGZhZTgwOGYzY2QyNTZmZGY1NjlkNWE5ZDhjY2I4OTI5ZTU1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTExLTA5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZTogQXR0cmlidXRlRXJyb3I6ICdOb25lVHlw ZScgb2JqZWN0IGhhcyBubyBhdHRyaWJ1dGUgJ21ham9yJworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5NTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSU9TU2ltdWxhdG9yUG9ydC5pb3NfdmVyc2lvbiBz aG91bGQgcmV0dXJuIGEgVmVyc2lvbiBvYmplY3QuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3BvcnQvaW9zX3NpbXVsYXRvci5weToKKyAgICAgICAgKElPU1NpbXVsYXRvclBvcnQuaW9z X3ZlcnNpb24pOiBSZXR1cm4gYSBWZXJzaW9uIG9iamVjdC4KKwogMjAxNy0xMS0wOSAgSm9uYXRo YW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgd2Via2l0cHk6IFVuaWZ5 IHZlcnNpb24gcGFyc2luZyBjb2RlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvaW9zX3NpbXVsYXRvci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nf c2ltdWxhdG9yLnB5CmluZGV4IDhlZTQ1OTE5YjUxOGRkYTQ1NDE4ODFmOGYxNmI4ZDRlYjc0ZjU4 MTMuLmUwZjFlYjUyNDk2ODE5ZjI2ZjYxN2RkZjAwNDA3OGI0Y2I3ODRlMTMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9pb3Nfc2ltdWxhdG9yLnB5CkBAIC0xMTQsOCArMTE0LDgg QEAgY2xhc3MgSU9TU2ltdWxhdG9yUG9ydChJT1NQb3J0KToKICAgICAgICAgaWYgc2VsZi5nZXRf b3B0aW9uKCd2ZXJzaW9uJyk6CiAgICAgICAgICAgICByZXR1cm4gVmVyc2lvbihzZWxmLmdldF9v cHRpb24oJ3ZlcnNpb24nKSkKICAgICAgICAgaWYgcnVudGltZV9pZGVudGlmaWVyOgotICAgICAg ICAgICAgcmV0dXJuICcuJy5qb2luKHN0cihpKSBmb3IgaSBpbiBSdW50aW1lLmZyb21faWRlbnRp ZmllcihydW50aW1lX2lkZW50aWZpZXIpLnZlcnNpb24pCi0gICAgICAgIHJldHVybiBzZWxmLmhv c3QucGxhdGZvcm0ueGNvZGVfc2RrX3ZlcnNpb24oJ2lwaG9uZXNpbXVsYXRvcicpCisgICAgICAg ICAgICByZXR1cm4gVmVyc2lvbihSdW50aW1lLmZyb21faWRlbnRpZmllcihydW50aW1lX2lkZW50 aWZpZXIpLnZlcnNpb24pCisgICAgICAgIHJldHVybiBWZXJzaW9uKHNlbGYuaG9zdC5wbGF0Zm9y bS54Y29kZV9zZGtfdmVyc2lvbignaXBob25lc2ltdWxhdG9yJykpCiAKICAgICBkZWYgc2ltdWxh dG9yX2RldmljZV90eXBlKHNlbGYpOgogICAgICAgICBkZXZpY2VfdHlwZV9pZGVudGlmaWVyID0g c2VsZi5nZXRfb3B0aW9uKCdkZXZpY2VfdHlwZScpCg==