179511 2017-11-09 16:34:57 -0800 [WPE] GLContextEGLWPE.cpp:44:96: error: invalid cast from type ‘GLNativeWindowType {aka long long unsigned int}’ to type ‘EGLNativeWindowType {aka unsigned int} 2017-11-20 07:58:02 -0800 1 1 1 Unclassified WebKit WPE WebKit Other PC Linux RESOLVED FIXED P2 Normal --- 178894 1 mcatanzaro clopez aperez bugs-noreply buildbot cgarcia clopez commit-queue magomez mcatanzaro ticaiolima zan oldest_to_newest 1370107 0 mcatanzaro 2017-11-09 16:34:57 -0800 When building for 32-bit ARM: ./platform/graphics/egl/GLContextEGLWPE.cpp: In static member function ‘static void* WebCore::GLContextEGL::createWindowSurfaceWPE(EGLDisplay, EGLConfig, GLNativeWindowType)’: ./platform/graphics/egl/GLContextEGLWPE.cpp:44:96: error: invalid cast from type ‘GLNativeWindowType {aka long long unsigned int}’ to type ‘EGLNativeWindowType {aka unsigned int}’ return eglCreateWindowSurface(display, config, reinterpret_cast<EGLNativeWindowType>(window), nullptr); So, that cast is clearly illegal. GLNativeWindowType is larger than EGLNativeWindowType, so it's not safe to cast in that direction. I notice that GLNativeWindowType is defined oddly in GLContext.h: #if USE(EGL) && !PLATFORM(GTK) && !PLATFORM(WPE) #include "eglplatform.h" typedef EGLNativeWindowType GLNativeWindowType; #else typedef uint64_t GLNativeWindowType; #endif I'm genuinely uncertain where the declaration of EGLNativeWindowType is coming from, but I see this in ANGLE's eglplatform.h: #elif defined(USE_OZONE) || defined(USE_WPE) typedef intptr_t EGLNativeDisplayType; typedef intptr_t EGLNativeWindowType; typedef intptr_t EGLNativePixmapType; And of course, intptr_t is a 32-bit type. I have no clue how this is supposed to work. 1370333 1 clopez 2017-11-10 08:26:29 -0800 (In reply to Michael Catanzaro from comment #0) > I'm genuinely uncertain where the declaration of EGLNativeWindowType is > coming from, but I see this in ANGLE's eglplatform.h: > EGLNativeWindowType is declared in /usr/include/EGL/eglplatform.h and has different definitions depending on the EGL platform you have defined (GBM, WaylandEGL, X11, etc) I think ANGLE headers should not be used for building this file. 1370387 2 mcatanzaro 2017-11-10 09:50:32 -0800 I don't know if ANGLE headers are actually used or not. I don't know where the definition of EGLNativeWindowType is coming from. But I'd be surprised that we have it defined to be intptr_t there if we're not using it. 1372502 3 clopez 2017-11-15 17:08:08 -0800 I have been bitten by this, so I have checked it. I think this started to happen with r217208 <https://trac.webkit.org/r217208> Patch incoming .. 1372508 4 327039 clopez 2017-11-15 17:36:25 -0800 Created attachment 327039 Patch 1372509 5 buildbot 2017-11-15 17:38:28 -0800 Attachment 327039 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:3: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: invalid cast [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1372649 6 mcatanzaro 2017-11-16 09:30:15 -0800 Thanks. I'm not qualified to review this; please ask Miguel and Zan. 1372905 7 clopez 2017-11-16 17:09:26 -0800 (In reply to Carlos Alberto Lopez Perez from comment #3) > > I think this started to happen with r217208 <https://trac.webkit.org/r217208> > When I wrote that I didn't noticed the age of the commit (6 months ago).. And IIRC I did ARMv7 builds of WPE trunk 1-2 months ago. So I guess something else than r217208 caused this In any case I still think the attached patch is ok, so any review of it is appreciated. 1373780 8 327039 commit-queue 2017-11-20 07:58:00 -0800 Comment on attachment 327039 Patch Clearing flags on attachment: 327039 Committed r225051: <https://trac.webkit.org/changeset/225051> 1373781 9 commit-queue 2017-11-20 07:58:02 -0800 All reviewed patches have been landed. Closing bug. 327039 2017-11-15 17:36:25 -0800 2017-11-20 07:58:00 -0800 Patch bug-179511-20171116023624.patch text/plain 2228 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0ODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFkOTM1YTc4ZGU4ZDQx NjUxOWJmYWU4ZWFmMDI0NDQ1MTljN2Y2My4uNjAxYzkwNzEwNmIxMzJhMjc5ZGVlMmRkOWM0MzNl ZTgzZWViODVlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTExLTE1ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtX UEVdIEdMQ29udGV4dEVHTFdQRS5jcHA6NDQ6OTY6IGVycm9yOiBpbnZhbGlkIGNhc3QgZnJvbSB0 eXBlIOKAmEdMTmF0aXZlV2luZG93VHlwZSB7YWthIGxvbmcgbG9uZyB1bnNpZ25lZCBpbnR94oCZ IHRvIHR5cGUg4oCYRUdMTmF0aXZlV2luZG93VHlwZSB7YWthIHVuc2lnbmVkIGludH0KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3OTUxMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyMTcyMDggY2hhbmdl ZCB0aGUgZGVmaW5pdGlvbiBvZiBHTE5hdGl2ZVdpbmRvd1R5cGUgZnJvbSBFR0xOYXRpdmVXaW5k b3dUeXBlIHRvIHVpbnQ2NF90IGZvciBwbGF0Zm9ybSBXUEUuCisgICAgICAgIFRoaXMgYnVpbHQg ZmluZSBvbiBhIDY0LWJpdCBwbGF0Zm9ybSBzaW5jZSB1aW50NjRfdCBtYXRjaGVzIHRoZSBzaXpl IG9mIGEgcG9pbnRlciwgYnV0IGZhaWxzIG9uIDMyLWJpdHMuCisKKyAgICAgICAgVGhpcyBzd2l0 Y2hlcyBiYWNrIHRoZSBkZWZpbml0aW9uIHRvIEVHTE5hdGl2ZVdpbmRvd1R5cGUuCisgICAgICAg IEFuZCB3ZSBuZWVkIHRvIGluY2x1ZGUgPEVHTC9lZ2xwbGF0Zm9ybS5oPiBmaXJzdCBpbiBvcmRl ciB0byBnZXQgYSBkZWZpbml0aW9uIGZvciBFR0xOYXRpdmVXaW5kb3dUeXBlIGl0c2VsZi4KKwor ICAgICAgICBUaGlzIGNvbW1pdCBwcmV0dHkgbXVjaCByZXZlcnRzIHRoZSBjaGFuZ2VzIHIyMTcy MDggZGlkIG9uIHBsYXRmb3JtL2dyYXBoaWNzL0dMQ29udGV4dC5oCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCBpdCBpcyBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L0dMQ29udGV4dC5oOgorCiAyMDE3LTExLTE1ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBl cmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NhaXJvXSBDbGFuZyB3YXJucyBhYm91dCBtaXNt YXRjaGVkIGRlY2xhcmF0aW9uIHR5cGUgdGFnIGZvciBHcmFwaGljc0NvbnRleHRTdGF0ZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmggYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HTENvbnRleHQuaAppbmRleCAwZTRlNDBm ZjYyYmQzMjI0ODVkZTAyOGVmZTMzNmI0MjM0MDg0MWVjLi4zNTRlMzFmMWYyNzZjNWNlNjBiNWZk MmVhYWMwNjFlYzg3YzM1MTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HTENvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9HTENvbnRleHQuaApAQCAtMjQsMTAgKzI0LDE3IEBACiAjaW5jbHVkZSAiUGxhdGZvcm1EaXNw bGF5LmgiCiAjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAKLSNpZiBVU0UoRUdMKSAmJiAh UExBVEZPUk0oR1RLKSAmJiAhUExBVEZPUk0oV1BFKQorI2lmIFVTRShFR0wpICYmICFQTEFURk9S TShHVEspCisjaWYgUExBVEZPUk0oV1BFKQorLy8gRklYTUU6IEZvciBub3cgZGVmYXVsdCB0byB0 aGUgR0JNIEVHTCBwbGF0Zm9ybSwgYnV0IHRoaXMgc2hvdWxkIHJlYWxseSBiZQorLy8gc29tZWhv dyBkZWR1Y2libGUgZnJvbSB0aGUgYnVpbGQgY29uZmlndXJhdGlvbi4KKyNkZWZpbmUgX19HQk1f XyAxCisjaW5jbHVkZSA8RUdML2VnbHBsYXRmb3JtLmg+CisjZWxzZQogI2luY2x1ZGUgImVnbHBs YXRmb3JtLmgiCisjZW5kaWYgLy8gUExBVEZPUk0oV1BFKQogdHlwZWRlZiBFR0xOYXRpdmVXaW5k b3dUeXBlIEdMTmF0aXZlV2luZG93VHlwZTsKLSNlbHNlCisjZWxzZSAvLyAhVVNFKEVHTCkgfHwg UExBVEZPUk0oR1RLKQogdHlwZWRlZiB1aW50NjRfdCBHTE5hdGl2ZVdpbmRvd1R5cGU7CiAjZW5k aWYKIAo=