179358 2017-11-06 18:48:51 -0800 [WPE] Use linker script to control exported symbols 2017-11-15 09:33:06 -0800 1 1 1 Unclassified WebKit WPE WebKit Other PC Linux RESOLVED FIXED P2 Normal --- 179492 178894 1 mcatanzaro mcatanzaro bugs-noreply clopez commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1368892 0 mcatanzaro 2017-11-06 18:48:51 -0800 The C API is being inadvertently exported because it's marked as WEBKIT_EXPORT in the header files. But of course it should only be exported in DEVELOPER_MODE, where it's needed for WebKitTestRunner. Use (almost) the same linker version script as GTK to fix this. It's slightly different because WPE does not have WebKitPluginProcess. This also reduces binary size of libWPEWebKit.so in debug mode from 615 MB down to 497 MB. (Haven't checked release mode.) This will break the WIP fdo backend of dyz. We should discuss which parts of the C API are really needed there (I don't immediately see anything), and how to expose them in the GLib API if needed. 1368893 1 326181 mcatanzaro 2017-11-06 18:51:25 -0800 Created attachment 326181 Patch 1369959 2 326181 clopez 2017-11-09 10:49:55 -0800 Comment on attachment 326181 Patch This breaks dyz for me: lib/wpe.lua:125: /home/clopez/webkit/wpe/WebKitBuild/Release/lib/libWPEWebKit.so: undefined symbol: WKPageConfigurationSetContext 1369971 3 clopez 2017-11-09 11:11:26 -0800 (In reply to Carlos Alberto Lopez Perez from comment #2) > Comment on attachment 326181 [details] > Patch > > This breaks dyz for me: > > lib/wpe.lua:125: > /home/clopez/webkit/wpe/WebKitBuild/Release/lib/libWPEWebKit.so: undefined > symbol: WKPageConfigurationSetContext Ok.. that is because the WPE JHBuild is still building an old version of dyz that uses the C API. Let's update it first. 1369986 4 clopez 2017-11-09 11:34:21 -0800 (In reply to Michael Catanzaro from comment #0) > This also reduces binary size of libWPEWebKit.so in debug mode from 615 MB > down to 497 MB. (Haven't checked release mode.) > Nice. In Release it reduces it in ~74 KBs less (after stripping).. Better than nothing 1370016 5 326181 commit-queue 2017-11-09 12:56:07 -0800 Comment on attachment 326181 Patch Clearing flags on attachment: 326181 Committed r224642: <https://trac.webkit.org/changeset/224642> 1370017 6 commit-queue 2017-11-09 12:56:08 -0800 All reviewed patches have been landed. Closing bug. 326181 2017-11-06 18:51:25 -0800 2017-11-09 12:56:07 -0800 Patch bug-179358-20171106205124.patch text/plain 2709 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IDdiOGEz NTNlOWRlM2VkZDY1YjBhNzMyOWRjMmI3YjIzMDhjY2Q2YzcuLmQwZDQzM2EyOTIyNjc1NDhhYzQ1 YThkMTM2OGI5OGRkYWIwNDc3OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC0xMDksMTEgKzEw OSw4IEBAIHNldChGT1JXQVJESU5HX0hFQURFUlNfV1BFX0RJUiAke0ZPUldBUkRJTkdfSEVBREVS U19ESVJ9L3dwZSkKIHNldChGT1JXQVJESU5HX0hFQURFUlNfV1BFX0VYVEVOU0lPTl9ESVIgJHtG T1JXQVJESU5HX0hFQURFUlNfRElSfS93cGUtd2ViZXh0ZW5zaW9uKQogc2V0KERFUklWRURfU09V UkNFU19XUEVfQVBJX0RJUiAke0RFUklWRURfU09VUkNFU19XRUJLSVRfRElSfS93cGUpCiAKLSMg QnVpbGQgd2l0aCAtZnZpc2liaWxpdHk9aGlkZGVuIHRvIHJlZHVjZSB0aGUgc2l6ZSBvZiB0aGUg c2hhcmVkIGxpYnJhcnkuCi0jIE5vdCB0byBiZSB1c2VkIHdoZW4gYnVpbGRpbmcgdGhlIFdlYktp dFRlc3RSdW5uZXIgbGlicmFyeS4KIGlmIChOT1QgREVWRUxPUEVSX01PREUpCi0gICAgc2V0KENN QUtFX0NfRkxBR1NfUkVMRUFTRSAiJHtDTUFLRV9DX0ZMQUdTX1JFTEVBU0V9IC1mdmlzaWJpbGl0 eT1oaWRkZW4iKQotICAgIHNldChDTUFLRV9DWFhfRkxBR1NfUkVMRUFTRSAiJHtDTUFLRV9DWFhf RkxBR1NfUkVMRUFTRX0gLWZ2aXNpYmlsaXR5PWhpZGRlbiAtZnZpc2liaWxpdHktaW5saW5lcy1o aWRkZW4iKQorICAgIHNldChXZWJLaXRfVkVSU0lPTl9TQ1JJUFQgIi1XbCwtLXZlcnNpb24tc2Ny aXB0LCR7Q01BS0VfTU9EVUxFX1BBVEh9L3dwZXN5bWJvbHMuZmlsdGVyIikKIGVuZGlmICgpCiAK IGluY2x1ZGUoR1N0cmVhbWVyQ2hlY2tzKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL3dwZXN5 bWJvbHMuZmlsdGVyIGIvU291cmNlL2NtYWtlL3dwZXN5bWJvbHMuZmlsdGVyCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LmI4MDBmZTVlZWJmM2I3OGQ5ZDQ0MzFlNGUzNTNiOGQ2NTQyNDEyN2MKLS0tIC9kZXYvbnVsbAor KysgYi9Tb3VyY2UvY21ha2Uvd3Blc3ltYm9scy5maWx0ZXIKQEAgLTAsMCArMSwxMiBAQAorewor Z2xvYmFsOgorICB3ZWJraXRfKjsKKyAgV2ViUHJvY2Vzc01haW5Vbml4OworICBOZXR3b3JrUHJv Y2Vzc01haW5Vbml4OworICBTdG9yYWdlUHJvY2Vzc01haW5Vbml4OworICBfWk42V2ViS2l0MjJX ZWJLaXRFeHRlbnNpb25NYW5hZ2VyMTBpbml0aWFsaXplRVBOU18xNEluamVjdGVkQnVuZGxlRVBO M0FQSTZPYmplY3RFOworICBfWk42V2ViS2l0MjJXZWJLaXRFeHRlbnNpb25NYW5hZ2VyOXNpbmds ZXRvbkV2OworbG9jYWw6CisgIHdlYmtpdF9tZWRpYV9wbGF5ZXJfZGVidWc7CisgICo7Cit9Owpk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDZlOTQ2Njk1NzUwN2U0YmYy YmVmZDM1MWNkNjg4MjA4OTRkMzU1NDcuLmYzMTVjZjAzOWRlNWU5MWY4MTMwNWZlZDZmNDkxY2I4 NDIzNjMzZGYgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwyMyBAQAogMjAxNy0xMS0wNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxp YS5jb20+CiAKKyAgICAgICAgW1dQRV0gVXNlIGxpbmtlciBzY3JpcHQgdG8gY29udHJvbCBleHBv cnRlZCBzeW1ib2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzkzNTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgQyBBUEkgaXMgYmVpbmcgaW5hZHZlcnRlbnRseSBleHBvcnRlZCBiZWNhdXNlIGl0 J3MgbWFya2VkIGFzIFdFQktJVF9FWFBPUlQgaW4gdGhlIGhlYWRlcgorICAgICAgICBmaWxlcy4g QnV0IG9mIGNvdXJzZSBpdCBzaG91bGQgb25seSBiZSBleHBvcnRlZCBpbiBERVZFTE9QRVJfTU9E RSwgd2hlcmUgaXQncyBuZWVkZWQgZm9yCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXIuIFVzZSAo YWxtb3N0KSB0aGUgc2FtZSBsaW5rZXIgdmVyc2lvbiBzY3JpcHQgYXMgR1RLIHRvIGZpeCB0aGlz LiBJdCdzCisgICAgICAgIHNsaWdodGx5IGRpZmZlcmVudCBiZWNhdXNlIFdQRSBkb2VzIG5vdCBo YXZlIFdlYktpdFBsdWdpblByb2Nlc3MuCisKKyAgICAgICAgVGhpcyBhbHNvIHJlZHVjZXMgYmlu YXJ5IHNpemUgb2YgbGliV1BFV2ViS2l0LnNvIGluIGRlYnVnIG1vZGUgZnJvbSA2MTUgTUIgZG93 biB0byA0OTcgTUIuCisgICAgICAgIChIYXZlbid0IGNoZWNrZWQgcmVsZWFzZSBtb2RlLikKKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOgorICAgICAgICAqIFNvdXJj ZS9jbWFrZS93cGVzeW1ib2xzLmZpbHRlcjogQWRkZWQuCisKKzIwMTctMTEtMDYgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQs IGZpeCBXUEUgYnVpbGQgYWZ0ZXIgcjIyNDQ5MgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc5MDA5CiAK