179072 2017-10-31 13:03:42 -0700 Web Inspector: Canvas Tab: selecting Frame tree element should update preview/slider, does nothing 2017-12-04 17:40:54 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 173807 175485 1 bburg hi commit-queue hi inspector-bugzilla-changes mattbaker webkit-bug-importer oldest_to_newest 1366517 0 bburg 2017-10-31 13:03:42 -0700 Steps to reproduce: - Capture a bunch of frames that change slightly, like webkit.org or acko.net animated backgrounds - Select a frame, go between frames with arrow keys => Preview doesn't update, unless going to "initial state" This is really annoying because I want to quickly find a frame with a particular visual feature or glitch. If I use the slider to try and scrub, then the preview flickers a lot as it needs to show all intermediate clear() calls. When I select a frame tree element, I would expect it to show the a preview after the final output-affecting command in the frame window. That way I can expand an interesting frame and see how it's built up from an initial clear() call. 1366519 1 webkit-bug-importer 2017-10-31 13:04:28 -0700 <rdar://problem/35278711> 1366524 2 hi 2017-10-31 13:14:52 -0700 The original Recording tab had this functionality. The new Canvas tab removed it (<https://webkit.org/b/177606>). I don't take multi-frame recordings very often, so I'm don't have a strong opinion about how it should work. 1367837 3 325869 hi 2017-11-03 00:32:26 -0700 Created attachment 325869 Patch 1368523 4 325869 mattbaker 2017-11-05 19:27:39 -0800 Comment on attachment 325869 Patch r=me, with some thoughts: I left this behavior out during the redesign, because of the effect it has on the slider when selecting actions in the sidebar with up/down keys. Doing nothing when selecting a frame tree element probably wasn't the right choice, but was done to prevent this: With multiple frames expanded, select the first frame: Frame 1* Action 1 Action 2 Frame 2 Action 3 => Slider shows 2 of 3 Press down arrow once: Frame 1 Action 1* Action 2 Frame 2 Action 3 => Slider shows 1 of 3 For the change in the slider to be monotonic, selecting a frame tree element would need to select the first child action instead of the last. But this prevents skipping to the end of the recording by selecting the last frame tree element. 1368526 5 325869 commit-queue 2017-11-05 19:47:09 -0800 Comment on attachment 325869 Patch Clearing flags on attachment: 325869 Committed r224475: <https://trac.webkit.org/changeset/224475> 1368527 6 commit-queue 2017-11-05 19:47:10 -0800 All reviewed patches have been landed. Closing bug. 325869 2017-11-03 00:32:26 -0700 2017-11-05 19:47:09 -0800 Patch bug-179072-20171103003225.patch text/plain 3583 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY0Zjc1NGM3MDU1NDgyYWQ5ZWFiNTg1MzIxNzlh MDQ1ZTc4MTZhMWUuLmU3OGZjNjhlMThjNzI3NzRlZTlhNmQ2MmE4MWU5OTJkNDczYTFkYjUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE3LTExLTAzICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENhbnZhcyBUYWI6IHNlbGVjdGluZyBGcmFtZSB0cmVlIGVsZW1lbnQgc2hvdWxkIHVwZGF0 ZSBwcmV2aWV3L3NsaWRlciwgZG9lcyBub3RoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzkwNzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1 Mjc4NzExPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9DYW52YXNUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAg KFdJLkNhbnZhc1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5fbmF2aWdhdGlvblNpZGViYXJUcmVl T3V0bGluZVNlbGVjdGlvbkNoYW5nZWQpOgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9SZWNvcmRpbmdBY3Rpb25UcmVlRWxlbWVudC5jc3M6CisgICAgICAgICguaXRlbS5hY3Rpb24g PiAudGl0bGVzIC5wYXJhbWV0ZXIuc3dpenpsZWQpOgorICAgICAgICAoLnRyZWUtb3V0bGluZTpu b3QoOmZvY3VzLCAuZm9yY2UtZm9jdXMpIC5pdGVtLmFjdGlvbjpub3QoLmluaXRpYWwtc3RhdGUs IC5wYXJlbnQsIC5pbnZhbGlkKSA+IC5pY29uKTogRGVsZXRlZC4KKyAgICAgICAgKGJvZHk6bm90 KC53aW5kb3ctaW5hY3RpdmUsIC53aW5kb3ctZG9ja2VkLWluYWN0aXZlKSAuaXRlbS5hY3Rpb24g PiAudGl0bGVzIC5wYXJhbWV0ZXIuc3dpenpsZWQpOiBEZWxldGVkLgorICAgICAgICBEcml2ZS1i eTogcmVtb3ZlIGV4dHJhIDpmb2N1cyBzZWxlY3RvcnMgdG8gcHJldmVudCBpY29uIGZsYXNoaW5n IHdoZW4gdGhlIHdpbmRvdyBpcyBibHVycmVkLgorCisyMDE3LTExLTAzICBEZXZpbiBSb3Vzc28g IDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENhbnZh czJEIFByb2ZpbGluZzogaGlnaGxpZ2h0IGV4cGVuc2l2ZSBjb250ZXh0IGNvbW1hbmRzIGluIHRo ZSBjYXB0dXJlZCBjb21tYW5kIGxvZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc4MzAyCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMzE1ODg0OT4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nh bnZhc1RhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQ2FudmFzVGFiQ29udGVudFZpZXcuanMKaW5kZXggMmNjYTc5NzlmY2NmMGI0OWZm OGNmOGQ4NDYzYjYxN2VlNDc3OTE3My4uZGE4YWFjNzJkNWZmZjg0YTk1OTM0ZjQxY2ZkNWQ2MThh NjNhNzE0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQ2FudmFzVGFiQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzVGFiQ29udGVudFZpZXcuanMKQEAgLTI3MSwxNCAr MjcxLDE0IEBAIFdJLkNhbnZhc1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgQ2FudmFzVGFiQ29udGVu dFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50QnJvd3NlclRhCiAgICAgICAgIGlmICghZXZlbnQuZGF0 YS5zZWxlY3RlZEVsZW1lbnQpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgbGV0IHNl bGVjdGVkVHJlZUVsZW1lbnQgPSBldmVudC5kYXRhLnNlbGVjdGVkRWxlbWVudDsKLSAgICAgICAg aWYgKHNlbGVjdGVkVHJlZUVsZW1lbnQgaW5zdGFuY2VvZiBXSS5Gb2xkZXJUcmVlRWxlbWVudCkK LSAgICAgICAgICAgIHJldHVybjsKLQogICAgICAgICBsZXQgcmVjb3JkaW5nQ29udGVudFZpZXcg PSB0aGlzLmNvbnRlbnRCcm93c2VyLmN1cnJlbnRDb250ZW50VmlldzsKICAgICAgICAgaWYgKCEo cmVjb3JkaW5nQ29udGVudFZpZXcgaW5zdGFuY2VvZiBXSS5SZWNvcmRpbmdDb250ZW50Vmlldykp CiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgbGV0IHNlbGVjdGVkVHJlZUVsZW1lbnQg PSBldmVudC5kYXRhLnNlbGVjdGVkRWxlbWVudDsKKyAgICAgICAgaWYgKHNlbGVjdGVkVHJlZUVs ZW1lbnQgaW5zdGFuY2VvZiBXSS5Gb2xkZXJUcmVlRWxlbWVudCkKKyAgICAgICAgICAgIHNlbGVj dGVkVHJlZUVsZW1lbnQgPSBzZWxlY3RlZFRyZWVFbGVtZW50LmNoaWxkcmVuLmxhc3RWYWx1ZTsK KwogICAgICAgICB0aGlzLl91cGRhdGVBY3Rpb25JbmRleChzZWxlY3RlZFRyZWVFbGVtZW50Lmlu ZGV4LCB7c3VwcHJlc3NOYXZpZ2F0aW9uU2lkZWJhclVwZGF0ZTogdHJ1ZX0pOwogICAgIH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVj b3JkaW5nQWN0aW9uVHJlZUVsZW1lbnQuY3NzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvUmVjb3JkaW5nQWN0aW9uVHJlZUVsZW1lbnQuY3NzCmluZGV4IDViNDQ0 NjEyOWFmMjcwMDVlMTFiNDYzMGQ0YzcyM2M4MjQ2NjJhNjMuLjM4YjY1MzdjZjQ0Yzc1MTEzZDI3 NzQ4ZGZlMThlMzg2ZjM2M2E3YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1JlY29yZGluZ0FjdGlvblRyZWVFbGVtZW50LmNzcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNvcmRpbmdBY3Rpb25U cmVlRWxlbWVudC5jc3MKQEAgLTI3LDEwICsyNyw2IEBACiAgICAgY29udGVudDogdXJsKCIuLi9J bWFnZXMvU291cmNlLnN2ZyIpOwogfQogCi0udHJlZS1vdXRsaW5lOm5vdCg6Zm9jdXMsIC5mb3Jj ZS1mb2N1cykgLml0ZW0uYWN0aW9uOm5vdCguaW5pdGlhbC1zdGF0ZSwgLnBhcmVudCwgLmludmFs aWQpID4gLmljb24gewotICAgIG9wYWNpdHk6IDAuNzsKLX0KLQogLml0ZW0uYWN0aW9uOm5vdCgu aW5pdGlhbC1zdGF0ZSk6OmJlZm9yZSB7CiAgICAgcG9zaXRpb246IHJlbGF0aXZlOwogICAgIHRv cDogM3B4OwpAQCAtNjEsNyArNTcsNyBAQCBib2R5W2Rpcj1ydGxdIC5pdGVtLmFjdGlvbjo6YmVm b3JlIHsKICAgICBvcGFjaXR5OiAxOwogfQogCi1ib2R5Om5vdCgud2luZG93LWluYWN0aXZlLCAu d2luZG93LWRvY2tlZC1pbmFjdGl2ZSkgLml0ZW0uYWN0aW9uID4gLnRpdGxlcyAucGFyYW1ldGVy LnN3aXp6bGVkIHsKKy5pdGVtLmFjdGlvbiA+IC50aXRsZXMgLnBhcmFtZXRlci5zd2l6emxlZCB7 CiAgICAgY29sb3I6IHZhcigtLXRleHQtY29sb3ItZ3JheS1tZWRpdW0pOwogfQogCg==