179039 2017-10-30 17:29:42 -0700 [WPE] -Wsign-compare warning in EventSenderProxyWPE.cpp 2017-11-15 12:08:40 -0800 1 1 1 Unclassified WebKit WPE WebKit Other PC Linux RESOLVED FIXED P2 Normal --- 178894 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro webkit-bug-importer zan oldest_to_newest 1366246 0 mcatanzaro 2017-10-30 17:29:42 -0700 In bug #178899 I was accidentally using a release build, so I missed a spot: [1342/1390] Building CXX object Tools/...nner.dir/wpe/EventSenderProxyWPE.cpp.o In file included from ../../Source/WTF/wtf/CheckedArithmetic.h:29:0, from ../../Source/WTF/wtf/Vector.h:29, from ../../Source/WTF/wtf/Deque.h:37, from ../../Tools/WebKitTestRunner/EventSenderProxy.h:30, from ../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:27: ../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: In member function ‘void WTR::EventSenderProxy::updateTouchPoint(int, int, int)’: ../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:292:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] ASSERT(index >= 0 && index <= m_touchEvents.size()); ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WTF/wtf/Assertions.h:301:11: note: in definition of macro ‘ASSERT’ if (!(assertion)) { \ ^~~~~~~~~ ../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: In member function ‘void WTR::EventSenderProxy::releaseTouchPoint(int)’: ../../Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:367:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] ASSERT(index >= 0 && index <= m_touchEvents.size()); ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WTF/wtf/Assertions.h:301:11: note: in definition of macro ‘ASSERT’ if (!(assertion)) { \ ^~~~~~~~~ 1366296 1 325412 mcatanzaro 2017-10-30 19:36:42 -0700 Created attachment 325412 Patch 1368608 2 325412 commit-queue 2017-11-06 06:42:58 -0800 Comment on attachment 325412 Patch Clearing flags on attachment: 325412 Committed r224488: <https://trac.webkit.org/changeset/224488> 1368609 3 commit-queue 2017-11-06 06:43:00 -0800 All reviewed patches have been landed. Closing bug. 325412 2017-10-30 19:36:42 -0700 2017-11-06 06:42:58 -0800 Patch bug-179039-20171030213641.patch text/plain 1827 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjA2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjlkZGM3NTgwYjlmNTIzMTQ2MmQxNjIwYzU1MjM5ZDUy NDFmYzkzMi4uM2U1OWNiZGI0M2Q4ZGUwYjZmYmU4ZDdhNjI4OGJkNDU1ZTRkMDU3ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDE3LTEwLTMwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KIAorICAgICAgICBbV1BFXSAtV3NpZ24tY29tcGFyZSB3YXJuaW5nIGluIEV2ZW50U2VuZGVy UHJveHlXUEUuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzkwMzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFdlYktpdFRlc3RSdW5uZXIvd3BlL0V2ZW50U2VuZGVyUHJveHlXUEUuY3BwOgorICAg ICAgICAoV1RSOjpFdmVudFNlbmRlclByb3h5Ojp1cGRhdGVUb3VjaFBvaW50KToKKyAgICAgICAg KFdUUjo6RXZlbnRTZW5kZXJQcm94eTo6cmVsZWFzZVRvdWNoUG9pbnQpOgorCisyMDE3LTEwLTMw ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwogICAgICAgICBX S0J1bmRsZVBhZ2VXaWxsU2VuZFN1Ym1pdEV2ZW50Q2FsbGJhY2sgaXMgY2FsbGVkIHdpdGggaW5j b3JyZWN0IGZyYW1lIHBhcmFtZXRlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc2NzE5CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvd3BlL0V2ZW50U2VuZGVyUHJveHlXUEUuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93 cGUvRXZlbnRTZW5kZXJQcm94eVdQRS5jcHAKaW5kZXggZmQ4ZDQ2YTQzNmM3ZDA4NWI2OGY4NzZm YWUwNzVhMmExMmI5Y2U3Ny4uYjI3MTE4OGUwNjlmMWIxMTlkYjBmYjg1MGY4NmJiYTI4ZWVkODRl OCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93cGUvRXZlbnRTZW5kZXJQcm94 eVdQRS5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93cGUvRXZlbnRTZW5kZXJQcm94 eVdQRS5jcHAKQEAgLTI4OSw3ICsyODksNyBAQCB2b2lkIEV2ZW50U2VuZGVyUHJveHk6OmFkZFRv dWNoUG9pbnQoaW50IHgsIGludCB5KQogCiB2b2lkIEV2ZW50U2VuZGVyUHJveHk6OnVwZGF0ZVRv dWNoUG9pbnQoaW50IGluZGV4LCBpbnQgeCwgaW50IHkpCiB7Ci0gICAgQVNTRVJUKGluZGV4ID49 IDAgJiYgaW5kZXggPD0gbV90b3VjaEV2ZW50cy5zaXplKCkpOworICAgIEFTU0VSVChpbmRleCA+ PSAwICYmIHN0YXRpY19jYXN0PHNpemVfdD4oaW5kZXgpIDw9IG1fdG91Y2hFdmVudHMuc2l6ZSgp KTsKIAogICAgIGF1dG8mIHJhd0V2ZW50ID0gbV90b3VjaEV2ZW50c1tpbmRleF07CiAgICAgcmF3 RXZlbnQueCA9IHg7CkBAIC0zNjQsNyArMzY0LDcgQEAgdm9pZCBFdmVudFNlbmRlclByb3h5Ojpj bGVhclRvdWNoUG9pbnRzKCkKIAogdm9pZCBFdmVudFNlbmRlclByb3h5OjpyZWxlYXNlVG91Y2hQ b2ludChpbnQgaW5kZXgpCiB7Ci0gICAgQVNTRVJUKGluZGV4ID49IDAgJiYgaW5kZXggPD0gbV90 b3VjaEV2ZW50cy5zaXplKCkpOworICAgIEFTU0VSVChpbmRleCA+PSAwICYmIHN0YXRpY19jYXN0 PHNpemVfdD4oaW5kZXgpIDw9IG1fdG91Y2hFdmVudHMuc2l6ZSgpKTsKIAogICAgIGF1dG8mIHJh d0V2ZW50ID0gbV90b3VjaEV2ZW50c1tpbmRleF07CiAgICAgcmF3RXZlbnQudGltZSA9IG1fdGlt ZTsK