178805 2017-10-25 10:12:56 -0700 Web Inspector: Canvas Tab: starting a second recording doesn't show red titlebar if the first recording was empty 2017-12-04 17:40:34 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://acko.net InRadar P2 Normal --- 173807 175485 1 bburg hi bburg commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1364262 0 bburg 2017-10-25 10:12:56 -0700 STR: 1. Go to a site with a canvas that doesn't do anything without interaction (acko.net) 2. Select the Canvas, start a recording 3. Stop the recording => Nothing happens, the recording is empty 4. Start a new recording again => Red titlebar not present, Recording button doesn't change from circle to square 1364263 1 webkit-bug-importer 2017-10-25 10:13:19 -0700 <rdar://problem/35176303> 1364388 2 324865 hi 2017-10-25 12:31:44 -0700 Created attachment 324865 Patch 1364422 3 324865 bburg 2017-10-25 13:24:13 -0700 Comment on attachment 324865 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324865&action=review r=me with some test issues. Please re-EWS the test changes, thanks. > LayoutTests/inspector/canvas/recording-2d.html:480 > + throw "Missing 2D canvas."; Does an async function wrap this in an Error? If not, please throw an Error. Throwing a string will lose exception context, IIRC. > LayoutTests/inspector/canvas/recording-2d.html:493 > + await CanvasAgent.stopRecording(canvas.identifier); It is weird to use CanvasAgent directly, but use CanvasManager right above. I'd prefer you stick to manager API if using inspector-test.js 1364464 4 324865 hi 2017-10-25 14:14:51 -0700 Comment on attachment 324865 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324865&action=review >> LayoutTests/inspector/canvas/recording-2d.html:493 >> + await CanvasAgent.stopRecording(canvas.identifier); > > It is weird to use CanvasAgent directly, but use CanvasManager right above. I'd prefer you stick to manager API if using inspector-test.js The issue with using CanvasManager is that it doesn't return a promise, meaning that we cant use async-await. I'll restructure the test to make it work. 1364473 5 324895 hi 2017-10-25 14:20:08 -0700 Created attachment 324895 Patch 1364490 6 324895 bburg 2017-10-25 14:45:24 -0700 Comment on attachment 324895 Patch r=mews 1364491 7 bburg 2017-10-25 14:45:49 -0700 (In reply to Devin Rousso from comment #4) > Comment on attachment 324865 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324865&action=review > > >> LayoutTests/inspector/canvas/recording-2d.html:493 > >> + await CanvasAgent.stopRecording(canvas.identifier); > > > > It is weird to use CanvasAgent directly, but use CanvasManager right above. I'd prefer you stick to manager API if using inspector-test.js > > The issue with using CanvasManager is that it doesn't return a promise, > meaning that we cant use async-await. I'll restructure the test to make it > work. I figured. Sorry to ruin your fun. Someday we'll fix that? 1364586 8 324895 commit-queue 2017-10-25 16:50:15 -0700 Comment on attachment 324895 Patch Clearing flags on attachment: 324895 Committed r223998: <https://trac.webkit.org/changeset/223998> 1364587 9 commit-queue 2017-10-25 16:50:16 -0700 All reviewed patches have been landed. Closing bug. 324865 2017-10-25 12:31:44 -0700 2017-10-25 14:20:07 -0700 Patch bug-178805-20171025123143.patch text/plain 5004 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NmE5MTQ3YjRkZTY4MzgyN2VmZTYzMjg1OWIzZmNiMThhZjM1ODQ4Li4x MzU2ZjZhNDNmNTg3MjMyYzgwY2QyMzBjZGI5MDhjMjYzODk2YjlkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTctMTAtMjUgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNz by5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzIFRhYjogc3RhcnRpbmcgYSBz ZWNvbmQgcmVjb3JkaW5nIGRvZXNuJ3Qgc2hvdyByZWQgdGl0bGViYXIgaWYgdGhlIGZpcnN0IHJl Y29yZGluZyB3YXMgZW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3ODgwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzUxNzYzMDM+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCB1cGRhdGVkIGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rv ckNhbnZhc0FnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNhbnZhc0FnZW50 OjpkaWRGaW5pc2hSZWNvcmRpbmdDYW52YXNGcmFtZSk6CisgICAgICAgIElmIHRoZSByZWNvcmRp bmcgd2FzIHN0b3BwZWQgYW5kIGhhZCBubyBkYXRhLCByZXNldCB0aGUgQ2FsbFRyYWNpbmdBY3Rp dmUgZmxhZyB0byBmYWxzZS4KKwogMjAxNy0xMC0yNSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2Vr QGlnYWxpYS5jb20+CiAKICAgICAgICAgTWFrZSBTRVJWSUNFX1dPUktFUiBmZWF0dXJlIGJ1aWxk YWJsZSBvbiBHVEssIFdQRQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckNhbnZhc0FnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JDYW52YXNBZ2VudC5jcHAKaW5kZXggZmQxMjFjNjE2NGJmNDZjODNjYzkyOWI3MTI2Y2YzZDQ4 MzU3MDhkMy4uMDBhMWE3YmVlMGQ3MWJlYWYyOGViNDk5NjFhOGVhMTVkNzUxYTc2YSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNhbnZhc0FnZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwCkBA IC00NjEsOCArNDYxLDExIEBAIHZvaWQgSW5zcGVjdG9yQ2FudmFzQWdlbnQ6OmRpZEZpbmlzaFJl Y29yZGluZ0NhbnZhc0ZyYW1lKEhUTUxDYW52YXNFbGVtZW50JiBjYW52CiAgICAgICAgIHJldHVy bjsKIAogICAgIGlmICghaW5zcGVjdG9yQ2FudmFzLT5oYXNSZWNvcmRpbmdEYXRhKCkpIHsKLSAg ICAgICAgaWYgKGZvcmNlRGlzcGF0Y2gpCisgICAgICAgIGlmIChmb3JjZURpc3BhdGNoKSB7CiAg ICAgICAgICAgICBtX2Zyb250ZW5kRGlzcGF0Y2hlci0+cmVjb3JkaW5nRmluaXNoZWQoaW5zcGVj dG9yQ2FudmFzLT5pZGVudGlmaWVyKCksIG51bGxwdHIpOworCisgICAgICAgICAgICBpbnNwZWN0 b3JDYW52YXMtPnJlc2V0UmVjb3JkaW5nRGF0YSgpOworICAgICAgICB9CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCBmMjFiMjI4NDMwYzU2MWY1NDA1NWZlM2FiZDU2MTVhYmI1NDg2 OWY0Li5kNTNiYTI1ZTY5OTZlNDQ5MTQxMzI5OTQ4NDQwZWVmNjA2MmI5YzI3IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMTYgQEAKIDIwMTctMTAtMjUgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNz by5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzIFRhYjogc3RhcnRpbmcgYSBz ZWNvbmQgcmVjb3JkaW5nIGRvZXNuJ3Qgc2hvdyByZWQgdGl0bGViYXIgaWYgdGhlIGZpcnN0IHJl Y29yZGluZyB3YXMgZW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3ODgwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzUxNzYzMDM+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv Y2FudmFzL3JlY29yZGluZy0yZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL2Nh bnZhcy9yZWNvcmRpbmctMmQuaHRtbDoKKworMjAxNy0xMC0yNSAgRGV2aW4gUm91c3NvICA8d2Vi a2l0QGRldmlucm91c3NvLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBwcmVzZXJ2ZSBS ZWNvcmRpbmdzIGZvciBlYWNoIENhbnZhcyBhZnRlciBjbG9zaW5nIHRoZSBDYW52YXMgdGFiCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg3NjcKICAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MTY3MjM5PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctMmQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctMmQtZXhwZWN0ZWQudHh0CmluZGV4IDUzMzgwYjU0 YTEyNTE0ZDBhNmEyZGY0ZTNjYWE1NTE2OTY1NWM5MjMuLjFjZjBhNDUwYTgwYjcwYmNjZmQxM2Jh MjJhMWRlMGIyNTI0M2U3ZDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52 YXMvcmVjb3JkaW5nLTJkLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y2FudmFzL3JlY29yZGluZy0yZC1leHBlY3RlZC50eHQKQEAgLTEzNjQsMyArMTM2NCw3IEBAIFBB U1M6IFRoZSBmaXJzdCBmcmFtZSBzaG91bGQgaGF2ZSAxIGFjdGlvbi4KIFBBU1M6IFRoZSBhY3Rp b24gc2hvdWxkIGhhdmUgMSBwYXJhbWV0ZXIuCiBQQVNTOiBUaGUgcGFyYW1ldGVyIHNob3VsZCBi ZSBudWxsLgogCistLSBSdW5uaW5nIHRlc3QgY2FzZTogQ2FudmFzLnJlY29yZGluZzJELk5vQWN0 aW9ucworUEFTUzogQSByZWNvcmRpbmcgc2hvdWxkIGhhdmUgYmVlbiBzdGFydGVkIGFuZCBzdG9w cGVkIG9uY2UuCitQQVNTOiBBIHJlY29yZGluZyBzaG91bGQgaGF2ZSBiZWVuIHN0YXJ0ZWQgYW5k IHN0b3BwZWQgdHdpY2UuCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52 YXMvcmVjb3JkaW5nLTJkLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL3JlY29y ZGluZy0yZC5odG1sCmluZGV4IGI2N2E2MzQ1NDcxOTc4ZjgzMzFkZTI5ZmFhNzAzMjM1OTZiYjJj YTcuLjcyY2IyNjQwMjZhOTRkNzM0OWFhNjg3MWYxOWFjZDlhN2E4ZGY0NTMgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLTJkLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctMmQuaHRtbApAQCAtNDcxLDYgKzQ3 MSwzNiBAQCBmdW5jdGlvbiB0ZXN0KCkgewogICAgICAgICB9LAogICAgIH0pOwogCisgICAgc3Vp dGUuYWRkVGVzdENhc2UoeworICAgICAgICBuYW1lOiAiQ2FudmFzLnJlY29yZGluZzJELk5vQWN0 aW9ucyIsCisgICAgICAgIGRlc2NyaXB0aW9uOiAiQ2hlY2sgdGhhdCBhIGNhbnZhcyBpcyBzdGls bCBhYmxlIHRvIGJlIHJlY29yZGVkIGFmdGVyIHN0b3BwaW5nIGEgcmVjb3JkaW5nIHdpdGggbm8g YWN0aW9ucy4iLAorICAgICAgICBhc3luYyB0ZXN0KCkgeworICAgICAgICAgICAgbGV0IGNhbnZh cyA9IGdldENhbnZhcyhXSS5DYW52YXMuQ29udGV4dFR5cGUuQ2FudmFzMkQpOworICAgICAgICAg ICAgaWYgKCFjYW52YXMpCisgICAgICAgICAgICAgICAgdGhyb3cgIk1pc3NpbmcgMkQgY2FudmFz LiI7CisKKyAgICAgICAgICAgIGxldCBldmVudENvdW50ID0gMDsKKyAgICAgICAgICAgIGZ1bmN0 aW9uIGhhbmRsZVJlY29yZGluZ1N0b3BwZWQoZXZlbnQpIHsKKyAgICAgICAgICAgICAgICBJbnNw ZWN0b3JUZXN0LmFzc2VydChldmVudC5kYXRhLmNhbnZhcyA9PT0gY2FudmFzLCAiV2Ugc2hvdWxk IGhhdmUgc3RvcHBlZCByZWNvcmRpbmcgdGhlIHNlbGVjdGVkIGNhbnZhcy4iKTsKKyAgICAgICAg ICAgICAgICArK2V2ZW50Q291bnQ7CisKKyAgICAgICAgICAgICAgICBpZiAoZXZlbnRDb3VudCA+ PSAyKQorICAgICAgICAgICAgICAgICAgICBXSS5jYW52YXNNYW5hZ2VyLnJlbW92ZUV2ZW50TGlz dGVuZXIoaGFuZGxlUmVjb3JkaW5nU3RvcHBlZCk7CisgICAgICAgICAgICB9CisgICAgICAgICAg ICBXSS5jYW52YXNNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV0kuQ2FudmFzTWFuYWdlci5FdmVu dC5SZWNvcmRpbmdTdG9wcGVkLCBoYW5kbGVSZWNvcmRpbmdTdG9wcGVkKTsKKworICAgICAgICAg ICAgYXdhaXQgQ2FudmFzQWdlbnQuc3RhcnRSZWNvcmRpbmcoY2FudmFzLmlkZW50aWZpZXIpOwor ICAgICAgICAgICAgYXdhaXQgQ2FudmFzQWdlbnQuc3RvcFJlY29yZGluZyhjYW52YXMuaWRlbnRp Zmllcik7CisKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0RXF1YWwoZXZlbnRDb3Vu dCwgMSwgIkEgcmVjb3JkaW5nIHNob3VsZCBoYXZlIGJlZW4gc3RhcnRlZCBhbmQgc3RvcHBlZCBv bmNlLiIpOworCisgICAgICAgICAgICBhd2FpdCBDYW52YXNBZ2VudC5zdGFydFJlY29yZGluZyhj YW52YXMuaWRlbnRpZmllcik7CisgICAgICAgICAgICBhd2FpdCBDYW52YXNBZ2VudC5zdG9wUmVj b3JkaW5nKGNhbnZhcy5pZGVudGlmaWVyKTsKKworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5l eHBlY3RFcXVhbChldmVudENvdW50LCAyLCAiQSByZWNvcmRpbmcgc2hvdWxkIGhhdmUgYmVlbiBz dGFydGVkIGFuZCBzdG9wcGVkIHR3aWNlLiIpOworICAgICAgICB9LAorICAgIH0pOworCiAgICAg c3VpdGUucnVuVGVzdENhc2VzQW5kRmluaXNoKCk7CiB9CiA8L3NjcmlwdD4K 324895 2017-10-25 14:20:08 -0700 2017-10-25 16:50:15 -0700 Patch bug-178805-20171025142008.patch text/plain 5008 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NmE5MTQ3YjRkZTY4MzgyN2VmZTYzMjg1OWIzZmNiMThhZjM1ODQ4Li43 NWMwNjQ3NThlMmFhNDk1ZGQ1MjRiYmU2YjQ1NjQ3MTYyZmVhMjZmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTctMTAtMjUgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNz by5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzIFRhYjogc3RhcnRpbmcgYSBz ZWNvbmQgcmVjb3JkaW5nIGRvZXNuJ3Qgc2hvdyByZWQgdGl0bGViYXIgaWYgdGhlIGZpcnN0IHJl Y29yZGluZyB3YXMgZW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3ODgwNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzUxNzYzMDM+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQnJpYW4gQnVyZy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHVw ZGF0ZWQgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ2Fu dmFzQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ2FudmFzQWdlbnQ6OmRp ZEZpbmlzaFJlY29yZGluZ0NhbnZhc0ZyYW1lKToKKyAgICAgICAgSWYgdGhlIHJlY29yZGluZyB3 YXMgc3RvcHBlZCBhbmQgaGFkIG5vIGRhdGEsIHJlc2V0IHRoZSBDYWxsVHJhY2luZ0FjdGl2ZSBm bGFnIHRvIGZhbHNlLgorCiAyMDE3LTEwLTI1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdh bGlhLmNvbT4KIAogICAgICAgICBNYWtlIFNFUlZJQ0VfV09SS0VSIGZlYXR1cmUgYnVpbGRhYmxl IG9uIEdUSywgV1BFCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQ2FudmFzQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNh bnZhc0FnZW50LmNwcAppbmRleCBmZDEyMWM2MTY0YmY0NmM4M2NjOTI5YjcxMjZjZjNkNDgzNTcw OGQzLi4wMGExYTdiZWUwZDcxYmVhZjI4ZWI0OTk2MWE4ZWExNWQ3NTFhNzZhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDYW52YXNBZ2VudC5jcHAKQEAgLTQ2 MSw4ICs0NjEsMTEgQEAgdm9pZCBJbnNwZWN0b3JDYW52YXNBZ2VudDo6ZGlkRmluaXNoUmVjb3Jk aW5nQ2FudmFzRnJhbWUoSFRNTENhbnZhc0VsZW1lbnQmIGNhbnYKICAgICAgICAgcmV0dXJuOwog CiAgICAgaWYgKCFpbnNwZWN0b3JDYW52YXMtPmhhc1JlY29yZGluZ0RhdGEoKSkgewotICAgICAg ICBpZiAoZm9yY2VEaXNwYXRjaCkKKyAgICAgICAgaWYgKGZvcmNlRGlzcGF0Y2gpIHsKICAgICAg ICAgICAgIG1fZnJvbnRlbmREaXNwYXRjaGVyLT5yZWNvcmRpbmdGaW5pc2hlZChpbnNwZWN0b3JD YW52YXMtPmlkZW50aWZpZXIoKSwgbnVsbHB0cik7CisKKyAgICAgICAgICAgIGluc3BlY3RvckNh bnZhcy0+cmVzZXRSZWNvcmRpbmdEYXRhKCk7CisgICAgICAgIH0KICAgICAgICAgcmV0dXJuOwog ICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IGYyMWIyMjg0MzBjNTYxZjU0MDU1ZmUzYWJkNTYxNWFiYjU0ODY5ZjQu LmMxZjhmNzE3OTM0NWRiOWUyZDMxNzRiNWM2YWJjNDZkYjFkNWM2YzAgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSAr MSwxNiBAQAogMjAxNy0xMC0yNSAgRGV2aW4gUm91c3NvICA8d2Via2l0QGRldmlucm91c3NvLmNv bT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBDYW52YXMgVGFiOiBzdGFydGluZyBhIHNlY29u ZCByZWNvcmRpbmcgZG9lc24ndCBzaG93IHJlZCB0aXRsZWJhciBpZiB0aGUgZmlyc3QgcmVjb3Jk aW5nIHdhcyBlbXB0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTc4ODA1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTE3NjMwMz4KKworICAgICAg ICBSZXZpZXdlZCBieSBCcmlhbiBCdXJnLgorCisgICAgICAgICogaW5zcGVjdG9yL2NhbnZhcy9y ZWNvcmRpbmctMmQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGluc3BlY3Rvci9jYW52YXMvcmVj b3JkaW5nLTJkLmh0bWw6CisKKzIwMTctMTAtMjUgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZp bnJvdXNzby5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogcHJlc2VydmUgUmVjb3JkaW5n cyBmb3IgZWFjaCBDYW52YXMgYWZ0ZXIgY2xvc2luZyB0aGUgQ2FudmFzIHRhYgogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NzY3CiAgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNTE2NzIzOT4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rv ci9jYW52YXMvcmVjb3JkaW5nLTJkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9jYW52YXMvcmVjb3JkaW5nLTJkLWV4cGVjdGVkLnR4dAppbmRleCA1MzM4MGI1NGExMjUxNGQw YTZhMmRmNGUzY2FhNTUxNjk2NTVjOTIzLi4xY2YwYTQ1MGE4MGI3MGJjY2ZkMTNiYTIyYTFkZTBi MjUyNDNlN2Q5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL3JlY29y ZGluZy0yZC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NhbnZhcy9y ZWNvcmRpbmctMmQtZXhwZWN0ZWQudHh0CkBAIC0xMzY0LDMgKzEzNjQsNyBAQCBQQVNTOiBUaGUg Zmlyc3QgZnJhbWUgc2hvdWxkIGhhdmUgMSBhY3Rpb24uCiBQQVNTOiBUaGUgYWN0aW9uIHNob3Vs ZCBoYXZlIDEgcGFyYW1ldGVyLgogUEFTUzogVGhlIHBhcmFtZXRlciBzaG91bGQgYmUgbnVsbC4K IAorLS0gUnVubmluZyB0ZXN0IGNhc2U6IENhbnZhcy5yZWNvcmRpbmcyRC5Ob0FjdGlvbnMKK1BB U1M6IEEgcmVjb3JkaW5nIHNob3VsZCBoYXZlIGJlZW4gc3RhcnRlZCBhbmQgc3RvcHBlZCBvbmNl LgorUEFTUzogQSByZWNvcmRpbmcgc2hvdWxkIGhhdmUgYmVlbiBzdGFydGVkIGFuZCBzdG9wcGVk IHR3aWNlLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL3JlY29y ZGluZy0yZC5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NhbnZhcy9yZWNvcmRpbmctMmQu aHRtbAppbmRleCBiNjdhNjM0NTQ3MTk3OGY4MzMxZGUyOWZhYTcwMzIzNTk2YmIyY2E3Li5jMjUy MTAyZTg4Mjc3NjIxZTRmZTdkNmM1ODVlNGU3ZjFkZDM5NmFkIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvY2FudmFzL3JlY29yZGluZy0yZC5odG1sCisrKyBiL0xheW91dFRlc3Rz L2luc3BlY3Rvci9jYW52YXMvcmVjb3JkaW5nLTJkLmh0bWwKQEAgLTQ3MSw2ICs0NzEsMzkgQEAg ZnVuY3Rpb24gdGVzdCgpIHsKICAgICAgICAgfSwKICAgICB9KTsKIAorICAgIHN1aXRlLmFkZFRl c3RDYXNlKHsKKyAgICAgICAgbmFtZTogIkNhbnZhcy5yZWNvcmRpbmcyRC5Ob0FjdGlvbnMiLAor ICAgICAgICBkZXNjcmlwdGlvbjogIkNoZWNrIHRoYXQgYSBjYW52YXMgaXMgc3RpbGwgYWJsZSB0 byBiZSByZWNvcmRlZCBhZnRlciBzdG9wcGluZyBhIHJlY29yZGluZyB3aXRoIG5vIGFjdGlvbnMu IiwKKyAgICAgICAgdGVzdChyZXNvbHZlLCByZWplY3QpIHsKKyAgICAgICAgICAgIGxldCBjYW52 YXMgPSBnZXRDYW52YXMoV0kuQ2FudmFzLkNvbnRleHRUeXBlLkNhbnZhczJEKTsKKyAgICAgICAg ICAgIGlmICghY2FudmFzKQorICAgICAgICAgICAgICAgIHRocm93ICJNaXNzaW5nIDJEIGNhbnZh cy4iOworCisgICAgICAgICAgICBsZXQgZXZlbnRDb3VudCA9IDA7CisgICAgICAgICAgICBmdW5j dGlvbiBoYW5kbGVSZWNvcmRpbmdTdG9wcGVkKGV2ZW50KSB7CisgICAgICAgICAgICAgICAgSW5z cGVjdG9yVGVzdC5hc3NlcnQoZXZlbnQuZGF0YS5jYW52YXMgPT09IGNhbnZhcywgIldlIHNob3Vs ZCBoYXZlIHN0b3BwZWQgcmVjb3JkaW5nIHRoZSBzZWxlY3RlZCBjYW52YXMuIik7CisgICAgICAg ICAgICAgICAgKytldmVudENvdW50OworCisgICAgICAgICAgICAgICAgaWYgKGV2ZW50Q291bnQg PT0gMSkKKyAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5wYXNzKCJBIHJlY29yZGlu ZyBzaG91bGQgaGF2ZSBiZWVuIHN0YXJ0ZWQgYW5kIHN0b3BwZWQgb25jZS4iKTsKKworICAgICAg ICAgICAgICAgIGlmIChldmVudENvdW50ID49IDIpIHsKKyAgICAgICAgICAgICAgICAgICAgSW5z cGVjdG9yVGVzdC5wYXNzKCJBIHJlY29yZGluZyBzaG91bGQgaGF2ZSBiZWVuIHN0YXJ0ZWQgYW5k IHN0b3BwZWQgdHdpY2UuIik7CisKKyAgICAgICAgICAgICAgICAgICAgV0kuY2FudmFzTWFuYWdl ci5yZW1vdmVFdmVudExpc3RlbmVyKGhhbmRsZVJlY29yZGluZ1N0b3BwZWQpOworICAgICAgICAg ICAgICAgICAgICByZXNvbHZlKCk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQor ICAgICAgICAgICAgV0kuY2FudmFzTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdJLkNhbnZhc01h bmFnZXIuRXZlbnQuUmVjb3JkaW5nU3RvcHBlZCwgaGFuZGxlUmVjb3JkaW5nU3RvcHBlZCk7CisK KyAgICAgICAgICAgIFdJLmNhbnZhc01hbmFnZXIuc3RhcnRSZWNvcmRpbmcoY2FudmFzKTsKKyAg ICAgICAgICAgIFdJLmNhbnZhc01hbmFnZXIuc3RvcFJlY29yZGluZygpOworCisgICAgICAgICAg ICBXSS5jYW52YXNNYW5hZ2VyLnN0YXJ0UmVjb3JkaW5nKGNhbnZhcyk7CisgICAgICAgICAgICBX SS5jYW52YXNNYW5hZ2VyLnN0b3BSZWNvcmRpbmcoKTsKKyAgICAgICAgfSwKKyAgICB9KTsKKwog ICAgIHN1aXRlLnJ1blRlc3RDYXNlc0FuZEZpbmlzaCgpOwogfQogPC9zY3JpcHQ+Cg==