178788 2017-10-25 06:17:20 -0700 [HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer 2017-11-15 12:45:32 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 178625 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro mmaxfield webkit-bug-importer oldest_to_newest 1364184 0 cgarcia 2017-10-25 06:17:20 -0700 Instead of using the TextRun direction. If the TextRun is ltr, but the harfbuzz buffer is rtl, the character indexes will be swapped in m_coreTextIndices. 1364185 1 324814 cgarcia 2017-10-25 06:20:27 -0700 Created attachment 324814 Patch 1364206 2 324814 mcatanzaro 2017-10-25 08:25:19 -0700 Comment on attachment 324814 Patch ¯\_(ツ)_/¯ 1364702 3 cgarcia 2017-10-25 23:03:43 -0700 Committed r224007: <https://trac.webkit.org/changeset/224007> 1372241 4 webkit-bug-importer 2017-11-15 12:45:32 -0800 <rdar://problem/35568097> 324814 2017-10-25 06:20:27 -0700 2017-10-25 08:25:19 -0700 Patch wc-hf-ltr.diff text/plain 5584 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMTJiZjI3NTZiNi4uOTZiN2Q0MDhlZDQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0xMC0yNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0hhcmZCdXp6XSBDb21wbGV4VGV4dFJ1biBzaG91bGQgaW5p dGlhbGl6ZSBkaXJlY3Rpb24gZnJvbSB0aGUgaGFyZmJ1enogYnVmZmVyCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg3ODgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIHVzaW5nIHRoZSBU ZXh0UnVuIGRpcmVjdGlvbi4gSWYgdGhlIFRleHRSdW4gaXMgbHRyLCBidXQgdGhlIGhhcmZidXp6 IGJ1ZmZlciBpcyBydGwsIHRoZSBjaGFyYWN0ZXIKKyAgICAgICAgaW5kZXhlcyB3aWxsIGJlIHN3 YXBwZWQgaW4gbV9jb3JlVGV4dEluZGljZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9Db21wbGV4VGV4dENvbnRyb2xsZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBsZXhUZXh0 Q29udHJvbGxlcjo6Q29tcGxleFRleHRSdW46OmNyZWF0ZSk6IFJlbW92ZSB0aGUgbHRyIHBhcmFt ZXRlci4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Db21wbGV4VGV4dENv bnRyb2xsZXJIYXJmQnV6ei5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wbGV4VGV4dENvbnRy b2xsZXI6OkNvbXBsZXhUZXh0UnVuOjpDb21wbGV4VGV4dFJ1bik6IEluaXRpYWxpemUgbV9pc0xU UiB1c2luZyBoYl9idWZmZXJfZ2V0X2RpcmVjdGlvbigpLgorICAgICAgICAoV2ViQ29yZTo6Q29t cGxleFRleHRDb250cm9sbGVyOjpjb2xsZWN0Q29tcGxleFRleHRSdW5zRm9yQ2hhcmFjdGVycyk6 IERvIG5vdCBwYXNzIGx0ciB0byBDb21wbGV4VGV4dFJ1bjo6Y3JlYXRlKCkuCisKIDIwMTctMTAt MjUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFNpbXBsZSBhbmQgY29tcGxleCBwYXRocyBhcmUgbm90IGFwcGxpZWQgY29uc2lzdGVudGx5CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db21wbGV4VGV4dENv bnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbXBsZXhUZXh0 Q29udHJvbGxlci5oCmluZGV4IDYzNzhhZmJjNjE4Li5kOGY2M2JmMjI1NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29tcGxleFRleHRDb250cm9sbGVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29tcGxleFRleHRDb250cm9s bGVyLmgKQEAgLTc5LDkgKzc5LDkgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuIGFkb3B0 UmVmKCpuZXcgQ29tcGxleFRleHRSdW4oY3RSdW4sIGZvbnQsIGNoYXJhY3RlcnMsIHN0cmluZ0xv Y2F0aW9uLCBzdHJpbmdMZW5ndGgsIGluZGV4QmVnaW4sIGluZGV4RW5kKSk7CiAgICAgICAgIH0K IAotICAgICAgICBzdGF0aWMgUmVmPENvbXBsZXhUZXh0UnVuPiBjcmVhdGUoaGJfYnVmZmVyX3Qq IGJ1ZmZlciwgY29uc3QgRm9udCYgZm9udCwgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHVuc2ln bmVkIHN0cmluZ0xvY2F0aW9uLCB1bnNpZ25lZCBzdHJpbmdMZW5ndGgsIHVuc2lnbmVkIGluZGV4 QmVnaW4sIHVuc2lnbmVkIGluZGV4RW5kLCBib29sIGx0cikKKyAgICAgICAgc3RhdGljIFJlZjxD b21wbGV4VGV4dFJ1bj4gY3JlYXRlKGhiX2J1ZmZlcl90KiBidWZmZXIsIGNvbnN0IEZvbnQmIGZv bnQsIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBzdHJpbmdMb2NhdGlvbiwgdW5z aWduZWQgc3RyaW5nTGVuZ3RoLCB1bnNpZ25lZCBpbmRleEJlZ2luLCB1bnNpZ25lZCBpbmRleEVu ZCkKICAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQ29tcGxleFRl eHRSdW4oYnVmZmVyLCBmb250LCBjaGFyYWN0ZXJzLCBzdHJpbmdMb2NhdGlvbiwgc3RyaW5nTGVu Z3RoLCBpbmRleEJlZ2luLCBpbmRleEVuZCwgbHRyKSk7CisgICAgICAgICAgICByZXR1cm4gYWRv cHRSZWYoKm5ldyBDb21wbGV4VGV4dFJ1bihidWZmZXIsIGZvbnQsIGNoYXJhY3RlcnMsIHN0cmlu Z0xvY2F0aW9uLCBzdHJpbmdMZW5ndGgsIGluZGV4QmVnaW4sIGluZGV4RW5kKSk7CiAgICAgICAg IH0KIAogICAgICAgICBzdGF0aWMgUmVmPENvbXBsZXhUZXh0UnVuPiBjcmVhdGUoY29uc3QgRm9u dCYgZm9udCwgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHVuc2lnbmVkIHN0cmluZ0xvY2F0aW9u LCB1bnNpZ25lZCBzdHJpbmdMZW5ndGgsIHVuc2lnbmVkIGluZGV4QmVnaW4sIHVuc2lnbmVkIGlu ZGV4RW5kLCBib29sIGx0cikKQEAgLTE0Miw3ICsxNDIsNyBAQCBwdWJsaWM6CiAKICAgICBwcml2 YXRlOgogICAgICAgICBDb21wbGV4VGV4dFJ1bihDVFJ1blJlZiwgY29uc3QgRm9udCYsIGNvbnN0 IFVDaGFyKiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBzdHJpbmdMb2NhdGlvbiwgdW5zaWduZWQgc3Ry aW5nTGVuZ3RoLCB1bnNpZ25lZCBpbmRleEJlZ2luLCB1bnNpZ25lZCBpbmRleEVuZCk7Ci0gICAg ICAgIENvbXBsZXhUZXh0UnVuKGhiX2J1ZmZlcl90KiwgY29uc3QgRm9udCYsIGNvbnN0IFVDaGFy KiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBzdHJpbmdMb2NhdGlvbiwgdW5zaWduZWQgc3RyaW5nTGVu Z3RoLCB1bnNpZ25lZCBpbmRleEJlZ2luLCB1bnNpZ25lZCBpbmRleEVuZCwgYm9vbCBsdHIpOwor ICAgICAgICBDb21wbGV4VGV4dFJ1bihoYl9idWZmZXJfdCosIGNvbnN0IEZvbnQmLCBjb25zdCBV Q2hhciogY2hhcmFjdGVycywgdW5zaWduZWQgc3RyaW5nTG9jYXRpb24sIHVuc2lnbmVkIHN0cmlu Z0xlbmd0aCwgdW5zaWduZWQgaW5kZXhCZWdpbiwgdW5zaWduZWQgaW5kZXhFbmQpOwogICAgICAg ICBDb21wbGV4VGV4dFJ1bihjb25zdCBGb250JiwgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHVu c2lnbmVkIHN0cmluZ0xvY2F0aW9uLCB1bnNpZ25lZCBzdHJpbmdMZW5ndGgsIHVuc2lnbmVkIGlu ZGV4QmVnaW4sIHVuc2lnbmVkIGluZGV4RW5kLCBib29sIGx0cik7CiAgICAgICAgIFdFQkNPUkVf RVhQT1JUIENvbXBsZXhUZXh0UnVuKGNvbnN0IFZlY3RvcjxGbG9hdFNpemU+JiBhZHZhbmNlcywg Y29uc3QgVmVjdG9yPEZsb2F0UG9pbnQ+JiBvcmlnaW5zLCBjb25zdCBWZWN0b3I8R2x5cGg+JiBn bHlwaHMsIGNvbnN0IFZlY3Rvcjx1bnNpZ25lZD4mIHN0cmluZ0luZGljZXMsIEZsb2F0U2l6ZSBp bml0aWFsQWR2YW5jZSwgY29uc3QgRm9udCYsIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCB1bnNp Z25lZCBzdHJpbmdMb2NhdGlvbiwgdW5zaWduZWQgc3RyaW5nTGVuZ3RoLCB1bnNpZ25lZCBpbmRl eEJlZ2luLCB1bnNpZ25lZCBpbmRleEVuZCwgYm9vbCBsdHIpOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Db21wbGV4VGV4dENvbnRyb2xs ZXJIYXJmQnV6ei5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6 ei9Db21wbGV4VGV4dENvbnRyb2xsZXJIYXJmQnV6ei5jcHAKaW5kZXggYjE3MDMzYzU4YzEuLjk0 ODBlYjkzYzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9o YXJmYnV6ei9Db21wbGV4VGV4dENvbnRyb2xsZXJIYXJmQnV6ei5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovQ29tcGxleFRleHRDb250cm9sbGVySGFy ZkJ1enouY3BwCkBAIC0zOCw3ICszOCw3IEBAIHN0YXRpYyBpbmxpbmUgZmxvYXQgaGFyZkJ1enpQ b3NpdGlvblRvRmxvYXQoaGJfcG9zaXRpb25fdCB2YWx1ZSkKICAgICByZXR1cm4gc3RhdGljX2Nh c3Q8ZmxvYXQ+KHZhbHVlKSAvICgxIDw8IDE2KTsKIH0KIAotQ29tcGxleFRleHRDb250cm9sbGVy OjpDb21wbGV4VGV4dFJ1bjo6Q29tcGxleFRleHRSdW4oaGJfYnVmZmVyX3QqIGJ1ZmZlciwgY29u c3QgRm9udCYgZm9udCwgY29uc3QgVUNoYXIqIGNoYXJhY3RlcnMsIHVuc2lnbmVkIHN0cmluZ0xv Y2F0aW9uLCB1bnNpZ25lZCBzdHJpbmdMZW5ndGgsIHVuc2lnbmVkIGluZGV4QmVnaW4sIHVuc2ln bmVkIGluZGV4RW5kLCBib29sIGx0cikKK0NvbXBsZXhUZXh0Q29udHJvbGxlcjo6Q29tcGxleFRl eHRSdW46OkNvbXBsZXhUZXh0UnVuKGhiX2J1ZmZlcl90KiBidWZmZXIsIGNvbnN0IEZvbnQmIGZv bnQsIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBzdHJpbmdMb2NhdGlvbiwgdW5z aWduZWQgc3RyaW5nTGVuZ3RoLCB1bnNpZ25lZCBpbmRleEJlZ2luLCB1bnNpZ25lZCBpbmRleEVu ZCkKICAgICA6IG1faW5pdGlhbEFkdmFuY2UoMCwgMCkKICAgICAsIG1fZm9udChmb250KQogICAg ICwgbV9jaGFyYWN0ZXJzKGNoYXJhY3RlcnMpCkBAIC00Nyw3ICs0Nyw3IEBAIENvbXBsZXhUZXh0 Q29udHJvbGxlcjo6Q29tcGxleFRleHRSdW46OkNvbXBsZXhUZXh0UnVuKGhiX2J1ZmZlcl90KiBi dWZmZXIsIGNvbnN0CiAgICAgLCBtX2luZGV4RW5kKGluZGV4RW5kKQogICAgICwgbV9nbHlwaENv dW50KGhiX2J1ZmZlcl9nZXRfbGVuZ3RoKGJ1ZmZlcikpCiAgICAgLCBtX3N0cmluZ0xvY2F0aW9u KHN0cmluZ0xvY2F0aW9uKQotICAgICwgbV9pc0xUUihsdHIpCisgICAgLCBtX2lzTFRSKEhCX0RJ UkVDVElPTl9JU19GT1JXQVJEKGhiX2J1ZmZlcl9nZXRfZGlyZWN0aW9uKGJ1ZmZlcikpKQogewog ICAgIGlmICghbV9nbHlwaENvdW50KQogICAgICAgICByZXR1cm47CkBAIC0yMjQsNyArMjI0LDcg QEAgdm9pZCBDb21wbGV4VGV4dENvbnRyb2xsZXI6OmNvbGxlY3RDb21wbGV4VGV4dFJ1bnNGb3JD aGFyYWN0ZXJzKGNvbnN0IFVDaGFyKiBjaGEKIAogICAgICAgICBIYlVuaXF1ZVB0cjxoYl9mb250 X3Q+IGhhcmZCdXp6Rm9udChmYWNlLT5jcmVhdGVGb250KCkpOwogICAgICAgICBoYl9zaGFwZSho YXJmQnV6ekZvbnQuZ2V0KCksIGJ1ZmZlci5nZXQoKSwgZmVhdHVyZXMuaXNFbXB0eSgpID8gbnVs bHB0ciA6IGZlYXR1cmVzLmRhdGEoKSwgZmVhdHVyZXMuc2l6ZSgpKTsKLSAgICAgICAgbV9jb21w bGV4VGV4dFJ1bnMuYXBwZW5kKENvbXBsZXhUZXh0UnVuOjpjcmVhdGUoYnVmZmVyLmdldCgpLCAq Zm9udCwgY2hhcmFjdGVycywgc3RyaW5nTG9jYXRpb24sIGxlbmd0aCwgcnVuLnN0YXJ0SW5kZXgs IHJ1bi5lbmRJbmRleCwgbV9ydW4ubHRyKCkpKTsKKyAgICAgICAgbV9jb21wbGV4VGV4dFJ1bnMu YXBwZW5kKENvbXBsZXhUZXh0UnVuOjpjcmVhdGUoYnVmZmVyLmdldCgpLCAqZm9udCwgY2hhcmFj dGVycywgc3RyaW5nTG9jYXRpb24sIGxlbmd0aCwgcnVuLnN0YXJ0SW5kZXgsIHJ1bi5lbmRJbmRl eCkpOwogICAgICAgICBoYl9idWZmZXJfcmVzZXQoYnVmZmVyLmdldCgpKTsKICAgICB9CiB9Cg==