178642 2017-10-22 02:12:25 -0700 stress/check-string-ident.js is improperly skipped 2017-11-15 13:11:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 108645 1 zan zan fpizlo mark.lam ryanhaddad saam webkit-bug-importer oldest_to_newest 1363131 0 zan 2017-10-22 02:12:25 -0700 The stress/check-string-ident.js was added in r207017: https://trac.webkit.org/changeset/207017/webkit It was later skipped in r208205: https://trac.webkit.org/changeset/208205/webkit It's still flaky, with the number of DFG compiles varying across different runs. It's not properly skipped though -- while the skip directive is used in the JS file, the following defaultNoEagerRun directive still sets up the test to run as if the skipping wasn't done. 1363132 1 324523 zan 2017-10-22 02:15:56 -0700 Created attachment 324523 Patch 1363133 2 324523 zan 2017-10-22 02:19:57 -0700 Comment on attachment 324523 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324523&action=review > JSTests/stress/check-string-ident.js:-2 > +// Skipped due to flakiness, used defaultNoEagerRun before. > //@ skip > -//@ defaultNoEagerRun This enforces skipping on all platforms (as it was probably intended), but I've only seen the test fail on ARM platforms. 1363215 3 324523 zan 2017-10-22 22:27:31 -0700 Comment on attachment 324523 Patch Clearing flags on attachment: 324523 Committed r223832: <https://trac.webkit.org/changeset/223832> 1363216 4 zan 2017-10-22 22:27:35 -0700 All reviewed patches have been landed. Closing bug. 1372393 5 webkit-bug-importer 2017-11-15 13:11:23 -0800 <rdar://problem/35568948> 324523 2017-10-22 02:15:56 -0700 2017-10-22 22:27:31 -0700 Patch bug-178642-20171022111555.patch text/plain 1187 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODIyCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDliYTczNjNiMmE2MWI2ZDdkOTIxYjIyMmFiY2Ji YTFiMDRjMzRkZjguLmE5NmExZWUxZWUyMmUyMjFlMjkxNzU0OWFhNTNmMWNhZmExMDI2ZTMgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTctMTAtMjIgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEu Y29tPgorCisgICAgICAgIHN0cmVzcy9jaGVjay1zdHJpbmctaWRlbnQuanMgaXMgaW1wcm9wZXJs eSBza2lwcGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzg2NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHN0cmVzcy9jaGVjay1zdHJpbmctaWRlbnQuanM6IERyb3AgdGhlIGRlZmF1bHROb0VhZ2Vy UnVuIGRpcmVjdGl2ZQorICAgICAgICBzaW5jZSBpdCBlbmZvcmNlcyB0aGUgcnVuLWpzYy1zdHJl c3MtdGVzdHMgc2NyaXB0IHRvIHN0aWxsIHNldCB1cCB0aGUKKyAgICAgICAgdGVzdCB0byBydW4s IGRlc3BpdGUgdGhlIHNraXAgZGlyZWN0aXZlIHRoYXQncyB1c2VkIGJlZm9yZS4KKwogMjAxNy0x MC0yMCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgdGVz dCBjYXNlIGZvciByMjE0MzM0LgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvY2hlY2stc3Ry aW5nLWlkZW50LmpzIGIvSlNUZXN0cy9zdHJlc3MvY2hlY2stc3RyaW5nLWlkZW50LmpzCmluZGV4 IGEyYmNiYmY4NzE0MWEyZTIyNDI0YjY3NzNjMDRhODQyMzFlZWYzYmMuLmZjMTc0MjE3OThlZmUy MmM2MjlmODA0NWQ2ODJlNDFiMjI4MWY3YjcgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL2No ZWNrLXN0cmluZy1pZGVudC5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9jaGVjay1zdHJpbmctaWRl bnQuanMKQEAgLTEsNSArMSw1IEBACisvLyBTa2lwcGVkIGR1ZSB0byBmbGFraW5lc3MsIHVzZWQg ZGVmYXVsdE5vRWFnZXJSdW4gYmVmb3JlLgogLy9AIHNraXAKLS8vQCBkZWZhdWx0Tm9FYWdlclJ1 bgogCiBjb25zdCBvID0geyBiYXo6IDIwIH07CiBmdW5jdGlvbiBmb28ocCkgewo=