178371 2017-10-16 18:29:47 -0700 de-flakify http/tests/security/cross-frame-access-put.html 2017-10-17 10:42:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 178272 1 achristensen achristensen ryanhaddad sam thorton webkit-bug-importer oldest_to_newest 1361048 0 achristensen 2017-10-16 18:29:47 -0700 de-flakify http/tests/security/cross-frame-access-put.html 1361049 1 323966 achristensen 2017-10-16 18:32:23 -0700 Created attachment 323966 Patch 1361051 2 achristensen 2017-10-16 18:32:37 -0700 *** Bug 151053 has been marked as a duplicate of this bug. *** 1361292 3 323966 thorton 2017-10-17 10:27:08 -0700 Comment on attachment 323966 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323966&action=review > LayoutTests/ChangeLog:8 > + In the iframe, the test was being run after 0ms. Sometimes, the whole iframe hadn't loaded yet, You should get signoff from the test's author, since it's in security/ > LayoutTests/http/tests/security/cross-frame-access-put.html:33 > + alert(message.data); Did you mean to leave this alert here? 1361304 4 achristensen 2017-10-17 10:40:06 -0700 Mostly added in http://trac.webkit.org/r30634 I cc'd Sam in case he has any input, but this test still tests the accessibility of properties and still reports those results. This test was never intended to test the synchronousness of loading. 1361305 5 achristensen 2017-10-17 10:40:47 -0700 (In reply to Tim Horton from comment #3) > > LayoutTests/http/tests/security/cross-frame-access-put.html:33 > > + alert(message.data); > > Did you mean to leave this alert here? Yes, so we can see that the message is being sent in the results. 1361308 6 achristensen 2017-10-17 10:41:40 -0700 http://trac.webkit.org/r223556 1361310 7 webkit-bug-importer 2017-10-17 10:42:49 -0700 <rdar://problem/35032351> 323966 2017-10-16 18:32:23 -0700 2017-10-17 10:27:08 -0700 Patch bug-178371-20171016183222.patch text/plain 5198 achristensen SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyMzQ1MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTE2ICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgZGUtZmxha2lmeSBodHRwL3Rl c3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1wdXQuaHRtbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MzcxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIGlmcmFtZSwgdGhlIHRlc3Qg d2FzIGJlaW5nIHJ1biBhZnRlciAwbXMuICBTb21ldGltZXMsIHRoZSB3aG9sZSBpZnJhbWUgaGFk bid0IGxvYWRlZCB5ZXQsCisgICAgICAgIHNvIHdpbmRvdy5pbm5lckhlaWdodCBhbmQgd2luZG93 LmlubmVyV2lkdGggd2VyZSAwIGluc3RlYWQgb2YgdGhlaXIgaW50ZW5kZWQgdmFsdWVzLiAgVGhp cyBjaGFuZ2VzCisgICAgICAgIHRoZSB0ZXN0IHRvIHdhaXQgZm9yIHRoZSBpZnJhbWUgdG8gZmlu aXNoIGxvYWRpbmcgYmVmb3JlIHJ1bm5pbmcgdGhlIHRlc3QsIHRoZW4gcG9zdCBhIG1lc3NhZ2Ug dG8KKyAgICAgICAgdGhlIHBhcmVudCB0byB0ZWxsIGl0IHRvIGZpbmlzaCBydW5uaW5nIGl0cyB0 ZXN0IGluc3RlYWQgb2YganVzdCByZWx5aW5nIG9uIHNldFRpbWVvdXQoLi4uLCAwKSB0bworICAg ICAgICBhbHdheXMgd29yayBhZnRlciB0aGUgaWZyYW1lIGhhZCBmaW5pc2hlZCBsb2FkaW5nLgor CisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtcHV0LWV4 cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFj Y2Vzcy1wdXQuaHRtbDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L3Jlc291cmNlcy9j cm9zcy1mcmFtZS1pZnJhbWUtZm9yLXB1dC10ZXN0Lmh0bWw6CisgICAgICAgICogcGxhdGZvcm0v bWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDE3LTEwLTE2ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRE9NUXVhZC5wMSAvIHAyIC8gcDMgLyBwNCBzaG91 bGQgYmVoYXZlIGFzIFtTYW1lT2JqZWN0XQpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9z ZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtcHV0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1wdXQt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMjM0MDcpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1wdXQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC0xODUsNiArMTg1LDcgQEAgQUxFUlQ6IFBBU1M6IHdpbmRvdy5zZXRJbnRlcnZhbCBz aG91bGQgYgogQUxFUlQ6IFBBU1M6IHdpbmRvdy5zZXRUaW1lb3V0IHNob3VsZCBiZSAnZnVuY3Rp b24gc2V0VGltZW91dCgpIHsgICAgW25hdGl2ZSBjb2RlXX0nIGFuZCBpcy4KIEFMRVJUOiBQQVNT OiB3aW5kb3cuc2hvd01vZGFsRGlhbG9nIG1hdGNoZWQgdGhlIGV4cGVjdGVkIHZhbHVlLgogQUxF UlQ6IFBBU1M6IHdpbmRvdy5zdG9wIHNob3VsZCBiZSAnZnVuY3Rpb24gc3RvcCgpIHsgICAgW25h dGl2ZSBjb2RlXX0nIGFuZCBpcy4KK0FMRVJUOiBjb250aW51ZSB0ZXN0IGluIHBhcmVudCBmcmFt ZQogVGhpcyB0ZXN0IGNoZWNrcyBjcm9zcy1mcmFtZSBhY2Nlc3Mgc2VjdXJpdHkgb2Ygd2luZG93 IGF0dHJpYnV0ZSBzZXR0ZXJzIChyZGFyOi8vcHJvYmxlbS81MzI2NzkxKS4KIAogCkluZGV4OiBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1wdXQuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZy YW1lLWFjY2Vzcy1wdXQuaHRtbAkocmV2aXNpb24gMjIzNDA3KQorKysgTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtcHV0Lmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTE5LDIwICsxOSwxOCBAQCBmdW5jdGlvbiBzZXRGb3JiaWRkZW5Qcm9wZXJ0eShvYmos IHByb3ApCiAKIHdpbmRvdy50YXJnZXRXaW5kb3cgPSB3aW5kb3cuZnJhbWVzWzBdOwogCit3aW5k b3cuYWRkRXZlbnRMaXN0ZW5lcigibWVzc2FnZSIsIHRlc3QsIGZhbHNlKTsKKwogd2luZG93Lm9u bG9hZCA9IGZ1bmN0aW9uKCkKIHsKICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKICAgICAg ICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CiAgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGls RG9uZSgpOwogICAgIH0KLQotICAgIC8vIFRoZXJlIGlzIGNvZGUgaW4gc3ViZnJhbWUgdGhhdCBy dW5zIHNvbWUgdGVzdHMsIGFuZCB0aGF0IGlzIHNjaGVkdWxlZCBvbiBhIHplcm8gZGVsYXkKLSAg ICAvLyB0aW1lciB3aGVuIHRoZSBzdWJmcmFtZSBsb2Fkcy4gVGhlIHRpbWVyIHRoYXQgd2Ugc2No ZWR1bGUgaGVyZSB3aWxsIHJ1biBhZnRlciB0aGUgb25lCi0gICAgLy8gaW4gc3ViZnJhbWUsIG1h a2luZyB0aGUgb3JkZXIgb2YgdGVzdHMgcHJlZGljdGFibGUuCi0gICAgc2V0VGltZW91dCh0ZXN0 LCAwKTsKIH0KIAotZnVuY3Rpb24gdGVzdCgpIHsKK2Z1bmN0aW9uIHRlc3QobWVzc2FnZSkgewor ICAgIGFsZXJ0KG1lc3NhZ2UuZGF0YSk7CiAgICAgLy8gRklYTUU6IFRoaXMgdGVzdCBzaG91bGQg dXNlIGZhc3Qvd2luZG93L3Jlc291cmNlcy93aW5kb3ctcHJvcGVydGllcy5qcyBpbnN0ZWFkIG9m IGEgY3VzdG9tIGxpc3QuCiAgICAgLy8gQ29uc3RydWN0b3JzCiAgICAgc2V0Rm9yYmlkZGVuUHJv cGVydHkodGFyZ2V0V2luZG93LCAiQXR0ciIpOwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9zZWN1cml0eS9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUtaWZyYW1lLWZvci1wdXQtdGVzdC5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvcmVzb3VyY2Vz L2Nyb3NzLWZyYW1lLWlmcmFtZS1mb3ItcHV0LXRlc3QuaHRtbAkocmV2aXNpb24gMjIzNDA3KQor KysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9yZXNvdXJjZXMvY3Jvc3MtZnJhbWUt aWZyYW1lLWZvci1wdXQtdGVzdC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yNDEsNyArMjQxLDcg QEAKIAogICAgICAgICAvLyBUaGUgdGVzdCBydW5zIG9uIGEgdGltZXIgYW5kIG5vdCBpbiBhIGxv YWQgZXZlbnQgaGFuZGxlciBiZWNhdXNlIHdlIHdhbnQgYm90aAogICAgICAgICAvLyB3aW5kb3cu b25sb2FkIGFuZCB3aW5kb3cuZXZlbnQgdG8gYmUgdW5kZWZpbmVkLgotICAgICAgICBzZXRUaW1l b3V0KGZ1bmN0aW9uKCkgeworICAgICAgICBmdW5jdGlvbiBydW5UZXN0KCkgewogICAgICAgICAg ICAgLy8gQ29uc3RydWN0b3JzCiAgICAgICAgICAgICBzaG91bGRCZSgid2luZG93LkF0dHIiLCAi QXR0ck9sZCIpOwogICAgICAgICAgICAgc2hvdWxkQmUoIndpbmRvdy5DREFUQVNlY3Rpb24iLCAi Q0RBVEFTZWN0aW9uT2xkIik7CkBAIC00NTEsNyArNDUxLDE1IEBACiAgICAgICAgICAgICAvLyBz aG93TW9kYWxEaWFsb2cgaXMgbm90IGltcGxlbWVudGVkIG9uIGFsbCBwbGF0Zm9ybXMgZm9yIER1 bXBSZW5kZXJUcmVlLiAgU28gZG9uJ3QgZGlzcGxheSB0aGUgdmFsdWVzLgogICAgICAgICAgICAg c2hvdWxkQmUoIndpbmRvdy5zaG93TW9kYWxEaWFsb2ciLCAic2hvd01vZGFsRGlhbG9nT2xkIiwg dHJ1ZSk7CiAgICAgICAgICAgICBzaG91bGRCZSgid2luZG93LnN0b3AiLCAic3RvcE9sZCIpOwot ICAgICAgICB9LCAwKTsKKyAgICAgICAgICAgIHdpbmRvdy5wYXJlbnQucG9zdE1lc3NhZ2UoImNv bnRpbnVlIHRlc3QgaW4gcGFyZW50IGZyYW1lIiwgIioiKQorICAgICAgICB9OworICAgICAgICBm dW5jdGlvbiBjaGVja0FuZFJ1blRlc3QoKSB7CisgICAgICAgICAgICBpZiAod2luZG93LmlubmVy SGVpZ2h0ID09IDE1MCkKKyAgICAgICAgICAgICAgICBydW5UZXN0KCk7CisgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICAgICAgc2V0VGltZW91dChjaGVja0FuZFJ1blRlc3QsIDEwKTsKKyAg ICAgICAgfQorICAgICAgICBjaGVja0FuZFJ1blRlc3QoKTsKICAgICA8L3NjcmlwdD4KIDwvYm9k eT4KIDwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVj dGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RF eHBlY3RhdGlvbnMJKHJldmlzaW9uIDIyMzQ0NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy13azIvVGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMzQwLDggKzM0MCw2IEBA IHdlYmtpdC5vcmcvYi8xNTAyNDEgd2ViYXJjaGl2ZS9sb2FkaW5nL28KIAogd2Via2l0Lm9yZy9i LzE1MDk0MiBhbmltYXRpb25zL211bHRpcGxlLWJhY2tncm91bmRzLmh0bWwgWyBQYXNzIEltYWdl T25seUZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTUxMDUzIGh0dHAvdGVzdHMvc2VjdXJpdHkv Y3Jvc3MtZnJhbWUtYWNjZXNzLXB1dC5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogd2Via2l0Lm9y Zy9iLzE1MTMyNiBbIFlvc2VtaXRlKyBdIHdlYmFyY2hpdmUvbG9hZGluZy9taXNzaW5nLWRhdGEu aHRtbCBbIFBhc3MgQ3Jhc2ggXQogCiB3ZWJraXQub3JnL2IvMTUxNDU1IFsgUmVsZWFzZSBdIGh0 dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy9tZXRob2RzLWFzeW5jLmh0bWwgWyBQYXNz IFRpbWVvdXQgXQo=