17806 2008-03-12 14:04:21 -0700 Arena.h's CLEAR_UNUSED should use statement1;statement2 instead of (statement1,statement2) 2008-03-13 20:45:45 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mark eric oldest_to_newest 73505 0 mark 2008-03-12 14:04:21 -0700 I don't think this (statement1,statement2) thing is necessary, and it's causing trouble for me in a build with DEBUG defined. As far as I'm aware, the only use of CLEAR_UNUSED is in Arena.cpp. 73506 1 19710 mark 2008-03-12 14:05:06 -0700 Created attachment 19710 Fix 73508 2 19710 eric 2008-03-12 14:17:41 -0700 Comment on attachment 19710 Fix I don't understand why your compiler would barf here. Or why our build doesn't barf. But the change looks sane. r=me. 73665 3 eric 2008-03-13 20:45:45 -0700 Thank you mark for making such easy-to-land patches. These took only a few minutes to land on my train ride home. :) These are revisions r31048 through r31053 19710 2008-03-12 14:05:06 -0700 2008-03-12 14:17:41 -0700 Fix webkit-17806.1.patch text/plain 1225 mark SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMxMDA1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMDMt MTIgIE1hcmsgTWVudG92YWkgIDxtYXJrQG1veGllbmV0LmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL0FyZW5hLmg6IFVzZSBz dGF0ZW1lbnQxO3N0YXRlbWVudDIgaW5zdGVhZCBvZgorCSAgKHN0YXRlbWVudDEsc3RhdGVtZW50 MikgaW4gQ0xFQVJfVU5VU0VELgorCiAyMDA4LTAzLTEyICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFw cGxlLmNvbT4KIAogICAgICAgICBNYWtlIHRoZSB6b29tIGZhY3RvciBhIGZsb2F0IGFuZCBub3Qg YSBwZXJjZW50LgpJbmRleDogcGxhdGZvcm0vQXJlbmEuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9y bS9BcmVuYS5oCShyZXZpc2lvbiAzMTAwNCkKKysrIHBsYXRmb3JtL0FyZW5hLmgJKHdvcmtpbmcg Y29weSkKQEAgLTk4LDkgKzk4LDkgQEAgdm9pZCogQXJlbmFBbGxvY2F0ZShBcmVuYVBvb2wgKnBv b2wsIHVucwogCiAjaWZkZWYgREVCVUcKICNkZWZpbmUgRlJFRV9QQVRURVJOIDB4REEKLSNkZWZp bmUgQ0xFQVJfVU5VU0VEKGEpIChBU1NFUlQoKGEpLT5hdmFpbCA8PSAoYSktPmxpbWl0KSwgXAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgbWVtc2V0KCh2b2lkKikoYSktPmF2YWlsLCBGUkVF X1BBVFRFUk4sIFwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYSktPmxpbWl0IC0gKGEp LT5hdmFpbCkpCisjZGVmaW5lIENMRUFSX1VOVVNFRChhKSBBU1NFUlQoKGEpLT5hdmFpbCA8PSAo YSktPmxpbWl0KTsgXAorICAgICAgICAgICAgICAgICAgICAgICAgbWVtc2V0KCh2b2lkKikoYSkt PmF2YWlsLCBGUkVFX1BBVFRFUk4sIFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYSkt PmxpbWl0IC0gKGEpLT5hdmFpbCkKICNkZWZpbmUgQ0xFQVJfQVJFTkEoYSkgIG1lbXNldCgodm9p ZCopKGEpLCBGUkVFX1BBVFRFUk4sIFwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYSkt PmxpbWl0IC0gKHV3b3JkKShhKSkKICNlbHNlCg==