177921 2017-10-05 00:33:35 -0700 [WinCairo] Fix build after Bug 167956 2017-10-05 03:50:34 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 167956 1 fujii fujii buildbot cgarcia commit-queue mmaxfield webkit-bug-importer oldest_to_newest 1356890 0 fujii 2017-10-05 00:33:35 -0700 [WinCairo] Fix build after Bug 167956 https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/6901 > FAILED: bin64/TestWebCoreLib.dll lib64/TestWebCoreLib.lib > cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll --intdir=Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir --manifests -- "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\link.exe" /nologo Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\win\main.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\win\TestWebCoreStubs.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\TestsController.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\AffineTransform.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\CalculationValue.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\ComplexTextController.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\CSSParser.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\FloatRect.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\FloatPoint.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\FloatSize.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\GridPosition.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\HTMLParserIdioms.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\IntRect.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\IntPoint.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\IntSize.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\LayoutUnit.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\MIMETypeRegistry.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\ParsedContentRange.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\SecurityOrigin.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\SharedBuffer.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\SharedBufferTest.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\TimeRanges.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\TransformationMatrix.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\URL.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\URLParser.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\win\DIBPixelData.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\win\LinkedFonts.cpp.obj Tools\TestWebKitAPI\CMakeFiles\TestWebCoreLib.dir\Tests\WebCore\win\BitmapImage.cpp.obj /out:bin64\TestWebCoreLib.dll /implib:lib64\TestWebCoreLib.lib /pdb:bin64\TestWebCoreLib.pdb /dll /version:0.0 /machine:x64 /DEBUG /OPT:ICF /OPT:REF /INCREMENTAL:NO /INCREMENTAL:NO -LIBPATH:C:\WebKit-BuildSlave\win-cairo-release\build\WebKitBuild\Release\lib64 -LIBPATH:C:\WebKit-BuildSlave\win-cairo-release\build\WebKitLibraries\win\lib64 Crypt32.lib D2d1.lib Dwrite.lib dxguid.lib Iphlpapi.lib Psapi.lib Shlwapi.lib Usp10.lib lib64\WebCore.lib lib64\WebCoreDerivedSources.lib WindowsCodecs.lib lib64\gtest.lib ..\..\WebKitLibraries\win\lib64\cairo.lib lib64\libANGLE.lib libeay32.lib mfuuid.lib ssleay32.lib strmiids.lib vcruntime.lib CFlite.lib ..\..\WebKitLibraries\win\lib64\libxml2.lib ..\..\WebKitLibraries\win\lib64\libxslt.lib ..\..\WebKitLibraries\win\lib64\SQLite3.lib lib64\JavaScriptCore.lib lib64\PAL.lib ..\..\WebKitLibraries\win\lib64\zdll.lib ..\..\WebKitLibraries\win\lib64\libcurl_imp.lib ..\..\WebKitLibraries\win\lib64\ssleay32.lib ..\..\WebKitLibraries\win\lib64\libeay32.lib ..\..\WebKitLibraries\win\lib64\libjpeg.lib ..\..\WebKitLibraries\win\lib64\libpng.lib ..\..\WebKitLibraries\win\lib64\zdll.lib ..\..\WebKitLibraries\win\lib64\libcurl_imp.lib ..\..\WebKitLibraries\win\lib64\ssleay32.lib ..\..\WebKitLibraries\win\lib64\libeay32.lib ..\..\WebKitLibraries\win\lib64\libjpeg.lib ..\..\WebKitLibraries\win\lib64\libpng.lib ..\..\WebKitLibraries\win\lib64\cairo.lib CFLite.lib comctl32.lib crypt32.lib iphlpapi.lib libcurl_imp.lib rpcrt4.lib shlwapi.lib usp10.lib version.lib ws2_32.lib lib64\libEGL.lib lib64\libGLESv2.lib lib64\libANGLE.lib D3d9.lib lib64\WTF.lib ..\..\WebKitLibraries\win\lib64\libicuuc.lib winmm.lib ..\..\WebKitLibraries\win\lib64\libicuin.lib CFlite.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ." > Creating library lib64\TestWebCoreLib.lib and object lib64\TestWebCoreLib.exp > > WebCore.lib(ComplexTextController.cpp.obj) : error LNK2019: unresolved external symbol "public: class WebCore::Font const * __cdecl WebCore::FontCascade::fontForCombiningCharacterSequence(wchar_t const *,unsigned __int64)const " (?fontForCombiningCharacterSequence@FontCascade@WebCore@@QEBAPEBVFont@2@PEB_W_K@Z) referenced in function "private: void __cdecl WebCore::ComplexTextController::collectComplexTextRuns(void)" (?collectComplexTextRuns@ComplexTextController@WebCore@@AEAAXXZ) > > bin64\TestWebCoreLib.dll : fatal error LNK1120: 1 unresolved externals 1356909 1 322802 fujii 2017-10-05 01:10:09 -0700 Created attachment 322802 Patch 1356944 2 322802 commit-queue 2017-10-05 03:49:49 -0700 Comment on attachment 322802 Patch Clearing flags on attachment: 322802 Committed r222908: <http://trac.webkit.org/changeset/222908> 1356945 3 commit-queue 2017-10-05 03:49:50 -0700 All reviewed patches have been landed. Closing bug. 1356946 4 webkit-bug-importer 2017-10-05 03:50:34 -0700 <rdar://problem/34830965> 322802 2017-10-05 01:10:09 -0700 2017-10-05 03:49:49 -0700 Patch bug-177921-20171005171008.patch text/plain 1542 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGExMmUxM2FhYTY2MDlk ZDM4NDQwZTI1ZTI5M2Q3NDgzODExYzFkNS4uY2MxZmJlZjFjZGQ3NmNlZTFhMjNmMzUxOWQ5NzQ4 MjI3N2QwNmZmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEwLTA1ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gRml4IGJ1aWxkIGFmdGVyIEJ1ZyAxNjc5NTYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzkyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZvbnRDYXNjYWRlOjpmb250Rm9yQ29tYmluaW5nQ2hhcmFj dGVyU2VxdWVuY2Ugd2Fzbid0IGRlZmluZWQgZm9yCisgICAgICAgIFdpbkNhaXJvIHBvcnQuIEl0 IHNob3VsZCBiZSBkZWZpbmVkIGlmICFVU0UoSEFSRkJVWlopLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcDogVXNlICFVU0UoSEFSRkJVWlopIGluc3Rl YWQgb2YgIVVTRShDQUlSTykuCisKIDIwMTctMTAtMDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hy aXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgV2ViQ29yZVN5c3RlbUludGVy ZmFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENh c2NhZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhc2NhZGUu Y3BwCmluZGV4IGY2YzFmMzNmM2NlMmM4OGQwZmE1MjY5Y2I3NzMzYzgzNDgwZWQxODQuLjlkMGJh NjNhYjRjMWEzMjZhZjgzZDQ5ZWVjZWIyMzJkODUzNjE1YTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FzY2FkZS5jcHAKQEAgLTE1OTMsNyArMTU5Myw3 IEBAIGludCBGb250Q2FzY2FkZTo6b2Zmc2V0Rm9yUG9zaXRpb25Gb3JDb21wbGV4VGV4dChjb25z dCBUZXh0UnVuJiBydW4sIGZsb2F0IHgsIGJvCiB9CiAjZW5kaWYKIAotI2lmICFQTEFURk9STShD T0NPQSkgJiYgIVVTRShDQUlSTykKKyNpZiAhUExBVEZPUk0oQ09DT0EpICYmICFVU0UoSEFSRkJV WlopCiAvLyBGSVhNRTogVW5pZnkgdGhpcyB3aXRoIHRoZSBtYWNPUyBhbmQgaU9TIGltcGxlbWVu dGF0aW9uLgogY29uc3QgRm9udCogRm9udENhc2NhZGU6OmZvbnRGb3JDb21iaW5pbmdDaGFyYWN0 ZXJTZXF1ZW5jZShjb25zdCBVQ2hhciogY2hhcmFjdGVycywgc2l6ZV90IGxlbmd0aCkgY29uc3QK IHsK