177758 2017-10-02 11:18:26 -0700 Remove length argument from TextPainter::paint() 2017-10-15 14:54:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 178278 1 dbates dbates achristensen bfulgham mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1355339 0 dbates 2017-10-02 11:18:26 -0700 Remove length argument from TextPainter::paint(). Instead have the function use the length of the specified text run. 1355347 1 322398 dbates 2017-10-02 11:24:35 -0700 Created attachment 322398 Patch 1355395 2 322398 dbates 2017-10-02 12:23:44 -0700 Comment on attachment 322398 Patch Clearing flags on attachment: 322398 Committed r222732: <http://trac.webkit.org/changeset/222732> 1355396 3 dbates 2017-10-02 12:23:47 -0700 All reviewed patches have been landed. Closing bug. 1355398 4 webkit-bug-importer 2017-10-02 12:25:22 -0700 <rdar://problem/34773231> 322398 2017-10-02 11:24:35 -0700 2017-10-02 12:23:44 -0700 Patch bug-177758-20171002112434.patch text/plain 6011 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWRmZmNmYjBlY2QyZTRm ZmJlNmEwYjIzN2QwNDMyYzI2YWIzOWExNy4uYTc0MmRiYWUwNzExOGEzNTgxZWY0NTBiYjIzOGE3 NTczMzRmZDVlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE3LTEwLTAyICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgbGVuZ3RoIGFy Z3VtZW50IGZyb20gVGV4dFBhaW50ZXI6OnBhaW50KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Nzc1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmUgVGV4dFBhaW50ZXIucGFpbnQoKSB1c2UgdGhl IGxlbmd0aCBvZiB0aGUgc3BlY2lmaWVkIFRleHRSdW4gYXMgb3Bwb3NlZCB0bworICAgICAgICB0 YWtpbmcgYW4gZXhwbGljaXQgYXJndW1lbnQgZm9yIHRoZSBsZW5ndGggb2YgdGhlIFRleHRSdW4u CisKKyAgICAgICAgRm9sbG93aW5nIHIyMjI2NzAgSW5saW5lVGV4dEJveCBjcmVhdGVzIGEgVGV4 dFJ1biB3aXRoIHJlc3BlY3QgdG8gdGhlIHRydW5jYXRlZAorICAgICAgICBsaW5lLiBQcmlvciB0 byByMjIyNjcwIElubGluZVRleHRCb3ggZGlkIG5vdCBkbyB0aGlzIGFuZCBoZW5jZSBpdCBoYWQg dG8gcGFzcyBib3RoCisgICAgICAgIHRoZSBUZXh0UnVuIGFuZCB0cnVuY2F0ZWQgbGVuZ3RoIHRv IFRleHRQYWludGVyLnBhaW50KCkgdG8gaGF2ZSB0aGUgbGluZSBwYWludGVkLgorICAgICAgICBD b2RlIHRoYXQgbmVlZHMgdG8gcGFpbnQgYSBzdWJzdHJpbmcgb2YgYSBUZXh0UnVuIGNhbiBzdGls bCBkbyBzbyBieSB1c2luZyBUZXh0UGFpbnRlci5wYWludFJhbmdlKCkuCisKKyAgICAgICAgTm8g ZnVuY3Rpb25hbGl0eSBjaGFuZ2VkLiBTbywgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcmVu ZGVyaW5nL0lubGluZVRleHRCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5saW5lVGV4dEJv eDo6cGFpbnQpOgorICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0RnVuY3Rpb25z LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OnBhaW50Rmxvdyk6Cisg ICAgICAgICogcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRl eHRQYWludGVyOjpwYWludCk6CisgICAgICAgICogcmVuZGVyaW5nL1RleHRQYWludGVyLmg6CisK IDIwMTctMDktMzAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg RG9uJ3QgcmV2ZWFsIGZpbGUgVVJMIHdoZW4gcGFzdGluZyBhbiBpbWFnZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCmluZGV4IGI2NGZjZWIzYTlmMzk4Y2MwMTY4 M2U0ZmNkMmU0ZWVmNjE1M2M4YmIuLjRlOTY2ZGMzOTI2YjJhM2E5OTg4MzFmZjJkZGRhNjIyZmI5 MGZjODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKQEAg LTU2OCw3ICs1NjgsNyBAQCB2b2lkIElubGluZVRleHRCb3g6OnBhaW50KFBhaW50SW5mbyYgcGFp bnRJbmZvLCBjb25zdCBMYXlvdXRQb2ludCYgcGFpbnRPZmZzZXQsCiAgICAgICAgIGlmIChjdXJy ZW50RW5kIDwgbGVuZ3RoKQogICAgICAgICAgICAgdGV4dFBhaW50ZXIucGFpbnRSYW5nZSh0ZXh0 UnVuLCBib3hSZWN0LCB0ZXh0T3JpZ2luLCBjdXJyZW50RW5kLCBsZW5ndGgpOwogICAgIH0gZWxz ZQotICAgICAgICB0ZXh0UGFpbnRlci5wYWludCh0ZXh0UnVuLCBsZW5ndGgsIGJveFJlY3QsIHRl eHRPcmlnaW4sIHNlbGVjdGlvblN0YXJ0LCBzZWxlY3Rpb25FbmQsIHBhaW50U2VsZWN0ZWRUZXh0 T25seSwgcGFpbnRTZWxlY3RlZFRleHRTZXBhcmF0ZWx5LCBwYWludE5vblNlbGVjdGVkVGV4dE9u bHkpOworICAgICAgICB0ZXh0UGFpbnRlci5wYWludCh0ZXh0UnVuLCBib3hSZWN0LCB0ZXh0T3Jp Z2luLCBzZWxlY3Rpb25TdGFydCwgc2VsZWN0aW9uRW5kLCBwYWludFNlbGVjdGVkVGV4dE9ubHks IHBhaW50U2VsZWN0ZWRUZXh0U2VwYXJhdGVseSwgcGFpbnROb25TZWxlY3RlZFRleHRPbmx5KTsK IAogICAgIC8vIFBhaW50IGRlY29yYXRpb25zCiAgICAgVGV4dERlY29yYXRpb24gdGV4dERlY29y YXRpb25zID0gbGluZVN0eWxlLnRleHREZWNvcmF0aW9uc0luRWZmZWN0KCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dEZ1bmN0aW9ucy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dEZ1bmN0aW9ucy5jcHAK aW5kZXggMDZiNjFjYzc1NjVmMWI5ZDI3ZTBmZjI1MDhhYzA2Mjg2MzdkYzYzMi4uYTg5NDNiMTNl YWQyMDBlZTRjODI1NjQ1ZTc5ZTRlNGYyZDI0MTA5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXRGdW5jdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0RnVuY3Rpb25zLmNwcApAQCAtMTIwLDcg KzEyMCw3IEBAIHZvaWQgcGFpbnRGbG93KGNvbnN0IFJlbmRlckJsb2NrRmxvdyYgZmxvdywgY29u c3QgTGF5b3V0JiBsYXlvdXQsIFBhaW50SW5mbyYgcGFpCiAgICAgICAgIFRleHRSdW4gdGV4dFJ1 bihydW4uaGFzSHlwaGVuKCkgPyB0ZXh0V2l0aEh5cGhlbiA6IHJ1bi50ZXh0KCksIDAsIHJ1bi5l eHBhbnNpb24oKSwgcnVuLmV4cGFuc2lvbkJlaGF2aW9yKCkpOwogICAgICAgICB0ZXh0UnVuLnNl dFRhYlNpemUoIXN0eWxlLmNvbGxhcHNlV2hpdGVTcGFjZSgpLCBzdHlsZS50YWJTaXplKCkpOwog ICAgICAgICBGbG9hdFBvaW50IHRleHRPcmlnaW4gPSBGbG9hdFBvaW50KHJlY3QueCgpICsgcGFp bnRPZmZzZXQueCgpLCByb3VuZFRvRGV2aWNlUGl4ZWwocnVuLmJhc2VsaW5lUG9zaXRpb24oKSAr IHBhaW50T2Zmc2V0LnkoKSwgZGV2aWNlU2NhbGVGYWN0b3IpKTsKLSAgICAgICAgdGV4dFBhaW50 ZXIucGFpbnQodGV4dFJ1biwgdGV4dFJ1bi5sZW5ndGgoKSwgcmVjdCwgdGV4dE9yaWdpbik7Cisg ICAgICAgIHRleHRQYWludGVyLnBhaW50KHRleHRSdW4sIHJlY3QsIHRleHRPcmlnaW4pOwogICAg ICAgICBpZiAodGV4dERlY29yYXRpb25QYWludGVyKSB7CiAgICAgICAgICAgICB0ZXh0RGVjb3Jh dGlvblBhaW50ZXItPnNldFdpZHRoKHJlY3Qud2lkdGgoKSk7CiAgICAgICAgICAgICB0ZXh0RGVj b3JhdGlvblBhaW50ZXItPnBhaW50VGV4dERlY29yYXRpb24odGV4dFJ1biwgdGV4dE9yaWdpbiwg cmVjdC5sb2NhdGlvbigpICsgcGFpbnRPZmZzZXQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9U ZXh0UGFpbnRlci5jcHAKaW5kZXggNjBlOTIwZWFmN2VkMzRiZDQ2NGQyZjkyNTg1ZmVhN2FjNWY1 MzM4OS4uOGRjMzc4ZjNjZjg0ODQ1YTY3MzAyNDg1ODU1YzgzZDJkMmY2NmNlMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvVGV4dFBhaW50ZXIuY3BwCkBAIC0xOTAsMTAgKzE5MCwxMSBAQCB2 b2lkIFRleHRQYWludGVyOjpwYWludFJhbmdlKGNvbnN0IFRleHRSdW4mIHRleHRSdW4sIGNvbnN0 IEZsb2F0UmVjdCYgYm94UmVjdCwgYwogICAgIHBhaW50VGV4dEFuZEVtcGhhc2lzTWFya3NJZk5l ZWRlZCh0ZXh0UnVuLCBib3hSZWN0LCB0ZXh0T3JpZ2luLCBzdGFydCwgZW5kLCBtX3N0eWxlLCBt X3NoYWRvdyk7CiB9CiAgICAgCi12b2lkIFRleHRQYWludGVyOjpwYWludChjb25zdCBUZXh0UnVu JiB0ZXh0UnVuLCB1bnNpZ25lZCBsZW5ndGgsIGNvbnN0IEZsb2F0UmVjdCYgYm94UmVjdCwgY29u c3QgRmxvYXRQb2ludCYgdGV4dE9yaWdpbiwgdW5zaWduZWQgc2VsZWN0aW9uU3RhcnQsIHVuc2ln bmVkIHNlbGVjdGlvbkVuZCwKK3ZvaWQgVGV4dFBhaW50ZXI6OnBhaW50KGNvbnN0IFRleHRSdW4m IHRleHRSdW4sIGNvbnN0IEZsb2F0UmVjdCYgYm94UmVjdCwgY29uc3QgRmxvYXRQb2ludCYgdGV4 dE9yaWdpbiwgdW5zaWduZWQgc2VsZWN0aW9uU3RhcnQsIHVuc2lnbmVkIHNlbGVjdGlvbkVuZCwK ICAgICBib29sIHBhaW50U2VsZWN0ZWRUZXh0T25seSwgYm9vbCBwYWludFNlbGVjdGVkVGV4dFNl cGFyYXRlbHksIGJvb2wgcGFpbnROb25TZWxlY3RlZFRleHRPbmx5KQogewogICAgIEFTU0VSVCht X2ZvbnQpOworICAgIHVuc2lnbmVkIGxlbmd0aCA9IHRleHRSdW4ubGVuZ3RoKCk7CiAgICAgaWYg KCFwYWludFNlbGVjdGVkVGV4dE9ubHkpIHsKICAgICAgICAgLy8gRm9yIHN0cm9rZWQgcGFpbnRp bmcsIHdlIGhhdmUgdG8gY2hhbmdlIHRoZSB0ZXh0IGRyYXdpbmcgbW9kZS4gSXQncyBwcm9iYWJs eSBkYW5nZXJvdXMgdG8gbGVhdmUgdGhhdCBtdXRhdGVkIGFzIGEgc2lkZQogICAgICAgICAvLyBl ZmZlY3QsIHNvIG9ubHkgd2hlbiB3ZSBrbm93IHdlJ3JlIHN0cm9raW5nLCBkbyBhIHNhdmUvcmVz dG9yZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5o IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmgKaW5kZXggYzhhN2IzOTNj NjlkYTNlYmMzNGUzYmQ1M2VjNGZlYjg4YjI4NDFlZi4uYzc0ZDllYTQ4ZmIzNGY2MTMyZWVjMGE1 MmVmNjQyZmQ0MDE0ODJiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Rl eHRQYWludGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmgK QEAgLTYyLDggKzYyLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0RW1waGFzaXNNYXJrKGNvbnN0 IEF0b21pY1N0cmluZyYgbWFyaywgZmxvYXQgb2Zmc2V0LCBjb25zdCBSZW5kZXJDb21iaW5lVGV4 dCopOwogCiAgICAgdm9pZCBwYWludFJhbmdlKGNvbnN0IFRleHRSdW4mLCBjb25zdCBGbG9hdFJl Y3QmIGJveFJlY3QsIGNvbnN0IEZsb2F0UG9pbnQmIHRleHRPcmlnaW4sIHVuc2lnbmVkIHN0YXJ0 LCB1bnNpZ25lZCBlbmQpOwotICAgIHZvaWQgcGFpbnQoY29uc3QgVGV4dFJ1biYsIHVuc2lnbmVk IGxlbmd0aCwgY29uc3QgRmxvYXRSZWN0JiBib3hSZWN0LCBjb25zdCBGbG9hdFBvaW50JiB0ZXh0 T3JpZ2luLAotICAgICAgICB1bnNpZ25lZCBzZWxlY3Rpb25TdGFydCA9IDAsIHVuc2lnbmVkIHNl bGVjdGlvbkVuZCA9IDAsIGJvb2wgcGFpbnRTZWxlY3RlZFRleHRPbmx5ID0gZmFsc2UsIGJvb2wg cGFpbnRTZWxlY3RlZFRleHRTZXBhcmF0ZWx5ID0gZmFsc2UsIGJvb2wgcGFpbnROb25TZWxlY3Rl ZFRleHRPbmx5ID0gZmFsc2UpOworICAgIHZvaWQgcGFpbnQoY29uc3QgVGV4dFJ1biYsIGNvbnN0 IEZsb2F0UmVjdCYgYm94UmVjdCwgY29uc3QgRmxvYXRQb2ludCYgdGV4dE9yaWdpbiwgdW5zaWdu ZWQgc2VsZWN0aW9uU3RhcnQgPSAwLCB1bnNpZ25lZCBzZWxlY3Rpb25FbmQgPSAwLCBib29sIHBh aW50U2VsZWN0ZWRUZXh0T25seSA9IGZhbHNlLCBib29sIHBhaW50U2VsZWN0ZWRUZXh0U2VwYXJh dGVseSA9IGZhbHNlLCBib29sIHBhaW50Tm9uU2VsZWN0ZWRUZXh0T25seSA9IGZhbHNlKTsKIAog cHJpdmF0ZToKICAgICB2b2lkIHBhaW50VGV4dE9yRW1waGFzaXNNYXJrcyhjb25zdCBGb250Q2Fz Y2FkZSYsIGNvbnN0IFRleHRSdW4mLCBjb25zdCBBdG9taWNTdHJpbmcmIGVtcGhhc2lzTWFyaywg ZmxvYXQgZW1waGFzaXNNYXJrT2Zmc2V0LAo=