177643 2017-09-28 22:29:50 -0700 Make WSL demo compatible with Microsoft Edge 2018-10-13 19:26:06 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 176199 1 mmaxfield mmaxfield commit-queue dino fpizlo keith_miller saam webkit-bug-importer oldest_to_newest 1354453 0 mmaxfield 2017-09-28 22:29:50 -0700 Make WSL demo compatible with Microsoft Edge 1354456 1 322169 mmaxfield 2017-09-28 22:34:28 -0700 Created attachment 322169 Patch 1354475 2 322169 saam 2017-09-28 23:35:21 -0700 Comment on attachment 322169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322169&action=review > Tools/ChangeLog:7 > + because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides Do you know why they throw? Is it just an engine bug on their end? 1354476 3 322169 commit-queue 2017-09-29 00:09:50 -0700 Comment on attachment 322169 Patch Rejecting attachment 322169 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 322169, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/4696196 1354477 4 mmaxfield 2017-09-29 00:12:20 -0700 (In reply to Saam Barati from comment #2) > Comment on attachment 322169 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322169&action=review > > > Tools/ChangeLog:7 > > + because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides > > Do you know why they throw? Is it just an engine bug on their end? Looks like it's a bug in our own engine because it looks like it's not supposed to work out of the box (and it works out of the box on WebKit). https://stackoverflow.com/questions/22754315/for-loop-for-htmlcollection-elements#answer-22754453 says: Update for ES6 in 2016 You can now use the ES6 for/of construct with a NodeList and an HTMLCollection by just adding this to your code: NodeList.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator]; HTMLCollection.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator]; 1354478 5 mmaxfield 2017-09-29 00:13:26 -0700 (In reply to Myles C. Maxfield from comment #4) > (In reply to Saam Barati from comment #2) > > Comment on attachment 322169 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=322169&action=review > > > > > Tools/ChangeLog:7 > > > + because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides > > > > Do you know why they throw? Is it just an engine bug on their end? > > Looks like it's a bug in our own engine because it looks like it's not > supposed to work out of the box (and it works out of the box on WebKit). > https://stackoverflow.com/questions/22754315/for-loop-for-htmlcollection- > elements#answer-22754453 says: > > Update for ES6 in 2016 > You can now use the ES6 for/of construct with a NodeList and an > HTMLCollection by just adding this to your code: > NodeList.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator]; > HTMLCollection.prototype[Symbol.iterator] = Array.prototype[Symbol.iterator]; Wait, scratch that - I didn't read far enough in the answer. Seems that Edge just hasn't caught up yet to the rest of the browsers. 1355710 6 mmaxfield 2017-10-02 23:37:06 -0700 Committed r222770: <http://trac.webkit.org/changeset/222770> 1355711 7 webkit-bug-importer 2017-10-02 23:37:41 -0700 <rdar://problem/34785032> 1468975 8 mmaxfield 2018-10-13 19:26:06 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/171 322169 2017-09-28 22:34:28 -0700 2017-09-29 00:09:50 -0700 Patch patch.txt text/plain 3064 mmaxfield ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwMzE1 OWQ1Li5iZWVhOGI2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMDktMjggIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFdTTCBkZW1vIGNvbXBhdGlibGUg d2l0aCBNaWNyb3NvZnQgRWRnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc3NjQzCisKKyAgICAgICAgVGhpcyBwYXRjaCBkb2VzIHR3byB0aGluZ3Mu IFRoZSBmaXJzdCBpcyBpdCBtaWdyYXRlcyBhIGxvb3Agb3ZlciBQYXJlbnROb2RlLmNoaWxkcmVu IHRvIGEgbGVnYWN5IHN0eWxlIGxvb3AKKyAgICAgICAgYmVjYXVzZSBNaWNyb3NvZnQgRWRnZSB0 aHJvd3MgYW4gZXhjZXB0aW9uIHdoZW4gdHJ5aW5nIHRvIHVzZSBhIGZvci4uLm9mIGxvb3Agd2l0 aCBpdC4gVGhpcyBwYXRjaCBhbHNvIGhpZGVzCisgICAgICAgIHRoZSBjb21waWxhdGlvbiBiZWhp bmQgYSBzZXRUaW1lb3V0KDApIHNvIHRoZXJlIGlzIHNvbWUgaW5kaWNhdGlvbiB0aGF0IHNvbWV0 aGluZyBpcyBoYXBwZW5pbmcgZHVyaW5nIGEKKyAgICAgICAgY29tcGlsZS4KKworICAgICAgICBS ZXZpZXdlZCBieSBubyBvbmUgKE9PUFMhKTsKKworICAgICAgICAqIFRvb2xzL1dlYkdQVVNoYWRp bmdMYW5ndWFnZVJJL2luZGV4Lmh0bWw6CisKIDIwMTctMDktMjggIENvbW1pdCBRdWV1ZSAgPGNv bW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHIyMjI2MzkuCmRpZmYgLS1naXQgYS9Ub29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9pbmRl eC5odG1sIGIvVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvaW5kZXguaHRtbAppbmRleCA2 YWQ0NjRmLi5hOTY5N2ZlIDEwMDY0NAotLS0gYS9Ub29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VS SS9pbmRleC5odG1sCisrKyBiL1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL2luZGV4Lmh0 bWwKQEAgLTE4OSw2ICsxODksNyBAQCBmcmFnbWVudCBGcmFnbWVudE91dHB1dCBmcmFnbWVudFNo YWRlcihWZXJ0ZXhPdXRwdXQgc3RhZ2VJbikgewogfWA7CiAKIGxldCBzaGFkZXJTb3VyY2VUZXh0 YXJlYTsKK2xldCBjb21waWxlQnV0dG9uOwogbGV0IGxvY2FsU3RvcmFnZTsKIGxldCBjb21waWxl TG9nRWxlbWVudDsKIGxldCB2ZXJ0ZXhTaGFkZXJTZWxlY3Q7CkBAIC0yMDksNyArMjEwLDggQEAg bGV0IHN0YWdlSW5Bcmd1bWVudEluZGV4OwogCiB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibG9h ZCIsIGZ1bmN0aW9uKCkgewogICAgIHNoYWRlclNvdXJjZVRleHRhcmVhID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoIlNoYWRlclNvdXJjZSIpOwotICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJDb21waWxlQnV0dG9uIikuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCBjb21waWxlUHJlc2Vu dFNoYWRlclNvdXJjZSk7CisgICAgY29tcGlsZUJ1dHRvbiA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJDb21waWxlQnV0dG9uIik7CisgICAgY29tcGlsZUJ1dHRvbi5hZGRFdmVudExpc3RlbmVy KCJjbGljayIsIGNvbXBpbGVQcmVzZW50U2hhZGVyU291cmNlKTsKICAgICBjb21waWxlTG9nRWxl bWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJDb21waWxlTG9nIik7CiAgICAgdmVydGV4 U2hhZGVyU2VsZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIlZlcnRleFNoYWRlclNlbGVj dCIpOwogICAgIGZyYWdtZW50U2hhZGVyU2VsZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo IkZyYWdtZW50U2hhZGVyU2VsZWN0Iik7CkBAIC0yMzAsNyArMjMyLDcgQEAgd2luZG93LmFkZEV2 ZW50TGlzdGVuZXIoImxvYWQiLCBmdW5jdGlvbigpIHsKICAgICBpZiAoIXNoYWRlclNvdXJjZSkK ICAgICAgICAgc2hhZGVyU291cmNlID0gZGVmYXVsdFNoYWRlclNvdXJjZTsKICAgICBzaGFkZXJT b3VyY2VUZXh0YXJlYS52YWx1ZSA9IHNoYWRlclNvdXJjZTsKLSAgICBjb21waWxlUHJlc2VudFNo YWRlclNvdXJjZSgpOworICAgIHdpbmRvdy5zZXRUaW1lb3V0KGNvbXBpbGVQcmVzZW50U2hhZGVy U291cmNlLCAwKTsKIH0pOwogCiBmdW5jdGlvbiBjbGVhckRhdGFUYWJsZSgpCkBAIC0yNjksNyAr MjcxLDEzIEBAIGZ1bmN0aW9uIHByZXNlbnRFcnJvcihtZXNzYWdlKSB7CiB9CiAKIGZ1bmN0aW9u IGNvbXBpbGVQcmVzZW50U2hhZGVyU291cmNlKCkgewotICAgIGNvbXBpbGVMb2dFbGVtZW50LnRl eHRDb250ZW50ID0gIiI7CisgICAgY29tcGlsZUxvZ0VsZW1lbnQudGV4dENvbnRlbnQgPSAiQ29t cGlsaW5nLi4uIjsKKyAgICBjb21waWxlQnV0dG9uLmRpc2FibGVkID0gdHJ1ZTsKKyAgICB3aW5k b3cuc2V0VGltZW91dChkb0NvbXBpbGVQcmVzZW50U2hhZGVyU291cmNlLCAwKTsKK30KKworZnVu Y3Rpb24gZG9Db21waWxlUHJlc2VudFNoYWRlclNvdXJjZSgpIHsKKyAgICBjb21waWxlQnV0dG9u LmRpc2FibGVkID0gZmFsc2U7CiAgICAgbGV0IHN0YXJ0ID0gbmV3IERhdGUoKS5nZXRUaW1lKCk7 CiAgICAgbGV0IHJlc3VsdDsKICAgICB0cnkgewpAQCAtMzg1LDcgKzM5Myw4IEBAIGZ1bmN0aW9u IHJ1blNoYWRlcnMoKSB7CiAgICAgbGV0IGZ1bmMgPSBpbmxpbmVkVmVydGV4U2hhZGVyOwogCiAg ICAgbGV0IGluZGV4ID0gMDsKLSAgICBmb3IgKGxldCBjaGlsZEVsZW1lbnQgb2YgZGF0YVRhYmxl LmNoaWxkcmVuKSB7CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCBkYXRhVGFibGUuY2hpbGRyZW4u bGVuZ3RoOyArK2kpIHsKKyAgICAgICAgbGV0IGNoaWxkRWxlbWVudCA9IGRhdGFUYWJsZS5jaGls ZHJlbltpXTsKICAgICAgICAgaWYgKCEoY2hpbGRFbGVtZW50IGluc3RhbmNlb2YgSFRNTFRhYmxl Um93RWxlbWVudCkpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgbGV0IHZhbHVlID0g Y2hpbGRFbGVtZW50LmNoaWxkcmVuWzFdLmZpcnN0Q2hpbGQudmFsdWU7Cg==