177550 2017-09-27 10:51:07 -0700 [GStreamer] Try to play AVC codec even if H.264 decoder only advertises byte-stream profile. 2017-10-02 06:17:46 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cturner cturner bugs-noreply clopez commit-queue eocanha eric.carlson jer.noble jonlee zan oldest_to_newest 1353171 0 cturner 2017-09-27 10:51:07 -0700 Try to play AVC codec even if H.264 decoder only advertises byte-stream profile. 1354156 1 jonlee 2017-09-28 10:08:00 -0700 Can you discuss a little bit more your use case? 1354315 2 cturner 2017-09-28 14:58:52 -0700 It seems I've accidentally pulled the trigger on uploading this patch before it's ready. This is specific to GTK/WPE, sorry for the false alarm. 1354322 3 322123 cturner 2017-09-28 15:06:21 -0700 Created attachment 322123 Patch 1354484 4 eocanha 2017-09-29 02:58:06 -0700 Looks good. I'm assuming that playbin properly places an h264parse element to convert from avc to byte-stream, right? 1354486 5 cturner 2017-09-29 03:19:15 -0700 > I'm assuming that playbin properly places an h264parse element to convert from avc to byte-stream, right? That's correct. The GstH264Parse element will be inserted by playbin when the H.264 decoder only advertises byte-stream. While this isn't the case for a typical desktop GStreamer using libav, whose decoder supports both AVC and byte-stream. But on embedded systems like the Pi, the OpenMAX decoder only advertises byte-stream, and in this case the playbin will automatically convert it for us. That's why we didn't notice any issues on desktop, because the filter did succeed, it's just not necessary with the ability of our pipeline to dynamically convert to bytestream if needed. 1354602 6 322123 clopez 2017-09-29 10:57:05 -0700 Comment on attachment 322123 Patch r=me if this looks good for Enrique :) 1355186 7 322369 cturner 2017-10-02 03:49:25 -0700 Created attachment 322369 Patch for landing 1355207 8 322369 commit-queue 2017-10-02 06:17:45 -0700 Comment on attachment 322369 Patch for landing Clearing flags on attachment: 322369 Committed r222707: <http://trac.webkit.org/changeset/222707> 1355208 9 commit-queue 2017-10-02 06:17:46 -0700 All reviewed patches have been landed. Closing bug. 322123 2017-09-28 15:06:21 -0700 2017-10-02 03:49:21 -0700 Patch bug-177550-20170928220620.patch text/plain 2692 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTZlNDY5MzBlODM5Yjll NTU4ZGNjZTc3YTY2N2I0MTJiNTIzMGY5MS4uMTE1MzllOGFmZWRmMDk4N2NhMjkyNjI4MzM3MDJl MWI5NmQ5OTNiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA5LTI3ICBDaGFy bGVzIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBUcnkgdG8gcGxheSBB VkMgY29kZWMgZXZlbiBpZiBILjI2NCBkZWNvZGVyIG9ubHkgYWR2ZXJ0aXNlcyBieXRlLXN0cmVh bSBwcm9maWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc3NTUwCisKKyAgICAgICAgR1N0cmVhbWVyJ3MgZWxlbWVudCBmYWN0b3J5IGZpbHRlcnMg d2lsbCBjbGFpbSB0aGV5IGNhbid0IHBsYXkgdmlkZW9zIHdpdGggQVZDCisgICAgICAgIGNvZGVj IHN0cmluZ3MsIGJ1dCB0aGUgZWxlbWVudHMgcmVhbGx5IGFyZSBjYXBhYmxlIG9mIHBsYXlpbmcg dGhlbSB3aGVuIGZpbHRlcnMKKyAgICAgICAgbGlrZSB2aWRlb2NvbnZlcnQgYXJlIGluc2VydGVk IGJ5IHBsYXliaW4uIFZpZGVvcyBvZiB0aGlzIHZhcmlldHkgYXJlIGluIHRoZSBZb3VUdWJlCisg ICAgICAgIDIwMTggRU1FIGNvbmZvcm1hbmNlIHRlc3RzLgorCisgICAgICAgIEFsc28gcmVwbGFj ZSBzdGQ6OmFycmF5IHdpdGggYSBzdGFjayBhcnJheSwgdGhpcyBzYXZlcyBoYXZpbmcgdG8gY291 bnQKKyAgICAgICAgdGhlIG51bWJlciBvZiBlbGVtZW50cyAodGhlIGNvbXBpbGVyIGRvZXMgdGhh dCBub3cpIGFuZCByZWR1Y2VzIGJyYWNlcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvZGVj U2V0KToKKwogMjAxNy0wOS0yNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVmIGVsZW1lbnQga2V5cyBpbiBDU1NBbmltYXRpb25Db250cm9sbGVyUHJpdmF0 ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L21zZS9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0UuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJNU0UuY3BwCmluZGV4IGZlMGMzNTI2MmFhN2QxODMyZjM4ZmVmOWUxMzkyZTFkZGVlMTNkMTku Ljg4NWZlM2NmZjkxMjA0MzdlMWI1MTgwM2NmNDQ5MTAzMmFkNGIzN2IgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyTVNFLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHAKQEAg LTc3NywxNSArNzc3LDE0IEBAIGNvbnN0IHN0YXRpYyBIYXNoU2V0PEF0b21pY1N0cmluZz4mIGNv ZGVjU2V0KCkKICAgICAgICAgICAgIFZlY3RvcjxBdG9taWNTdHJpbmc+IHdlYmtpdENvZGVjczsK ICAgICAgICAgfTsKIAotICAgICAgICBzdGQ6OmFycmF5PEdzdENhcHNXZWJLaXRNYXBwaW5nLCA3 PiBtYXBwaW5nID0geyB7Ci0gICAgICAgICAgICB7IFZpZGVvRGVjb2RlciwgInZpZGVvL3gtaDI2 NCwgIHByb2ZpbGU9KHN0cmluZyl7IGNvbnN0cmFpbmVkLWJhc2VsaW5lLCBiYXNlbGluZSB9Iiwg eyAieC1oMjY0IiB9IH0sCi0gICAgICAgICAgICB7IFZpZGVvRGVjb2RlciwgInZpZGVvL3gtaDI2 NCwgc3RyZWFtLWZvcm1hdD1hdmMiLCB7ICJhdmMqIn0gfSwKKyAgICAgICAgR3N0Q2Fwc1dlYktp dE1hcHBpbmcgbWFwcGluZ1tdID0geworICAgICAgICAgICAgeyBWaWRlb0RlY29kZXIsICJ2aWRl by94LWgyNjQsICBwcm9maWxlPShzdHJpbmcpeyBjb25zdHJhaW5lZC1iYXNlbGluZSwgYmFzZWxp bmUgfSIsIHsgIngtaDI2NCIsICJhdmMqIiB9IH0sCiAgICAgICAgICAgICB7IFZpZGVvRGVjb2Rl ciwgInZpZGVvL21wZWcsIG1wZWd2ZXJzaW9uPShpbnQpezEsMn0sIHN5c3RlbXN0cmVhbT0oYm9v bGVhbilmYWxzZSIsIHsgIm1wZWciIH0gfSwKICAgICAgICAgICAgIHsgVmlkZW9EZWNvZGVyLCAi dmlkZW8veC12cDgiLCB7ICJ2cDgiLCAieC12cDgiIH0gfSwKICAgICAgICAgICAgIHsgVmlkZW9E ZWNvZGVyLCAidmlkZW8veC12cDkiLCB7ICJ2cDkiLCAieC12cDkiIH0gfSwKICAgICAgICAgICAg IHsgQXVkaW9EZWNvZGVyLCAiYXVkaW8veC12b3JiaXMiLCB7ICJ2b3JiaXMiLCAieC12b3JiaXMi IH0gfSwKICAgICAgICAgICAgIHsgQXVkaW9EZWNvZGVyLCAiYXVkaW8veC1vcHVzIiwgeyAib3B1 cyIsICJ4LW9wdXMiIH0gfQotICAgICAgICB9IH07CisgICAgICAgIH07CiAKICAgICAgICAgZm9y IChhdXRvJiBjdXJyZW50IDogbWFwcGluZykgewogICAgICAgICAgICAgR0xpc3QqIGZhY3Rvcmll cyA9IG51bGxwdHI7Cg== 322369 2017-10-02 03:49:25 -0700 2017-10-02 06:17:45 -0700 Patch for landing bug-177550-20171002104923.patch text/plain 2696 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE1NjcwNTEwMDYyNGM0 Zjk5MGE2Nzk5ZjhlNDk4MmZmMzg0YmMzYi4uYjVkMjNkMTc0ZWJkYWI0YTJjZmQwZmI0ZDlmMjli NDgxMjQ1MTk2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTAyICBDaGFy bGVzIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBUcnkgdG8gcGxheSBB VkMgY29kZWMgZXZlbiBpZiBILjI2NCBkZWNvZGVyIG9ubHkgYWR2ZXJ0aXNlcyBieXRlLXN0cmVh bSBwcm9maWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc3NTUwCisKKyAgICAgICAgR1N0cmVhbWVyJ3MgZWxlbWVudCBmYWN0b3J5IGZpbHRlcnMg d2lsbCBjbGFpbSB0aGV5IGNhbid0IHBsYXkgdmlkZW9zIHdpdGggQVZDCisgICAgICAgIGNvZGVj IHN0cmluZ3MsIGJ1dCB0aGUgZWxlbWVudHMgcmVhbGx5IGFyZSBjYXBhYmxlIG9mIHBsYXlpbmcg dGhlbSB3aGVuIGZpbHRlcnMKKyAgICAgICAgbGlrZSB2aWRlb2NvbnZlcnQgYXJlIGluc2VydGVk IGJ5IHBsYXliaW4uIFZpZGVvcyBvZiB0aGlzIHZhcmlldHkgYXJlIGluIHRoZSBZb3VUdWJlCisg ICAgICAgIDIwMTggRU1FIGNvbmZvcm1hbmNlIHRlc3RzLgorCisgICAgICAgIEFsc28gcmVwbGFj ZSBzdGQ6OmFycmF5IHdpdGggYSBzdGFjayBhcnJheSwgdGhpcyBzYXZlcyBoYXZpbmcgdG8gY291 bnQKKyAgICAgICAgdGhlIG51bWJlciBvZiBlbGVtZW50cyAodGhlIGNvbXBpbGVyIGRvZXMgdGhh dCBub3cpIGFuZCByZWR1Y2VzIGJyYWNlcy4KKworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3Mg QWxiZXJ0byBMb3BleiBQZXJlei4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9tc2UvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmNvZGVjU2V0KToKKwogMjAxNy0xMC0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBQYXN0ZWJvYXJkIHNob3VsZG4ndCBhZGQgIkZpbGVzIiBhcyBh IHR5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9tc2UvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyTVNFLmNwcAppbmRleCAwNGM2ZTEyYTdhN2Q2OTY4NzcwYTMzNmJiY2U0YTg5NGFkYWU5 YWM4Li5jMTkxYjc1YjNiZmE3YWQwNzhmYzMwMTExNzY2YzkwYmQ5MjBiZjg5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0UuY3Bw CkBAIC03NzgsMTUgKzc3OCwxNCBAQCBjb25zdCBzdGF0aWMgSGFzaFNldDxBdG9taWNTdHJpbmc+ JiBjb2RlY1NldCgpCiAgICAgICAgICAgICBWZWN0b3I8QXRvbWljU3RyaW5nPiB3ZWJraXRDb2Rl Y3M7CiAgICAgICAgIH07CiAKLSAgICAgICAgc3RkOjphcnJheTxHc3RDYXBzV2ViS2l0TWFwcGlu ZywgNz4gbWFwcGluZyA9IHsgewotICAgICAgICAgICAgeyBWaWRlb0RlY29kZXIsICJ2aWRlby94 LWgyNjQsICBwcm9maWxlPShzdHJpbmcpeyBjb25zdHJhaW5lZC1iYXNlbGluZSwgYmFzZWxpbmUg fSIsIHsgIngtaDI2NCIgfSB9LAotICAgICAgICAgICAgeyBWaWRlb0RlY29kZXIsICJ2aWRlby94 LWgyNjQsIHN0cmVhbS1mb3JtYXQ9YXZjIiwgeyAiYXZjKiJ9IH0sCisgICAgICAgIEdzdENhcHNX ZWJLaXRNYXBwaW5nIG1hcHBpbmdbXSA9IHsKKyAgICAgICAgICAgIHsgVmlkZW9EZWNvZGVyLCAi dmlkZW8veC1oMjY0LCAgcHJvZmlsZT0oc3RyaW5nKXsgY29uc3RyYWluZWQtYmFzZWxpbmUsIGJh c2VsaW5lIH0iLCB7ICJ4LWgyNjQiLCAiYXZjKiIgfSB9LAogICAgICAgICAgICAgeyBWaWRlb0Rl Y29kZXIsICJ2aWRlby9tcGVnLCBtcGVndmVyc2lvbj0oaW50KXsxLDJ9LCBzeXN0ZW1zdHJlYW09 KGJvb2xlYW4pZmFsc2UiLCB7ICJtcGVnIiB9IH0sCiAgICAgICAgICAgICB7IFZpZGVvRGVjb2Rl ciwgInZpZGVvL3gtdnA4IiwgeyAidnA4IiwgIngtdnA4IiB9IH0sCiAgICAgICAgICAgICB7IFZp ZGVvRGVjb2RlciwgInZpZGVvL3gtdnA5IiwgeyAidnA5IiwgIngtdnA5IiB9IH0sCiAgICAgICAg ICAgICB7IEF1ZGlvRGVjb2RlciwgImF1ZGlvL3gtdm9yYmlzIiwgeyAidm9yYmlzIiwgIngtdm9y YmlzIiB9IH0sCiAgICAgICAgICAgICB7IEF1ZGlvRGVjb2RlciwgImF1ZGlvL3gtb3B1cyIsIHsg Im9wdXMiLCAieC1vcHVzIiB9IH0KLSAgICAgICAgfSB9OworICAgICAgICB9OwogCiAgICAgICAg IGZvciAoYXV0byYgY3VycmVudCA6IG1hcHBpbmcpIHsKICAgICAgICAgICAgIEdMaXN0KiBmYWN0 b3JpZXMgPSBudWxscHRyOwo=