177286 2017-09-20 18:42:17 -0700 [CMake][Win] EventTargetInterfaces.h are generated twice 2017-09-27 12:21:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=163774 InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham commit-queue pvollan webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1351096 0 fujii 2017-09-20 18:42:17 -0700 Some source files are compiled unnecessarily in the incremental build. The log of WinCairo port clean build: https://gist.github.com/fujii/1a52f7b02ac4e16927b0b34b4b3eb874#file-webkit-win-cairo-clean-build-txt The log of WinCairo port null incremental build: https://gist.github.com/fujii/1a52f7b02ac4e16927b0b34b4b3eb874#file-webkit-win-cairo-incremental-build-txt In the first clean bulid log, EventTargetInterfaces.h are generated twice in both WebCoreDerivedSources and WebCore projects. > 22>------ Build started: Project: WebCoreDerivedSources, Configuration: Debug x64 ------ > (...) > 22> Generating ../../DerivedSources/WebCore/EventTargetInterfaces.h > (...) > 32>------ Build started: Project: WebCore (WebCore\WebCore), Configuration: Debug x64 ------ > (...) > 32> Generating ../../DerivedSources/WebCore/EventTargetInterfaces.h 1351104 1 321401 fujii 2017-09-20 19:40:03 -0700 Created attachment 321401 Patch 1351395 2 achristensen 2017-09-21 14:29:35 -0700 If you want this to be reviewed, please set the r? flag. 1351719 3 bfulgham 2017-09-22 11:00:01 -0700 Per Arne: Will this change be okay with our internal build? I think so, but you are the expert :-) 1351727 4 pvollan 2017-09-22 11:15:42 -0700 (In reply to Brent Fulgham from comment #3) > Per Arne: Will this change be okay with our internal build? I think so, but > you are the expert :-) I think so, since this change is limited to WebCore :) 1351728 5 321401 bfulgham 2017-09-22 11:16:08 -0700 Comment on attachment 321401 Patch r=me 1351746 6 321401 commit-queue 2017-09-22 11:44:58 -0700 Comment on attachment 321401 Patch Clearing flags on attachment: 321401 Committed r222395: <http://trac.webkit.org/changeset/222395> 1351747 7 commit-queue 2017-09-22 11:44:59 -0700 All reviewed patches have been landed. Closing bug. 1353321 8 webkit-bug-importer 2017-09-27 12:21:10 -0700 <rdar://problem/34693106> 321401 2017-09-20 19:40:03 -0700 2017-09-22 11:44:58 -0700 Patch bug-177286-20170921114002.patch text/plain 1807 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGE2Y2Y1NmUwZGNjYzY2 OGRjN2E5ZWE1ZWMwMTcyMTJmOWM0ODZjZC4uYzlkZjVmNGZmOTU0NWE0ZjM3Zjc5ZmQ2OGVjYmNi ZTM3MzdlOGM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA5LTIwICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV1b V2luXSBFdmVudFRhcmdldEludGVyZmFjZXMuaCBhcmUgZ2VuZXJhdGVkIHR3aWNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzcyODYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFdmVudFRhcmdldEludGVy ZmFjZXMuaCBhcmUgZ2VuZXJhdGVkIHR3aWNlIGluIGJvdGgKKyAgICAgICAgV2ViQ29yZURlcml2 ZWRTb3VyY2VzLnZjeHByb2ogYW5kIFdlYkNvcmUudmN4cHJvai4gVGhpcyBjYXVzZXMKKyAgICAg ICAgdW5uZWNlc3NhcnkgcmVjb21waWxhdGlvbiBpbiBDTWFrZSBWaXN1YWxTdHVkaW8gYnVpbGQu CisKKyAgICAgICAgV2ViQ29yZSB0YXJnZXQgYWxyZWFkeSBoYXMgYSBkZXBlbmRlbmN5IHRvIFdl YkNvcmVEZXJpdmVkU291cmNlcworICAgICAgICB0YXJnZXQgYnkgY2FsbGluZyBhZGRfZGVwZW5k ZW5jaWVzLiBXZWJDb3JlIHRhcmdldCBkb2Vzbid0IG5lZWQgdG8KKyAgICAgICAgZ2VuZXJhdGUg aXQuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogRG9uJ3QgQUREX1NPVVJDRV9XRUJDT1JF X0RFUklWRURfREVQRU5ERU5DSUVTIHdpdGggRXZlbnRUYXJnZXRJbnRlcmZhY2VzLmguCisKIDIw MTctMDktMjAgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFNw ZWxsaW5nIGFuZCBncmFtbWFyIGRvdHMgc2hvdWxkIG5vdCBvdmVybGFwCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMu dHh0CmluZGV4IGU3YzE0YjIwYWI2MDZiNjBmZDMyMWQ1NDZmNThhYWRhNTNjYmE4ZWQuLmEwZGI0 YTgyNTdiMTdlNGEzNDc5MDc2YWMxZjk0YTNmOGRmOWIwYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0 CkBAIC00MDE3LDggKzQwMTcsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0RFUklWRURfU09VUkNF UyAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vRXZlbnRJbnRlcmZhYwogCiAKIEdFTkVS QVRFX0VWRU5UX0ZBQ1RPUlkoJHtXRUJDT1JFX0RJUn0vZG9tL0V2ZW50VGFyZ2V0RmFjdG9yeS5p biBFdmVudFRhcmdldEludGVyZmFjZXMuaCkKLUFERF9TT1VSQ0VfV0VCQ09SRV9ERVJJVkVEX0RF UEVOREVOQ0lFUygke1dFQkNPUkVfRElSfS9kb20vRXZlbnROYW1lcy5jcHAgRXZlbnRUYXJnZXRJ bnRlcmZhY2VzLmgpCi1BRERfU09VUkNFX1dFQkNPUkVfREVSSVZFRF9ERVBFTkRFTkNJRVMoJHtX RUJDT1JFX0RJUn0vZG9tL0RPTUFsbEluT25lLmNwcCBFdmVudFRhcmdldEludGVyZmFjZXMuaCkK IGxpc3QoQVBQRU5EIFdlYkNvcmVfREVSSVZFRF9TT1VSQ0VTICR7REVSSVZFRF9TT1VSQ0VTX1dF QkNPUkVfRElSfS9FdmVudFRhcmdldEludGVyZmFjZXMuaCkKIAogCg==