177249 2017-09-20 10:16:44 -0700 inspector/dom/content-node-region-info.html and inspector/dom/content-flow tests crashing 2017-09-20 23:51:29 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177287 InRadar P2 Normal --- 174978 1 ryanhaddad webkit-unassigned ap commit-queue inspector-bugzilla-changes joepeck koivisto mattbaker oldest_to_newest 1350815 0 ryanhaddad 2017-09-20 10:16:44 -0700 inspector/dom/content-node-region-info.html and inspector/dom/content-flow tests crashing https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r222259%20(4421)/results.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000108621c19 Inspector::InspectorObjectBase::writeJSON(WTF::StringBuilder&) const + 361 (InspectorValues.cpp:784) 1 com.apple.JavaScriptCore 0x0000000108621c22 Inspector::InspectorObjectBase::writeJSON(WTF::StringBuilder&) const + 370 (InspectorValues.cpp:777) 2 com.apple.JavaScriptCore 0x00000001086208f3 Inspector::InspectorValue::toJSONString() const + 83 (InspectorValues.cpp:549) 3 com.apple.JavaScriptCore 0x00000001085d0bf1 Inspector::BackendDispatcher::sendResponse(long, WTF::RefPtr<Inspector::InspectorObject>&&) + 321 (InspectorBackendDispatcher.cpp:197) 4 com.apple.JavaScriptCore 0x00000001085d89fe Inspector::CSSBackendDispatcher::getNamedFlowCollection(long, WTF::RefPtr<Inspector::InspectorObject>&&) + 558 (InspectorBackendDispatchers.cpp:722) 5 com.apple.JavaScriptCore 0x00000001085d5b04 Inspector::CSSBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) + 580 (InspectorBackendDispatchers.cpp:257) 6 com.apple.JavaScriptCore 0x00000001085d1685 Inspector::BackendDispatcher::dispatch(WTF::String const&) + 2293 (Ref.h:57) 7 com.apple.WebKit 0x000000010382f142 void IPC::handleMessage<Messages::WebInspector::SendMessageToBackend, WebKit::WebInspector, void (WebKit::WebInspector::*)(WTF::String const&)>(IPC::Decoder&, WebKit::WebInspector*, void (WebKit::WebInspector::*)(WTF::String const&)) + 66 (HandleMessage.h:127) 8 com.apple.WebKit 0x000000010366571b IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 119 (Connection.cpp:930) 9 com.apple.WebKit 0x000000010366825a IPC::Connection::dispatchOneMessage() + 176 (Connection.cpp:959) 10 com.apple.JavaScriptCore 0x0000000108ab89d4 WTF::RunLoop::performWork() + 164 (RunLoop.cpp:107) 11 com.apple.JavaScriptCore 0x0000000108ab8bf2 WTF::RunLoop::performWork(void*) + 34 (RunLoopCF.cpp:39) 12 com.apple.CoreFoundation 0x00007fff8b84b3e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 13 com.apple.CoreFoundation 0x00007fff8b82c65c __CFRunLoopDoSources0 + 556 14 com.apple.CoreFoundation 0x00007fff8b82bb46 __CFRunLoopRun + 934 15 com.apple.CoreFoundation 0x00007fff8b82b544 CFRunLoopRunSpecific + 420 16 com.apple.HIToolbox 0x00007fff8ad8bebc RunCurrentEventLoopInMode + 240 17 com.apple.HIToolbox 0x00007fff8ad8bcf1 ReceiveNextEventCommon + 432 18 com.apple.HIToolbox 0x00007fff8ad8bb26 _BlockUntilNextEventMatchingListInModeWithFilter + 71 19 com.apple.AppKit 0x00007fff89324a54 _DPSNextEvent + 1120 20 com.apple.AppKit 0x00007fff89aa07ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 2796 21 com.apple.AppKit 0x00007fff893193db -[NSApplication run] + 926 22 com.apple.AppKit 0x00007fff892e3e0e NSApplicationMain + 1237 23 libxpc.dylib 0x00007fffa17bc8c7 _xpc_objc_main + 775 24 libxpc.dylib 0x00007fffa17bb2e4 xpc_main + 494 25 com.apple.WebKit.WebContent 0x000000010360c69a main + 490 (XPCServiceMain.mm:122) 26 libdyld.dylib 0x00007fffa1563235 start + 1 1350818 1 ryanhaddad 2017-09-20 10:22:09 -0700 Skipped these tests in https://trac.webkit.org/changeset/222268/webkit inspector/dom/content-flow-content-nodes.html inspector/dom/content-flow-content-removal.html inspector/dom/content-flow-list.html inspector/dom/content-node-region-info.html 1350819 2 ryanhaddad 2017-09-20 10:22:38 -0700 This started with https://trac.webkit.org/changeset/222259/webkit, which removes CSS regions / "named flow" code. 1350820 3 ryanhaddad 2017-09-20 10:23:14 -0700 Maybe these tests will need to be removed. 1351133 4 koivisto 2017-09-20 22:50:19 -0700 <rdar://problem/34559968> 1351134 5 321411 koivisto 2017-09-20 22:54:22 -0700 Created attachment 321411 patch 1351138 6 mattbaker 2017-09-20 23:14:08 -0700 Support for CSS regions in Web Inspector is being removed here: <https://webkit.org/b/177287> Web Inspector: Remove support for CSS Regions 1351144 7 321411 commit-queue 2017-09-20 23:49:57 -0700 Comment on attachment 321411 patch Clearing flags on attachment: 321411 Committed r222314: <http://trac.webkit.org/changeset/222314> 1351145 8 commit-queue 2017-09-20 23:49:59 -0700 All reviewed patches have been landed. Closing bug. 1351146 9 koivisto 2017-09-20 23:51:29 -0700 That should fix the crashes, the tests and code can be remove in bug 177287. 321411 2017-09-20 22:54:22 -0700 2017-09-20 23:49:57 -0700 patch region-inspector-crash.patch text/plain 1836 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjMxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA5LTIwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBpbnNwZWN0b3IvZG9tL2NvbnRl bnQtbm9kZS1yZWdpb24taW5mby5odG1sIGFuZCBpbnNwZWN0b3IvZG9tL2NvbnRlbnQtZmxvdyB0 ZXN0cyBjcmFzaGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTc3MjQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDU1OTk2OD4KKworICAgICAg ICBVbnJldmlld2VkLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNTU0FnZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNTU0FnZW50OjpnZXROYW1lZEZsb3dDb2xs ZWN0aW9uKToKKworICAgICAgICAgICAgRml4IGNyYXNoaW5nIGJ5IGFkZGluZyBhIGZldyBsaW5l cyBvZiByZW1vdmVkIGNvZGUgYmFjay4KKwogMjAxNy0wOS0yMCAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSByZWR1bmRhbnQgU2VsZWN0aW9uU3VidHJl ZURhdGEgZnVuY3Rpb25zLgpJbmRleDogU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNTU0FnZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yQ1NTQWdlbnQuY3BwCShyZXZpc2lvbiAyMjIyNjMpCisrKyBTb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yQ1NTQWdlbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NzcsOCAr Nzc3LDE1IEBAIHZvaWQgSW5zcGVjdG9yQ1NTQWdlbnQ6OmZvcmNlUHNldWRvU3RhdGUKICAgICBl bGVtZW50LT5kb2N1bWVudCgpLnN0eWxlU2NvcGUoKS5kaWRDaGFuZ2VTdHlsZVNoZWV0RW52aXJv bm1lbnQoKTsKIH0KIAotdm9pZCBJbnNwZWN0b3JDU1NBZ2VudDo6Z2V0TmFtZWRGbG93Q29sbGVj dGlvbihFcnJvclN0cmluZyYsIGludCwgUmVmUHRyPEluc3BlY3Rvcjo6UHJvdG9jb2w6OkFycmF5 PEluc3BlY3Rvcjo6UHJvdG9jb2w6OkNTUzo6TmFtZWRGbG93Pj4mKQordm9pZCBJbnNwZWN0b3JD U1NBZ2VudDo6Z2V0TmFtZWRGbG93Q29sbGVjdGlvbihFcnJvclN0cmluZyYgZXJyb3JTdHJpbmcs IGludCBkb2N1bWVudE5vZGVJZCwgUmVmUHRyPEluc3BlY3Rvcjo6UHJvdG9jb2w6OkFycmF5PElu c3BlY3Rvcjo6UHJvdG9jb2w6OkNTUzo6TmFtZWRGbG93Pj4mIHJlc3VsdCkKIHsKKyAgICBEb2N1 bWVudCogZG9jdW1lbnQgPSBtX2RvbUFnZW50LT5hc3NlcnREb2N1bWVudChlcnJvclN0cmluZywg ZG9jdW1lbnROb2RlSWQpOworICAgIGlmICghZG9jdW1lbnQpCisgICAgICAgIHJldHVybjsKKwor ICAgIGF1dG8gbmFtZWRGbG93cyA9IEluc3BlY3Rvcjo6UHJvdG9jb2w6OkFycmF5PEluc3BlY3Rv cjo6UHJvdG9jb2w6OkNTUzo6TmFtZWRGbG93Pjo6Y3JlYXRlKCk7CisKKyAgICByZXN1bHQgPSBX VEZNb3ZlKG5hbWVkRmxvd3MpOwogfQogCiBJbnNwZWN0b3JTdHlsZVNoZWV0Rm9ySW5saW5lU3R5 bGUmIEluc3BlY3RvckNTU0FnZW50Ojphc0luc3BlY3RvclN0eWxlU2hlZXQoU3R5bGVkRWxlbWVu dCYgZWxlbWVudCkK