177123 2017-09-18 21:26:35 -0700 Cannot put typedefs of templated structs inside structs 2018-10-13 19:36:33 -0700 1 1 1 Unclassified WebKit WebGPU Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 176199 1 mmaxfield fpizlo fpizlo msaboff webkit-bug-importer oldest_to_newest 1350246 0 mmaxfield 2017-09-18 21:26:35 -0700 >>> prepare("/internal/test", 0, "struct Foo { int2 x; }") Exception: Error: Cannot determine if an uninstantiated type is primitive: vec2<int32> 1350249 1 321181 fpizlo 2017-09-18 22:07:25 -0700 Created attachment 321181 the patch 1350345 2 321181 msaboff 2017-09-19 09:34:46 -0700 Comment on attachment 321181 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=321181&action=review r=me > Tools/ChangeLog:39 > + type. This chews threw the wrapper and then instantiates the wrapped type, as we want it to. Change "threw" to "through" 1350351 3 fpizlo 2017-09-19 09:39:53 -0700 Landed in https://trac.webkit.org/changeset/222210/webkit 1353705 4 webkit-bug-importer 2017-09-27 12:52:45 -0700 <rdar://problem/34694197> 1468985 5 mmaxfield 2018-10-13 19:36:33 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/181 321181 2017-09-18 22:07:25 -0700 2017-09-19 09:34:46 -0700 the patch blah.patch text/plain 6980 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjIwMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDU4IEBACisyMDE3LTA5LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgQ2Fubm90IHB1dCB0eXBlZGVmcyBvZiB0ZW1wbGF0ZWQgc3RydWN0cyBpbnNpZGUg c3RydWN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc3MTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAor ICAgICAgICBFdmVyIHNpbmNlIEkgd3JvdGUgdGhlIGdlbmVyaWMgdHlwZSBpbnN0YW50aWF0aW9u IGNvZGUgaW4gV1NMLCBpdCBoYWQgYSBiaXphcnJlIHN0aW5rIHRvIGl0LiBJCisgICAgICAgIGRp ZCBub3Qga25vdyB3aGF0IGl0IHdhcywgdW50aWwgSSBtZXQgdGhpcyB0ZXN0IGNhc2U6CisgICAg ICAgIAorICAgICAgICAgICAgc3RydWN0IEZvbyB7IGludDIgeDsgfQorICAgICAgICAKKyAgICAg ICAgVGhlIHByb2JsZW0gd2FzIHRoYXQgVHlwZSBoYXMgYSBnZXR0ZXIgY2FsbGVkIGluc3RhbnRp YXRlZFR5cGUsIHdoaWNoIGludm9rZWQKKyAgICAgICAgSW5zdGFudGlhdGVJbW1lZGlhdGVzLiBU aGF0J3MgZ3JlYXQuIFdoZXJlIHdlIHdlbnQgd3Jvbmcgd2FzIHRoYXQgVHlwZVJlZiBvdmVycm9k ZQorICAgICAgICBpbnN0YW50aWF0ZWRUeXBlLCBhbmQgdGhlbiBJbnN0YW50aWF0ZUltbWVkaWF0 ZXMgY2FsbGVkIFR5cGVSZWYuaW5zdGFudGlhdGVkVHlwZSBmcm9tIGl0cworICAgICAgICB2aXNp dFR5cGVSZWYuIFdoYXQgYSBtZXNzLiBOb25lIG9mIHRoYXQgd2FzIG5lY2Vzc2FyeSBmb3IgYW55 dGhpbmcsIGFuZCBpdCB3YXMganVzdCB3cm9uZy4gVGhpcworICAgICAgICBwYXRjaCBmaXhlcyBp dCBzbyB0aGF0OgorICAgICAgICAKKyAgICAgICAgLSBUeXBlIGhhcyBhbiBpbnN0YW50aWF0ZWRU eXBlIGdldHRlciwgd2hpY2ggZG9lcyBJbnN0YW50aWF0ZUltbWVkaWF0ZXMuIEkgZGlkbid0IGNo YW5nZSB0aGlzLgorICAgICAgICAgIFRoaXMgd2FzIHRoZSBvbmx5IHBhcnQgb2YgdGhlIHN0YXR1 cyBxdW8gdGhhdCByZWFsbHkgbWFkZSBzZW5zZS4KKyAgICAgICAgCisgICAgICAgIC0gVHlwZVJl ZiBubyBsb25nZXIgb3ZlcnJpZGVzIGluc3RhbnRpYXRlZFR5cGUuCisgICAgICAgIAorICAgICAg ICAtIEluc3RhbnRpYW50ZUltbWVkaWF0ZXMucHJvdG90eXBlLnZpc2l0VHlwZVJlZiBub3cgZG9l cyB3aGF0IFR5cGVSZWYncyBpbnN0YW50aWF0ZWRUeXBlIHdvdWxkCisgICAgICAgICAgaGF2ZSBk b25lLgorICAgICAgICAKKyAgICAgICAgQW5kIHZvaWxhISBUaGlzIHRlc3QgY2FzZSBwYXNzZXMg YW5kIHNvIGRvIGFsbCBvZiB0aGUgb3RoZXIgdGVzdCBjYXNlcy4KKyAgICAgICAgCisgICAgICAg IFRoZSByZWFzb24gd2h5IHRoYXQgc3BlY2lmaWMgdGVzdCBjYXNlIGRpZCBub3Qgd29yayB3YXMg dGhhdCB0aGUgdXNlIG9mIGEgVHlwZURlZiAoaW50MikgZm9yCisgICAgICAgIGEgZ2VuZXJpYyB0 eXBlIGluc3RhbnRpYXRpb24gKHZlYzI8aW50PikgY2F1c2VkIHRoZXJlIHRvIGJlIHR3byBUeXBl UmVmJ3MgaW4gYSByb3csIHNvcnRhIGxpa2UKKyAgICAgICAgdGhpcywgaWYgd2UgY291bGQgdXNl IHdyYXAoKSB0byBkZW5vdGUgYSBUeXBlUmVmIHRoYXQganVzdCB3cmFwcGVkIGFub3RoZXIgdHlw ZToKKyAgICAgICAgCisgICAgICAgICAgICB3cmFwKHZlYzI8aW50PikKKyAgICAgICAgCisgICAg ICAgIFdlIHdvdWxkIGNhbGwgaW5zdGFudGlhdGVkVHlwZSBvbiB0aGlzIG1vbnN0cm9zaXR5LiBT aW5jZSBUeXBlUmVmIG92ZXJyb2RlIGluc3RhbnRpYXRlZFR5cGUsCisgICAgICAgIHdlIHdvdWxk IHN0b3AgdGhlcmUgYmVjYXVzZSB0aGF0IFR5cGVSZWYgaGFzIG5vIHR5cGUgYXJndW1lbnRzIC0g aXQncyBqdXN0IGEgd3JhcHBlci4gV2VsbCwKKyAgICAgICAgYWN0dWFsbHksIHdlJ2QgZG8gc29t ZXRoaW5nIGEgYml0IHN0cmFuZ2VyIHRoYW4gc3RvcHBpbmcgdGhlcmUgLSB0aGVyZSdzIG1vcmUg dG8gdGhlIHN0b3J5IC0KKyAgICAgICAgYnV0IHRoZSBlZmZlY3Qgd2FzIHRoZSBzYW1lLiBOb3cg d2UgZG8gSW5zdGFudGlhdGVJbW1lZGlhdGVzLCB3aGljaCByZWN1cnNpdmVseSBidWlsZHMgYSBu ZXcKKyAgICAgICAgdHlwZS4gVGhpcyBjaGV3cyB0aHJldyB0aGUgd3JhcHBlciBhbmQgdGhlbiBp bnN0YW50aWF0ZXMgdGhlIHdyYXBwZWQgdHlwZSwgYXMgd2Ugd2FudCBpdCB0by4KKyAgICAgICAg QWxzbywgdGhpcyBhcHByb2FjaCBubyBsb25nZXIgaGFzIHRoZSBzdGluay4gaW5zdGFudGlhdGVk VHlwZSBpc24ndCBvdmVycmlkZW4gYnkgYW55b25lCisgICAgICAgIGFueW1vcmUhCisKKyAgICAg ICAgKiBXZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9DaGVja2VyLmpzOgorICAgICAgICAqIFdlYkdQ VVNoYWRpbmdMYW5ndWFnZVJJL0luc3RhbnRpYXRlSW1tZWRpYXRlcy5qczoKKyAgICAgICAgKElu c3RhbnRpYXRlSW1tZWRpYXRlcy5wcm90b3R5cGUudmlzaXRUeXBlUmVmKToKKyAgICAgICAgKElu c3RhbnRpYXRlSW1tZWRpYXRlcy5wcm90b3R5cGUudmlzaXRSZWZlcmVuY2VUeXBlKTogRGVsZXRl ZC4KKyAgICAgICAgKiBXZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzOgorICAgICAgICAo VEVTVF9pbnN0YW50aWF0ZVN0cnVjdEluU3RydWN0V2l0aEludDIpOgorICAgICAgICAqIFdlYkdQ VVNoYWRpbmdMYW5ndWFnZVJJL1R5cGVSZWYuanM6CisgICAgICAgIChUeXBlUmVmLndyYXApOgor ICAgICAgICAoVHlwZVJlZi5wcm90b3R5cGUuc2V0VHlwZUFuZEFyZ3VtZW50cyk6CisgICAgICAg IChUeXBlUmVmLnByb3RvdHlwZS50b1N0cmluZyk6CisgICAgICAgIChUeXBlUmVmKToKKyAgICAg ICAgKFR5cGVSZWYucHJvdG90eXBlLmdldCBpbnN0YW50aWF0ZWRUeXBlKTogRGVsZXRlZC4KKwog MjAxNy0wOS0xOCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFtX U0xdIENhbm5vdCBwdXQgdGVtcGxhdGVkIHN0cnVjdHMgaW5zaWRlIHN0cnVjdHMKSW5kZXg6IFRv b2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0NoZWNrZXIuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvQ2hlY2tlci5qcwkocmV2aXNpb24gMjIyMjAxKQor KysgVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvQ2hlY2tlci5qcwkod29ya2luZyBjb3B5 KQpAQCAtNTMsNyArNTMsNyBAQCBjbGFzcyBDaGVja2VyIGV4dGVuZHMgVmlzaXRvciB7CiAgICAg ICAgICAgICAgICAgZG9TdGF0ZW1lbnQoZnVuYyk7CiAgICAgICAgIH0KICAgICB9Ci0gICAgICAg IAorICAgIAogICAgIHZpc2l0RnVuY0RlZihub2RlKQogICAgIHsKICAgICAgICAgbm9kZS5ib2R5 LnZpc2l0KHRoaXMpOwpJbmRleDogVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvSW5zdGFu dGlhdGVJbW1lZGlhdGVzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5n dWFnZVJJL0luc3RhbnRpYXRlSW1tZWRpYXRlcy5qcwkocmV2aXNpb24gMjIyMjAxKQorKysgVG9v bHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvSW5zdGFudGlhdGVJbW1lZGlhdGVzLmpzCSh3b3Jr aW5nIGNvcHkpCkBAIC0yOCw4ICsyOCwxMiBAQCBjbGFzcyBJbnN0YW50aWF0ZUltbWVkaWF0ZXMg ZXh0ZW5kcyBSZXdyCiAgICAgdmlzaXRUeXBlUmVmKG5vZGUpCiAgICAgewogICAgICAgICBub2Rl ID0gc3VwZXIudmlzaXRUeXBlUmVmKG5vZGUpOwotICAgICAgICBsZXQgcmVzdWx0ID0gbm9kZS5p bnN0YW50aWF0ZWRUeXBlLnZpc2l0KG5ldyBBdXRvV3JhcHBlcigpKTsKLSAgICAgICAgcmV0dXJu IHJlc3VsdDsKKyAgICAgICAgaWYgKCFub2RlLnR5cGUuaW5zdGFudGlhdGUpIHsKKyAgICAgICAg ICAgIGlmIChub2RlLnR5cGVBcmd1bWVudHMubGVuZ3RoKQorICAgICAgICAgICAgICAgIHRocm93 IG5ldyBFcnJvcigidHlwZSBkb2VzIG5vdCBzdXBwb3J0IGluc3RhbnRpYXRpb246ICIgKyB0eXBl ICsgIiAoIiArIHR5cGUuY29uc3RydWN0b3IubmFtZSArICIpIik7CisgICAgICAgICAgICByZXR1 cm4gbm9kZTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gbm9kZS50eXBlLmluc3RhbnRpYXRl KG5vZGUudHlwZUFyZ3VtZW50cykudmlzaXQobmV3IEF1dG9XcmFwcGVyKCkpOwogICAgIH0KICAg ICAKICAgICB2aXNpdFJlZmVyZW5jZVR5cGUobm9kZSkKSW5kZXg6IFRvb2xzL1dlYkdQVVNoYWRp bmdMYW5ndWFnZVJJL1Rlc3QuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViR1BVU2hhZGluZ0xh bmd1YWdlUkkvVGVzdC5qcwkocmV2aXNpb24gMjIyMjAxKQorKysgVG9vbHMvV2ViR1BVU2hhZGlu Z0xhbmd1YWdlUkkvVGVzdC5qcwkod29ya2luZyBjb3B5KQpAQCAtMzkyMiw2ICszOTIyLDIzIEBA IGZ1bmN0aW9uIFRFU1RfaW5zdGFudGlhdGVTdHJ1Y3RJblN0cnVjdCgKICAgICBjaGVja0ludChw cm9ncmFtLCBjYWxsRnVuY3Rpb24ocHJvZ3JhbSwgImZvbyIsIFtdLCBbXSksIDQzKTsKIH0KIAor ZnVuY3Rpb24gVEVTVF9pbnN0YW50aWF0ZVN0cnVjdEluU3RydWN0V2l0aEludDIoKQoreworICAg IGxldCBwcm9ncmFtID0gZG9QcmVwKGAKKyAgICAgICAgc3RydWN0IEZvbyB7CisgICAgICAgICAg ICBpbnQyIHg7CisgICAgICAgIH0KKyAgICAgICAgaW50IGZvbygpCisgICAgICAgIHsKKyAgICAg ICAgICAgIEZvbyB4OworICAgICAgICAgICAgeC54LnggPSA0MjsKKyAgICAgICAgICAgIHgueC54 Kys7CisgICAgICAgICAgICByZXR1cm4geC54Lng7CisgICAgICAgIH0KKyAgICBgKTsKKyAgICBj aGVja0ludChwcm9ncmFtLCBjYWxsRnVuY3Rpb24ocHJvZ3JhbSwgImZvbyIsIFtdLCBbXSksIDQz KTsKK30KKwogZnVuY3Rpb24gVEVTVF9zaW1wbGVFbnVtKCkKIHsKICAgICBsZXQgcHJvZ3JhbSA9 IGRvUHJlcChgCkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9UeXBlUmVmLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1R5cGVSZWYuanMJ KHJldmlzaW9uIDIyMjIwMSkKKysrIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1R5cGVS ZWYuanMJKHdvcmtpbmcgY29weSkKQEAgLTM4LDcgKzM4LDcgQEAgY2xhc3MgVHlwZVJlZiBleHRl bmRzIFR5cGUgewogICAgIHsKICAgICAgICAgaWYgKHR5cGUgaW5zdGFuY2VvZiBUeXBlUmVmICYm ICF0eXBlLnR5cGVBcmd1bWVudHMpCiAgICAgICAgICAgICByZXR1cm4gdHlwZTsKLSAgICAgICAg bGV0IHJlc3VsdCA9IG5ldyBUeXBlUmVmKHR5cGUub3JpZ2luLCB0eXBlLm5hbWUsIFtdKTsKKyAg ICAgICAgbGV0IHJlc3VsdCA9IG5ldyBUeXBlUmVmKHR5cGUub3JpZ2luLCBudWxsLCBbXSk7CiAg ICAgICAgIHJlc3VsdC50eXBlID0gdHlwZTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9 CkBAIC01NCwxNyArNTQsNiBAQCBjbGFzcyBUeXBlUmVmIGV4dGVuZHMgVHlwZSB7CiAgICAgZ2V0 IG5hbWUoKSB7IHJldHVybiB0aGlzLl9uYW1lOyB9CiAgICAgZ2V0IHR5cGVBcmd1bWVudHMoKSB7 IHJldHVybiB0aGlzLl90eXBlQXJndW1lbnRzOyB9CiAgICAgCi0gICAgZ2V0IGluc3RhbnRpYXRl ZFR5cGUoKQotICAgIHsKLSAgICAgICAgbGV0IHR5cGUgPSB0aGlzLnR5cGUudW5pZnlOb2RlOwot ICAgICAgICBpZiAoIXR5cGUuaW5zdGFudGlhdGUpIHsKLSAgICAgICAgICAgIGlmICh0aGlzLnR5 cGVBcmd1bWVudHMubGVuZ3RoKQotICAgICAgICAgICAgICAgIHRocm93IG5ldyBFcnJvcigidHlw ZSBkb2VzIG5vdCBzdXBwb3J0IGluc3RhbnRpYXRpb246ICIgKyB0eXBlICsgIiAoIiArIHR5cGUu Y29uc3RydWN0b3IubmFtZSArICIpIik7Ci0gICAgICAgICAgICByZXR1cm4gdGhpczsKLSAgICAg ICAgfQotICAgICAgICByZXR1cm4gdHlwZS5pbnN0YW50aWF0ZSh0aGlzLnR5cGVBcmd1bWVudHMp OwotICAgIH0KLSAgICAKICAgICBnZXQgdW5pZnlOb2RlKCkKICAgICB7CiAgICAgICAgIGlmICgh dGhpcy50eXBlQXJndW1lbnRzLmxlbmd0aCkKQEAgLTk1LDcgKzg0LDcgQEAgY2xhc3MgVHlwZVJl ZiBleHRlbmRzIFR5cGUgewogICAgIAogICAgIHNldFR5cGVBbmRBcmd1bWVudHModHlwZSwgdHlw ZUFyZ3VtZW50cykKICAgICB7Ci0gICAgICAgIHRoaXMuX25hbWUgPSB0eXBlLm5hbWU7CisgICAg ICAgIHRoaXMuX25hbWUgPSBudWxsOwogICAgICAgICB0aGlzLnR5cGUgPSB0eXBlOwogICAgICAg ICB0aGlzLl90eXBlQXJndW1lbnRzID0gdHlwZUFyZ3VtZW50czsKICAgICB9CkBAIC0xMTgsNyAr MTA3LDcgQEAgY2xhc3MgVHlwZVJlZiBleHRlbmRzIFR5cGUgewogICAgIHRvU3RyaW5nKCkKICAg ICB7CiAgICAgICAgIGlmICghdGhpcy5uYW1lKQotICAgICAgICAgICAgcmV0dXJuICJyZWY6IiAr IHRoaXMudHlwZS50b1N0cmluZygpOworICAgICAgICAgICAgcmV0dXJuIHRoaXMudHlwZS50b1N0 cmluZygpOwogICAgICAgICBpZiAoIXRoaXMudHlwZUFyZ3VtZW50cy5sZW5ndGgpCiAgICAgICAg ICAgICByZXR1cm4gdGhpcy5uYW1lOwogICAgICAgICByZXR1cm4gdGhpcy5uYW1lICsgIjwiICsg dGhpcy50eXBlQXJndW1lbnRzICsgIj4iOwo=