177104 2017-09-18 14:58:53 -0700 WSL should know that constexpr parameters are not lvalues 2018-10-13 19:42:53 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 176199 1 fpizlo fpizlo saam webkit-bug-importer oldest_to_newest 1350107 0 fpizlo 2017-09-18 14:58:53 -0700 Patch forthcoming. 1350119 1 321139 fpizlo 2017-09-18 15:34:37 -0700 Created attachment 321139 the patch 1350204 2 fpizlo 2017-09-18 19:03:07 -0700 Landed in https://trac.webkit.org/changeset/222184/webkit 1353738 3 webkit-bug-importer 2017-09-27 12:55:38 -0700 <rdar://problem/34694285> 1468993 4 mmaxfield 2018-10-13 19:42:53 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/187 321139 2017-09-18 15:34:37 -0700 2017-09-18 15:35:15 -0700 the patch blah.patch text/plain 5375 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjE4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDM0IEBACisyMDE3LTA5LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgV1NMIHNob3VsZCBrbm93IHRoYXQgY29uc3RleHByIHBhcmFtZXRlcnMgYXJlIG5v dCBsdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzcxMDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAg CisgICAgICAgIFRoaXMgc2hvdWxkIGJlIGFuIGVycm9yOgorICAgICAgICAKKyAgICAgICAgICAg IHZvaWQgZm9vPGludCB4PigpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgeCA9IDQy OworICAgICAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgUHJldmlvdXNseSwgaXQgd2Fzbid0 LCBiZWNhdXNlIFZhcmlhYmxlUmVmIGFsd2F5cyB0aG91Z2h0IHRoYXQgaXQgd2FzIGFuIExWYWx1 ZS4gVGhpcyBwYXRjaAorICAgICAgICB0ZWFjaGVzIHRoZSB0eXBlIGNoZWNrZXIgdGhhdCBub3Qg YWxsIFZhcmlhYmxlUmVmcyBhcmUgTFZhbHVlcy4KKworICAgICAgICAqIFdlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL0NvbnN0ZXhwclR5cGVQYXJhbWV0ZXIuanM6CisgICAgICAgIChDb25zdGV4cHJU eXBlUGFyYW1ldGVyLnByb3RvdHlwZS5nZXQgdmFySXNMVmFsdWUpOgorICAgICAgICAqIFdlYkdQ VVNoYWRpbmdMYW5ndWFnZVJJL0Z1bmNQYXJhbWV0ZXIuanM6CisgICAgICAgIChGdW5jUGFyYW1l dGVyLnByb3RvdHlwZS5nZXQgdmFySXNMVmFsdWUpOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL1Rlc3QuanM6CisgICAgICAgIChURVNUX25vbkFycmF5UmVmQXJyYXlMZW5ndGhT dWNjZWVkKToKKyAgICAgICAgKFRFU1Rfbm9uQXJyYXlSZWZBcnJheUxlbmd0aEZhaWwpOgorICAg ICAgICAoVEVTVF9ub25BcnJheVJlZkFycmF5TGVuZ3RoKTogRGVsZXRlZC4KKyAgICAgICAgKFRF U1RfYXNzaWduTGVuZ3RoKTogRGVsZXRlZC4KKyAgICAgICAgKiBXZWJHUFVTaGFkaW5nTGFuZ3Vh Z2VSSS9WYXJpYWJsZURlY2wuanM6CisgICAgICAgIChWYXJpYWJsZURlY2wucHJvdG90eXBlLmdl dCB2YXJJc0xWYWx1ZSk6CisgICAgICAgICogV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvVmFyaWFi bGVSZWYuanM6CisgICAgICAgIChWYXJpYWJsZVJlZi5wcm90b3R5cGUuZ2V0IGlzTFZhbHVlKToK KwogMjAxNy0wOS0xOCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjIyMTcwLgpJbmRleDogVG9vbHMvV2ViR1BV U2hhZGluZ0xhbmd1YWdlUkkvQ29uc3RleHByVHlwZVBhcmFtZXRlci5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9Db25zdGV4cHJUeXBlUGFyYW1ldGVyLmpz CShyZXZpc2lvbiAyMjIxODEpCisrKyBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9Db25z dGV4cHJUeXBlUGFyYW1ldGVyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0zNyw2ICszNyw3IEBAIGNs YXNzIENvbnN0ZXhwclR5cGVQYXJhbWV0ZXIgZXh0ZW5kcyBWYWwKICAgICBnZXQgdHlwZSgpIHsg cmV0dXJuIHRoaXMuX3R5cGU7IH0KICAgICBnZXQgaXNDb25zdGV4cHIoKSB7IHJldHVybiB0cnVl OyB9CiAgICAgZ2V0IGlzVW5pZmlhYmxlKCkgeyByZXR1cm4gdHJ1ZTsgfQorICAgIGdldCB2YXJJ c0xWYWx1ZSgpIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgCiAgICAgdHlwZVZhcmlhYmxlVW5pZnko dW5pZmljYXRpb25Db250ZXh0LCBvdGhlcikKICAgICB7CkluZGV4OiBUb29scy9XZWJHUFVTaGFk aW5nTGFuZ3VhZ2VSSS9GdW5jUGFyYW1ldGVyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQ VVNoYWRpbmdMYW5ndWFnZVJJL0Z1bmNQYXJhbWV0ZXIuanMJKHJldmlzaW9uIDIyMjE4MSkKKysr IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0Z1bmNQYXJhbWV0ZXIuanMJKHdvcmtpbmcg Y29weSkKQEAgLTM3LDYgKzM3LDcgQEAgY2xhc3MgRnVuY1BhcmFtZXRlciBleHRlbmRzIFZhbHVl IHsKICAgICBnZXQgb3JpZ2luKCkgeyByZXR1cm4gdGhpcy5fb3JpZ2luOyB9CiAgICAgZ2V0IG5h bWUoKSB7IHJldHVybiB0aGlzLl9uYW1lOyB9CiAgICAgZ2V0IHR5cGUoKSB7IHJldHVybiB0aGlz Ll90eXBlOyB9CisgICAgZ2V0IHZhcklzTFZhbHVlKCkgeyByZXR1cm4gdHJ1ZTsgfQogICAgIAog ICAgIHRvU3RyaW5nKCkKICAgICB7CkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VS SS9UZXN0LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rl c3QuanMJKHJldmlzaW9uIDIyMjE4MSkKKysrIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJ L1Rlc3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTI2MjUsNyArMjYyNSw3IEBAIGZ1bmN0aW9uIFRF U1Rfc2ltcGxlTGVuZ3RoKCkKICAgICBjaGVja1VpbnQocHJvZ3JhbSwgY2FsbEZ1bmN0aW9uKHBy b2dyYW0sICJmb28iLCBbXSwgW10pLCA3NTQpOwogfQogCi1mdW5jdGlvbiBURVNUX25vbkFycmF5 UmVmQXJyYXlMZW5ndGgoKQorZnVuY3Rpb24gVEVTVF9ub25BcnJheVJlZkFycmF5TGVuZ3RoU3Vj Y2VlZCgpCiB7CiAgICAgbGV0IHByb2dyYW0gPSBkb1ByZXAoYAogICAgICAgICB1aW50IGZvbygp CkBAIC0yNjM3LDYgKzI2MzcsNTUgQEAgZnVuY3Rpb24gVEVTVF9ub25BcnJheVJlZkFycmF5TGVu Z3RoKCkKICAgICBjaGVja1VpbnQocHJvZ3JhbSwgY2FsbEZ1bmN0aW9uKHByb2dyYW0sICJmb28i LCBbXSwgW10pLCA3NTQpOwogfQogCitmdW5jdGlvbiBURVNUX25vbkFycmF5UmVmQXJyYXlMZW5n dGhGYWlsKCkKK3sKKyAgICBjaGVja0ZhaWwoCisgICAgICAgICgpID0+IGRvUHJlcChgCisgICAg ICAgICAgICB0aHJlYWQgdWludF4gbGVuZ3RoUHRyKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAg ICAgICAgICBpbnRbNDJdIGFycmF5OworICAgICAgICAgICAgICAgIHJldHVybiAmKGFycmF5Lmxl bmd0aCk7CisgICAgICAgICAgICB9CisgICAgICAgIGApLAorICAgICAgICBlID0+IGUgaW5zdGFu Y2VvZiBXVHlwZUVycm9yKTsKK30KKworZnVuY3Rpb24gVEVTVF9jb25zdGV4cHJJc05vdExWYWx1 ZVB0cigpCit7CisgICAgY2hlY2tGYWlsKAorICAgICAgICAoKSA9PiBkb1ByZXAoYAorICAgICAg ICAgICAgdGhyZWFkIGludF4gZm9vPGludCB4PigpCisgICAgICAgICAgICB7CisgICAgICAgICAg ICAgICAgcmV0dXJuICZ4OworICAgICAgICAgICAgfQorICAgICAgICBgKSwKKyAgICAgICAgZSA9 PiBlIGluc3RhbmNlb2YgV1R5cGVFcnJvcik7Cit9CisKK2Z1bmN0aW9uIFRFU1RfY29uc3RleHBy SXNOb3RMVmFsdWVBc3NpZ24oKQoreworICAgIGNoZWNrRmFpbCgKKyAgICAgICAgKCkgPT4gZG9Q cmVwKGAKKyAgICAgICAgICAgIHZvaWQgZm9vPGludCB4PigpCisgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgeCA9IDQyOworICAgICAgICAgICAgfQorICAgICAgICBgKSwKKyAgICAgICAg ZSA9PiBlIGluc3RhbmNlb2YgV1R5cGVFcnJvcik7Cit9CisKK2Z1bmN0aW9uIFRFU1RfY29uc3Rl eHBySXNOb3RMVmFsdWVSTVcoKQoreworICAgIGNoZWNrRmFpbCgKKyAgICAgICAgKCkgPT4gZG9Q cmVwKGAKKyAgICAgICAgICAgIHZvaWQgZm9vPGludCB4PigpCisgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgeCArPSA0MjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgYCksCisgICAgICAg IGUgPT4gZSBpbnN0YW5jZW9mIFdUeXBlRXJyb3IpOworfQorCiBmdW5jdGlvbiBURVNUX2Fzc2ln bkxlbmd0aCgpCiB7CiAgICAgY2hlY2tGYWlsKApJbmRleDogVG9vbHMvV2ViR1BVU2hhZGluZ0xh bmd1YWdlUkkvVmFyaWFibGVEZWNsLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRp bmdMYW5ndWFnZVJJL1ZhcmlhYmxlRGVjbC5qcwkocmV2aXNpb24gMjIyMTgxKQorKysgVG9vbHMv V2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvVmFyaWFibGVEZWNsLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0zOCw2ICszOCw3IEBAIGNsYXNzIFZhcmlhYmxlRGVjbCBleHRlbmRzIFZhbHVlIHsKICAgICBn ZXQgbmFtZSgpIHsgcmV0dXJuIHRoaXMuX25hbWU7IH0KICAgICBnZXQgdHlwZSgpIHsgcmV0dXJu IHRoaXMuX3R5cGU7IH0KICAgICBnZXQgaW5pdGlhbGl6ZXIoKSB7IHJldHVybiB0aGlzLl9pbml0 aWFsaXplcjsgfQorICAgIGdldCB2YXJJc0xWYWx1ZSgpIHsgcmV0dXJuIHRydWU7IH0KICAgICAK ICAgICB0b1N0cmluZygpCiAgICAgewpJbmRleDogVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdl UkkvVmFyaWFibGVSZWYuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1 YWdlUkkvVmFyaWFibGVSZWYuanMJKHJldmlzaW9uIDIyMjE4MSkKKysrIFRvb2xzL1dlYkdQVVNo YWRpbmdMYW5ndWFnZVJJL1ZhcmlhYmxlUmVmLmpzCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0 Miw3IEBAIGNsYXNzIFZhcmlhYmxlUmVmIGV4dGVuZHMgRXhwcmVzc2lvbiB7CiAgICAgZ2V0IG5h bWUoKSB7IHJldHVybiB0aGlzLl9uYW1lOyB9CiAgICAgZ2V0IGlzQ29uc3RleHByKCkgeyByZXR1 cm4gdGhpcy52YXJpYWJsZS5pc0NvbnN0ZXhwcjsgfQogICAgIGdldCB1bmlmeU5vZGUoKSB7IHJl dHVybiB0aGlzLnZhcmlhYmxlLnVuaWZ5Tm9kZTsgfSAvLyBUaGlzIG9ubHkgbWFrZXMgc2Vuc2Ug d2hlbiB0aGlzIGlzIGEgY29uc3RleHByLgotICAgIGdldCBpc0xWYWx1ZSgpIHsgcmV0dXJuIHRy dWU7IH0KKyAgICBnZXQgaXNMVmFsdWUoKSB7IHJldHVybiB0aGlzLnZhcmlhYmxlLnZhcklzTFZh bHVlOyB9CiAgICAgZ2V0IGFkZHJlc3NTcGFjZSgpIHsgcmV0dXJuICJ0aHJlYWQiOyB9CiAgICAg CiAgICAgdG9TdHJpbmcoKQo=