177028 2017-09-15 16:53:00 -0700 Avoid calling String::format() in PlatformCAFilters::setFiltersOnLayer() 2019-02-03 11:11:17 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 30342 1 sabouhallawa sabouhallawa commit-queue dino sam simon.fraser thorton webkit-bug-importer oldest_to_newest 1349569 0 sabouhallawa 2017-09-15 16:53:00 -0700 From instrumenting the MotionMark Focus test with fixed complexity, this function alone takes 2% of the execution time. 1349571 1 320969 sabouhallawa 2017-09-15 16:55:48 -0700 Created attachment 320969 Patch 1349585 2 320969 thorton 2017-09-15 17:10:49 -0700 Comment on attachment 320969 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320969&action=review > Source/WebCore/ChangeLog:8 > + String::fromat() is a bigger hammer for what we need to do in this function. FROMAT > Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:71 > + static NeverDestroyed<String> filterNamePrefix ="filter_"; There's a missing space after the =. Also isn't there a way to make this more efficient b/c it comes from a literal (something like ASCIILiteral? or does that just happen magically? I don't know. Look around.) 1349592 3 320976 sabouhallawa 2017-09-15 17:26:50 -0700 Created attachment 320976 Patch 1349608 4 320984 sabouhallawa 2017-09-15 18:44:38 -0700 Created attachment 320984 Patch 1349615 5 320984 commit-queue 2017-09-15 19:26:48 -0700 Comment on attachment 320984 Patch Clearing flags on attachment: 320984 Committed r222125: <http://trac.webkit.org/changeset/222125> 1349616 6 commit-queue 2017-09-15 19:26:49 -0700 All reviewed patches have been landed. Closing bug. 1349796 7 320984 sam 2017-09-17 15:18:38 -0700 Comment on attachment 320984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320984&action=review > Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:74 > + String filterName = filterNamePrefix.get() + String::number(i); For the future, this could be make more efficient by doing: #include <wtf/text/StringConcatenate.h> #include <wtf/text/StringConcatenateNumbers.h> auto filterName = makeString("filter_", i); 1353603 8 webkit-bug-importer 2017-09-27 12:41:37 -0700 <rdar://problem/34693768> 320969 2017-09-15 16:55:48 -0700 2017-09-15 17:26:48 -0700 Patch bug-177028-20170915165547.patch text/plain 1662 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjExOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA5LTE1ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgY2Fs bGluZyBTdHJpbmc6OmZvcm1hdCgpIGluIFBsYXRmb3JtQ0FGaWx0ZXJzOjpzZXRGaWx0ZXJzT25M YXllcigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzcwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT dHJpbmc6OmZyb21hdCgpIGlzIGEgYmlnZ2VyIGhhbW1lciBmb3Igd2hhdCB3ZSBuZWVkIHRvIGRv IGluIHRoaXMgZnVuY3Rpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2Nv YS9QbGF0Zm9ybUNBRmlsdGVyc0NvY29hLm1tOgorCiAyMDE3LTA5LTE1ICBXZW5zb24gSHNpZWgg IDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEF2b2lkIHN0eWxlIHJlY29tcHV0 YXRpb24gd2hlbiBmb3J3YXJkaW5nIGEgZm9jdXMgZXZlbnQgdG8gYW4gdGV4dCBmaWVsZCdzIGlu cHV0IHR5cGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL2NvY29h L1BsYXRmb3JtQ0FGaWx0ZXJzQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2EvY29jb2EvUGxhdGZvcm1DQUZpbHRlcnNDb2NvYS5tbQkocmV2 aXNpb24gMjIxOTk2KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvY29j b2EvUGxhdGZvcm1DQUZpbHRlcnNDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtNjgsOSArNjgs MTAgQEAgdm9pZCBQbGF0Zm9ybUNBRmlsdGVyczo6c2V0RmlsdGVyc09uTGF5ZQogICAgIEJFR0lO X0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgIAogICAgIFJldGFpblB0cjxOU011dGFibGVBcnJh eT4gYXJyYXkgPSBhZG9wdE5TKFtbTlNNdXRhYmxlQXJyYXkgYWxsb2NdIGluaXRdKTsKLSAgICAK KyAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8U3RyaW5nPiBmaWx0ZXJOYW1lUHJlZml4ID0iZmls dGVyXyI7CisKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZmlsdGVycy5zaXplKCk7ICsr aSkgewotICAgICAgICBTdHJpbmcgZmlsdGVyTmFtZSA9IFN0cmluZzo6Zm9ybWF0KCJmaWx0ZXJf JWQiLCBpKTsKKyAgICAgICAgU3RyaW5nIGZpbHRlck5hbWUgPSBmaWx0ZXJOYW1lUHJlZml4Lmdl dCgpICsgQXRvbWljU3RyaW5nOjpudW1iZXIoaSk7CiAgICAgICAgIGNvbnN0IEZpbHRlck9wZXJh dGlvbiYgZmlsdGVyT3BlcmF0aW9uID0gKmZpbHRlcnMuYXQoaSk7CiAgICAgICAgIHN3aXRjaCAo ZmlsdGVyT3BlcmF0aW9uLnR5cGUoKSkgewogICAgICAgICBjYXNlIEZpbHRlck9wZXJhdGlvbjo6 REVGQVVMVDoK 320976 2017-09-15 17:26:50 -0700 2017-09-15 18:44:36 -0700 Patch bug-177028-20170915172649.patch text/plain 1683 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjExOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA5LTE1ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgY2Fs bGluZyBTdHJpbmc6OmZvcm1hdCgpIGluIFBsYXRmb3JtQ0FGaWx0ZXJzOjpzZXRGaWx0ZXJzT25M YXllcigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzcwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIFN0cmlu Zzo6Zm9ybWF0KCkgaXMgYSBiaWdnZXIgaGFtbWVyIGZvciB3aGF0IHdlIG5lZWQgdG8gZG8gaW4g dGhpcyBmdW5jdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL2NvY29hL1Bs YXRmb3JtQ0FGaWx0ZXJzQ29jb2EubW06CisKIDIwMTctMDktMTUgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgc3R5bGUgcmVjb21wdXRhdGlv biB3aGVuIGZvcndhcmRpbmcgYSBmb2N1cyBldmVudCB0byBhbiB0ZXh0IGZpZWxkJ3MgaW5wdXQg dHlwZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvY29jb2EvUGxh dGZvcm1DQUZpbHRlcnNDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBRmlsdGVyc0NvY29hLm1tCShyZXZpc2lv biAyMjE5OTYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9Q bGF0Zm9ybUNBRmlsdGVyc0NvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02OCw5ICs2OCwxMCBA QCB2b2lkIFBsYXRmb3JtQ0FGaWx0ZXJzOjpzZXRGaWx0ZXJzT25MYXllCiAgICAgQkVHSU5fQkxP Q0tfT0JKQ19FWENFUFRJT05TCiAgICAgCiAgICAgUmV0YWluUHRyPE5TTXV0YWJsZUFycmF5PiBh cnJheSA9IGFkb3B0TlMoW1tOU011dGFibGVBcnJheSBhbGxvY10gaW5pdF0pOwotICAgIAorICAg IHN0YXRpYyBOZXZlckRlc3Ryb3llZDxTdHJpbmc+IGZpbHRlck5hbWVQcmVmaXgoTUFLRV9TVEFU SUNfU1RSSU5HX0lNUEwoImZpbHRlcl8iKSk7CisKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgZmlsdGVycy5zaXplKCk7ICsraSkgewotICAgICAgICBTdHJpbmcgZmlsdGVyTmFtZSA9IFN0 cmluZzo6Zm9ybWF0KCJmaWx0ZXJfJWQiLCBpKTsKKyAgICAgICAgU3RyaW5nIGZpbHRlck5hbWUg PSBmaWx0ZXJOYW1lUHJlZml4LmdldCgpICsgQXRvbWljU3RyaW5nOjpudW1iZXIoaSk7CiAgICAg ICAgIGNvbnN0IEZpbHRlck9wZXJhdGlvbiYgZmlsdGVyT3BlcmF0aW9uID0gKmZpbHRlcnMuYXQo aSk7CiAgICAgICAgIHN3aXRjaCAoZmlsdGVyT3BlcmF0aW9uLnR5cGUoKSkgewogICAgICAgICBj YXNlIEZpbHRlck9wZXJhdGlvbjo6REVGQVVMVDoK 320984 2017-09-15 18:44:38 -0700 2017-09-15 19:26:48 -0700 Patch bug-177028-20170915184437.patch text/plain 1677 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjExOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA5LTE1ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgY2Fs bGluZyBTdHJpbmc6OmZvcm1hdCgpIGluIFBsYXRmb3JtQ0FGaWx0ZXJzOjpzZXRGaWx0ZXJzT25M YXllcigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzcwMjgKKworICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIFN0cmlu Zzo6Zm9ybWF0KCkgaXMgYSBiaWdnZXIgaGFtbWVyIGZvciB3aGF0IHdlIG5lZWQgdG8gZG8gaW4g dGhpcyBmdW5jdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL2NvY29hL1Bs YXRmb3JtQ0FGaWx0ZXJzQ29jb2EubW06CisKIDIwMTctMDktMTUgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQXZvaWQgc3R5bGUgcmVjb21wdXRhdGlv biB3aGVuIGZvcndhcmRpbmcgYSBmb2N1cyBldmVudCB0byBhbiB0ZXh0IGZpZWxkJ3MgaW5wdXQg dHlwZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvY29jb2EvUGxh dGZvcm1DQUZpbHRlcnNDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBRmlsdGVyc0NvY29hLm1tCShyZXZpc2lv biAyMjE5OTYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9Q bGF0Zm9ybUNBRmlsdGVyc0NvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02OCw5ICs2OCwxMCBA QCB2b2lkIFBsYXRmb3JtQ0FGaWx0ZXJzOjpzZXRGaWx0ZXJzT25MYXllCiAgICAgQkVHSU5fQkxP Q0tfT0JKQ19FWENFUFRJT05TCiAgICAgCiAgICAgUmV0YWluUHRyPE5TTXV0YWJsZUFycmF5PiBh cnJheSA9IGFkb3B0TlMoW1tOU011dGFibGVBcnJheSBhbGxvY10gaW5pdF0pOwotICAgIAorICAg IHN0YXRpYyBOZXZlckRlc3Ryb3llZDxTdHJpbmc+IGZpbHRlck5hbWVQcmVmaXgoTUFLRV9TVEFU SUNfU1RSSU5HX0lNUEwoImZpbHRlcl8iKSk7CisKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgZmlsdGVycy5zaXplKCk7ICsraSkgewotICAgICAgICBTdHJpbmcgZmlsdGVyTmFtZSA9IFN0 cmluZzo6Zm9ybWF0KCJmaWx0ZXJfJWQiLCBpKTsKKyAgICAgICAgU3RyaW5nIGZpbHRlck5hbWUg PSBmaWx0ZXJOYW1lUHJlZml4LmdldCgpICsgU3RyaW5nOjpudW1iZXIoaSk7CiAgICAgICAgIGNv bnN0IEZpbHRlck9wZXJhdGlvbiYgZmlsdGVyT3BlcmF0aW9uID0gKmZpbHRlcnMuYXQoaSk7CiAg ICAgICAgIHN3aXRjaCAoZmlsdGVyT3BlcmF0aW9uLnR5cGUoKSkgewogICAgICAgICBjYXNlIEZp bHRlck9wZXJhdGlvbjo6REVGQVVMVDoK