176891 2017-09-13 23:54:10 -0700 [WinCairo] Add an option to build WebKitLegacy or WebKit 2017-09-27 12:34:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 174003 1 Yousuke.Kimoto webkit-unassigned achristensen commit-queue don.olmstead webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1348671 0 Yousuke.Kimoto 2017-09-13 23:54:10 -0700 To build WebKitLegacy and WebKit on WinCairo, we'd like to introduce ENABLE_WEBKIT_LEGACY for WInCiaro's CMake files to choose the two architecture. For WebKitLegacy: $ perl Tools\Scripts\build-webkit --no-ninja --wincairo --64-bit For WebKit: $ perl Tools\Scripts\build-webkit --no-ninja --64-bit --wincairo --cmakeargs="-DENABLE_WEBKIT_LEGACY=OFF" 1348701 1 320749 Yousuke.Kimoto 2017-09-14 01:45:14 -0700 Created attachment 320749 [PATCH] Add an option to build WebKitLegacy or WebKit 1348851 2 320749 achristensen 2017-09-14 10:46:31 -0700 Comment on attachment 320749 [PATCH] Add an option to build WebKitLegacy or WebKit Won't we want to add an else to both of these conditions? 1349144 3 320749 don.olmstead 2017-09-14 18:13:54 -0700 Comment on attachment 320749 [PATCH] Add an option to build WebKitLegacy or WebKit Ok so I got some clarification this will work with the following command perl Tools\Scripts\build-webkit --64-bit --wincairo --cmakeargs="-DENABLE_WEBKIT_LEGACY=OFF" In this case the root CMakeLists.txt has if (NOT DEFINED ENABLE_WEBKIT) set(ENABLE_WEBKIT ON) endif () So this will end up building with WebKit instead of WebKitLegacy. 1349146 4 320749 commit-queue 2017-09-14 18:42:56 -0700 Comment on attachment 320749 [PATCH] Add an option to build WebKitLegacy or WebKit Clearing flags on attachment: 320749 Committed r222070: <http://trac.webkit.org/changeset/222070> 1349147 5 commit-queue 2017-09-14 18:42:57 -0700 All reviewed patches have been landed. Closing bug. 1353483 6 webkit-bug-importer 2017-09-27 12:34:13 -0700 <rdar://problem/34693503> 320749 2017-09-14 01:45:14 -0700 2017-09-14 18:42:56 -0700 [PATCH] Add an option to build WebKitLegacy or WebKit bz176891.diff text/plain 2351 Yousuke.Kimoto ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5NmM3Y2VkLi4wMTk0Mzg4 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTctMDktMTQgIFlvdXN1a2UgS2ltb3RvICA8eW91c3VrZS5raW1vdG9Ac29ueS5jb20+CisK KyAgICAgICAgW1dpbkNhaXJvXSBBZGQgYW4gb3B0aW9uIHRvIGJ1aWxkIFdlYktpdExlZ2FjeSBv ciBXZWJLaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3Njg5MQorCisgICAgICAgIEFkZGVkIGFuIG9wdGlvbiB0byBidWlsZCBXZWJLaXRMZWdhY3kg b3IgV2ViS2l0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2U6CisKIDIwMTctMDktMDcgIEFkcmlh biBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtD TWFrZV0gQWRkICJkaXN0IiBhbmQgImRpc3RjaGVjayIgdGFyZ2V0cwpkaWZmIC0tZ2l0IGEvU291 cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFr ZQppbmRleCBlZWZlYzU1Li5mZDNjY2MzIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9u c1dpbi5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZQpAQCAtNyw4ICs3 LDEwIEBAIGFkZF9kZWZpbml0aW9ucygtRF9XSU5ET1dTIC1EV0lOVkVSPTB4NjAxIC1EX1dJTjMy X1dJTk5UPTB4NjAxKQogYWRkX2RlZmluaXRpb25zKC1ETk9NSU5NQVgpCiBhZGRfZGVmaW5pdGlv bnMoLURVTklDT0RFIC1EX1VOSUNPREUpCiAKLXNldChFTkFCTEVfV0VCS0lUX0xFR0FDWSBPTikK LXNldChFTkFCTEVfV0VCS0lUIE9GRikKK2lmICgoTk9UIERFRklORUQgRU5BQkxFX1dFQktJVF9M RUdBQ1kpIE9SIEVOQUJMRV9XRUJLSVRfTEVHQUNZKQorICAgIHNldChFTkFCTEVfV0VCS0lUX0xF R0FDWSBPTikKKyAgICBzZXQoRU5BQkxFX1dFQktJVCBPRkYpCitlbmRpZiAoKQogCiBXRUJLSVRf T1BUSU9OX0JFR0lOKCkKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV8z RF9UUkFOU0ZPUk1TIFBVQkxJQyBPTikKZGlmZiAtLWdpdCBhL1Rvb2xzL0NNYWtlTGlzdHMudHh0 IGIvVG9vbHMvQ01ha2VMaXN0cy50eHQKaW5kZXggMmVhNzFiZC4uNmE4Mjc3ZiAxMDA2NDQKLS0t IGEvVG9vbHMvQ01ha2VMaXN0cy50eHQKKysrIGIvVG9vbHMvQ01ha2VMaXN0cy50eHQKQEAgLTMz LDkgKzMzLDExIEBAIGVsc2VpZiAoIiR7UE9SVH0iIFNUUkVRVUFMICJXUEUiKQogICAgIGVuZGlm ICgpCiBlbHNlaWYgKCIke1BPUlR9IiBTVFJFUVVBTCAiV2luIikKICAgICBhZGRfc3ViZGlyZWN0 b3J5KER1bXBSZW5kZXJUcmVlKQotICAgIGFkZF9zdWJkaXJlY3RvcnkoVGVzdFdlYktpdEFQSSkK LSAgICBhZGRfc3ViZGlyZWN0b3J5KE1pbmlCcm93c2VyL3dpbikKICAgICBhZGRfc3ViZGlyZWN0 b3J5KEltYWdlRGlmZikKKyAgICBpZiAoRU5BQkxFX1dFQktJVF9MRUdBQ1kpCisgICAgICAgIGFk ZF9zdWJkaXJlY3RvcnkoVGVzdFdlYktpdEFQSSkKKyAgICAgICAgYWRkX3N1YmRpcmVjdG9yeShN aW5pQnJvd3Nlci93aW4pCisgICAgZW5kaWYgKCkKIGVuZGlmICgpCiAKIGlmIChFTkFCTEVfV0VC S0lUIEFORCBFTkFCTEVfQVBJX1RFU1RTKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIv VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGMwZTcwMDkuLjcxNTQ5NDQgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0w OS0xNCAgWW91c3VrZSBLaW1vdG8gIDx5b3VzdWtlLmtpbW90b0Bzb255LmNvbT4KKworICAgICAg ICBbV2luQ2Fpcm9dIEFkZCBhbiBvcHRpb24gdG8gYnVpbGQgV2ViS2l0TGVnYWN5IGFuZCBXZWJL aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Njg5 MQorCisgICAgICAgIFNpbmNlIFRlc3RXZWJLaXRBUEkgYW5kIE1pbmlCcm93c2VyL3dpbiBhcmUg dXNlZCBmb3IgV2ViS2l0TGVnYWN5LAorICAgICAgICB0aG9zZSBzdWJkaXJlY3RvcmllcyBhcmUg aWdub3JlZCBmb3IgV2ViS2l0IGJ1aWxkLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTctMDktMTMgIE1hdHQg TGV3aXMgIDxqbGV3aXMzQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMjIxOTc2Lgo=