176814 2017-09-12 16:43:50 -0700 String.prototype.replace() puts extra '<' in result when a named capture reference is used without named captures in the RegExp 2022-09-07 08:27:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=205785 InRadar P2 Normal --- 1 msaboff msaboff buildbot keith_miller mark.lam saam thisiskatewinslet webkit-bug-importer oldest_to_newest 1348094 0 msaboff 2017-09-12 16:43:50 -0700 According to the named capture proposed spec changes, when the string "$<" is seen in the replacement string but the search RegExp doesn't contain any named groups, "$<" should be copied to the output. See step 1 for the "$<" row in Table 1of the proposal (https://tc39.github.io/proposal-regexp-named-groups/#table-45). Currently we are copying "$<<". 1348095 1 webkit-bug-importer 2017-09-12 16:44:21 -0700 <rdar://problem/34399809> 1348101 2 320582 msaboff 2017-09-12 16:54:58 -0700 Created attachment 320582 Patch 1348117 3 320582 mark.lam 2017-09-12 17:18:18 -0700 Comment on attachment 320582 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320582&action=review LGTM > Source/JavaScriptCore/ChangeLog:8 > + The copy and advance indecies where off by one and needed a little fine tuning. typo:/indecies/indices/ 1348118 4 msaboff 2017-09-12 17:20:38 -0700 Committed r221949: <http://trac.webkit.org/changeset/221949> 320582 2017-09-12 16:54:58 -0700 2017-09-12 17:18:18 -0700 Patch 176814.patch text/plain 4351 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxOTQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE3LTA5LTEyICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFN0cmluZy5wcm90b3R5cGUucmVwbGFjZSgpIHB1dHMgZXh0cmEgJzwnIGluIHJlc3VsdCB3 aGVuIGEgbmFtZWQgY2FwdHVyZSByZWZlcmVuY2UgaXMgdXNlZCB3aXRob3V0IG5hbWVkIGNhcHR1 cmVzIGluIHRoZSBSZWdFeHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NjgxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBjb3B5IGFuZCBhZHZhbmNlIGluZGVjaWVzIHdoZXJlIG9mZiBieSBvbmUg YW5kIG5lZWRlZCBhIGxpdHRsZSBmaW5lIHR1bmluZy4KKworICAgICAgICAqIHJ1bnRpbWUvU3Ry aW5nUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6c3Vic3RpdHV0ZUJhY2tyZWZlcmVuY2Vz U2xvdyk6CisKIDIwMTctMDktMTEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIE1vcmUgZXhjZXB0aW9uIGNoZWNrIGJvb2sta2VlcGluZyBuZWVkZWQgZm91bmQgYnkg MzItYml0IEpTQyB0ZXN0IGZhaWx1cmVzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAyMjE5NDEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90b3R5cGUuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yMTMsNyArMjEzLDggQEAgc3RhdGljIE5FVkVSX0lOTElORSBTdHJpbmcgc3Vi c3RpdHV0ZUJhYwogICAgICAgICAgICAgLy8gTmFtZWQgYmFjayByZWZlcmVuY2UKICAgICAgICAg ICAgIGlmICghaGFzTmFtZWRDYXB0dXJlcykgewogICAgICAgICAgICAgICAgIHN1YnN0aXR1dGVk UmVwbGFjZW1lbnQuYXBwZW5kKHJlcGxhY2VtZW50LnN1YnN0cmluZyhpLCAyKSk7Ci0gICAgICAg ICAgICAgICAgb2Zmc2V0ID0gaSArIDE7CisgICAgICAgICAgICAgICAgb2Zmc2V0ID0gaSArIDI7 CisgICAgICAgICAgICAgICAgYWR2YW5jZSA9IDE7CiAgICAgICAgICAgICAgICAgY29udGludWU7 CiAgICAgICAgICAgICB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMTk0MSkKKysrIExheW91dFRl c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA5LTEy ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZy5w cm90b3R5cGUucmVwbGFjZSgpIHB1dHMgZXh0cmEgJzwnIGluIHJlc3VsdCB3aGVuIGEgbmFtZWQg Y2FwdHVyZSByZWZlcmVuY2UgaXMgdXNlZCB3aXRob3V0IG5hbWVkIGNhcHR1cmVzIGluIHRoZSBS ZWdFeHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NjgxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5l dyByZWdyZXNzaW9uIHRlc3QgY2FzZS4KKworICAgICAgICAqIGpzL3JlZ2V4cC1uYW1lZC1jYXB0 dXJlLWdyb3Vwcy1leHBlY3RlZC50eHQ6CisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL3JlZ2V4 cC1uYW1lZC1jYXB0dXJlLWdyb3Vwcy5qczoKKwogMjAxNy0wOS0xMiAgTWljaGFlbCBDYXRhbnph cm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gVW5yZXZpZXdlZCwg dXBkYXRlIGNyYXNoIGV4cGVjdGF0aW9ucyBhZnRlciByMjIxOTI1CkluZGV4OiBMYXlvdXRUZXN0 cy9qcy9yZWdleHAtbmFtZWQtY2FwdHVyZS1ncm91cHMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2pzL3JlZ2V4cC1uYW1lZC1jYXB0dXJlLWdyb3Vwcy1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDIyMTk0MSkKKysrIExheW91dFRlc3RzL2pzL3JlZ2V4cC1uYW1lZC1jYXB0 dXJlLWdyb3Vwcy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDYgKzQ1LDcgQEAg UEFTUyAiMTAvMjAvMTkzMCIucmVwbGFjZSgvKD88bW9udGg+XGR7MgogUEFTUyAiMTAvMjAvMTkz MCIucmVwbGFjZSgvKD88bW9udGg+XGR7Mn0pXC8oPzxkYXk+XGR7Mn0pXC8oPzx5ZWFyPlxkezR9 KS8sICIkMi0kPG1vbnRoPi0kPHllYXI+IikgaXMgIjIwLTEwLTE5MzAiCiBQQVNTICIxMC8yMC8x OTMwIi5yZXBsYWNlKC8oPzxtb250aD5cZHsyfSlcLyg/PGRheT5cZHsyfSlcLyg/PHllYXI+XGR7 NH0pLywgIiQ8ZGF5Pi0kMS0kPHllYXI+IikgaXMgIjIwLTEwLTE5MzAiCiBQQVNTICIxMC8yMC8x OTMwIi5yZXBsYWNlKC8oPzxtb250aD5cZHsyfSlcLyg/PGRheT5cZHsyfSlcLyg/PHllYXI+XGR7 NH0pLywgIiQ8ZGF5Pi0kPG1vbnRoPi0kMyIpIGlzICIyMC0xMC0xOTMwIgorUEFTUyAiUmVwbGFj ZSBqdXN0IFRISVMgaW4gdGhpcyBzdHJpbmciLnJlcGxhY2UoL1RISVMvLCAiJDxUSEFUPiIpIGlz ICJSZXBsYWNlIGp1c3QgJDxUSEFUPiBpbiB0aGlzIHN0cmluZyIKIFBBU1MgIkdpdmUgbWUgYSBc J2tcJyEiLm1hdGNoKC9HaXZlIG1lIGEgXCdca1wnLylbMF0gaXMgIkdpdmUgbWUgYSBcJ2tcJyIK IFBBU1MgIkdpdmUgbWUgXCdrMlwnISIubWF0Y2goL0dpdmUgbWUgXCdcazJcJy8pWzBdIGlzICJH aXZlIG1lIFwnazJcJyIKIFBBU1MgIkdpdmUgbWUgYSBcJ2thdFwnISIubWF0Y2goL0dpdmUgbWUg YSBcJ1xrYXRcJy8pWzBdIGlzICJHaXZlIG1lIGEgXCdrYXRcJyIKSW5kZXg6IExheW91dFRlc3Rz L2pzL3NjcmlwdC10ZXN0cy9yZWdleHAtbmFtZWQtY2FwdHVyZS1ncm91cHMuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3JlZ2V4cC1uYW1lZC1jYXB0dXJlLWdy b3Vwcy5qcwkocmV2aXNpb24gMjIxOTQxKQorKysgTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3Rz L3JlZ2V4cC1uYW1lZC1jYXB0dXJlLWdyb3Vwcy5qcwkod29ya2luZyBjb3B5KQpAQCAtNzcsNiAr NzcsOSBAQCBzaG91bGRCZSgnIjEwLzIwLzE5MzAiLnJlcGxhY2UoLyg/PG1vbnRoCiBzaG91bGRC ZSgnIjEwLzIwLzE5MzAiLnJlcGxhY2UoLyg/PG1vbnRoPlxcZHsyfSlcXFwvKD88ZGF5PlxcZHsy fSlcXFwvKD88eWVhcj5cXGR7NH0pLywgIiQ8ZGF5Pi0kMS0kPHllYXI+IiknLCAnIjIwLTEwLTE5 MzAiJyk7CiBzaG91bGRCZSgnIjEwLzIwLzE5MzAiLnJlcGxhY2UoLyg/PG1vbnRoPlxcZHsyfSlc XFwvKD88ZGF5PlxcZHsyfSlcXFwvKD88eWVhcj5cXGR7NH0pLywgIiQ8ZGF5Pi0kPG1vbnRoPi0k MyIpJywgJyIyMC0xMC0xOTMwIicpOwogCisvLyBWZXJpZnkgU3RyaW5nLnJlcGxhY2Ugd29ya3Mg Y29ycmVjdGx5IHdpdGhvdXQgbmFtZWQgY2FwdHVyZXMgaW4gdGhlIFJlZ0V4cAorc2hvdWxkQmUo JyJSZXBsYWNlIGp1c3QgVEhJUyBpbiB0aGlzIHN0cmluZyIucmVwbGFjZSgvVEhJUy8sICIkPFRI QVQ+IiknLCAnIlJlcGxhY2UganVzdCAkPFRIQVQ+IGluIHRoaXMgc3RyaW5nIicpOworCiAvLyBW ZXJpZnkgdGhhdCBuYW1lZCBiYWNrIHJlZmVyZW5jZXMgZm9yIG5vbi1leGlzdGluZyBuYW1lZCBn cm91cCBtYXRjaGVzIHRoZSBrPGdyb3VwTmFtZT4gZm9yIG5vbi11bmljb2RlIHBhdHRlcm5zLgog c2hvdWxkQmUoJyJHaXZlIG1lIGEgXFxcJ2tcXFwnISIubWF0Y2goL0dpdmUgbWUgYSBcXFwnXFxc a1xcXCcvKVswXScsICciR2l2ZSBtZSBhIFxcXCdrXFxcJyInKTsKIHNob3VsZEJlKCciR2l2ZSBt ZSBcXFwnazJcXFwnISIubWF0Y2goL0dpdmUgbWUgXFxcJ1xcXGsyXFxcJy8pWzBdJywgJyJHaXZl IG1lIFxcXCdrMlxcXCciJyk7Cg==