176675 2017-09-10 14:56:13 -0700 IntLiteral should prefer int32 during overload resolution 2018-10-13 16:52:49 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 176199 1 fpizlo fpizlo ggaren keith_miller mmaxfield saam webkit-bug-importer oldest_to_newest 1347291 0 fpizlo 2017-09-10 14:56:13 -0700 This should resolve unambiguously: int foo(int) uint foo(uint) foo(42) This should be an error: uint foo(uint) double foo(double) foo(42) 1347318 1 320407 fpizlo 2017-09-10 16:56:35 -0700 Created attachment 320407 the patch 1347406 2 320407 mmaxfield 2017-09-11 08:39:08 -0700 Comment on attachment 320407 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=320407&action=review > Tools/WebGPUShadingLanguageRI/Test.js:1439 > + int foo<T>(T) { return 1; } Why should this fail? I would expect T to become an int. 1347445 3 fpizlo 2017-09-11 10:09:21 -0700 (In reply to Myles C. Maxfield from comment #2) > Comment on attachment 320407 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320407&action=review > > > Tools/WebGPUShadingLanguageRI/Test.js:1439 > > + int foo<T>(T) { return 1; } > > Why should this fail? I would expect T to become an int. I think that's what we should eventually do. It would take some extra effort to implement this. Filed: https://bugs.webkit.org/show_bug.cgi?id=176707 1347451 4 fpizlo 2017-09-11 10:21:04 -0700 Landed in https://trac.webkit.org/changeset/221859/webkit 1347498 5 mmaxfield 2017-09-11 11:25:46 -0700 (In reply to Filip Pizlo from comment #3) > (In reply to Myles C. Maxfield from comment #2) > > Comment on attachment 320407 [details] > > the patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=320407&action=review > > > > > Tools/WebGPUShadingLanguageRI/Test.js:1439 > > > + int foo<T>(T) { return 1; } > > > > Why should this fail? I would expect T to become an int. > > I think that's what we should eventually do. It would take some extra > effort to implement this. > > Filed: https://bugs.webkit.org/show_bug.cgi?id=176707 If we expect that an idea language wouldn't work this way, we probably shouldn't have this as a test. 1347499 6 mmaxfield 2017-09-11 11:25:58 -0700 (In reply to Myles C. Maxfield from comment #5) > (In reply to Filip Pizlo from comment #3) > > (In reply to Myles C. Maxfield from comment #2) > > > Comment on attachment 320407 [details] > > > the patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=320407&action=review > > > > > > > Tools/WebGPUShadingLanguageRI/Test.js:1439 > > > > + int foo<T>(T) { return 1; } > > > > > > Why should this fail? I would expect T to become an int. > > > > I think that's what we should eventually do. It would take some extra > > effort to implement this. > > > > Filed: https://bugs.webkit.org/show_bug.cgi?id=176707 > > If we expect that an idea language wouldn't work this way, we probably > shouldn't have this as a test. **ideal language 1347506 7 fpizlo 2017-09-11 11:33:45 -0700 (In reply to Myles C. Maxfield from comment #6) > (In reply to Myles C. Maxfield from comment #5) > > (In reply to Filip Pizlo from comment #3) > > > (In reply to Myles C. Maxfield from comment #2) > > > > Comment on attachment 320407 [details] > > > > the patch > > > > > > > > View in context: > > > > https://bugs.webkit.org/attachment.cgi?id=320407&action=review > > > > > > > > > Tools/WebGPUShadingLanguageRI/Test.js:1439 > > > > > + int foo<T>(T) { return 1; } > > > > > > > > Why should this fail? I would expect T to become an int. > > > > > > I think that's what we should eventually do. It would take some extra > > > effort to implement this. > > > > > > Filed: https://bugs.webkit.org/show_bug.cgi?id=176707 > > > > If we expect that an idea language wouldn't work this way, we probably > > shouldn't have this as a test. > > **ideal language More tests are better. I think it's good practice to add tests for how you expect your code to behave right now, even if that means having to change the test later. That makes sense here, since the current behavior isn't really "wrong" (it doesn't render the type system unsound or anything like that) - it's just subject to change. 1353464 8 webkit-bug-importer 2017-09-27 12:33:01 -0700 <rdar://problem/34693466> 1468944 9 mmaxfield 2018-10-13 16:52:49 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/145 320407 2017-09-10 16:56:35 -0700 2017-09-11 08:39:08 -0700 the patch blah.patch text/plain 7823 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTg0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDM0IEBACisyMDE3LTA5LTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgSW50TGl0ZXJhbCBzaG91bGQgcHJlZmVyIGludDMyIGR1cmluZyBvdmVybG9hZCBy ZXNvbHV0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzY2NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAg CisgICAgICAgIFRoaXMgbWFrZXMgaW50TGl0ZXJhbFR5cGUgcHJlZmVyIHRvIHJlc29sdmUgdG8g aW50IG92ZXIgb3RoZXIgdHlwZXMuCisgICAgICAgIAorICAgICAgICBUaGlzIGFsc28gYWRkcyB0 ZXN0cyB0aGF0IGlmIHlvdSBwYXNzIGludExpdGVyYWwgdG8gVCwgdGhlbiB5b3UgY2FuIG1ha2Ug aXQgd29yayBieSBzYXlpbmcKKyAgICAgICAgaW50KGludExpdGVyYWwpLgorCisgICAgICAgICog V2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvSW50TGl0ZXJhbFR5cGUuanM6CisgICAgICAgIChJbnRM aXRlcmFsVHlwZSk6CisgICAgICAgIChJbnRMaXRlcmFsVHlwZS5wcm90b3R5cGUuY29udmVyc2lv bkNvc3QpOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL05vZGUuanM6CisgICAg ICAgIChOb2RlLnByb3RvdHlwZS5jb252ZXJzaW9uQ29zdCk6CisgICAgICAgICogV2ViR1BVU2hh ZGluZ0xhbmd1YWdlUkkvUmVzb2x2ZU92ZXJsb2FkSW1wbC5qczoKKyAgICAgICAgKHJlc29sdmVP dmVybG9hZEltcGwpOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jld3JpdGVy LmpzOgorICAgICAgICAoUmV3cml0ZXIucHJvdG90eXBlLnZpc2l0SW50TGl0ZXJhbFR5cGUpOgor ICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanM6CisgICAgICAgIChURVNU X2ludE92ZXJsb2FkUmVzb2x1dGlvbik6CisgICAgICAgIChURVNUX2ludE92ZXJsb2FkUmVzb2x1 dGlvblJldmVyc2VPcmRlcik6CisgICAgICAgIChURVNUX2ludE92ZXJsb2FkUmVzb2x1dGlvbkdl bmVyaWMpOgorICAgICAgICAoVEVTVF9pbnRMaXRlcmFsR2VuZXJpYyk6CisgICAgICAgICogV2Vi R1BVU2hhZGluZ0xhbmd1YWdlUkkvVW5pZmljYXRpb25Db250ZXh0LmpzOgorICAgICAgICAoVW5p ZmljYXRpb25Db250ZXh0LnByb3RvdHlwZS5nZXQgY29udmVyc2lvbkNvc3QpOgorICAgICAgICAq IFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Zpc2l0b3IuanM6CisgICAgICAgIChWaXNpdG9yLnBy b3RvdHlwZS52aXNpdEludExpdGVyYWxUeXBlKToKKwogMjAxNy0wOS0wNyAgRmlsaXAgUGl6bG8g IDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFdTTCBvdmVybG9hZCByZXNvbHV0aW9uIHNo b3VsZCBub3QgYmUgY2FzY2FkaW5nCkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VS SS9JbnRMaXRlcmFsVHlwZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJHUFVTaGFkaW5nTGFu Z3VhZ2VSSS9JbnRMaXRlcmFsVHlwZS5qcwkocmV2aXNpb24gMjIxODM5KQorKysgVG9vbHMvV2Vi R1BVU2hhZGluZ0xhbmd1YWdlUkkvSW50TGl0ZXJhbFR5cGUuanMJKHdvcmtpbmcgY29weSkKQEAg LTMwLDYgKzMwLDcgQEAgY2xhc3MgSW50TGl0ZXJhbFR5cGUgZXh0ZW5kcyBUeXBlIHsKICAgICAg ICAgc3VwZXIoKTsKICAgICAgICAgdGhpcy5fb3JpZ2luID0gb3JpZ2luOwogICAgICAgICB0aGlz Ll92YWx1ZSA9IHZhbHVlOworICAgICAgICB0aGlzLmludFR5cGUgPSBuZXcgVHlwZVJlZihvcmln aW4sICJpbnQiLCBbXSk7CiAgICAgfQogICAgIAogICAgIGdldCBvcmlnaW4oKSB7IHJldHVybiB0 aGlzLl9vcmlnaW47IH0KQEAgLTYyLDYgKzYzLDE0IEBAIGNsYXNzIEludExpdGVyYWxUeXBlIGV4 dGVuZHMgVHlwZSB7CiAgICAgICAgIHRocm93IG5ldyBFcnJvcigiSW50TGl0ZXJhbFR5cGUgc2hv dWxkIG5ldmVyIGJlIHVzZWQgYXMgYSB0eXBlIHBhcmFtZXRlciIpOwogICAgIH0KICAgICAKKyAg ICBjb252ZXJzaW9uQ29zdCh1bmlmaWNhdGlvbkNvbnRleHQpCisgICAgeworICAgICAgICBsZXQg cmVhbFRoaXMgPSB1bmlmaWNhdGlvbkNvbnRleHQuZmluZCh0aGlzKTsKKyAgICAgICAgaWYgKHJl YWxUaGlzLmVxdWFscyh0aGlzLmludFR5cGUpKQorICAgICAgICAgICAgcmV0dXJuIDA7CisgICAg ICAgIHJldHVybiAxOworICAgIH0KKyAgICAKICAgICBjb21taXRVbmlmaWNhdGlvbih1bmlmaWNh dGlvbkNvbnRleHQpCiAgICAgewogICAgICAgICB0aGlzLnR5cGUgPSB1bmlmaWNhdGlvbkNvbnRl eHQuZmluZCh0aGlzKTsKSW5kZXg6IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL05vZGUu anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvTm9kZS5qcwko cmV2aXNpb24gMjIxODM5KQorKysgVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvTm9kZS5q cwkod29ya2luZyBjb3B5KQpAQCAtNzksNiArNzksOCBAQCBjbGFzcyBOb2RlIHsKICAgICAKICAg ICBnZXQgaXNOYXRpdmUoKSB7IHJldHVybiBmYWxzZTsgfQogICAgIAorICAgIGNvbnZlcnNpb25D b3N0KHVuaWZpY2F0aW9uQ29udGV4dCkgeyByZXR1cm4gMDsgfQorICAgIAogICAgIGVxdWFscyhv dGhlcikKICAgICB7CiAgICAgICAgIGxldCB1bmlmaWNhdGlvbkNvbnRleHQgPSBuZXcgVW5pZmlj YXRpb25Db250ZXh0KCk7CkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9SZXNv bHZlT3ZlcmxvYWRJbXBsLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5n dWFnZVJJL1Jlc29sdmVPdmVybG9hZEltcGwuanMJKHJldmlzaW9uIDIyMTgzOSkKKysrIFRvb2xz L1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jlc29sdmVPdmVybG9hZEltcGwuanMJKHdvcmtpbmcg Y29weSkKQEAgLTM5LDE4ICszOSwxOSBAQCBmdW5jdGlvbiByZXNvbHZlT3ZlcmxvYWRJbXBsKGZ1 bmN0aW9ucywgCiAgICAgaWYgKCFzdWNjZXNzZXMubGVuZ3RoKQogICAgICAgICByZXR1cm4ge2Zh aWx1cmVzOiBmYWlsdXJlc307CiAgICAgCisgICAgbGV0IG1pbmltdW1Db252ZXJzaW9uQ29zdCA9 IHN1Y2Nlc3Nlcy5yZWR1Y2UoCisgICAgICAgIChyZXN1bHQsIG92ZXJsb2FkKSA9PiBNYXRoLm1p bihyZXN1bHQsIG92ZXJsb2FkLnVuaWZpY2F0aW9uQ29udGV4dC5jb252ZXJzaW9uQ29zdCksCisg ICAgICAgIEluZmluaXR5KTsKKyAgICBzdWNjZXNzZXMgPSBzdWNjZXNzZXMuZmlsdGVyKAorICAg ICAgICBvdmVybG9hZCA9PiBvdmVybG9hZC51bmlmaWNhdGlvbkNvbnRleHQuY29udmVyc2lvbkNv c3QgPT0gbWluaW11bUNvbnZlcnNpb25Db3N0KTsKKyAgICAKICAgICAvLyBJZiBhbnkgb2YgdGhl IHNpZ25hdHVyZXMgYXJlIHJlc3RyaWN0ZWQgdGhlbiB3ZSBjb25zaWRlciB0aG9zZSBmaXJzdC4g VGhpcyBpcyBhbiBlc2NhcGUgbWVjaGFuaXNtIGZvcgogICAgIC8vIGJ1aWx0LWluIHRoaW5ncy4K ICAgICAvLyBGSVhNRTogSXQgc2hvdWxkIGJlIGFuIGVycm9yIHRvIGRlY2xhcmUgYSBmdW5jdGlv biB0aGF0IGlzIGF0IGxlYXN0IGFzIHNwZWNpZmljIGFzIGEgcmVzdHJpY3RlZCBmdW5jdGlvbi4K ICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NTgwCi0g ICAgbGV0IGhhc1Jlc3RyaWN0ZWQgPSBmYWxzZTsKLSAgICBmb3IgKGxldCBvdmVybG9hZCBvZiBz dWNjZXNzZXMpIHsKLSAgICAgICAgaWYgKG92ZXJsb2FkLmZ1bmMuaXNSZXN0cmljdGVkKSB7Ci0g ICAgICAgICAgICBoYXNSZXN0cmljdGVkID0gdHJ1ZTsKLSAgICAgICAgICAgIGJyZWFrOwotICAg ICAgICB9Ci0gICAgfQotICAgIAorICAgIGxldCBoYXNSZXN0cmljdGVkID0gc3VjY2Vzc2VzLnJl ZHVjZSgKKyAgICAgICAgKHJlc3VsdCwgb3ZlcmxvYWQpID0+IHJlc3VsdCB8fCBvdmVybG9hZC5m dW5jLmlzUmVzdHJpY3RlZCwKKyAgICAgICAgZmFsc2UpOwogICAgIGlmIChoYXNSZXN0cmljdGVk KQogICAgICAgICBzdWNjZXNzZXMgPSBzdWNjZXNzZXMuZmlsdGVyKG92ZXJsb2FkID0+IG92ZXJs b2FkLmZ1bmMuaXNSZXN0cmljdGVkKTsKICAgICAKSW5kZXg6IFRvb2xzL1dlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL1Jld3JpdGVyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL1Jld3JpdGVyLmpzCShyZXZpc2lvbiAyMjE4MzkpCisrKyBUb29scy9XZWJHUFVT aGFkaW5nTGFuZ3VhZ2VSSS9SZXdyaXRlci5qcwkod29ya2luZyBjb3B5KQpAQCAtMjExLDYgKzIx MSw3IEBAIGNsYXNzIFJld3JpdGVyIGV4dGVuZHMgVmlzaXRvckJhc2UgewogICAgIHsKICAgICAg ICAgbGV0IHJlc3VsdCA9IG5ldyBJbnRMaXRlcmFsVHlwZShub2RlLm9yaWdpbiwgbm9kZS52YWx1 ZSk7CiAgICAgICAgIHJlc3VsdC50eXBlID0gbm9kZS50eXBlID8gbm9kZS50eXBlLnZpc2l0KHRo aXMpIDogbnVsbDsKKyAgICAgICAgcmVzdWx0LmludFR5cGUgPSBub2RlLmludFR5cGUudmlzaXQo dGhpcyk7CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogCkluZGV4OiBUb29scy9XZWJH UFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNo YWRpbmdMYW5ndWFnZVJJL1Rlc3QuanMJKHJldmlzaW9uIDIyMTgzOSkKKysrIFRvb2xzL1dlYkdQ VVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTE0MDAsNiArMTQw MCw1NyBAQCBmdW5jdGlvbiBURVNUX2FtYmlndW91c092ZXJsb2FkVGllQnJlYWsoCiAgICAgYCk7 CiB9CiAKK2Z1bmN0aW9uIFRFU1RfaW50T3ZlcmxvYWRSZXNvbHV0aW9uKCkKK3sKKyAgICBsZXQg cHJvZ3JhbSA9IGRvUHJlcChgCisgICAgICAgIGludCBmb28oaW50KSB7IHJldHVybiAxOyB9Cisg ICAgICAgIGludCBmb28odWludCkgeyByZXR1cm4gMjsgfQorICAgICAgICBpbnQgZm9vKGRvdWJs ZSkgeyByZXR1cm4gMzsgfQorICAgICAgICBpbnQgYmFyKCkgeyByZXR1cm4gZm9vKDQyKTsgfQor ICAgIGApOworICAgIGNoZWNrSW50KHByb2dyYW0sIGNhbGxGdW5jdGlvbihwcm9ncmFtLCAiYmFy IiwgW10sIFtdKSwgMSk7Cit9CisKK2Z1bmN0aW9uIFRFU1RfaW50T3ZlcmxvYWRSZXNvbHV0aW9u UmV2ZXJzZU9yZGVyKCkKK3sKKyAgICBsZXQgcHJvZ3JhbSA9IGRvUHJlcChgCisgICAgICAgIGlu dCBmb28oZG91YmxlKSB7IHJldHVybiAzOyB9CisgICAgICAgIGludCBmb28odWludCkgeyByZXR1 cm4gMjsgfQorICAgICAgICBpbnQgZm9vKGludCkgeyByZXR1cm4gMTsgfQorICAgICAgICBpbnQg YmFyKCkgeyByZXR1cm4gZm9vKDQyKTsgfQorICAgIGApOworICAgIGNoZWNrSW50KHByb2dyYW0s IGNhbGxGdW5jdGlvbihwcm9ncmFtLCAiYmFyIiwgW10sIFtdKSwgMSk7Cit9CisKK2Z1bmN0aW9u IFRFU1RfaW50T3ZlcmxvYWRSZXNvbHV0aW9uR2VuZXJpYygpCit7CisgICAgbGV0IHByb2dyYW0g PSBkb1ByZXAoYAorICAgICAgICBpbnQgZm9vKGludCkgeyByZXR1cm4gMTsgfQorICAgICAgICBp bnQgZm9vPFQ+KFQpIHsgcmV0dXJuIDI7IH0KKyAgICAgICAgaW50IGJhcigpIHsgcmV0dXJuIGZv byg0Mik7IH0KKyAgICBgKTsKKyAgICBjaGVja0ludChwcm9ncmFtLCBjYWxsRnVuY3Rpb24ocHJv Z3JhbSwgImJhciIsIFtdLCBbXSksIDEpOworfQorCitmdW5jdGlvbiBURVNUX2ludExpdGVyYWxH ZW5lcmljKCkKK3sKKyAgICBjaGVja0ZhaWwoCisgICAgICAgICgpID0+IGRvUHJlcChgCisgICAg ICAgICAgICBpbnQgZm9vPFQ+KFQpIHsgcmV0dXJuIDE7IH0KKyAgICAgICAgICAgIGludCBiYXIo KSB7IHJldHVybiBmb28oNDIpOyB9CisgICAgICAgIGApLAorICAgICAgICAoZSkgPT4gZSBpbnN0 YW5jZW9mIFdUeXBlRXJyb3IpOworfQorCitmdW5jdGlvbiBURVNUX2ludExpdGVyYWxHZW5lcmlj KCkKK3sKKyAgICBsZXQgcHJvZ3JhbSA9IGRvUHJlcChgCisgICAgICAgIFQgZm9vPFQ+KFQgeCkg eyByZXR1cm4geDsgfQorICAgICAgICBpbnQgYmFyKCkgeyByZXR1cm4gZm9vKGludCg0MikpOyB9 CisgICAgYCk7CisgICAgY2hlY2tJbnQocHJvZ3JhbSwgY2FsbEZ1bmN0aW9uKHByb2dyYW0sICJi YXIiLCBbXSwgW10pLCA0Mik7Cit9CisKIGxldCBmaWx0ZXIgPSAvLiovOyAvLyBydW4gZXZlcnl0 aGluZyBieSBkZWZhdWx0CiBpZiAodGhpc1siYXJndW1lbnRzIl0pIHsKICAgICBmb3IgKGxldCBp ID0gMDsgaSA8IGFyZ3VtZW50cy5sZW5ndGg7IGkrKykgewpJbmRleDogVG9vbHMvV2ViR1BVU2hh ZGluZ0xhbmd1YWdlUkkvVW5pZmljYXRpb25Db250ZXh0LmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1VuaWZpY2F0aW9uQ29udGV4dC5qcwkocmV2aXNpb24g MjIxODM5KQorKysgVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvVW5pZmljYXRpb25Db250 ZXh0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYsNiArMTA2LDE0IEBAIGNsYXNzIFVuaWZpY2F0 aW9uQ29udGV4dCB7CiAgICAgICAgIHJldHVybiBhcmd1bWVudFNldC5zaXplID09IG51bVR5cGVW YXJpYWJsZUFyZ3VtZW50czsKICAgICB9CiAgICAgCisgICAgZ2V0IGNvbnZlcnNpb25Db3N0KCkK KyAgICB7CisgICAgICAgIGxldCByZXN1bHQgPSAwOworICAgICAgICBmb3IgKGxldCB0eXBlQXJn dW1lbnQgb2YgdGhpcy50eXBlQXJndW1lbnRzKCkpCisgICAgICAgICAgICByZXN1bHQgKz0gdHlw ZUFyZ3VtZW50LmNvbnZlcnNpb25Db3N0KHRoaXMpOworICAgICAgICByZXR1cm4gcmVzdWx0Owor ICAgIH0KKyAgICAKICAgICBjb21taXQoKQogICAgIHsKICAgICAgICAgZm9yIChsZXQgdHlwZUFy Z3VtZW50IG9mIHRoaXMudHlwZUFyZ3VtZW50cygpKQpJbmRleDogVG9vbHMvV2ViR1BVU2hhZGlu Z0xhbmd1YWdlUkkvVmlzaXRvci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJHUFVTaGFkaW5n TGFuZ3VhZ2VSSS9WaXNpdG9yLmpzCShyZXZpc2lvbiAyMjE4MzkpCisrKyBUb29scy9XZWJHUFVT aGFkaW5nTGFuZ3VhZ2VSSS9WaXNpdG9yLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yMzEsNiArMjMx LDcgQEAgY2xhc3MgVmlzaXRvciBleHRlbmRzIFZpc2l0b3JCYXNlIHsKICAgICB7CiAgICAgICAg IGlmIChub2RlLnR5cGUpCiAgICAgICAgICAgICBub2RlLnR5cGUudmlzaXQodGhpcyk7CisgICAg ICAgIG5vZGUuaW50VHlwZS52aXNpdCh0aGlzKTsKICAgICB9CiAgICAgCiAgICAgdmlzaXRVaW50 TGl0ZXJhbChub2RlKQo=