176591 2017-09-08 06:13:11 -0700 Make RenderLayerCompositor always use isRootLayer() 2017-09-27 12:34:02 -0700 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 176261 176684 1 fred.wang fred.wang darin simon.fraser webkit-bug-importer oldest_to_newest 1346774 0 fred.wang 2017-09-08 06:13:11 -0700 Sometimes, RenderLayerCompositor performs the verification &layer == m_renderView.layer() which could be replaced with the more readable isRootLayer() for consistency with the rest of the file. 1346776 1 320258 fred.wang 2017-09-08 06:23:32 -0700 Created attachment 320258 Patch 1346783 2 320260 fred.wang 2017-09-08 07:27:07 -0700 Created attachment 320260 Patch 1346795 3 fred.wang 2017-09-08 08:10:18 -0700 Some part is extracted from Simon's patch for bug 176261 1346855 4 320260 simon.fraser 2017-09-08 10:30:43 -0700 Comment on attachment 320260 Patch I would like to rename isRootLayer() to isRenderViewLayer() at the same time. 1347298 5 darin 2017-09-10 15:17:44 -0700 (In reply to Simon Fraser (smfr) from comment #4) > I would like to rename isRootLayer() to isRenderViewLayer() Good idea. > at the same time. Seems unnecessary to time it that way. Much bigger than this patch. Should do with do-webcore-rename! 1347352 6 fred.wang 2017-09-10 22:50:28 -0700 Committed r221845: <http://trac.webkit.org/changeset/221845> 1353481 7 webkit-bug-importer 2017-09-27 12:34:02 -0700 <rdar://problem/34693498> 320258 2017-09-08 06:23:32 -0700 2017-09-08 07:27:04 -0700 Patch bug-176591-20170908152330.patch text/plain 2841 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IxMWM3YjgxZDcwMWU2 YWZiMmViOTQ4ZWY0NTZkMzhkNDA2NmZlOC4uZWRhNzBkN2RiMTY5OWRhOTA5N2IxMWNlM2Y5Zjcz NjYwODVmODM2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA5LTA4ICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbWw+CisKKyAgICAgICAgTWFrZSBSZW5kZXJMYXll ckNvbXBvc2l0b3IgYWx3YXlzIHVzZSBpc1Jvb3RMYXllcigpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY1OTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJMYXllckNvbXBvc2l0b3IgY29udGFp bnMgYSBmZXcgY29tcGFyaXNvbnMgb2YgdGhlIGZvcm0gJmxheWVyID09IG1fcmVuZGVyVmlldy5s YXllcigpLgorICAgICAgICBUaGlzIHBhdGNoIHJlcGxhY2VzIHRoZW0gd2l0aCAibGF5ZXIuaXNS b290TGF5ZXIoKSIgd2hpY2ggc2ltcGx5IHZlcmlmaWVzIHRoYXQgImxheWVyIiBpcworICAgICAg ICBhc3NvY2lhdGVkIHRvIHRoZSBvbmUgKGFuZCBvbmx5IG9uZSkgUmVuZGVyVmlldyBvZiB0aGUg UmVuZGVyTGF5ZXJDb21wb3NpdG9yLiBJdCBtYWtlcyB0aGluZ3MKKyAgICAgICAgbW9yZSByZWFk YWJsZSBhbmQgbW9yZSBjb25zaXN0ZW50IHdpdGggdGhlIHJlc3Qgb2YgdGhlIGZpbGUuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBiZWhhdmlvciB1bmNoYW5nZWQuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckxheWVyQ29tcG9zaXRvcjo6cmVwYWludEluQ29tcG9zaXRlZEFuY2VzdG9yKToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6bmVlZHNGaXhlZFJvb3RCYWNrZ3JvdW5k TGF5ZXIgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1 cGRhdGVTY3JvbGxDb29yZGluYXRlZExheWVyKToKKwogMjAxNy0wOS0wNyAgQW5keSBFc3RlcyAg PGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gVXBzdHJlYW0gUVRLaXQtcmVsYXRl ZCBXZWJLaXRTeXN0ZW1JbnRlcmZhY2UgZnVuY3Rpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDdlZWIwNzA2MDIxMmFi ZWVhNmU2MTZkOTJmMDIxZWU1OTk0NzY1MmQuLmQ0NjY2YmE1ZWRhNzNiNWE0YmFkMmNkNTY3NWIx ZDgwODdiNGRmY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwCkBAIC0xMTUyLDcgKzExNTIsNyBAQCB2b2lkIFJlbmRlckxheWVy Q29tcG9zaXRvcjo6cmVwYWludEluQ29tcG9zaXRlZEFuY2VzdG9yKFJlbmRlckxheWVyJiBsYXll ciwgY29ucwogCiAgICAgLy8gVGhlIGNvbnRlbnRzIG9mIHRoaXMgbGF5ZXIgbWF5IGJlIG1vdmlu ZyBmcm9tIGEgR3JhcGhpY3NMYXllciB0byB0aGUgd2luZG93LAogICAgIC8vIHNvIHdlIG5lZWQg dG8gbWFrZSBzdXJlIHRoZSB3aW5kb3cgc3lzdGVtIHN5bmNocm9uaXplcyB0aG9zZSBjaGFuZ2Vz IG9uIHRoZSBzY3JlZW4uCi0gICAgaWYgKGNvbXBvc2l0ZWRBbmNlc3RvciA9PSBtX3JlbmRlclZp ZXcubGF5ZXIoKSkKKyAgICBpZiAoY29tcG9zaXRlZEFuY2VzdG9yLT5pc1Jvb3RMYXllcigpKQog ICAgICAgICBtX3JlbmRlclZpZXcuZnJhbWVWaWV3KCkuc2V0TmVlZHNPbmVTaG90RHJhd2luZ1N5 bmNocm9uaXphdGlvbigpOwogfQogCkBAIC0yOTIxLDcgKzI5MjEsNyBAQCBib29sIFJlbmRlckxh eWVyQ29tcG9zaXRvcjo6c3VwcG9ydHNGaXhlZFJvb3RCYWNrZ3JvdW5kQ29tcG9zaXRpbmcoKSBj b25zdAogCiBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6bmVlZHNGaXhlZFJvb3RCYWNrZ3Jv dW5kTGF5ZXIoY29uc3QgUmVuZGVyTGF5ZXImIGxheWVyKSBjb25zdAogewotICAgIGlmICgmbGF5 ZXIgIT0gbV9yZW5kZXJWaWV3LmxheWVyKCkpCisgICAgaWYgKCFsYXllci5pc1Jvb3RMYXllcigp KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAobV9yZW5kZXJWaWV3LnNldHRpbmdz KCkuZml4ZWRCYWNrZ3JvdW5kc1BhaW50UmVsYXRpdmVUb0RvY3VtZW50KCkpCkBAIC0zODkyLDcg KzM4OTIsNyBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlU2Nyb2xsQ29vcmRp bmF0ZWRMYXllcihSZW5kZXJMYXllciYgbGF5ZXIsIExheQogICAgIGlmICghc2Nyb2xsaW5nQ29v cmRpbmF0b3IgfHwgIXNjcm9sbGluZ0Nvb3JkaW5hdG9yLT5jb29yZGluYXRlc1Njcm9sbGluZ0Zv ckZyYW1lVmlldyhtX3JlbmRlclZpZXcuZnJhbWVWaWV3KCkpKQogICAgICAgICByZXR1cm47CiAK LSAgICBib29sIGlzUm9vdExheWVyID0gJmxheWVyID09IG1fcmVuZGVyVmlldy5sYXllcigpOwor ICAgIGJvb2wgaXNSb290TGF5ZXIgPSBsYXllci5pc1Jvb3RMYXllcigpOwogCiAgICAgaWYgKCFs YXllci5wYXJlbnQoKSAmJiAhaXNSb290TGF5ZXIpCiAgICAgICAgIHJldHVybjsK 320260 2017-09-08 07:27:07 -0700 2017-09-10 15:16:47 -0700 Patch bug-176591-20170908162706.patch text/plain 3615 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IwOTU4MmRjOGY1Yzcx OGExZWU2ODA4MDhhMDYwMzY2MzdkODFhZi4uZjYxOTI5YTc5YjE2NDNhYjZkZDE1ZDI2OTFkYjA2 MTgyYjI4ODU3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA5LTA4ICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbWw+CisKKyAgICAgICAgTWFrZSBSZW5kZXJMYXll ckNvbXBvc2l0b3IgYWx3YXlzIHVzZSBpc1Jvb3RMYXllcigpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY1OTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJMYXllckNvbXBvc2l0b3IgY29udGFp bnMgYSBmZXcgY29tcGFyaXNvbnMgb2YgdGhlIGZvcm0gJmxheWVyID09IG1fcmVuZGVyVmlldy5s YXllcigpLgorICAgICAgICBUaGlzIHBhdGNoIHJlcGxhY2VzIHRoZW0gd2l0aCAibGF5ZXIuaXNS b290TGF5ZXIoKSIgd2hpY2ggc2ltcGx5IHZlcmlmaWVzIHRoYXQgImxheWVyIiBpcworICAgICAg ICBhc3NvY2lhdGVkIHRvIHRoZSBvbmUgKGFuZCBvbmx5IG9uZSkgUmVuZGVyVmlldyBvZiB0aGUg UmVuZGVyTGF5ZXJDb21wb3NpdG9yLiBJdCBtYWtlcyB0aGluZ3MKKyAgICAgICAgbW9yZSByZWFk YWJsZSBhbmQgbW9yZSBjb25zaXN0ZW50IHdpdGggdGhlIHJlc3Qgb2YgdGhlIGZpbGUuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBiZWhhdmlvciB1bmNoYW5nZWQuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckxheWVyQ29tcG9zaXRvcjo6cmVwYWludEluQ29tcG9zaXRlZEFuY2VzdG9yKToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6bmVlZHNGaXhlZFJvb3RCYWNrZ3JvdW5k TGF5ZXIgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1 cGRhdGVTY3JvbGxDb29yZGluYXRlZExheWVyKToKKwogMjAxNy0wOS0wOCAgWmFuIERvYmVyc2Vr ICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gaW5pdGlhbGl6 YXRpb25EYXRhRW5jb3VudGVyZWQoKSBkaXNwYXRjaCBjYW4gb3V0bGl2ZSBNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXJCYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDdlZWIwNzA2MDIxMmFiZWVhNmU2MTZkOTJmMDIx ZWU1OTk0NzY1MmQuLjU2MzgxMmQ1Mjc2MTUyNmM0MDVhMjJhYzgwMGFhZWVmY2I5Mjk3ZjcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwCkBAIC0xMTQzLDE2ICsxMTQzLDE3IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpy ZXBhaW50T25Db21wb3NpdGluZ0NoYW5nZShSZW5kZXJMYXllciYgbGF5ZXIpCiB2b2lkIFJlbmRl ckxheWVyQ29tcG9zaXRvcjo6cmVwYWludEluQ29tcG9zaXRlZEFuY2VzdG9yKFJlbmRlckxheWVy JiBsYXllciwgY29uc3QgTGF5b3V0UmVjdCYgcmVjdCkKIHsKICAgICBSZW5kZXJMYXllciogY29t cG9zaXRlZEFuY2VzdG9yID0gbGF5ZXIuZW5jbG9zaW5nQ29tcG9zaXRpbmdMYXllckZvclJlcGFp bnQoRXhjbHVkZVNlbGYpOwotICAgIGlmIChjb21wb3NpdGVkQW5jZXN0b3IpIHsKLSAgICAgICAg QVNTRVJUKGNvbXBvc2l0ZWRBbmNlc3Rvci0+YmFja2luZygpKTsKLSAgICAgICAgTGF5b3V0UmVj dCByZXBhaW50UmVjdCA9IHJlY3Q7Ci0gICAgICAgIHJlcGFpbnRSZWN0Lm1vdmUobGF5ZXIub2Zm c2V0RnJvbUFuY2VzdG9yKGNvbXBvc2l0ZWRBbmNlc3RvcikpOwotICAgICAgICBjb21wb3NpdGVk QW5jZXN0b3ItPnNldEJhY2tpbmdOZWVkc1JlcGFpbnRJblJlY3QocmVwYWludFJlY3QpOwotICAg IH0KKyAgICBpZiAoIWNvbXBvc2l0ZWRBbmNlc3RvcikKKyAgICAgICAgcmV0dXJuOworCisgICAg QVNTRVJUKGNvbXBvc2l0ZWRBbmNlc3Rvci0+YmFja2luZygpKTsKKyAgICBMYXlvdXRSZWN0IHJl cGFpbnRSZWN0ID0gcmVjdDsKKyAgICByZXBhaW50UmVjdC5tb3ZlKGxheWVyLm9mZnNldEZyb21B bmNlc3Rvcihjb21wb3NpdGVkQW5jZXN0b3IpKTsKKyAgICBjb21wb3NpdGVkQW5jZXN0b3ItPnNl dEJhY2tpbmdOZWVkc1JlcGFpbnRJblJlY3QocmVwYWludFJlY3QpOwogCiAgICAgLy8gVGhlIGNv bnRlbnRzIG9mIHRoaXMgbGF5ZXIgbWF5IGJlIG1vdmluZyBmcm9tIGEgR3JhcGhpY3NMYXllciB0 byB0aGUgd2luZG93LAogICAgIC8vIHNvIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoZSB3aW5kb3cg c3lzdGVtIHN5bmNocm9uaXplcyB0aG9zZSBjaGFuZ2VzIG9uIHRoZSBzY3JlZW4uCi0gICAgaWYg KGNvbXBvc2l0ZWRBbmNlc3RvciA9PSBtX3JlbmRlclZpZXcubGF5ZXIoKSkKKyAgICBpZiAoY29t cG9zaXRlZEFuY2VzdG9yLT5pc1Jvb3RMYXllcigpKQogICAgICAgICBtX3JlbmRlclZpZXcuZnJh bWVWaWV3KCkuc2V0TmVlZHNPbmVTaG90RHJhd2luZ1N5bmNocm9uaXphdGlvbigpOwogfQogCkBA IC0yOTIxLDcgKzI5MjIsNyBAQCBib29sIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6c3VwcG9ydHNG aXhlZFJvb3RCYWNrZ3JvdW5kQ29tcG9zaXRpbmcoKSBjb25zdAogCiBib29sIFJlbmRlckxheWVy Q29tcG9zaXRvcjo6bmVlZHNGaXhlZFJvb3RCYWNrZ3JvdW5kTGF5ZXIoY29uc3QgUmVuZGVyTGF5 ZXImIGxheWVyKSBjb25zdAogewotICAgIGlmICgmbGF5ZXIgIT0gbV9yZW5kZXJWaWV3LmxheWVy KCkpCisgICAgaWYgKCFsYXllci5pc1Jvb3RMYXllcigpKQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAKICAgICBpZiAobV9yZW5kZXJWaWV3LnNldHRpbmdzKCkuZml4ZWRCYWNrZ3JvdW5kc1BhaW50 UmVsYXRpdmVUb0RvY3VtZW50KCkpCkBAIC0zODkyLDcgKzM4OTMsNyBAQCB2b2lkIFJlbmRlckxh eWVyQ29tcG9zaXRvcjo6dXBkYXRlU2Nyb2xsQ29vcmRpbmF0ZWRMYXllcihSZW5kZXJMYXllciYg bGF5ZXIsIExheQogICAgIGlmICghc2Nyb2xsaW5nQ29vcmRpbmF0b3IgfHwgIXNjcm9sbGluZ0Nv b3JkaW5hdG9yLT5jb29yZGluYXRlc1Njcm9sbGluZ0ZvckZyYW1lVmlldyhtX3JlbmRlclZpZXcu ZnJhbWVWaWV3KCkpKQogICAgICAgICByZXR1cm47CiAKLSAgICBib29sIGlzUm9vdExheWVyID0g JmxheWVyID09IG1fcmVuZGVyVmlldy5sYXllcigpOworICAgIGJvb2wgaXNSb290TGF5ZXIgPSBs YXllci5pc1Jvb3RMYXllcigpOwogCiAgICAgaWYgKCFsYXllci5wYXJlbnQoKSAmJiAhaXNSb290 TGF5ZXIpCiAgICAgICAgIHJldHVybjsK