176440 2017-09-05 22:23:08 -0700 WSL: Inliner doesn't allow double-negation 2018-10-13 16:58:06 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 176199 1 mmaxfield fpizlo fpizlo mmaxfield webkit-bug-importer oldest_to_newest 1345812 0 mmaxfield 2017-09-05 22:23:08 -0700 doPrep() fails with "bool foo(bool x) { return !!x; }" 1346021 1 320043 fpizlo 2017-09-06 11:34:47 -0700 Created attachment 320043 the patch 1346028 2 320043 mmaxfield 2017-09-06 11:53:06 -0700 Comment on attachment 320043 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=320043&action=review > Tools/WebGPUShadingLanguageRI/Parse.js:-649 > - result.origin = operatorToken.origin; Thanks > Tools/WebGPUShadingLanguageRI/VisitingSet.js:36 > + print("item: " + item + " (" + item.constructor.name + ")"); Print 1346058 3 fpizlo 2017-09-06 13:04:17 -0700 Landed in https://trac.webkit.org/changeset/221692/webkit 1353502 4 webkit-bug-importer 2017-09-27 12:35:16 -0700 <rdar://problem/34693538> 1468949 5 mmaxfield 2018-10-13 16:58:06 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/150 320043 2017-09-06 11:34:47 -0700 2017-09-06 11:53:06 -0700 the patch blah.patch text/plain 6966 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTY4NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMxIEBACisyMDE3LTA5LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgV1NMOiBJbmxpbmVyIGRvZXNuJ3QgYWxsb3cgZG91YmxlLW5lZ2F0aW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY0NDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBw cm9ibGVtIHdhcyB0aGF0IHdlIHdlcmUgdmlzaXRpbmcgdGhlIG9wZXJhbmRzIHRvIGNhbGxzIHdo aWxlIGluc2lkZSBkb1Zpc2l0LiBUaGlzIGlzIHRvbyBzdHJpY3QKKyAgICAgICAgc2luY2UgaXQg cmVqZWN0cyBuZXN0ZWQgY2FsbHMgbGlrZSBmb28oZm9vKHgpKS4gVGhlIHNvbHV0aW9uIGlzIHRv IHZpc2l0IHRoZSBvcGVyYW5kcyB0byBjYWxscyBiZWZvcmUKKyAgICAgICAgZW50ZXJpbmcgZG9W aXNpdC4KKyAgICAgICAgCisgICAgICAgIFRoaXMgYWxzbyBmaXhlcyBzb21lIG90aGVyIGlzc3Vl cyBpbiB0aGUgcGFyc2VyIHRoYXQgbWFkZSB0aGUgSW5saW5lcidzIGVycm9yIHJlYWxseSBzdHJh bmdlLgorCisgICAgICAgICogV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvRnVuYy5qczoKKyAgICAg ICAgKEZ1bmMpOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0lubGluZXIuanM6 CisgICAgICAgIChJbmxpbmVyLnByb3RvdHlwZS52aXNpdENhbGxFeHByZXNzaW9uKToKKyAgICAg ICAgKElubGluZXIpOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1BhcnNlLmpz OgorICAgICAgICAocGFyc2VPcGVyYXRvckZ1bmNEZWZWYWx1ZXMpOgorICAgICAgICAocGFyc2VO b25PcGVyYXRvckZ1bmNEZWZWYWx1ZXMpOgorICAgICAgICAocGFyc2VHZW5lcmljRnVuY0RlZlZh bHVlcyk6CisgICAgICAgIChwYXJzZUZ1bmNEZWNsKToKKyAgICAgICAgKiBXZWJHUFVTaGFkaW5n TGFuZ3VhZ2VSSS9UZXN0LmpzOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Zp c2l0aW5nU2V0LmpzOgorICAgICAgICAoVmlzaXRpbmdTZXQucHJvdG90eXBlLmRvVmlzaXQpOgor ICAgICAgICAoVmlzaXRpbmdTZXQpOgorCiAyMDE3LTA5LTA2ICBNeWxlcyBDLiBNYXhmaWVsZCAg PG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgV1NMIHNob3VsZCBjb3JyZWN0bHkgaGFu ZGxlIHRoZSBpbnRlcmFjdGlvbiBiZXR3ZWVuIGNhc3Rpbmcgb3BlcmF0b3JzIGFuZCBjb21wbGV4 IHR5cGVzCkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9GdW5jLmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0Z1bmMuanMJKHJldmlzaW9u IDIyMTY4NSkKKysrIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0Z1bmMuanMJKHdvcmtp bmcgY29weSkKQEAgLTI3LDYgKzI3LDggQEAKIGNsYXNzIEZ1bmMgZXh0ZW5kcyBOb2RlIHsKICAg ICBjb25zdHJ1Y3RvcihvcmlnaW4sIG5hbWUsIHJldHVyblR5cGUsIHR5cGVQYXJhbWV0ZXJzLCBw YXJhbWV0ZXJzLCBpc0Nhc3QpCiAgICAgeworICAgICAgICBpZiAoIShvcmlnaW4gaW5zdGFuY2Vv ZiBMZXhlclRva2VuKSkKKyAgICAgICAgICAgIHRocm93IG5ldyBFcnJvcigiQmFkIG9yaWdpbjog IiArIG9yaWdpbik7CiAgICAgICAgIHN1cGVyKCk7CiAgICAgICAgIHRoaXMuX29yaWdpbiA9IG9y aWdpbjsKICAgICAgICAgdGhpcy5fbmFtZSA9IG5hbWU7CkluZGV4OiBUb29scy9XZWJHUFVTaGFk aW5nTGFuZ3VhZ2VSSS9JbmxpbmVyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRp bmdMYW5ndWFnZVJJL0lubGluZXIuanMJKHJldmlzaW9uIDIyMTY4NSkKKysrIFRvb2xzL1dlYkdQ VVNoYWRpbmdMYW5ndWFnZVJJL0lubGluZXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTQzLDE5ICs0 MywxNiBAQCBjbGFzcyBJbmxpbmVyIGV4dGVuZHMgUmV3cml0ZXIgewogICAgIAogICAgIHZpc2l0 Q2FsbEV4cHJlc3Npb24obm9kZSkKICAgICB7CisgICAgICAgIGxldCByZXN1bHQgPSBzdXBlci52 aXNpdENhbGxFeHByZXNzaW9uKG5vZGUpOwogICAgICAgICByZXR1cm4gdGhpcy5fdmlzaXRpbmcu ZG9WaXNpdChub2RlLmZ1bmMsICgpID0+IHsKLSAgICAgICAgICAgIGxldCBmdW5jID0gdGhpcy5f cHJvZ3JhbS5mdW5jSW5zdGFudGlhdG9yLmdldFVuaXF1ZShub2RlLmZ1bmMsIG5vZGUuYWN0dWFs VHlwZUFyZ3VtZW50cyk7CisgICAgICAgICAgICBsZXQgZnVuYyA9IHRoaXMuX3Byb2dyYW0uZnVu Y0luc3RhbnRpYXRvci5nZXRVbmlxdWUocmVzdWx0LmZ1bmMsIHJlc3VsdC5hY3R1YWxUeXBlQXJn dW1lbnRzKTsKICAgICAgICAgICAgIGlmIChmdW5jLmlzTmF0aXZlKSB7Ci0gICAgICAgICAgICAg ICAgbGV0IHJlc3VsdCA9IHN1cGVyLnZpc2l0Q2FsbEV4cHJlc3Npb24obm9kZSk7CiAgICAgICAg ICAgICAgICAgcmVzdWx0Lm5hdGl2ZUZ1bmNJbnN0YW5jZSA9IGZ1bmM7CiAgICAgICAgICAgICAg ICAgcmV0dXJuIHJlc3VsdDsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIF9pbmxpbmVGdW5j dGlvbih0aGlzLl9wcm9ncmFtLCBmdW5jLCB0aGlzLl92aXNpdGluZyk7CiAgICAgICAgICAgICBy ZXR1cm4gbmV3IEZ1bmN0aW9uTGlrZUJsb2NrKAotICAgICAgICAgICAgICAgIG5vZGUub3JpZ2lu LAotICAgICAgICAgICAgICAgIGZ1bmMucmV0dXJuVHlwZSwKLSAgICAgICAgICAgICAgICBub2Rl LmFyZ3VtZW50TGlzdC5tYXAoYXJndW1lbnQgPT4gYXJndW1lbnQudmlzaXQodGhpcykpLAotICAg ICAgICAgICAgICAgIGZ1bmMucGFyYW1ldGVycywgZnVuYy5ib2R5KTsKKyAgICAgICAgICAgICAg ICByZXN1bHQub3JpZ2luLCBmdW5jLnJldHVyblR5cGUsIHJlc3VsdC5hcmd1bWVudExpc3QsIGZ1 bmMucGFyYW1ldGVycywgZnVuYy5ib2R5KTsKICAgICAgICAgfSk7CiAgICAgfQogfQpJbmRleDog VG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvUGFyc2UuanMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvUGFyc2UuanMJKHJldmlzaW9uIDIyMTY4NSkKKysr IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1BhcnNlLmpzCSh3b3JraW5nIGNvcHkpCkBA IC02MjQsMTAgKzYyNCwxMyBAQCBmdW5jdGlvbiBwYXJzZShwcm9ncmFtLCBvcmlnaW4sIGxpbmVO dW1iCiAgICAgewogICAgICAgICBsZXQgcmVzdWx0ID0ge307CiAgICAgICAgIC8vIEZJWE1FOiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MzE2IENvcnJlY3RseSBo YW5kbGUgdGhlIGludGVyYWN0aW9uIGJldHdlZW4gY2FzdGluZyBvcGVyYXRvcnMgYW5kIGNvbXBs ZXggdHlwZXMKLSAgICAgICAgbGV0IGNhc3RUeXBlID0gY29uc3VtZUtpbmQoImlkZW50aWZpZXIi KS50ZXh0OwotICAgICAgICByZXN1bHQucmV0dXJuVHlwZSA9IG5ldyBUeXBlUmVmKG5hbWUsIGNh c3RUeXBlLCBbXSk7Ci0gICAgICAgIHJlc3VsdC5uYW1lID0gIm9wZXJhdG9yICIgKyBjYXN0VHlw ZTsKKyAgICAgICAgbGV0IGNhc3RUeXBlID0gY29uc3VtZUtpbmQoImlkZW50aWZpZXIiKTsKKyAg ICAgICAgcmVzdWx0LnJldHVyblR5cGUgPSBuZXcgVHlwZVJlZihjYXN0VHlwZSwgY2FzdFR5cGUu dGV4dCwgW10pOworICAgICAgICByZXN1bHQubmFtZSA9ICJvcGVyYXRvciAiICsgY2FzdFR5cGUu dGV4dDsKICAgICAgICAgcmVzdWx0LmlzQ2FzdCA9IHRydWU7CisgICAgICAgIHJlc3VsdC5vcmln aW4gPSBjYXN0VHlwZTsKKyAgICAgICAgaWYgKCEocmVzdWx0Lm9yaWdpbiBpbnN0YW5jZW9mIExl eGVyVG9rZW4pKQorICAgICAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJCYWQgb3JpZ2luOiAiICsg cmVzdWx0Lm9yaWdpbik7CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQogCkBAIC02Mzgs NiArNjQxLDggQEAgZnVuY3Rpb24gcGFyc2UocHJvZ3JhbSwgb3JpZ2luLCBsaW5lTnVtYgogICAg ICAgICByZXN1bHQub3JpZ2luID0gcmVzdWx0LnJldHVyblR5cGUub3JpZ2luOwogICAgICAgICBy ZXN1bHQubmFtZSA9IHBhcnNlRnVuY05hbWUoKTsKICAgICAgICAgcmVzdWx0LmlzQ2FzdCA9IGZh bHNlOworICAgICAgICBpZiAoIShyZXN1bHQub3JpZ2luIGluc3RhbmNlb2YgTGV4ZXJUb2tlbikp CisgICAgICAgICAgICB0aHJvdyBuZXcgRXJyb3IoIkJhZCBvcmlnaW46ICIgKyByZXN1bHQub3Jp Z2luKTsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAKQEAgLTY0Niw3ICs2NTEsNyBA QCBmdW5jdGlvbiBwYXJzZShwcm9ncmFtLCBvcmlnaW4sIGxpbmVOdW1iCiAgICAgICAgIGxldCBv cGVyYXRvclRva2VuID0gdHJ5Q29uc3VtZSgib3BlcmF0b3IiKTsKICAgICAgICAgaWYgKG9wZXJh dG9yVG9rZW4pIHsKICAgICAgICAgICAgIGxldCByZXN1bHQgPSBwYXJzZU9wZXJhdG9yRnVuY0Rl ZlZhbHVlcygpOwotICAgICAgICAgICAgcmVzdWx0Lm9yaWdpbiA9IG9wZXJhdG9yVG9rZW4ub3Jp Z2luOworICAgICAgICAgICAgcmVzdWx0Lm9yaWdpbiA9IG9wZXJhdG9yVG9rZW47CiAgICAgICAg ICAgICByZXR1cm4gcmVzdWx0OwogICAgICAgICB9CiAgICAgICAgIHJldHVybiBwYXJzZU5vbk9w ZXJhdG9yRnVuY0RlZlZhbHVlcygpOwpAQCAtNjU1LDYgKzY2MCw4IEBAIGZ1bmN0aW9uIHBhcnNl KHByb2dyYW0sIG9yaWdpbiwgbGluZU51bWIKICAgICBmdW5jdGlvbiBwYXJzZUZ1bmNEZWNsKCkK ICAgICB7CiAgICAgICAgIGxldCB2YWx1ZXMgPSBwYXJzZUdlbmVyaWNGdW5jRGVmVmFsdWVzKCk7 CisgICAgICAgIGlmICghKHZhbHVlcy5vcmlnaW4gaW5zdGFuY2VvZiBMZXhlclRva2VuKSkKKyAg ICAgICAgICAgIHRocm93IG5ldyBFcnJvcigiQmFkIG9yaWdpbjogIiArIHZhbHVlcy5vcmlnaW4p OwogICAgICAgICBsZXQgdHlwZVBhcmFtZXRlcnMgPSBwYXJzZVR5cGVQYXJhbWV0ZXJzKCk7CiAg ICAgICAgIGxldCBwYXJhbWV0ZXJzID0gcGFyc2VQYXJhbWV0ZXJzKCk7CiAgICAgICAgIHJldHVy biBuZXcgRnVuYyh2YWx1ZXMub3JpZ2luLCB2YWx1ZXMubmFtZSwgdmFsdWVzLnJldHVyblR5cGUs IHR5cGVQYXJhbWV0ZXJzLCBwYXJhbWV0ZXJzLCB2YWx1ZXMuaXNDYXN0KTsKSW5kZXg6IFRvb2xz L1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2Vi R1BVU2hhZGluZ0xhbmd1YWdlUkkvVGVzdC5qcwkocmV2aXNpb24gMjIxNjg1KQorKysgVG9vbHMv V2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvVGVzdC5qcwkod29ya2luZyBjb3B5KQpAQCAtOTcwLDYg Kzk3MCwxOCBAQCBmdW5jdGlvbiBURVNUX251bGxUeXBlVmFyaWFibGVVbmlmeSgpCiAgICAgICAg IH0pOwogfQogCitmdW5jdGlvbiBURVNUX2RvdWJsZU5vdCgpCit7CisgICAgbGV0IHByb2dyYW0g PSBkb1ByZXAoYAorICAgICAgICBib29sIGZvbyhib29sIHgpCisgICAgICAgIHsKKyAgICAgICAg ICAgIHJldHVybiAhIXg7CisgICAgICAgIH0KKyAgICBgKTsKKyAgICBjaGVja0Jvb2wocHJvZ3Jh bSwgY2FsbEZ1bmN0aW9uKHByb2dyYW0sICJmb28iLCBbXSwgW21ha2VCb29sKHByb2dyYW0sIHRy dWUpXSksIHRydWUpOworICAgIGNoZWNrQm9vbChwcm9ncmFtLCBjYWxsRnVuY3Rpb24ocHJvZ3Jh bSwgImZvbyIsIFtdLCBbbWFrZUJvb2wocHJvZ3JhbSwgZmFsc2UpXSksIGZhbHNlKTsKK30KKwog bGV0IGZpbHRlciA9IC8uKi87IC8vIHJ1biBldmVyeXRoaW5nIGJ5IGRlZmF1bHQKIGlmICh0aGlz WyJhcmd1bWVudHMiXSkgewogICAgIGZvciAobGV0IGkgPSAwOyBpIDwgYXJndW1lbnRzLmxlbmd0 aDsgaSsrKSB7CkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9WaXNpdGluZ1Nl dC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9WaXNpdGlu Z1NldC5qcwkocmV2aXNpb24gMjIxNjg1KQorKysgVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdl UkkvVmlzaXRpbmdTZXQuanMJKHdvcmtpbmcgY29weSkKQEAgLTMyLDggKzMyLDEwIEBAIGNsYXNz IFZpc2l0aW5nU2V0IHsKICAgICAKICAgICBkb1Zpc2l0KGl0ZW0sIGNhbGxiYWNrKQogICAgIHsK LSAgICAgICAgaWYgKHRoaXMuX3NldC5oYXMoaXRlbSkpCi0gICAgICAgICAgICB0aHJvdyBuZXcg V1R5cGVFcnJvcihpdGVtLm9yaWdpbi5vcmlnaW5TdHJpbmcsICJSZWN1cnNpdmUgIiArIGl0ZW0u a2luZCk7CisgICAgICAgIGlmICh0aGlzLl9zZXQuaGFzKGl0ZW0pKSB7CisgICAgICAgICAgICBw cmludCgiaXRlbTogIiArIGl0ZW0gKyAiICgiICsgaXRlbS5jb25zdHJ1Y3Rvci5uYW1lICsgIiki KTsKKyAgICAgICAgICAgIHRocm93IG5ldyBXVHlwZUVycm9yKGl0ZW0ub3JpZ2luLm9yaWdpblN0 cmluZywgIlJlY3Vyc2l2ZSAiICsgaXRlbS5raW5kLm5hbWUpOworICAgICAgICB9CiAgICAgICAg IHRoaXMuX3NldC5hZGQoaXRlbSk7CiAgICAgICAgIHRyeSB7CiAgICAgICAgICAgICByZXR1cm4g Y2FsbGJhY2soKTsK