176355 2017-09-05 01:41:14 -0700 Speedometer 2.0: Delete ToDo items in reversed order for Inferno suite 2017-09-08 00:54:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=172341 https://bugs.webkit.org/show_bug.cgi?id=176586 P2 Normal --- 172339 1 shiyu.zhang webkit-unassigned addyo lforschler pan.deng rniwa tianyou.li oldest_to_newest 1345383 0 319886 shiyu.zhang 2017-09-05 01:41:14 -0700 Created attachment 319886 Delete todo-items in reversed order for inferno suite Inferno case shows a strange behavior when deleting items. The deleteButtons array will be dynamically updated once one todo-item is deleted. For example, after deleteButtons[i].click() executed, deleteButtons[i+1] was copied to deleteButtons[i], deleteButtons[i+2] was copied to deleteButtons[i+1] ... This behavior caused the bug of "don't delete all ToDo items" in https://bugs.webkit.org/show_bug.cgi?id=172341. I tried to delete items in reversed order for Inferno case as the patch did. All the todo-items can be deleted and the results on my PC (Ubuntu Chrome R60) showed 4x score improvement for Inferno case. I think it’s unusual to dynamically update deleteButtons array in the Inferno use case. Maybe we can walk around this by deleting items in reversed order for Inferno case. 1345784 1 rniwa 2017-09-05 20:18:53 -0700 No, we don't want to make each test case faster like this. The whole point of this benchmark is to have browser engines optimize DOM API, not measure what they're already fast at. 319886 2017-09-05 01:41:14 -0700 2017-09-05 01:41:14 -0700 Delete todo-items in reversed order for inferno suite inferno-bug.pat text/plain 727 shiyu.zhang SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3Rlc3RzLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3Rlc3Rz LmpzCShyZXZpc2lvbiAyMjE2MTIpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jl c291cmNlcy90ZXN0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtNDM3LDggKzQzNyw4IEBACiAgICAg ICAgIH0pLAogICAgICAgICBuZXcgQmVuY2htYXJrVGVzdFN0ZXAoJ0RlbGV0aW5nSXRlbXMnLCBm dW5jdGlvbiAocGFyYW1zLCBjb250ZW50V2luZG93LCBjb250ZW50RG9jdW1lbnQpIHsKICAgICAg ICAgICAgIHZhciBkZWxldGVCdXR0b25zID0gY29udGVudERvY3VtZW50LnF1ZXJ5U2VsZWN0b3JB bGwoJy5kZXN0cm95Jyk7Ci0gICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IG51bWJlck9m SXRlbXNUb0FkZDsgaSsrKQotICAgICAgICAgICAgICAgIGNvbnRlbnREb2N1bWVudC5xdWVyeVNl bGVjdG9yKCcuZGVzdHJveScpLmNsaWNrKCk7CisgICAgICAgICAgICBmb3IgKHZhciBpID0gbnVt YmVyT2ZJdGVtc1RvQWRkLTE7IGkgPj0gMDsgaS0tKQorICAgICAgICAgICAgICAgIGRlbGV0ZUJ1 dHRvbnNbaV0uY2xpY2soKTsKICAgICAgICAgfSksCiAgICAgXQogfSk7Cg==