176286 2017-09-02 19:20:19 -0700 WSL Node.prototype.visit should probably do memoization 2018-10-13 17:06:39 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 176199 1 fpizlo fpizlo ggaren jfbastien keith_miller mark.lam mmaxfield msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1344893 0 fpizlo 2017-09-02 19:20:19 -0700 ... 1346506 1 320165 fpizlo 2017-09-07 13:06:55 -0700 Created attachment 320165 the patch 1346543 2 320165 mark.lam 2017-09-07 14:15:17 -0700 Comment on attachment 320165 the patch r=me 1346545 3 fpizlo 2017-09-07 14:19:06 -0700 Landed in https://trac.webkit.org/changeset/221757/webkit 1353586 4 webkit-bug-importer 2017-09-27 12:40:25 -0700 <rdar://problem/34693730> 1468957 5 mmaxfield 2018-10-13 17:06:39 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/158 320165 2017-09-07 13:06:55 -0700 2017-09-07 14:15:17 -0700 the patch blah.patch text/plain 7364 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTc1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMyIEBACisyMDE3LTA5LTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgV1NMIE5vZGUucHJvdG90eXBlLnZpc2l0IHNob3VsZCBwcm9iYWJseSBkbyBtZW1v aXphdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc2Mjg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAor ICAgICAgICBWaXNpdG9ycyBjYW4gc29tZXRpbWVzIHJldmlzaXQgdGhlIHNhbWUgdGhpbmcuIEZv ciBleGFtcGxlLCB3ZSBtYXkgdmlzaXQgYSBGdW5jRGVmIGJlY2F1c2UgaXQgYmVsb25ncworICAg ICAgICB0byBQcm9ncmFtIGFuZCB3ZSBtYXkgdmlzaXQgaXQgYWdhaW4gYmVjYXVzZSBhIENhbGxF eHByZXNzaW9uIHJlc29sdmVkIHRvIGl0LiBUaGF0J3MganVzdCBwbGFpbiBzaWxseS4KKyAgICAg ICAgCisgICAgICAgIE91ciB0ZXN0cyBkb24ndCBjdXJyZW50bHkgZG8gdGhpcywgc28gaXQncyBu b3QgYSBwZXJmb3JtYW5jZSBwcm9ibGVtLCB5ZXQuIEFsc28sIHdlIHVzdWFsbHkgYXZvaWQgdGhh dAorICAgICAgICBraW5kIG9mIHJlcGV0aXRpdmUgdmlzaXRpbmcgaW5zaWRlIHRoZSB2aXNpdG9y IGltcGxlbWVudGF0aW9ucy4gQnV0IGFzIGZhciBhcyBJIGNhbiB0ZWxsLCB0aGlzIGlzIGFuCisg ICAgICAgIGVtZXJnZW50IHByb3BlcnR5IHJhdGhlciB0aGFuIGEgZGVsaWJlcmF0ZSBkZXNpZ24u CisgICAgICAgIAorICAgICAgICBUaGlzIGNoYW5nZSBqdXN0IG1ha2VzIHRoZSBwb2xpY3kgc3Vw ZXIgZXhwbGljaXQuIElmIHlvdSB2aXNpdCBzb21ldGhpbmcgbW9yZSB0aGFuIG9uY2Ugd2l0aCB0 aGUgc2FtZQorICAgICAgICB2aXNpdG9yLCB5b3UgZ2V0IHRoZSBzYW1lIGFuc3dlciBiYWNrLiBU aGlzIGlzIGFjaGlldmVkIGJ5IG1lYW5zIG9mIGEgbWVtbyB0YWJsZSBpbnNpZGUgZWFjaCB2aXNp dG9yLgorICAgICAgICAKKyAgICAgICAgKiBXZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9BbGwuanM6 CisgICAgICAgICogV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvRnVuY0luc3RhbnRpYXRvci5qczoK KyAgICAgICAgKiBXZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9Ob2RlLmpzOgorICAgICAgICAoTm9k ZS5wcm90b3R5cGUudmlzaXQpOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jl d3JpdGVyLmpzOgorICAgICAgICAoUmV3cml0ZXIpOgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL1Rlc3QuaHRtbDoKKyAgICAgICAgKiBXZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9W aXNpdG9yLmpzOgorICAgICAgICAoVmlzaXRvcik6CisgICAgICAgICogV2ViR1BVU2hhZGluZ0xh bmd1YWdlUkkvVmlzaXRvckJhc2UuanM6IEFkZGVkLgorICAgICAgICAoVmlzaXRvckJhc2UpOgor CiAyMDE3LTA5LTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg V1NMIHNob3VsZCBjaGVjayByZWN1cnNpb24KSW5kZXg6IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5n dWFnZVJJL0FsbC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VS SS9BbGwuanMJKHJldmlzaW9uIDIyMTc1MCkKKysrIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFn ZVJJL0FsbC5qcwkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksNyBAQCBsb2FkKCJUeXBlLmpz Iik7CiBsb2FkKCJSZWZlcmVuY2VUeXBlLmpzIik7CiBsb2FkKCJWYWx1ZS5qcyIpOwogbG9hZCgi RXhwcmVzc2lvbi5qcyIpOworbG9hZCgiVmlzaXRvckJhc2UuanMiKTsKIGxvYWQoIlJld3JpdGVy LmpzIik7CiBsb2FkKCJWaXNpdG9yLmpzIik7CiAKSW5kZXg6IFRvb2xzL1dlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL0Z1bmNJbnN0YW50aWF0b3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViR1BV U2hhZGluZ0xhbmd1YWdlUkkvRnVuY0luc3RhbnRpYXRvci5qcwkocmV2aXNpb24gMjIxNzQ5KQor KysgVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvRnVuY0luc3RhbnRpYXRvci5qcwkod29y a2luZyBjb3B5KQpAQCAtNzYsNyArNzYsNyBAQCBjbGFzcyBGdW5jSW5zdGFudGlhdG9yIHsKICAg ICAgICAgCiAgICAgICAgIGxldCBzdWJzdGl0dXRpb24gPSBuZXcgSW5zdGFudGlhdGlvblN1YnN0 aXR1dGlvbihmdW5jLnR5cGVQYXJhbWV0ZXJzLCB0eXBlQXJndW1lbnRzKTsKICAgICAgICAgCi0g ICAgICAgIGNsYXNzIEluc3RhbnRpYXRlIHsKKyAgICAgICAgY2xhc3MgSW5zdGFudGlhdGUgZXh0 ZW5kcyBWaXNpdG9yQmFzZSB7CiAgICAgICAgICAgICB2aXNpdEZ1bmNEZWYoZnVuYykKICAgICAg ICAgICAgIHsKICAgICAgICAgICAgICAgICByZXR1cm4gbmV3IEZ1bmNEZWYoCkluZGV4OiBUb29s cy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9Ob2RlLmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dl YkdQVVNoYWRpbmdMYW5ndWFnZVJJL05vZGUuanMJKHJldmlzaW9uIDIyMTc0OSkKKysrIFRvb2xz L1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL05vZGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTI3LDE4 ICsyNywxNyBAQAogY2xhc3MgTm9kZSB7CiAgICAgdmlzaXQodmlzaXRvcikKICAgICB7Ci0gICAg ICAgIC8vIEZJWE1FOiBXZSBjb3VsZCBzdGFzaCBhIG1lbW8gdGFibGUgaW4gdGhlIHZpc2l0b3Iu IFNvLCBiZWZvcmUgY2FsbGluZyB0aGUgdmlzaXRvciwgd2UgYXNrCi0gICAgICAgIC8vIGl0IGlm IHRoZXkgaGF2ZSBzZWVuIHRoaXMgbm9kZSBiZWZvcmUuIElmIHRoZXkgaGF2ZSwgdGhlbiB3ZSBy ZXR1cm4gd2hhdCB0aGV5IHJldHVybmVkIHRoZQotICAgICAgICAvLyBsYXN0IHRpbWUuIFRoaXMg YWxzbyB0cml2aWFsbHkgbWFrZXMgdGhlIHJld3JpdGVyIGRvIHJlbWFwcGluZyBjb3JyZWN0bHku IFRoZSBkb3duc2lkZSBvZgotICAgICAgICAvLyBub3QgZG9pbmcgaXQgaXMgbW9zdGx5IHRoYXQg dmFyaW91cyB2aXNpdG9ycyBtaWdodCBjaGVjayB0aGUgc2FtZSB0eXBlcyBtdWx0aXBsZSB0aW1l cy4KLSAgICAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NjI4NgorICAgICAgICBsZXQgbWVtb1RhYmxlID0gdmlzaXRvci5fbWVtb1RhYmxlOworICAgICAg ICBpZiAobWVtb1RhYmxlLmhhcyh0aGlzKSkKKyAgICAgICAgICAgIHJldHVybiBtZW1vVGFibGUu Z2V0KHRoaXMpOwogICAgICAgICAKICAgICAgICAgbGV0IHZpc2l0RnVuYyA9IHZpc2l0b3JbInZp c2l0IiArIHRoaXMuY29uc3RydWN0b3IubmFtZV07CiAgICAgICAgIGlmICghdmlzaXRGdW5jKQog ICAgICAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJObyB2aXNpdCBmdW5jdGlvbiBmb3IgIiArIHRo aXMuY29uc3RydWN0b3IubmFtZSArICIgaW4gIiArIHZpc2l0b3IuY29uc3RydWN0b3IubmFtZSk7 CiAgICAgICAgIGxldCByZXR1cm5WYWx1ZSA9IHZpc2l0RnVuYy5jYWxsKHZpc2l0b3IsIHRoaXMp OwogICAgICAgICBpZiAoInJldHVyblZhbHVlIiBpbiB2aXNpdG9yKQotICAgICAgICAgICAgcmV0 dXJuIHZpc2l0b3IucmV0dXJuVmFsdWU7CisgICAgICAgICAgICByZXR1cm5WYWx1ZSA9IHZpc2l0 b3IucmV0dXJuVmFsdWU7CisgICAgICAgIG1lbW9UYWJsZS5zZXQodGhpcywgcmV0dXJuVmFsdWUp OwogICAgICAgICByZXR1cm4gcmV0dXJuVmFsdWU7CiAgICAgfQogICAgIApJbmRleDogVG9vbHMv V2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvUmV3cml0ZXIuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv V2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvUmV3cml0ZXIuanMJKHJldmlzaW9uIDIyMTc0OSkKKysr IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzCSh3b3JraW5nIGNvcHkp CkBAIC0yNyw5ICsyNywxMCBAQAogLy8gRklYTUU6IFRoaXMgc2hvdWxkIGhhdmUgc2Vuc2libGUg YmVoYXZpb3Igd2hlbiBpdCBlbmNvdW50ZXJzIGRlZmluaXRpb25zIHRoYXQgaXQgY2Fubm90IGhh bmRsZS4gUmlnaHQKIC8vIG5vdyB3ZSBhcmUgaGFja2lzaGx5IHByZXZlbnRpbmcgdGhpcyBieSB3 cmFwcGluZyB0aGluZ3MgaW4gVHlwZVJlZi4gVGhhdCdzIHByb2JhYmx5IHdyb25nLgogLy8gaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjIwOAotY2xhc3MgUmV3cml0 ZXIgeworY2xhc3MgUmV3cml0ZXIgZXh0ZW5kcyBWaXNpdG9yQmFzZSB7CiAgICAgY29uc3RydWN0 b3IoKQogICAgIHsKKyAgICAgICAgc3VwZXIoKTsKICAgICAgICAgdGhpcy5fbWFwcGluZyA9IG5l dyBNYXAoKTsKICAgICB9CiAgICAgCkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VS SS9UZXN0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkv VGVzdC5odG1sCShyZXZpc2lvbiAyMjE3NTApCisrKyBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3Vh Z2VSSS9UZXN0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTYsNiArNiw3IEBACiA8c2NyaXB0IHNy Yz0iUmVmZXJlbmNlVHlwZS5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0iVmFsdWUuanMiPjwv c2NyaXB0PgogPHNjcmlwdCBzcmM9IkV4cHJlc3Npb24uanMiPjwvc2NyaXB0PgorPHNjcmlwdCBz cmM9IlZpc2l0b3JCYXNlLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSJSZXdyaXRlci5qcyI+ PC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0iVmlzaXRvci5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0IHNy Yz0iQWRkcmVzc1NwYWNlLmpzIj48L3NjcmlwdD4KSW5kZXg6IFRvb2xzL1dlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL1Zpc2l0b3IuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViR1BVU2hhZGluZ0xh bmd1YWdlUkkvVmlzaXRvci5qcwkocmV2aXNpb24gMjIxNzQ5KQorKysgVG9vbHMvV2ViR1BVU2hh ZGluZ0xhbmd1YWdlUkkvVmlzaXRvci5qcwkod29ya2luZyBjb3B5KQpAQCAtMjQsOSArMjQsMTAg QEAKICAqLwogInVzZSBzdHJpY3QiOwogCi1jbGFzcyBWaXNpdG9yIHsKK2NsYXNzIFZpc2l0b3Ig ZXh0ZW5kcyBWaXNpdG9yQmFzZSB7CiAgICAgY29uc3RydWN0b3IoKQogICAgIHsKKyAgICAgICAg c3VwZXIoKTsKICAgICB9CiAgICAgCiAgICAgdmlzaXRQcm9ncmFtKG5vZGUpCkluZGV4OiBUb29s cy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9WaXNpdG9yQmFzZS5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9WaXNpdG9yQmFzZS5qcwkobm9uZXhpc3RlbnQp CisrKyBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9WaXNpdG9yQmFzZS5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDMyIEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDE3IEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cworICogYXJlIG1ldDoKKyAqIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0 IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBj b25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAyLiBSZWRpc3RyaWJ1 dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAor ICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk aXNjbGFpbWVyIGluIHRoZQorICogICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJp YWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJF IElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gYGBBUyBJUycnIEFORCBBTlkKKyAqIEVYUFJFU1Mg T1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhF CisgKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZP UiBBIFBBUlRJQ1VMQVIKKyAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBT SEFMTCBBUFBMRSBJTkMuIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkgRElS RUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFSWSwgT1IgQ09O U0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKKyAqIFBS T0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1MgT0YgVVNFLCBE QVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENB VVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRS QUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0Ug T1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UKKyAqIE9GIFRI SVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE QU1BR0UuIAorICovCisidXNlIHN0cmljdCI7CisKK2NsYXNzIFZpc2l0b3JCYXNlIHsKKyAgICBj b25zdHJ1Y3RvcigpCisgICAgeworICAgICAgICB0aGlzLl9tZW1vVGFibGUgPSBuZXcgTWFwKCk7 CisgICAgfQorfQo=