176244 2017-09-01 14:41:34 -0700 WSL should have more tests of type checking failures 2018-10-13 19:51:22 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 176199 1 fpizlo fpizlo buildbot webkit-bug-importer oldest_to_newest 1344581 0 fpizlo 2017-09-01 14:41:34 -0700 Patch forthcoming. 1344582 1 319645 fpizlo 2017-09-01 14:41:52 -0700 Created attachment 319645 the patch 1344583 2 buildbot 2017-09-01 14:44:42 -0700 Attachment 319645 did not pass style-queue: ERROR: Tools/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1344584 3 319645 fpizlo 2017-09-01 14:44:54 -0700 Comment on attachment 319645 the patch r=myles 1344587 4 fpizlo 2017-09-01 14:49:03 -0700 Landed in https://trac.webkit.org/changeset/221497/webkit 1353605 5 webkit-bug-importer 2017-09-27 12:41:44 -0700 <rdar://problem/34693776> 1469001 6 mmaxfield 2018-10-13 19:51:22 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/195 319645 2017-09-01 14:41:52 -0700 2017-09-01 14:44:54 -0700 the patch blah.patch text/plain 3453 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTQ5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA5LTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIChPT1BTISkuCisgICAgICAgIE5lZWQg dGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0NoZWNrZXIuanM6CisgICAg ICAgIChDaGVja2VyLnByb3RvdHlwZS52aXNpdFByb3RvY29sRGVjbC5zZXQgdGhyb3cpOgorICAg ICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanM6CisgICAgICAgIChURVNUX3R5 cGVNaXNtYXRjaFJldHVybik6CisKIDIwMTctMDktMDEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFw cGxlLmNvbT4KIAogICAgICAgICBXU0wgc2hvdWxkIGJlIGJlIGFibGUgdG8gY2FsbCBhIGZ1bmN0 aW9uIGRlY2xhcmVkIGluIGEgcHJvdG9jb2wgZnJvbSBhIGdlbmVyaWMgZnVuY3Rpb24KSW5kZXg6 IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0NoZWNrZXIuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvQ2hlY2tlci5qcwkocmV2aXNpb24gMjIxNDk2 KQorKysgVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvQ2hlY2tlci5qcwkod29ya2luZyBj b3B5KQpAQCAtMTY1LDExICsxNjUsMTEgQEAgY2xhc3MgQ2hlY2tlciBleHRlbmRzIFZpc2l0b3Ig ewogICAgICAgICAgICAgaWYgKCFyZXN1bHRUeXBlKQogICAgICAgICAgICAgICAgIHRocm93IG5l dyBFcnJvcigiTnVsbCByZXN1bHQgdHlwZSBmcm9tICIgKyBub2RlLnZhbHVlKTsKICAgICAgICAg ICAgIGlmICghbm9kZS5mdW5jLnJldHVyblR5cGUuZXF1YWxzKHJlc3VsdFR5cGUpKQotICAgICAg ICAgICAgICAgIHRocm93IG5ldyBXVHlwZUVycm9yKG5vZGUub3JpZ2luLm9yaWdpblN0cmluZywg IlRyeWluZyB0byByZXR1cm4gIiArIHJlc3VsdFR5cGUgKyAiIGluIGEgZnVuY3Rpb24gdGhhdCBy ZXR1cm5zICIgKyBmdW5jLnJldHVyblR5cGUpOworICAgICAgICAgICAgICAgIHRocm93IG5ldyBX VHlwZUVycm9yKG5vZGUub3JpZ2luLm9yaWdpblN0cmluZywgIlRyeWluZyB0byByZXR1cm4gIiAr IHJlc3VsdFR5cGUgKyAiIGluIGEgZnVuY3Rpb24gdGhhdCByZXR1cm5zICIgKyBub2RlLmZ1bmMu cmV0dXJuVHlwZSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgCi0g ICAgICAgIGlmICghZnVuYy5yZXR1cm5UeXBlLmVxdWFscyh0aGlzLl9wcm9ncmFtLmludHJpbnNp Y3Mudm9pZCkpCisgICAgICAgIGlmICghbm9kZS5mdW5jLnJldHVyblR5cGUuZXF1YWxzKHRoaXMu X3Byb2dyYW0uaW50cmluc2ljcy52b2lkKSkKICAgICAgICAgICAgIHRocm93IG5ldyBXVHlwZUVy cm9yKG5vZGUub3JpZ2luLm9yaWdpblN0cmluZywgIk5vbi12b2lkIGZ1bmN0aW9uIG11c3QgcmV0 dXJuIGEgdmFsdWUiKTsKICAgICB9CiAgICAgCkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFu Z3VhZ2VSSS9UZXN0LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFn ZVJJL1Rlc3QuanMJKHJldmlzaW9uIDIyMTQ5NikKKysrIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5n dWFnZVJJL1Rlc3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTI1Miw2ICsyNTIsNjggQEAgZnVuY3Rp b24gVEVTVF9zaW1wbGVQcm90b2NvbCgpCiAgICAgY2hlY2tJbnQocHJvZ3JhbSwgY2FsbEZ1bmN0 aW9uKHByb2dyYW0sICJmb28iLCBbXSwgW21ha2VJbnQocHJvZ3JhbSwgNDUpXSksIDQ1ICsgNzMp OwogfQogCitmdW5jdGlvbiBURVNUX3R5cGVNaXNtYXRjaFJldHVybigpCit7CisgICAgY2hlY2tG YWlsKAorICAgICAgICAoKSA9PiBkb1ByZXAoYAorICAgICAgICAgICAgaW50IGZvbygpCisgICAg ICAgICAgICB7CisgICAgICAgICAgICAgICAgcmV0dXJuIDB1OworICAgICAgICAgICAgfQorICAg ICAgICBgKSwKKyAgICAgICAgKGUpID0+IGUgaW5zdGFuY2VvZiBXVHlwZUVycm9yKTsKK30KKwor ZnVuY3Rpb24gVEVTVF90eXBlTWlzbWF0Y2hWYXJpYWJsZURlY2woKQoreworICAgIGNoZWNrRmFp bCgKKyAgICAgICAgKCkgPT4gZG9QcmVwKGAKKyAgICAgICAgICAgIHZvaWQgZm9vKHVpbnQgeCkK KyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBpbnQgeSA9IHg7CisgICAgICAgICAgICB9 CisgICAgICAgIGApLAorICAgICAgICAoZSkgPT4gZSBpbnN0YW5jZW9mIFdUeXBlRXJyb3IpOwor fQorCitmdW5jdGlvbiBURVNUX3R5cGVNaXNtYXRjaEFzc2lnbm1lbnQoKQoreworICAgIGNoZWNr RmFpbCgKKyAgICAgICAgKCkgPT4gZG9QcmVwKGAKKyAgICAgICAgICAgIHZvaWQgZm9vKHVpbnQg eCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBpbnQgeTsKKyAgICAgICAgICAgICAg ICB5ID0geDsKKyAgICAgICAgICAgIH0KKyAgICAgICAgYCksCisgICAgICAgIChlKSA9PiBlIGlu c3RhbmNlb2YgV1R5cGVFcnJvcik7Cit9CisKK2Z1bmN0aW9uIFRFU1RfdHlwZU1pc21hdGNoUmV0 dXJuUGFyYW0oKQoreworICAgIGNoZWNrRmFpbCgKKyAgICAgICAgKCkgPT4gZG9QcmVwKGAKKyAg ICAgICAgICAgIGludCBmb28odWludCB4KQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg IHJldHVybiB4OworICAgICAgICAgICAgfQorICAgICAgICBgKSwKKyAgICAgICAgKGUpID0+IGUg aW5zdGFuY2VvZiBXVHlwZUVycm9yKTsKK30KKworZnVuY3Rpb24gVEVTVF9iYWRBZGQoKQorewor ICAgIGNoZWNrRmFpbCgKKyAgICAgICAgKCkgPT4gZG9QcmVwKGAKKyAgICAgICAgICAgIHZvaWQg YmFyPFQ+KFQpIHsgfQorICAgICAgICAgICAgdm9pZCBmb28oaW50IHgsIHVpbnQgeSkKKyAgICAg ICAgICAgIHsKKyAgICAgICAgICAgICAgICBiYXIoeCArIHkpOworICAgICAgICAgICAgfQorICAg ICAgICBgKSwKKyAgICAgICAgKGUpID0+IGUgaW5zdGFuY2VvZiBXVHlwZUVycm9yICYmIGUubWVz c2FnZS5pbmRleE9mKCJuYXRpdmUgaW50MzIgb3BlcmF0b3IrPD4oaW50MzIsaW50MzIpIikgIT0g LTEpOworfQorCiBsZXQgYmVmb3JlID0gcHJlY2lzZVRpbWUoKTsKIAogbGV0IGZpbHRlciA9IC8u Ki87IC8vIHJ1biBldmVyeXRoaW5nIGJ5IGRlZmF1bHQK