176189 2017-08-31 15:19:25 -0700 There should only be one callFunction API in WSL 2018-10-13 20:01:56 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 176199 1 fpizlo fpizlo mmaxfield saam webkit-bug-importer oldest_to_newest 1344156 0 fpizlo 2017-08-31 15:19:25 -0700 And it should always take TypedValues, and TypedValues should always have a type and an ePtr. TypedValue should make it easy to box and unbox. 1344157 1 319528 fpizlo 2017-08-31 15:21:26 -0700 Created attachment 319528 the patch 1344158 2 fpizlo 2017-08-31 15:24:07 -0700 Landed in https://trac.webkit.org/changeset/221449/webkit 1353751 3 webkit-bug-importer 2017-09-27 12:59:21 -0700 <rdar://problem/34694431> 1469011 4 mmaxfield 2018-10-13 20:01:56 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/205 319528 2017-08-31 15:21:26 -0700 2017-08-31 15:22:39 -0700 the patch blah.patch text/plain 4154 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTQ0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI3IEBACisyMDE3LTA4LTMxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgVGhlcmUgc2hvdWxkIG9ubHkgYmUgb25lIGNhbGxGdW5jdGlvbiBBUEkgaW4gV1NM CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYxODkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IFRoaXMgcmVtb3ZlcyB0aGUgbmVlZCBmb3IgY2FsbEZ1bmN0aW9uQnlSZWYsIHdoaWNoIHdhcyB3 ZWlyZC4gSXQncyBub3cgdGhlIGNhc2UgdGhlIFR5cGVkVmFsdWUKKyAgICAgICAgaXMgYWx3YXlz IGEgdHVwbGUgb2YgdHlwZSBhbmQgZVB0ciwgYW5kIFR5cGVkVmFsdWUgaGFzIGEgc3VwZXIgc2lt cGxlIEFQSSBmb3IgYm94aW5nIGFuZAorICAgICAgICB1bmJveGluZyBzaW5nbGUtY2VsbCB2YWx1 ZXMgbGlrZSBpbnRzLgorCisgICAgICAgICogV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvQ2FsbEZ1 bmN0aW9uLmpzOgorICAgICAgICAoY2FsbEZ1bmN0aW9uKToKKyAgICAgICAgKGNhbGxGdW5jdGlv bkJ5UmVmKTogRGVsZXRlZC4KKyAgICAgICAgKiBXZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0 LmpzOgorICAgICAgICAobWFrZUludCk6CisgICAgICAgICogV2ViR1BVU2hhZGluZ0xhbmd1YWdl UkkvVHlwZWRWYWx1ZS5qczoKKyAgICAgICAgKFR5cGVkVmFsdWUpOgorICAgICAgICAoVHlwZWRW YWx1ZS5wcm90b3R5cGUuZ2V0IHR5cGUpOgorICAgICAgICAoVHlwZWRWYWx1ZS5wcm90b3R5cGUu Z2V0IGVQdHIpOgorICAgICAgICAoVHlwZWRWYWx1ZS5ib3gpOgorICAgICAgICAoVHlwZWRWYWx1 ZS5wcm90b3R5cGUuZ2V0IHZhbHVlKToKKyAgICAgICAgKFR5cGVkVmFsdWUucHJvdG90eXBlLnRv U3RyaW5nKToKKwogMjAxNy0wOC0zMSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIFdTTCBFUHRyIGRvZXMgbm90IG5lZWQgdG8gY2FycnkgYXJvdW5kIHRoZSB0eXBl CkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9DYWxsRnVuY3Rpb24uanMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvQ2FsbEZ1bmN0aW9uLmpz CShyZXZpc2lvbiAyMjE0NDgpCisrKyBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9DYWxs RnVuY3Rpb24uanMJKHdvcmtpbmcgY29weSkKQEAgLTI1LDIzICsyNSwxNSBAQAogInVzZSBzdHJp Y3QiOwogCiAvLyBUaGlzIGFsbG93cyB5b3UgdG8gcGFzcyBzdHJ1Y3RzIGFuZCBhcnJheXMgaW4t cGxhY2UsIGJ1dCBpdCdzIGEgbW9yZSBhbm5veWluZyBBUEkuCi1mdW5jdGlvbiBjYWxsRnVuY3Rp b25CeVJlZihwcm9ncmFtLCBuYW1lLCB0eXBlQXJndW1lbnRzLCBhcmd1bWVudExpc3QpCitmdW5j dGlvbiBjYWxsRnVuY3Rpb24ocHJvZ3JhbSwgbmFtZSwgdHlwZUFyZ3VtZW50cywgYXJndW1lbnRM aXN0KQogewogICAgIGxldCBhcmd1bWVudFR5cGVzID0gYXJndW1lbnRMaXN0Lm1hcChhcmd1bWVu dCA9PiBhcmd1bWVudC50eXBlKTsKICAgICBsZXQgZnVuYyA9IHJlc29sdmVJbmxpbmVkRnVuY3Rp b24ocHJvZ3JhbSwgbmFtZSwgdHlwZUFyZ3VtZW50cywgYXJndW1lbnRUeXBlcyk7CiAgICAgaWYg KCFmdW5jKQogICAgICAgICB0aHJvdyBuZXcgV1R5cGVFcnJvcigiPGNhbGxGdW5jdGlvbj4iLCAi Q2Fubm90IHJlc29sdmUgZnVuY3Rpb24gY2FsbCAiICsgbmFtZSArICI8IiArIHR5cGVBcmd1bWVu dHMgKyAiPigiICsgYXJndW1lbnRMaXN0ICsgIikiKTsKICAgICBmb3IgKGxldCBpID0gMDsgaSA8 IGZ1bmMucGFyYW1ldGVycy5sZW5ndGg7ICsraSkKLSAgICAgICAgZnVuYy5wYXJhbWV0ZXJzW2ld LmVQdHIuY29weUZyb20oYXJndW1lbnRMaXN0W2ldLnZhbHVlLCBhcmd1bWVudFR5cGVzW2ldLnNp emUpOworICAgICAgICBmdW5jLnBhcmFtZXRlcnNbaV0uZVB0ci5jb3B5RnJvbShhcmd1bWVudExp c3RbaV0uZVB0ciwgYXJndW1lbnRUeXBlc1tpXS5zaXplKTsKICAgICBsZXQgcmVzdWx0ID0gbmV3 IEV2YWx1YXRvcihwcm9ncmFtKS52aXNpdEZ1bmN0aW9uQm9keShmdW5jLmJvZHkpOwogICAgIHJl dHVybiBuZXcgVHlwZWRWYWx1ZShmdW5jLnJldHVyblR5cGUsIHJlc3VsdCk7CiB9CiAKLS8vIFRo aXMgdXNlcyB0aGUgc2ltcGxpZmllZCBUeXBlZFZhbHVlIG9iamVjdCBmb3Igd3JhcHBpbmcgdmFs dWVzIGxpa2UgaW50ZWdlcnMgYW5kIGRvdWJsZXMuCi1mdW5jdGlvbiBjYWxsRnVuY3Rpb24ocHJv Z3JhbSwgbmFtZSwgdHlwZUFyZ3VtZW50cywgYXJndW1lbnRMaXN0KQotewotICAgIGxldCByZXN1 bHQgPSBjYWxsRnVuY3Rpb25CeVJlZigKLSAgICAgICAgcHJvZ3JhbSwgbmFtZSwgdHlwZUFyZ3Vt ZW50cywKLSAgICAgICAgYXJndW1lbnRMaXN0Lm1hcChhcmd1bWVudCA9PiBuZXcgVHlwZWRWYWx1 ZShhcmd1bWVudC50eXBlLCBFUHRyLmJveChhcmd1bWVudC52YWx1ZSkpKSk7Ci0gICAgcmV0dXJu IG5ldyBUeXBlZFZhbHVlKHJlc3VsdC50eXBlLCByZXN1bHQudmFsdWUubG9hZFZhbHVlKCkpOwot fQpJbmRleDogVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvVGVzdC5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzCShyZXZpc2lvbiAyMjE0 NDgpCisrKyBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzCSh3b3JraW5nIGNv cHkpCkBAIC0zMyw3ICszMyw3IEBAIGZ1bmN0aW9uIGRvUHJlcChjb2RlKQogCiBmdW5jdGlvbiBt YWtlSW50KHByb2dyYW0sIHZhbHVlKQogewotICAgIHJldHVybiBuZXcgVHlwZWRWYWx1ZShwcm9n cmFtLmludHJpbnNpY3MuaW50MzIsIHZhbHVlKTsKKyAgICByZXR1cm4gVHlwZWRWYWx1ZS5ib3go cHJvZ3JhbS5pbnRyaW5zaWNzLmludDMyLCB2YWx1ZSk7CiB9CiAKIGZ1bmN0aW9uIGNoZWNrSW50 KHByb2dyYW0sIHJlc3VsdCwgZXhwZWN0ZWQpCkluZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFu Z3VhZ2VSSS9UeXBlZFZhbHVlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdM YW5ndWFnZVJJL1R5cGVkVmFsdWUuanMJKHJldmlzaW9uIDIyMTQ0NikKKysrIFRvb2xzL1dlYkdQ VVNoYWRpbmdMYW5ndWFnZVJJL1R5cGVkVmFsdWUuanMJKHdvcmtpbmcgY29weSkKQEAgLTI1LDE0 ICsyNSwyNCBAQAogInVzZSBzdHJpY3QiOwogCiBjbGFzcyBUeXBlZFZhbHVlIHsKLSAgICBjb25z dHJ1Y3Rvcih0eXBlLCB2YWx1ZSkKKyAgICBjb25zdHJ1Y3Rvcih0eXBlLCBlUHRyKQogICAgIHsK LSAgICAgICAgdGhpcy50eXBlID0gdHlwZTsKLSAgICAgICAgdGhpcy52YWx1ZSA9IHZhbHVlOwor ICAgICAgICB0aGlzLl90eXBlID0gdHlwZTsKKyAgICAgICAgdGhpcy5fZVB0ciA9IGVQdHI7CiAg ICAgfQogICAgIAorICAgIGdldCB0eXBlKCkgeyByZXR1cm4gdGhpcy5fdHlwZTsgfQorICAgIGdl dCBlUHRyKCkgeyByZXR1cm4gdGhpcy5fZVB0cjsgfQorICAgIAorICAgIHN0YXRpYyBib3godHlw ZSwgdmFsdWUpCisgICAgeworICAgICAgICByZXR1cm4gbmV3IFR5cGVkVmFsdWUodHlwZSwgRVB0 ci5ib3godmFsdWUpKTsKKyAgICB9CisgICAgCisgICAgZ2V0IHZhbHVlKCkgeyByZXR1cm4gdGhp cy5lUHRyLmxvYWRWYWx1ZSgpOyB9CisgICAgCiAgICAgdG9TdHJpbmcoKQogICAgIHsKLSAgICAg ICAgcmV0dXJuIHRoaXMudHlwZSArICIoIiArIHRoaXMudmFsdWUgKyAiKSI7CisgICAgICAgIHJl dHVybiB0aGlzLnR5cGUgKyAiKCIgKyB0aGlzLmVQdHIgKyAiKSI7CiAgICAgfQogfQo=