176142 2017-08-30 20:16:58 -0700 Speedometer 2.0: Add dummy node to notify app is ready for Backbone suite 2017-09-27 12:47:54 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=176017 InRadar P2 Normal --- 172339 1 shiyu.zhang webkit-unassigned buildbot cdumez commit-queue lforschler rniwa webkit-bug-importer oldest_to_newest 1343842 0 shiyu.zhang 2017-08-30 20:16:58 -0700 There's a chance for BackboneJS suite that Speedometer attempted to add items before app.js was loaded. The deleteButtons.length in resources/test.js for BackboneJS suite could be zero sometimes as I observed. What's worse, BackboneJS suite will just skip complete/delete-items steps and never crash if checkboxes/deleteButtons.length is zero, which makes this issue difficult to be detected. 1343843 1 319437 shiyu.zhang 2017-08-30 20:32:42 -0700 Created attachment 319437 Patch 1343845 2 319437 shiyu.zhang 2017-08-30 20:38:19 -0700 Comment on attachment 319437 Patch A patch to fix this bug, PTAL. 1344498 3 319437 rniwa 2017-09-01 11:42:43 -0700 Comment on attachment 319437 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319437&action=review > PerformanceTests/Speedometer/resources/tests.js:233 > + var newTodo = contentDocument.getElementsByClassName('new-todo'); > + newTodo[0].focus(); > + return newTodo[0]; I think it's cleaner to use querySelector here. 1344500 4 319437 rniwa 2017-09-01 11:44:08 -0700 Comment on attachment 319437 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319437&action=review >> PerformanceTests/Speedometer/resources/tests.js:233 >> + return newTodo[0]; > > I think it's cleaner to use querySelector here. Can we also replace checkboxes.length and deleteButtons.length by numberOfItemsToAdd below so that we'd see a console error should this bug come back? 1345125 5 319831 shiyu.zhang 2017-09-03 20:41:22 -0700 Created attachment 319831 Patch 1345126 6 319831 shiyu.zhang 2017-09-03 20:45:05 -0700 Comment on attachment 319831 Patch Thanks for your advice! A new patch following your suggestion is here. 1345378 7 319831 commit-queue 2017-09-05 01:17:29 -0700 Comment on attachment 319831 Patch Clearing flags on attachment: 319831 Committed r221611: <http://trac.webkit.org/changeset/221611> 1345379 8 commit-queue 2017-09-05 01:17:30 -0700 All reviewed patches have been landed. Closing bug. 1353656 9 webkit-bug-importer 2017-09-27 12:47:54 -0700 <rdar://problem/34694038> 319437 2017-08-30 20:32:42 -0700 2017-09-03 20:41:18 -0700 Patch bug-176142-20170831193229.patch text/plain 2426 shiyu.zhang SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjE0MTMpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA4LTMxICBT aGl5dSBaaGFuZyAgPHNoaXl1LnpoYW5nQGludGVsLmNvbT4KKworICAgICAgICBTcGVlZG9tZXRl ciAyLjA6IEFkZCBkdW1teSBub2RlIHRvIG5vdGlmeSBhcHAgaXMgcmVhZHkgZm9yIEJhY2tib25l IHN1aXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzYxNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIENyZWF0ZSBhIGR1bW15IG5vZGUgdG8gbm90aWZ5IHRoYXQgYXBwIGlzIHJlYWR5IGZv ciBCYWNrYm9uZSBzdWl0ZS4gSXQgcHJldmVudHMgU3BlZWRvbWV0ZXIgaW5qZWN0aW5nIGl0ZW1z IGJlZm9yZSBhcHAuanMgaXMgbG9hZGVkLgorCisgICAgICAgICogU3BlZWRvbWV0ZXIvcmVzb3Vy Y2VzL3Rlc3RzLmpzOgorICAgICAgICAoU3VpdGVzLnB1c2gucHJlcGFyZSk6CisgICAgICAgICog U3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3RvZG9tdmMvYXJjaGl0ZWN0dXJlLWV4YW1wbGVzL2JhY2ti b25lL2pzL2FwcC5qczoKKwogMjAxNy0wOC0zMCAgU2hpeXUgWmhhbmcgIDxzaGl5dS56aGFuZ0Bp bnRlbC5jb20+CiAKICAgICAgICAgU3BlZWRvbWV0ZXIgMi4wOiBqUXVlcnkgdGVzdCBmYWlscyBv Y2Nhc2lvbmFsbHkKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2Vz L3Rlc3RzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVz b3VyY2VzL3Rlc3RzLmpzCShyZXZpc2lvbiAyMjE0MTIpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1Nw ZWVkb21ldGVyL3Jlc291cmNlcy90ZXN0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtMjI3LDkgKzIy NywxMCBAQCBTdWl0ZXMucHVzaCh7CiAgICAgdXJsOiAndG9kb212Yy9hcmNoaXRlY3R1cmUtZXhh bXBsZXMvYmFja2JvbmUvaW5kZXguaHRtbCcsCiAgICAgcHJlcGFyZTogZnVuY3Rpb24gKHJ1bm5l ciwgY29udGVudFdpbmRvdywgY29udGVudERvY3VtZW50KSB7CiAgICAgY29udGVudFdpbmRvdy5C YWNrYm9uZS5zeW5jID0gZnVuY3Rpb24gKCkge30KLSAgICAgICAgcmV0dXJuIHJ1bm5lci53YWl0 Rm9yRWxlbWVudCgnLm5ldy10b2RvJykudGhlbihmdW5jdGlvbiAoZWxlbWVudCkgewotICAgICAg ICAgICAgZWxlbWVudC5mb2N1cygpOwotICAgICAgICAgICAgcmV0dXJuIGVsZW1lbnQ7CisgICAg ICAgIHJldHVybiBydW5uZXIud2FpdEZvckVsZW1lbnQoJyNhcHBJc1JlYWR5JykudGhlbihmdW5j dGlvbiAoZWxlbWVudCkgeworICAgICAgICAgICAgdmFyIG5ld1RvZG8gPSBjb250ZW50RG9jdW1l bnQuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgnbmV3LXRvZG8nKTsKKyAgICAgICAgICAgIG5ld1Rv ZG9bMF0uZm9jdXMoKTsKKyAgICAgICAgICAgIHJldHVybiBuZXdUb2RvWzBdOwogICAgICAgICB9 KTsKICAgICB9LAogICAgIHRlc3RzOiBbCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21l dGVyL3Jlc291cmNlcy90b2RvbXZjL2FyY2hpdGVjdHVyZS1leGFtcGxlcy9iYWNrYm9uZS9qcy9h cHAuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci9yZXNvdXJj ZXMvdG9kb212Yy9hcmNoaXRlY3R1cmUtZXhhbXBsZXMvYmFja2JvbmUvanMvYXBwLmpzCShyZXZp c2lvbiAyMjE0MTIpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy90 b2RvbXZjL2FyY2hpdGVjdHVyZS1leGFtcGxlcy9iYWNrYm9uZS9qcy9hcHAuanMJKHdvcmtpbmcg Y29weSkKQEAgLTksNCArOSw4IEBAICQoZnVuY3Rpb24gKCkgewogCiAgICAgLy8ga2ljayB0aGlu Z3Mgb2ZmIGJ5IGNyZWF0aW5nIHRoZSBgQXBwYAogICAgIHdpbmRvdy5hcHBWaWV3ID0gbmV3IGFw cC5BcHBWaWV3KCk7CisKKyAgICB2YXIgZHVtbXlOb2RlVG9Ob3RpZnlBcHBJc1JlYWR5ID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CisgICAgZHVtbXlOb2RlVG9Ob3RpZnlBcHBJc1Jl YWR5LmlkID0gJ2FwcElzUmVhZHknOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZHVt bXlOb2RlVG9Ob3RpZnlBcHBJc1JlYWR5KTsKIH0pOwo= 319831 2017-09-03 20:41:22 -0700 2017-09-05 01:17:29 -0700 Patch bug-176142-20170904194114.patch text/plain 3166 shiyu.zhang SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjE1NjgpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA5LTA0ICBT aGl5dSBaaGFuZyAgPHNoaXl1LnpoYW5nQGludGVsLmNvbT4KKworICAgICAgICBTcGVlZG9tZXRl ciAyLjA6IEFkZCBkdW1teSBub2RlIHRvIG5vdGlmeSBhcHAgaXMgcmVhZHkgZm9yIEJhY2tib25l IHN1aXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzYxNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD cmVhdGUgYSBkdW1teSBub2RlIHRvIG5vdGlmeSB0aGF0IGFwcCBpcyByZWFkeSBmb3IgQmFja2Jv bmUgc3VpdGUuIEl0IHByZXZlbnRzIFNwZWVkb21ldGVyIGluamVjdGluZyBpdGVtcyBiZWZvcmUg YXBwLmpzIGlzIGxvYWRlZC4KKworICAgICAgICAqIFNwZWVkb21ldGVyL3Jlc291cmNlcy90ZXN0 cy5qczoKKyAgICAgICAgKFN1aXRlcy5wdXNoLnByZXBhcmUpOgorICAgICAgICAqIFNwZWVkb21l dGVyL3Jlc291cmNlcy90b2RvbXZjL2FyY2hpdGVjdHVyZS1leGFtcGxlcy9iYWNrYm9uZS9qcy9h cHAuanM6CisKIDIwMTctMDgtMzAgIFNoaXl1IFpoYW5nICA8c2hpeXUuemhhbmdAaW50ZWwuY29t PgogCiAgICAgICAgIFNwZWVkb21ldGVyIDIuMDogalF1ZXJ5IHRlc3QgZmFpbHMgb2NjYXNpb25h bGx5CkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy90ZXN0cy5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy90 ZXN0cy5qcwkocmV2aXNpb24gMjIxNDEyKQorKysgUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRl ci9yZXNvdXJjZXMvdGVzdHMuanMJKHdvcmtpbmcgY29weSkKQEAgLTIyNyw5ICsyMjcsMTAgQEAg U3VpdGVzLnB1c2goewogICAgIHVybDogJ3RvZG9tdmMvYXJjaGl0ZWN0dXJlLWV4YW1wbGVzL2Jh Y2tib25lL2luZGV4Lmh0bWwnLAogICAgIHByZXBhcmU6IGZ1bmN0aW9uIChydW5uZXIsIGNvbnRl bnRXaW5kb3csIGNvbnRlbnREb2N1bWVudCkgewogICAgIGNvbnRlbnRXaW5kb3cuQmFja2JvbmUu c3luYyA9IGZ1bmN0aW9uICgpIHt9Ci0gICAgICAgIHJldHVybiBydW5uZXIud2FpdEZvckVsZW1l bnQoJy5uZXctdG9kbycpLnRoZW4oZnVuY3Rpb24gKGVsZW1lbnQpIHsKLSAgICAgICAgICAgIGVs ZW1lbnQuZm9jdXMoKTsKLSAgICAgICAgICAgIHJldHVybiBlbGVtZW50OworICAgICAgICByZXR1 cm4gcnVubmVyLndhaXRGb3JFbGVtZW50KCcjYXBwSXNSZWFkeScpLnRoZW4oZnVuY3Rpb24gKGVs ZW1lbnQpIHsKKyAgICAgICAgICAgIHZhciBuZXdUb2RvID0gY29udGVudERvY3VtZW50LnF1ZXJ5 U2VsZWN0b3IoJy5uZXctdG9kbycpOworICAgICAgICAgICAgbmV3VG9kby5mb2N1cygpOworICAg ICAgICAgICAgcmV0dXJuIG5ld1RvZG87CiAgICAgICAgIH0pOwogICAgIH0sCiAgICAgdGVzdHM6 IFsKQEAgLTI0MSwxMiArMjQyLDEyIEBAIFN1aXRlcy5wdXNoKHsKICAgICAgICAgfSksCiAgICAg ICAgIG5ldyBCZW5jaG1hcmtUZXN0U3RlcCgnQ29tcGxldGluZ0FsbEl0ZW1zJywgZnVuY3Rpb24g KG5ld1RvZG8sIGNvbnRlbnRXaW5kb3csIGNvbnRlbnREb2N1bWVudCkgewogICAgICAgICAgICAg dmFyIGNoZWNrYm94ZXMgPSBjb250ZW50RG9jdW1lbnQucXVlcnlTZWxlY3RvckFsbCgnLnRvZ2ds ZScpOwotICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjaGVja2JveGVzLmxlbmd0aDsg aSsrKQorICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBudW1iZXJPZkl0ZW1zVG9BZGQ7 IGkrKykKICAgICAgICAgICAgICAgICBjaGVja2JveGVzW2ldLmNsaWNrKCk7CiAgICAgICAgIH0p LAogICAgICAgICBuZXcgQmVuY2htYXJrVGVzdFN0ZXAoJ0RlbGV0aW5nQWxsSXRlbXMnLCBmdW5j dGlvbiAobmV3VG9kbywgY29udGVudFdpbmRvdywgY29udGVudERvY3VtZW50KSB7CiAgICAgICAg ICAgICB2YXIgZGVsZXRlQnV0dG9ucyA9IGNvbnRlbnREb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxs KCcuZGVzdHJveScpOwotICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBkZWxldGVCdXR0 b25zLmxlbmd0aDsgaSsrKQorICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBudW1iZXJP Zkl0ZW1zVG9BZGQ7IGkrKykKICAgICAgICAgICAgICAgICBkZWxldGVCdXR0b25zW2ldLmNsaWNr KCk7CiAgICAgICAgIH0pLAogICAgIF0KSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0 ZXIvcmVzb3VyY2VzL3RvZG9tdmMvYXJjaGl0ZWN0dXJlLWV4YW1wbGVzL2JhY2tib25lL2pzL2Fw cC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNl cy90b2RvbXZjL2FyY2hpdGVjdHVyZS1leGFtcGxlcy9iYWNrYm9uZS9qcy9hcHAuanMJKHJldmlz aW9uIDIyMTQxMikKKysrIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3Rv ZG9tdmMvYXJjaGl0ZWN0dXJlLWV4YW1wbGVzL2JhY2tib25lL2pzL2FwcC5qcwkod29ya2luZyBj b3B5KQpAQCAtOSw0ICs5LDggQEAgJChmdW5jdGlvbiAoKSB7CiAKICAgICAvLyBraWNrIHRoaW5n cyBvZmYgYnkgY3JlYXRpbmcgdGhlIGBBcHBgCiAgICAgd2luZG93LmFwcFZpZXcgPSBuZXcgYXBw LkFwcFZpZXcoKTsKKworICAgIHZhciBkdW1teU5vZGVUb05vdGlmeUFwcElzUmVhZHkgPSBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKKyAgICBkdW1teU5vZGVUb05vdGlmeUFwcElzUmVh ZHkuaWQgPSAnYXBwSXNSZWFkeSc7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkdW1t eU5vZGVUb05vdGlmeUFwcElzUmVhZHkpOwogfSk7Cg==