176058 2017-08-29 10:52:49 -0700 [Code Style] Use uniform initializer syntax in member initializer list 2019-05-15 23:07:49 -0700 1 1 1 Unclassified WebKit WebKit Website WebKit Local Build All All RESOLVED WONTFIX https://lists.webkit.org/pipermail/webkit-dev/2017-August/029471.html P2 Normal --- 1 dbates webkit-unassigned andersca annulen darin jond oldest_to_newest 1343147 0 dbates 2017-08-29 10:52:49 -0700 <https://lists.webkit.org/pipermail/webkit-dev/2017-August/029471.html> 1343150 1 319261 dbates 2017-08-29 10:55:05 -0700 Created attachment 319261 Patch 1343151 2 319261 dbates 2017-08-29 10:57:20 -0700 Comment on attachment 319261 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319261&action=review > Websites/webkit.org/code-style.md:-763 > - : MySuperClass() We also prefer to omit calling the default base class constructor (as the compiler will emit code to do this for us). I did not change the example to reflect this. Let me know if I should. 1343159 3 319261 annulen 2017-08-29 11:19:06 -0700 Comment on attachment 319261 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319261&action=review >> Websites/webkit.org/code-style.md:-763 >> - : MySuperClass() > > We also prefer to omit calling the default base class constructor (as the compiler will emit code to do this for us). I did not change the example to reflect this. Let me know if I should. It may make sense to add arguments to base class ctor to avoid cofusion 1343292 4 319261 darin 2017-08-29 16:11:12 -0700 Comment on attachment 319261 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319261&action=review >>> Websites/webkit.org/code-style.md:-763 >>> - : MySuperClass() >> >> We also prefer to omit calling the default base class constructor (as the compiler will emit code to do this for us). I did not change the example to reflect this. Let me know if I should. > > It may make sense to add arguments to base class ctor to avoid cofusion I think we should. 1536727 5 dbates 2019-05-15 23:07:29 -0700 There appears to be no ❤️ to solidify this in the style guide. Makes me 😢. Maybe one day. Let's just move on. 319261 2017-08-29 10:55:05 -0700 2019-05-15 23:05:50 -0700 Patch bug-176058-20170829105505.patch text/plain 1849 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxMzA1CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDI1ZTU4 ZTU2MDU3YTI4NTZmM2I3MDkxY2VjOGYwMTQ5MzM3NWJiM2IuLmVkZjkwZjQzYjNhOTVjYjMzNTJh NmI4ZjQ5ZDIyNzQwMzQ0ZTIyNWYgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTctMDgtMjkgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAg ICAgIFtDb2RlIFN0eWxlXSBVc2UgdW5pZm9ybSBpbml0aWFsaXplciBzeW50YXggaW4gbWVtYmVy IGluaXRpYWxpemVyIGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NjA1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogY29kZS1zdHlsZS5tZDoKKwogMjAxNy0wOC0yMSAgUm9zcyBLaXJzbGluZyAg PHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgQWRkIFNvbnkgdG8gZG9tYWluIGFm ZmlsaWF0aW9ucyBvbiB0ZWFtIHBhZ2UKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcv Y29kZS1zdHlsZS5tZCBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kZS1zdHlsZS5tZAppbmRleCBk N2M4NjIyMWM0YmVmOGQ2Y2ZkN2Q5MTg1MTNhMjFjY2VlZmJlMTEyLi43YmE3NGZlZjY5N2U2NjY4 MmE1Mzg3Y2UxNDRlY2I0ZmI2ZGE4MTc2IDEwMDY0NAotLS0gYS9XZWJzaXRlcy93ZWJraXQub3Jn L2NvZGUtc3R5bGUubWQKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1kCkBA IC03NTQsMjAgKzc1NCwyMCBAQCBSZWZQdHI8V2lkZ2V0PiBwcm90ZWN0ZWQgPSB3aWRnZXQ7CiAK ICMjIyBPdGhlciBQdW5jdHVhdGlvbgogCi1bXSgjcHVuY3R1YXRpb24tbWVtYmVyLWluaXQpIENv bnN0cnVjdG9ycyBmb3IgQysrIGNsYXNzZXMgc2hvdWxkIGluaXRpYWxpemUgYWxsIG9mIHRoZWly IG1lbWJlcnMgdXNpbmcgQysrIGluaXRpYWxpemVyIHN5bnRheC4gRWFjaCBtZW1iZXIgKGFuZCBz dXBlcmNsYXNzKSBzaG91bGQgYmUgaW5kZW50ZWQgb24gYSBzZXBhcmF0ZSBsaW5lLCB3aXRoIHRo ZSBjb2xvbiBvciBjb21tYSBwcmVjZWRpbmcgdGhlIG1lbWJlciBvbiB0aGF0IGxpbmUuCitbXSgj cHVuY3R1YXRpb24tbWVtYmVyLWluaXQpIENvbnN0cnVjdG9ycyBmb3IgQysrIGNsYXNzZXMgc2hv dWxkIGluaXRpYWxpemUgYWxsIG9mIHRoZWlyIG1lbWJlcnMgdXNpbmcgYSBtZW1iZXIgaW5pdGlh bGl6ZXIgbGlzdCB3aXRoIHVuaWZvcm0gaW5pdGlhbGl6ZXIgc3ludGF4LiBFYWNoIG1lbWJlciAo YW5kIHN1cGVyY2xhc3MpIHNob3VsZCBiZSBpbmRlbnRlZCBvbiBhIHNlcGFyYXRlIGxpbmUsIHdp dGggdGhlIGNvbG9uIG9yIGNvbW1hIHByZWNlZGluZyB0aGUgbWVtYmVyIG9uIHRoYXQgbGluZS4K IAogIyMjIyMjIFJpZ2h0OgogCiBgYGBjcHAKIE15Q2xhc3M6Ok15Q2xhc3MoRG9jdW1lbnQqIGRv Y3VtZW50KQotICAgIDogTXlTdXBlckNsYXNzKCkKLSAgICAsIG1fbXlNZW1iZXIoMCkKLSAgICAs IG1fZG9jdW1lbnQoZG9jdW1lbnQpCisgICAgOiBNeVN1cGVyQ2xhc3MgeyB9CisgICAgLCBtX215 TWVtYmVyIHsgMCB9CisgICAgLCBtX2RvY3VtZW50IHsgZG9jdW1lbnQgfQogewogfQogCiBNeU90 aGVyQ2xhc3M6Ok15T3RoZXJDbGFzcygpCi0gICAgOiBNeVN1cGVyQ2xhc3MoKQorICAgIDogTXlT dXBlckNsYXNzIHsgfQogewogfQogYGBgCg==