175956 2017-08-24 14:55:19 -0700 Speedometer 2.0: Duplicate the current EmberJS test as EmberJS-Debug test 2017-08-25 14:22:27 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172339 175926 1 rniwa rniwa addyo buildbot cdumez fpizlo ggaren lforschler mathias saam webkit-bug-importer oldest_to_newest 1342177 0 rniwa 2017-08-24 14:55:19 -0700 In https://bugs.webkit.org/show_bug.cgi?id=175926, we found out that we weren't testing release build of Ember, and that release build of Ember is 3.5x-4x faster than debug build of Ember on Chrome/Safari. When we decided to use a release build of Ember instead of a debug build, we thought the difference was negligible due to an incorrect measurements we made in the past where we were basically testing the same debug builds twice. Since 4x difference indicates a debug build of Ember has a very different performance characteristics compared to a release build, we should keep the current version as EmberJS-Debug test. 1342180 1 319023 rniwa 2017-08-24 14:58:46 -0700 Created attachment 319023 Adds Ember-Debug-TodoMVC 1342183 2 rniwa 2017-08-24 15:00:03 -0700 Somehow the patch doesn't show the files I'm copying presumably because I directly used svn cp. Note that this is the current version of the test we have for Ember so there is no need for qualifications, comparisons between browsers, etc... 1342223 3 319023 saam 2017-08-24 16:13:45 -0700 Comment on attachment 319023 Adds Ember-Debug-TodoMVC r=me 1342523 4 rniwa 2017-08-25 14:21:37 -0700 Committed r221205: <http://trac.webkit.org/changeset/221205> 1342526 5 webkit-bug-importer 2017-08-25 14:22:27 -0700 <rdar://problem/34088816> 319023 2017-08-24 14:58:46 -0700 2017-08-24 16:13:45 -0700 Adds Ember-Debug-TodoMVC bug-175956-20170824145845.patch text/plain 2622 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjExNjMpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA4LTI0ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogRHVwbGljYXRlIHRoZSBjdXJyZW50IEVtYmVySlMgdGVzdCBhcyBFbWJlckpTLURlYnVnIHRl c3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTk1 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hZGUg dGhlIGNvcHkgb2YgRW1iZXIuanMgZGlyZWN0b3J5IGF0IHIyMTY5NDYgYXMgZW1iZXJqcy1kZWJ1 ZywgYW5kIGFkZGVkIGEgbmV3IHRlc3Qgc3VpdGUgIkVtYmVySlMtRGVidWctVG9kb01WQyIuIAor CisgICAgICAgICogU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3Rlc3RzLmpzOgorICAgICAgICAoU3Vp dGVzLnB1c2gucHJlcGFyZSk6CisgICAgICAgICogU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL3RvZG9t dmMvYXJjaGl0ZWN0dXJlLWV4YW1wbGVzL2VtYmVyanMtZGVidWc6IENvcGllZCBmcm9tIGVtYmVy anNAcjIxNjk0Ni4KKwogMjAxNy0wOC0yMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBTcGVlZG9tZXRlcjogQWRkIG1pc3Npbmcgc3R5bGVzaGVldCB0byBBbmd1 bGFyIGV4YW1wbGUKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2Vz L3Rlc3RzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVz b3VyY2VzL3Rlc3RzLmpzCShyZXZpc2lvbiAyMjExNjEpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1Nw ZWVkb21ldGVyL3Jlc291cmNlcy90ZXN0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtMTk0LDYgKzE5 NCwzNSBAQCBTdWl0ZXMucHVzaCh7CiB9KTsKIAogU3VpdGVzLnB1c2goeworICAgIG5hbWU6ICdF bWJlckpTLURlYnVnLVRvZG9NVkMnLAorICAgIHVybDogJ3RvZG9tdmMvYXJjaGl0ZWN0dXJlLWV4 YW1wbGVzL2VtYmVyanMtZGVidWcvaW5kZXguaHRtbCcsCisgICAgcHJlcGFyZTogZnVuY3Rpb24g KHJ1bm5lciwgY29udGVudFdpbmRvdywgY29udGVudERvY3VtZW50KSB7CisgICAgICAgIHJldHVy biBydW5uZXIud2FpdEZvckVsZW1lbnQoJyNuZXctdG9kbycpLnRoZW4oZnVuY3Rpb24gKGVsZW1l bnQpIHsKKyAgICAgICAgICAgIGVsZW1lbnQuZm9jdXMoKTsKKyAgICAgICAgICAgIHJldHVybiBl bGVtZW50OworICAgICAgICB9KTsKKyAgICB9LAorICAgIHRlc3RzOiBbCisgICAgICAgIG5ldyBC ZW5jaG1hcmtUZXN0U3RlcCgnQWRkaW5nJyArIG51bWJlck9mSXRlbXNUb0FkZCArICdJdGVtcycs IGZ1bmN0aW9uIChuZXdUb2RvLCBjb250ZW50V2luZG93LCBjb250ZW50RG9jdW1lbnQpIHsKKyAg ICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbnVtYmVyT2ZJdGVtc1RvQWRkOyBpKyspIHsK KyAgICAgICAgICAgICAgICBuZXdUb2RvLnZhbHVlID0gJ1NvbWV0aGluZyB0byBkbyAnICsgaTsK KyAgICAgICAgICAgICAgICB0cmlnZ2VyRW50ZXIobmV3VG9kbywgJ2tleWRvd24nKTsKKyAgICAg ICAgICAgIH0KKyAgICAgICAgfSksCisgICAgICAgIG5ldyBCZW5jaG1hcmtUZXN0U3RlcCgnQ29t cGxldGluZ0FsbEl0ZW1zJywgZnVuY3Rpb24gKHBhcmFtcywgY29udGVudFdpbmRvdywgY29udGVu dERvY3VtZW50KSB7CisgICAgICAgICAgICB2YXIgY2hlY2tib3hlcyA9IGNvbnRlbnREb2N1bWVu dC5xdWVyeVNlbGVjdG9yQWxsKCcudG9nZ2xlJyk7CisgICAgICAgICAgICBmb3IgKHZhciBpID0g MDsgaSA8IGNoZWNrYm94ZXMubGVuZ3RoOyBpKyspCisgICAgICAgICAgICAgICAgY2hlY2tib3hl c1tpXS5jbGljaygpOworICAgICAgICB9KSwKKyAgICAgICAgbmV3IEJlbmNobWFya1Rlc3RTdGVw KCdEZWxldGluZ0l0ZW1zJywgZnVuY3Rpb24gKHBhcmFtcywgY29udGVudFdpbmRvdywgY29udGVu dERvY3VtZW50KSB7CisgICAgICAgICAgICB2YXIgZGVsZXRlQnV0dG9ucyA9IGNvbnRlbnREb2N1 bWVudC5xdWVyeVNlbGVjdG9yQWxsKCcuZGVzdHJveScpOworICAgICAgICAgICAgZm9yICh2YXIg aSA9IDA7IGkgPCBkZWxldGVCdXR0b25zLmxlbmd0aDsgaSsrKQorICAgICAgICAgICAgICAgIGRl bGV0ZUJ1dHRvbnNbaV0uY2xpY2soKTsKKyAgICAgICAgfSksCisgICAgXQorfSk7CisKK1N1aXRl cy5wdXNoKHsKICAgICBuYW1lOiAnQmFja2JvbmVKUy1Ub2RvTVZDJywKICAgICB1cmw6ICd0b2Rv bXZjL2FyY2hpdGVjdHVyZS1leGFtcGxlcy9iYWNrYm9uZS9pbmRleC5odG1sJywKICAgICBwcmVw YXJlOiBmdW5jdGlvbiAocnVubmVyLCBjb250ZW50V2luZG93LCBjb250ZW50RG9jdW1lbnQpIHsK