175908 2017-08-23 14:56:20 -0700 Speedometer 2.0: Add the capability to run a specific suite 2017-08-23 17:00:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172339 1 rniwa rniwa buildbot cdumez joepeck lforschler saam webkit-bug-importer oldest_to_newest 1341806 0 rniwa 2017-08-23 14:56:20 -0700 Add the capability to run a specific test suite to Speedometer's main test runner. 1341812 1 318926 rniwa 2017-08-23 15:12:20 -0700 Created attachment 318926 Adds the feature 1341814 2 318928 rniwa 2017-08-23 15:13:19 -0700 Created attachment 318928 Updated change log 1341841 3 rniwa 2017-08-23 16:04:15 -0700 Committed r221114: <http://trac.webkit.org/changeset/221114> 1341842 4 webkit-bug-importer 2017-08-23 16:04:49 -0700 <rdar://problem/34046669> 1341848 5 318928 joepeck 2017-08-23 16:12:40 -0700 Comment on attachment 318928 Updated change log View in context: https://bugs.webkit.org/attachment.cgi?id=318928&action=review > PerformanceTests/Speedometer/resources/main.js:160 > + if (currentSuite.name.toLowerCase() == suiteToEnable) { > + currentSuite.disabled = false; > + found = true; Can there be duplicate names? If not, then you can `return true` here instead of continuing to loop. > PerformanceTests/Speedometer/resources/main.js:168 > + var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; }); This seems to be a duplicate of line 200 with no change between now and then. Seems this line can be removed. > PerformanceTests/Speedometer/resources/main.js:192 > + alert('No tests to run'); This might be more useful to include the name of the one test that no longer exists: alert('Suite "' + value + '" does not exist. No tests to run.'); 1341882 6 rniwa 2017-08-23 17:00:10 -0700 (In reply to Joseph Pecoraro from comment #5) > Comment on attachment 318928 [details] > Updated change log > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318928&action=review > > > PerformanceTests/Speedometer/resources/main.js:160 > > + if (currentSuite.name.toLowerCase() == suiteToEnable) { > > + currentSuite.disabled = false; > > + found = true; > > Can there be duplicate names? If not, then you can `return true` here > instead of continuing to loop. No, but we still have to set currentSuite.disabled to true in all other suite objects. > > PerformanceTests/Speedometer/resources/main.js:168 > > + var enabledSuites = Suites.filter(function (suite) { return !suite.disabled; }); > > This seems to be a duplicate of line 200 with no change between now and > then. Seems this line can be removed. Oops, removed. > > PerformanceTests/Speedometer/resources/main.js:192 > > + alert('No tests to run'); > > This might be more useful to include the name of the one test that no longer > exists: > > alert('Suite "' + value + '" does not exist. No tests to run.'); Fixed. 1341883 7 rniwa 2017-08-23 17:00:57 -0700 https://trac.webkit.org/changeset/221118 318926 2017-08-23 15:12:20 -0700 2017-08-23 15:13:18 -0700 Adds the feature bug-175908-20170823151219.patch text/plain 3058 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjExMDgpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA4LTIzICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogQWRkIHRoZSBjYXBhYmlsaXR5IHRvIHJ1biBhIHNwZWNpZmljIHN1aXRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU5MDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCA/c3VpdGU9WCBxdWVy eSBwYXJhbWV0ZXIgdG8gc3BlY2lmeSBhIHNwZWNpZmljIHN1aXRlIChlLmcuIFJlYWN0LVRvZG9N VkMpIHRvIHJ1bi4KKworICAgICAgICAqIFNwZWVkb21ldGVyL3Jlc291cmNlcy9tYWluLmpzOgor ICAgICAgICAoZW5hYmxlT25lU3VpdGUpOiBBZGRlZC4KKyAgICAgICAgKHN0YXJ0QmVuY2htYXJr KToKKyAgICAgICAgKHN0YXJ0VGVzdCk6CisKIDIwMTctMDgtMjMgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3BlZWRvbWV0ZXIgMi4wOiBBc3luYyB0aW1lIGlz IG5vdCBhbHdheXMgY2FwdHVyaW5nIGxheW91dCB0aW1lCkluZGV4OiBQZXJmb3JtYW5jZVRlc3Rz L1NwZWVkb21ldGVyL3Jlc291cmNlcy9tYWluLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNl VGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL21haW4uanMJKHJldmlzaW9uIDIyMTEwNykKKysr IFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL21haW4uanMJKHdvcmtpbmcg Y29weSkKQEAgLTE0OSw3ICsxNDksMjQgQEAgd2luZG93LmJlbmNobWFya0NsaWVudCA9IHsKICAg ICB9CiB9CiAKK2Z1bmN0aW9uIGVuYWJsZU9uZVN1aXRlKHN1aXRlcywgc3VpdGVUb0VuYWJsZSkK K3sKKyAgICBzdWl0ZVRvRW5hYmxlID0gc3VpdGVUb0VuYWJsZS50b0xvd2VyQ2FzZSgpOworICAg IHZhciBmb3VuZCA9IGZhbHNlOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgc3VpdGVzLmxlbmd0 aDsgaSsrKSB7CisgICAgICAgIHZhciBjdXJyZW50U3VpdGUgPSBzdWl0ZXNbaV07CisgICAgICAg IGlmIChjdXJyZW50U3VpdGUubmFtZS50b0xvd2VyQ2FzZSgpID09IHN1aXRlVG9FbmFibGUpIHsK KyAgICAgICAgICAgIGN1cnJlbnRTdWl0ZS5kaXNhYmxlZCA9IGZhbHNlOworICAgICAgICAgICAg Zm91bmQgPSB0cnVlOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIGN1cnJlbnRTdWl0ZS5k aXNhYmxlZCA9IHRydWU7CisgICAgfQorICAgIHJldHVybiBmb3VuZDsKK30KKwogZnVuY3Rpb24g c3RhcnRCZW5jaG1hcmsoKSB7CisgICAgdmFyIGVuYWJsZWRTdWl0ZXMgPSBTdWl0ZXMuZmlsdGVy KGZ1bmN0aW9uIChzdWl0ZSkgeyByZXR1cm4gIXN1aXRlLmRpc2FibGVkOyB9KTsKKwogICAgIGlm IChsb2NhdGlvbi5zZWFyY2gubGVuZ3RoID4gMSkgewogICAgICAgICB2YXIgcGFydHMgPSBsb2Nh dGlvbi5zZWFyY2guc3Vic3RyaW5nKDEpLnNwbGl0KCcmJyk7CiAgICAgICAgIGZvciAodmFyIGkg PSAwOyBpIDwgcGFydHMubGVuZ3RoOyBpKyspIHsKQEAgLTE3MCwxNiArMTg3LDI0IEBAIGZ1bmN0 aW9uIHN0YXJ0QmVuY2htYXJrKCkgewogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAg ICAgICAgICAgY29uc29sZS5lcnJvcignSW52YWxpZCBpdGVyYXRpb24gY291bnQ6ICcgKyB2YWx1 ZSk7CiAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlICdzdWl0ZSc6Cisg ICAgICAgICAgICAgICAgaWYgKCFlbmFibGVPbmVTdWl0ZShTdWl0ZXMsIHZhbHVlKSkgeworICAg ICAgICAgICAgICAgICAgICBhbGVydCgnTm8gdGVzdHMgdG8gcnVuJyk7CisgICAgICAgICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9CiAKLSAgICB2YXIgZW5hYmxl ZFN1aXRlcyA9IFN1aXRlcy5maWx0ZXIoZnVuY3Rpb24gKHN1aXRlKSB7IHJldHVybiAhc3VpdGUu ZGlzYWJsZWQgfSk7CisgICAgdmFyIGVuYWJsZWRTdWl0ZXMgPSBTdWl0ZXMuZmlsdGVyKGZ1bmN0 aW9uIChzdWl0ZSkgeyByZXR1cm4gIXN1aXRlLmRpc2FibGVkOyB9KTsKICAgICB2YXIgdG90YWxT dWJ0ZXN0Q291bnQgPSBlbmFibGVkU3VpdGVzLnJlZHVjZShmdW5jdGlvbiAodGVzdHNDb3VudCwg c3VpdGUpIHsgcmV0dXJuIHRlc3RzQ291bnQgKyBzdWl0ZS50ZXN0cy5sZW5ndGg7IH0sIDApOwog ICAgIGJlbmNobWFya0NsaWVudC50ZXN0c0NvdW50ID0gYmVuY2htYXJrQ2xpZW50Lml0ZXJhdGlv bkNvdW50ICogdG90YWxTdWJ0ZXN0Q291bnQ7CiAgICAgYmVuY2htYXJrQ2xpZW50LnN1aXRlc0Nv dW50ID0gZW5hYmxlZFN1aXRlcy5sZW5ndGg7CiAgICAgdmFyIHJ1bm5lciA9IG5ldyBCZW5jaG1h cmtSdW5uZXIoU3VpdGVzLCBiZW5jaG1hcmtDbGllbnQpOwogICAgIHJ1bm5lci5ydW5NdWx0aXBs ZUl0ZXJhdGlvbnMoYmVuY2htYXJrQ2xpZW50Lml0ZXJhdGlvbkNvdW50KTsKKworICAgIHJldHVy biB0cnVlOwogfQogCiBmdW5jdGlvbiBjb21wdXRlU2NvcmUodGltZSkgewpAQCAtMjA1LDggKzIz MCw4IEBAIGZ1bmN0aW9uIHNob3dIb21lKCkgewogfQogCiBmdW5jdGlvbiBzdGFydFRlc3QoKSB7 Ci0gICAgc2hvd1NlY3Rpb24oJ3J1bm5pbmcnKTsKLSAgICBzdGFydEJlbmNobWFyaygpOworICAg IGlmIChzdGFydEJlbmNobWFyaygpKQorICAgICAgICBzaG93U2VjdGlvbigncnVubmluZycpOwog fQogCiBmdW5jdGlvbiBzaG93UmVzdWx0c1N1bW1hcnkoKSB7Cg== 318928 2017-08-23 15:13:19 -0700 2017-08-23 15:59:13 -0700 Updated change log bug-175908-20170823151318.patch text/plain 3214 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjExMDgpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA4LTIzICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogQWRkIHRoZSBjYXBhYmlsaXR5IHRvIHJ1biBhIHNwZWNpZmljIHN1aXRlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU5MDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCA/c3VpdGU9WCBxdWVy eSBwYXJhbWV0ZXIgdG8gc3BlY2lmeSBhIHNwZWNpZmljIHN1aXRlIChlLmcuIFJlYWN0LVRvZG9N VkMpIHRvIHJ1bi4KKworICAgICAgICAqIFNwZWVkb21ldGVyL3Jlc291cmNlcy9tYWluLmpzOgor ICAgICAgICAoZW5hYmxlT25lU3VpdGUpOiBBZGRlZC4KKyAgICAgICAgKHN0YXJ0QmVuY2htYXJr KTogUmV0dXJuIHRydWUgaWYgdGhlIGJlbmNobWFyayBhY3R1YWxseSBoYWQgc3RhcnRlZCBydW5u aW5nLgorICAgICAgICAoc3RhcnRUZXN0KTogRG9uJ3QgdHJhbnNpdGlvbiB0byB0aGUgInJ1bm5p bmciIHN0YXRlIGlmIHRoZSBiZW5jaG1hcmsgZmFpbGVkIHRvIHN0YXJ0IChlLmcuIG5vIHRlc3Rz IHRvIHJ1bikuCisKIDIwMTctMDgtMjMgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgU3BlZWRvbWV0ZXIgMi4wOiBBc3luYyB0aW1lIGlzIG5vdCBhbHdheXMgY2Fw dHVyaW5nIGxheW91dCB0aW1lCkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jl c291cmNlcy9tYWluLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0 ZXIvcmVzb3VyY2VzL21haW4uanMJKHJldmlzaW9uIDIyMTEwNykKKysrIFBlcmZvcm1hbmNlVGVz dHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL21haW4uanMJKHdvcmtpbmcgY29weSkKQEAgLTE0OSw3 ICsxNDksMjQgQEAgd2luZG93LmJlbmNobWFya0NsaWVudCA9IHsKICAgICB9CiB9CiAKK2Z1bmN0 aW9uIGVuYWJsZU9uZVN1aXRlKHN1aXRlcywgc3VpdGVUb0VuYWJsZSkKK3sKKyAgICBzdWl0ZVRv RW5hYmxlID0gc3VpdGVUb0VuYWJsZS50b0xvd2VyQ2FzZSgpOworICAgIHZhciBmb3VuZCA9IGZh bHNlOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgc3VpdGVzLmxlbmd0aDsgaSsrKSB7CisgICAg ICAgIHZhciBjdXJyZW50U3VpdGUgPSBzdWl0ZXNbaV07CisgICAgICAgIGlmIChjdXJyZW50U3Vp dGUubmFtZS50b0xvd2VyQ2FzZSgpID09IHN1aXRlVG9FbmFibGUpIHsKKyAgICAgICAgICAgIGN1 cnJlbnRTdWl0ZS5kaXNhYmxlZCA9IGZhbHNlOworICAgICAgICAgICAgZm91bmQgPSB0cnVlOwor ICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIGN1cnJlbnRTdWl0ZS5kaXNhYmxlZCA9IHRydWU7 CisgICAgfQorICAgIHJldHVybiBmb3VuZDsKK30KKwogZnVuY3Rpb24gc3RhcnRCZW5jaG1hcmso KSB7CisgICAgdmFyIGVuYWJsZWRTdWl0ZXMgPSBTdWl0ZXMuZmlsdGVyKGZ1bmN0aW9uIChzdWl0 ZSkgeyByZXR1cm4gIXN1aXRlLmRpc2FibGVkOyB9KTsKKwogICAgIGlmIChsb2NhdGlvbi5zZWFy Y2gubGVuZ3RoID4gMSkgewogICAgICAgICB2YXIgcGFydHMgPSBsb2NhdGlvbi5zZWFyY2guc3Vi c3RyaW5nKDEpLnNwbGl0KCcmJyk7CiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcGFydHMu bGVuZ3RoOyBpKyspIHsKQEAgLTE3MCwxNiArMTg3LDI0IEBAIGZ1bmN0aW9uIHN0YXJ0QmVuY2ht YXJrKCkgewogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgY29uc29s ZS5lcnJvcignSW52YWxpZCBpdGVyYXRpb24gY291bnQ6ICcgKyB2YWx1ZSk7CiAgICAgICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgICAgICBjYXNlICdzdWl0ZSc6CisgICAgICAgICAgICAgICAg aWYgKCFlbmFibGVPbmVTdWl0ZShTdWl0ZXMsIHZhbHVlKSkgeworICAgICAgICAgICAgICAgICAg ICBhbGVydCgnTm8gdGVzdHMgdG8gcnVuJyk7CisgICAgICAgICAgICAgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0KICAgICB9CiAKLSAgICB2YXIgZW5hYmxlZFN1aXRlcyA9IFN1aXRl cy5maWx0ZXIoZnVuY3Rpb24gKHN1aXRlKSB7IHJldHVybiAhc3VpdGUuZGlzYWJsZWQgfSk7Cisg ICAgdmFyIGVuYWJsZWRTdWl0ZXMgPSBTdWl0ZXMuZmlsdGVyKGZ1bmN0aW9uIChzdWl0ZSkgeyBy ZXR1cm4gIXN1aXRlLmRpc2FibGVkOyB9KTsKICAgICB2YXIgdG90YWxTdWJ0ZXN0Q291bnQgPSBl bmFibGVkU3VpdGVzLnJlZHVjZShmdW5jdGlvbiAodGVzdHNDb3VudCwgc3VpdGUpIHsgcmV0dXJu IHRlc3RzQ291bnQgKyBzdWl0ZS50ZXN0cy5sZW5ndGg7IH0sIDApOwogICAgIGJlbmNobWFya0Ns aWVudC50ZXN0c0NvdW50ID0gYmVuY2htYXJrQ2xpZW50Lml0ZXJhdGlvbkNvdW50ICogdG90YWxT dWJ0ZXN0Q291bnQ7CiAgICAgYmVuY2htYXJrQ2xpZW50LnN1aXRlc0NvdW50ID0gZW5hYmxlZFN1 aXRlcy5sZW5ndGg7CiAgICAgdmFyIHJ1bm5lciA9IG5ldyBCZW5jaG1hcmtSdW5uZXIoU3VpdGVz LCBiZW5jaG1hcmtDbGllbnQpOwogICAgIHJ1bm5lci5ydW5NdWx0aXBsZUl0ZXJhdGlvbnMoYmVu Y2htYXJrQ2xpZW50Lml0ZXJhdGlvbkNvdW50KTsKKworICAgIHJldHVybiB0cnVlOwogfQogCiBm dW5jdGlvbiBjb21wdXRlU2NvcmUodGltZSkgewpAQCAtMjA1LDggKzIzMCw4IEBAIGZ1bmN0aW9u IHNob3dIb21lKCkgewogfQogCiBmdW5jdGlvbiBzdGFydFRlc3QoKSB7Ci0gICAgc2hvd1NlY3Rp b24oJ3J1bm5pbmcnKTsKLSAgICBzdGFydEJlbmNobWFyaygpOworICAgIGlmIChzdGFydEJlbmNo bWFyaygpKQorICAgICAgICBzaG93U2VjdGlvbigncnVubmluZycpOwogfQogCiBmdW5jdGlvbiBz aG93UmVzdWx0c1N1bW1hcnkoKSB7Cg==