175871 2017-08-22 20:33:02 -0700 Speedometer 2.0: Async time is not always capturing layout time 2017-08-23 14:43:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172339 1 rniwa rniwa addyo cdumez fpizlo ggaren jonlee kling koivisto lforschler mathias saam simon.fraser webkit-bug-importer oldest_to_newest 1341437 0 rniwa 2017-08-22 20:33:02 -0700 In some browsers, layout & paint happens in accordance with vsync / rAF. This means that async time doesn't always capture the time to update the layout. Work around this limitation by manually forcing the layout in async time measurement. 1341446 1 318851 rniwa 2017-08-22 21:16:17 -0700 Created attachment 318851 Improves the harness 1341452 2 rniwa 2017-08-22 21:59:51 -0700 There's no measurable difference in the total score. ==Before== Safari 117.0 118.3 115.7 Chrome 113.7 112.3 113.2 Firefox 79.91 78.17 79.60 ==After== Safari 116.7 117.9 118.4 Chrome 112.7 112.4 113.4 Firefox 79.39 79.68 79.10 1341793 3 318851 rniwa 2017-08-23 14:40:43 -0700 Comment on attachment 318851 Improves the harness Clearing flags on attachment: 318851 Committed r221106: <http://trac.webkit.org/changeset/221106> 1341794 4 rniwa 2017-08-23 14:40:45 -0700 All reviewed patches have been landed. Closing bug. 1341797 5 webkit-bug-importer 2017-08-23 14:43:57 -0700 <rdar://problem/34044521> 318851 2017-08-22 21:16:17 -0700 2017-08-23 14:40:43 -0700 Improves the harness bug-175871-20170822211616.patch text/plain 3396 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjEwNjUpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDE3LTA4LTIyICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogQXN5bmMgdGltZSBpcyBub3QgYWx3YXlzIGNhcHR1cmluZyBsYXlvdXQgdGltZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1ODcxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3BlZWRvbWV0ZXIgaGFy bmVzcyB3YXMgZGVzaWduZWQgdG8gY2FwdHVyZSB0aGUgdGltZSBicm93c2VyIGVuZ2luZSBzcGVu ZHMgcmVsYXlvdXRpbmcgYW5kIHJlcGFpbnRpbmcgdGhlIGNvbnRlbnQKKyAgICAgICAgYWZ0ZXIg RE9NIG11dGF0aW9ucyB0aGlzIGluIGl0cyBhc3luYyB0aW1lIG1lYXN1cmVtZW50LCB3aGljaCBp cyB0aGUgdGltZSBiZXR3ZWVuIGVhY2ggdGVzdCBjYXNlJ3MgY29kZSBoYWQgZmluaXNoZWQKKyAg ICAgICAgcnVubmluZyBhbmQgd2hlbiBhIG5ld2x5IHNjaGVkdWxlZCAwcyB0aW1lciBpcyBmaXJl ZCBpbW1lZGlhdGVseSBhZnRlcndhcmRzLgorCisgICAgICAgIEl0IHR1cm5zIG91dCB0aGF0IG1v ZGVybiB3ZWIgYnJvd3NlcnMgZGVmZXIgdGhpcyByZWZsb3cgYW5kIHJlcGFpbnQgd29yayB1bnRp bCB0aGUgbmV4dCBhbmltYXRpb24gZnJhbWUgaXMgcmVxdWVzdGVkLgorICAgICAgICBUaGlzIHJl c3VsdHMgaW4gU3BlZWRvbWV0ZXIgaGFybmVzcyBtZWFzdXJpbmcgcmVmbG93IGFuZCByZXBhaW50 IGNvc3Qgb25seSBzb21ldGltZXMgZGVwZW5kaW5nIG9uIHdoZW4gZWFjaCB0ZXN0IGNhc2UKKyAg ICAgICAgaGFkIGZpbmlzaGVkIHJ1bm5pbmcgcmVsYXRpdmUgdG8gdGhlIG5leHQgZnJhbWUgcmVx dWVzdC4KKworICAgICAgICBXaGlsZSBzdWNoIGEgYmVoYXZpb3IgbWFrZXMgc2Vuc2UgYW5kIG1p Z2h0IGJlIGRlc2lyYWJsZSBmb3IgYSBtb2Rlcm4gYnJvd3NlciBlbmdpbmUsIHdlIHdvdWxkIGxp a2UgdG8gY2FwdHVyZSBpdCBpbgorICAgICAgICB0aGUgYXN5bmMgdGltZSBmb3IgdGhlIHB1cnBv c2Ugb2YgU3BlZWRvbWV0ZXIuIFVuZm9ydHVuYXRlbHksIHRoZXJlIGlzbid0IGFuIGludGVyb3Bl cmFibGUgQVBJIGZvciBicm93c2VycyB0byByZXBvcnQKKyAgICAgICAgdGhlIHRvdGFsIGxheW91 dCBhbmQgcmVwYWludCB0aW1lLCBhbmQgcmVseWluZyBvbiAxNm1zLWdyYW51bGFyaXR5IHJlcXVl c3RBbmltYXRpb25GcmFtZSBpcyB0b28gY29hcnNlIGZvciBTcGVlZG9tZXRlci4KKworICAgICAg ICBUaGlzIHBhdGNoIHdvcmtzIGFyb3VuZCB0aGVzZSBsaW1pdGF0aW9ucyBieSBtYW51YWxseSBm b3JjaW5nIHRoZSBsYXlvdXQgaW4gYXN5bmMgdGltZSBtZWFzdXJlbWVudCBieSBjYWxsaW5nCisg ICAgICAgIGdldEJvdW5kaW5nQ2xpZW50UmVjdCgpIGluIGlmcmFtZSdzIGRvY3VtZW50LiBTaW5j ZSB0aGUgaGVpZ2h0IG9mIHRoZSBkb2N1bWVudCBkZXBlbmRzIG9uIHRoZSBudW1iZXIgb2YgdG9k byBpdGVtcywKKyAgICAgICAgdGhpcyBzaG91bGQgY2F1c2UgYnJvd3NlciBlbmdpbmVzIHRvIGRv IG1vc3QgaWYgbm90IGFsbCBvZiB0aGUgd29yayBuZWVkZWQgdG8gcmVmbG93IHRoZSBkb2N1bWVu dCBhdCBsZWFzdCBmb3Igbm93LgorCisgICAgICAgIE5vdGUgdGhhdCBldmVuIG5ldyBhc3luYyB0 aW1lIGRvZXNuJ3QgYWx3YXlzIGNhcHR1cmUgcGFpbnRpbmcgdGltZSBidXQgdGhlcmUgaXNuJ3Qg YSBnb29kIGNyb3NzLWJyb3dzZXIgbWVjaGFuaXNtCisgICAgICAgIHRvIG1lYXN1cmUgcGFpbnQg dGltZSBpbiB0aGUgZ3JhbnVyYWxpdHkgd2UgbmVlZCBmb3IgU3BlZWRvbWV0ZXIgYXQgdGhlIG1v bWVudCBhbnl3YXkuIChTaG91bGQgc3VjaCBhIG1lY2hhbmlzbSBleGlzdCwKKyAgICAgICAgdGhh dCBjb3VsZCBiZSBhIGh1Z2UgdGltaW5nIGF0dGFjayBzdXJmYWNlIHNvIGl0J3MgcHJvYmFibHkg YmVzdCB0aGF0IHdlIGRvbid0IGhhdmUgb25lLikKKworICAgICAgICAqIFNwZWVkb21ldGVyL3Jl c291cmNlcy9iZW5jaG1hcmstcnVubmVyLmpzOgorICAgICAgICAoQmVuY2htYXJrUnVubmVyLnBy b3RvdHlwZS5fcnVuVGVzdCk6CisKIDIwMTctMDgtMjIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihSMjIwMDQzKTogU3BlZWRvbWV0ZXIgMi4w OiBGaXggdmFuaWxsYSBKUyBleGFtcGxlcwpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9t ZXRlci9yZXNvdXJjZXMvYmVuY2htYXJrLXJ1bm5lci5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3Jt YW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy9iZW5jaG1hcmstcnVubmVyLmpzCShyZXZp c2lvbiAyMjEwNjIpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy9i ZW5jaG1hcmstcnVubmVyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xMzYsOSArMTM2LDEzIEBAIEJl bmNobWFya1J1bm5lci5wcm90b3R5cGUuX3J1blRlc3QgPSBmdW4KIAogICAgIHZhciBzdGFydFRp bWUgPSBub3coKTsKICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uICgpIHsKKyAgICAgICAgLy8gU29t ZSBicm93c2VycyBkb24ndCBpbW1lZGlhdGVseSB1cGRhdGUgdGhlIGxheW91dCBmb3IgcGFpbnQu CisgICAgICAgIC8vIEZvcmNlIHRoZSBsYXlvdXQgaGVyZSB0byBlbnN1cmUgd2UncmUgbWVhc3Vy aW5nIHRoZSBsYXlvdXQgdGltZS4KKyAgICAgICAgdmFyIGhlaWdodCA9IHNlbGYuX2ZyYW1lLmNv bnRlbnREb2N1bWVudC5ib2R5LmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLmhlaWdodDsKICAgICAg ICAgdmFyIGVuZFRpbWUgPSBub3coKTsKKyAgICAgICAgc2VsZi5fZnJhbWUuY29udGVudFdpbmRv dy5fdW51c2VkSGVpZ2h0VmFsdWUgPSBoZWlnaHQ7IC8vIFByZXZlbnQgZGVhZCBjb2RlIGVsaW1p bmF0aW9uLgogICAgICAgICBzZWxmLl93cml0ZU1hcmsoc3VpdGUubmFtZSArICcuJyArIHRlc3Qu bmFtZSArICctYXN5bmMtZW5kJyk7Ci0gICAgICAgIGNhbGxiYWNrKHN5bmNUaW1lLCBlbmRUaW1l IC0gc3RhcnRUaW1lKTsKKyAgICAgICAgY2FsbGJhY2soc3luY1RpbWUsIGVuZFRpbWUgLSBzdGFy dFRpbWUsIGhlaWdodCk7CiAgICAgfSwgMCk7CiB9CiAK