175816 2017-08-22 01:02:14 -0700 Speedometer 2.0: Add button to select and unselect all tests to InteractiveRunner.html 2017-08-22 13:43:34 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172339 1 rniwa rniwa addyo cdumez ggaren joepeck keith_miller lforschler mathias saam webkit-bug-importer oldest_to_newest 1340986 0 rniwa 2017-08-22 01:02:14 -0700 Now that we have doubled the number of test cases in Speedometer, we should have buttons to quickly select & unselect all test cases. 1340988 1 318745 rniwa 2017-08-22 01:07:29 -0700 Created attachment 318745 Adds the buttons 1340989 2 318746 rniwa 2017-08-22 01:08:21 -0700 Created attachment 318746 Removed superfluous newline 1341057 3 318746 saam 2017-08-22 08:29:19 -0700 Comment on attachment 318746 Removed superfluous newline View in context: https://bugs.webkit.org/attachment.cgi?id=318746&action=review r=me > PerformanceTests/Speedometer/InteractiveRunner.html:77 > + for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { For of? > PerformanceTests/Speedometer/InteractiveRunner.html:87 > + for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { Ditto 1341226 4 rniwa 2017-08-22 13:40:20 -0700 (In reply to Saam Barati from comment #3) > Comment on attachment 318746 [details] > Removed superfluous newline > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318746&action=review > > r=me > > > PerformanceTests/Speedometer/InteractiveRunner.html:77 > > + for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { > > For of? No, we don't want the runner code to require ES2015. We occasionally run the latest version of Speedometer in very old versions of Safari for validation purposes. See https://bugs.webkit.org/show_bug.cgi?id=172439 for example in which I ran trunk Speedometer on Safari 7. > > > PerformanceTests/Speedometer/InteractiveRunner.html:87 > > + for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { > > Ditto Ditto. 1341227 5 rniwa 2017-08-22 13:42:26 -0700 Committed r221039: <http://trac.webkit.org/changeset/221039> 1341228 6 webkit-bug-importer 2017-08-22 13:43:34 -0700 <rdar://problem/34020295> 318745 2017-08-22 01:07:29 -0700 2017-08-22 01:08:19 -0700 Adds the buttons bug-175816-20170822010727.patch text/plain 2094 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjEwMDUpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTIyICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogQWRkIGJ1dHRvbiB0byBzZWxlY3QgYW5kIHVuc2VsZWN0IGFsbCB0ZXN0cyB0byBJbnRlcmFj dGl2ZVJ1bm5lci5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzU4MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBidXR0b25zIHRvIHNlbGVjdCBhbmQgdW5zZWxlY3QgYWxsIHN1YnRlc3Rz IHRvIGFpZCBkZWJ1Z2dpbmcuCisKKyAgICAgICAgKiBTcGVlZG9tZXRlci9JbnRlcmFjdGl2ZVJ1 bm5lci5odG1sOgorICAgICAgICAoY3JlYXRlVUlGb3JTdWl0ZXMpOgorCiAyMDE3LTA4LTE4ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIx OTY0MCk6IFNwZWVkb21ldGVyIG5vIGxvbmdlciBydW5zIG9uIFNhZmFyaSA3CkluZGV4OiBQZXJm b3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL0ludGVyYWN0aXZlUnVubmVyLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci9JbnRlcmFjdGl2ZVJ1bm5lci5odG1s CShyZXZpc2lvbiAyMjEwMDEpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL0ludGVy YWN0aXZlUnVubmVyLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTYwLDYgKzYwLDcgQEAgZnVuY3Rp b24gY3JlYXRlVUlGb3JTdWl0ZXMoc3VpdGVzLCBvbnN0ZQogCiAgICAgY29udHJvbC5hcHBlbmRD aGlsZChvbCk7CiAKKwogICAgIHZhciBidXR0b24gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdi dXR0b24nKTsKICAgICBidXR0b24udGV4dENvbnRlbnQgPSAnU3RlcCc7CiAgICAgYnV0dG9uLm9u Y2xpY2sgPSBvbnN0ZXA7CkBAIC03MSw2ICs3MiwyNyBAQCBmdW5jdGlvbiBjcmVhdGVVSUZvclN1 aXRlcyhzdWl0ZXMsIG9uc3RlCiAgICAgYnV0dG9uLm9uY2xpY2sgPSBvbnJ1bjsKICAgICBjb250 cm9sLmFwcGVuZENoaWxkKGJ1dHRvbik7CiAKKyAgICB2YXIgYnV0dG9uID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgnYnV0dG9uJyk7CisgICAgYnV0dG9uLnRleHRDb250ZW50ID0gJ1NlbGVjdCBh bGwnOworICAgIGJ1dHRvbi5vbmNsaWNrID0gZnVuY3Rpb24gKCkgeworICAgICAgICBmb3IgKHZh ciBzdWl0ZUluZGV4ID0gMDsgc3VpdGVJbmRleCA8IHN1aXRlcy5sZW5ndGg7IHN1aXRlSW5kZXgr KykgeworICAgICAgICAgICAgc3VpdGVzW3N1aXRlSW5kZXhdLmRpc2FibGVkID0gZmFsc2U7Cisg ICAgICAgICAgICBjaGVja2JveGVzW3N1aXRlSW5kZXhdLmNoZWNrZWQgPSB0cnVlOworICAgICAg ICB9CisgICAgfTsKKyAgICBjb250cm9sLmFwcGVuZENoaWxkKGJ1dHRvbik7CisKKyAgICB2YXIg YnV0dG9uID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnYnV0dG9uJyk7CisgICAgYnV0dG9uLnRl eHRDb250ZW50ID0gJ1Vuc2VsZWN0IGFsbCc7CisgICAgYnV0dG9uLm9uY2xpY2sgPSBmdW5jdGlv biAoKSB7CisgICAgICAgIGZvciAodmFyIHN1aXRlSW5kZXggPSAwOyBzdWl0ZUluZGV4IDwgc3Vp dGVzLmxlbmd0aDsgc3VpdGVJbmRleCsrKSB7CisgICAgICAgICAgICBzdWl0ZXNbc3VpdGVJbmRl eF0uZGlzYWJsZWQgPSB0cnVlOworICAgICAgICAgICAgY2hlY2tib3hlc1tzdWl0ZUluZGV4XS5j aGVja2VkID0gZmFsc2U7CisgICAgICAgIH0KKworICAgIH07CisgICAgY29udHJvbC5hcHBlbmRD aGlsZChidXR0b24pOworCiAgICAgcmV0dXJuIGNvbnRyb2w7CiB9CiAK 318746 2017-08-22 01:08:21 -0700 2017-08-22 08:29:19 -0700 Removed superfluous newline bug-175816-20170822010819.patch text/plain 1883 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjEwMDUpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTIyICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogQWRkIGJ1dHRvbiB0byBzZWxlY3QgYW5kIHVuc2VsZWN0IGFsbCB0ZXN0cyB0byBJbnRlcmFj dGl2ZVJ1bm5lci5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzU4MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBidXR0b25zIHRvIHNlbGVjdCBhbmQgdW5zZWxlY3QgYWxsIHN1YnRlc3Rz IHRvIGFpZCBkZWJ1Z2dpbmcuCisKKyAgICAgICAgKiBTcGVlZG9tZXRlci9JbnRlcmFjdGl2ZVJ1 bm5lci5odG1sOgorICAgICAgICAoY3JlYXRlVUlGb3JTdWl0ZXMpOgorCiAyMDE3LTA4LTE4ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjIx OTY0MCk6IFNwZWVkb21ldGVyIG5vIGxvbmdlciBydW5zIG9uIFNhZmFyaSA3CkluZGV4OiBQZXJm b3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL0ludGVyYWN0aXZlUnVubmVyLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9TcGVlZG9tZXRlci9JbnRlcmFjdGl2ZVJ1bm5lci5odG1s CShyZXZpc2lvbiAyMjEwMDEpCisrKyBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL0ludGVy YWN0aXZlUnVubmVyLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTcxLDYgKzcxLDI3IEBAIGZ1bmN0 aW9uIGNyZWF0ZVVJRm9yU3VpdGVzKHN1aXRlcywgb25zdGUKICAgICBidXR0b24ub25jbGljayA9 IG9ucnVuOwogICAgIGNvbnRyb2wuYXBwZW5kQ2hpbGQoYnV0dG9uKTsKIAorICAgIHZhciBidXR0 b24gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdidXR0b24nKTsKKyAgICBidXR0b24udGV4dENv bnRlbnQgPSAnU2VsZWN0IGFsbCc7CisgICAgYnV0dG9uLm9uY2xpY2sgPSBmdW5jdGlvbiAoKSB7 CisgICAgICAgIGZvciAodmFyIHN1aXRlSW5kZXggPSAwOyBzdWl0ZUluZGV4IDwgc3VpdGVzLmxl bmd0aDsgc3VpdGVJbmRleCsrKSB7CisgICAgICAgICAgICBzdWl0ZXNbc3VpdGVJbmRleF0uZGlz YWJsZWQgPSBmYWxzZTsKKyAgICAgICAgICAgIGNoZWNrYm94ZXNbc3VpdGVJbmRleF0uY2hlY2tl ZCA9IHRydWU7CisgICAgICAgIH0KKyAgICB9OworICAgIGNvbnRyb2wuYXBwZW5kQ2hpbGQoYnV0 dG9uKTsKKworICAgIHZhciBidXR0b24gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdidXR0b24n KTsKKyAgICBidXR0b24udGV4dENvbnRlbnQgPSAnVW5zZWxlY3QgYWxsJzsKKyAgICBidXR0b24u b25jbGljayA9IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgZm9yICh2YXIgc3VpdGVJbmRleCA9IDA7 IHN1aXRlSW5kZXggPCBzdWl0ZXMubGVuZ3RoOyBzdWl0ZUluZGV4KyspIHsKKyAgICAgICAgICAg IHN1aXRlc1tzdWl0ZUluZGV4XS5kaXNhYmxlZCA9IHRydWU7CisgICAgICAgICAgICBjaGVja2Jv eGVzW3N1aXRlSW5kZXhdLmNoZWNrZWQgPSBmYWxzZTsKKyAgICAgICAgfQorCisgICAgfTsKKyAg ICBjb250cm9sLmFwcGVuZENoaWxkKGJ1dHRvbik7CisKICAgICByZXR1cm4gY29udHJvbDsKIH0K IAo=