175811 2017-08-21 22:06:47 -0700 Speedometer 2.0: Make it possible to change the iteration count via query string 2017-08-22 14:02:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 172339 1 rniwa rniwa cdumez fpizlo ggaren keith_miller lforschler mathias saam webkit-bug-importer oldest_to_newest 1340958 0 rniwa 2017-08-21 22:06:47 -0700 Make it possible to change the iteration count of Speedometer via query string. Also reduce the default iteration count from 20 to 10. 1340965 1 318738 rniwa 2017-08-21 23:00:02 -0700 Created attachment 318738 Patch 1341032 2 318738 mathias 2017-08-22 04:32:30 -0700 Comment on attachment 318738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318738&action=review > PerformanceTests/Speedometer/resources/main.js:154 > + var parts = location.search.substring(1).split('&'); Shame Edge doesn’t support `URLSearchParams` yet — that would simplify this section greatly! > PerformanceTests/Speedometer/resources/main.js:171 > + console.error('Invalid iteratin count: ' + value); typo: iteration 1341034 3 318738 saam 2017-08-22 05:00:49 -0700 Comment on attachment 318738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318738&action=review > PerformanceTests/Speedometer/resources/main.js:160 > + case 'unit': Why have this parameter if only “ms” is allowed? > PerformanceTests/Speedometer/resources/main.js:168 > + if (!isNaN(value)) Should be isNaN(parsedValue) 1341252 4 rniwa 2017-08-22 13:58:42 -0700 (In reply to Saam Barati from comment #3) > Comment on attachment 318738 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318738&action=review > > > PerformanceTests/Speedometer/resources/main.js:160 > > + case 'unit': > > Why have this parameter if only “ms” is allowed? Just for clarity. ?unit=ms reads better than ?ms. > > PerformanceTests/Speedometer/resources/main.js:168 > > + if (!isNaN(value)) > > Should be isNaN(parsedValue) Oops, fixed. 1341253 5 rniwa 2017-08-22 13:58:53 -0700 (In reply to Mathias Bynens from comment #2) > Comment on attachment 318738 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318738&action=review > > > PerformanceTests/Speedometer/resources/main.js:154 > > + var parts = location.search.substring(1).split('&'); > > Shame Edge doesn’t support `URLSearchParams` yet — that would simplify this > section greatly! > > > PerformanceTests/Speedometer/resources/main.js:171 > > + console.error('Invalid iteratin count: ' + value); > > typo: iteration Fixed. 1341255 6 rniwa 2017-08-22 14:00:51 -0700 Committed r221044: <http://trac.webkit.org/changeset/221044> 1341257 7 webkit-bug-importer 2017-08-22 14:02:04 -0700 <rdar://problem/34020863> 318738 2017-08-21 23:00:02 -0700 2017-08-22 05:00:49 -0700 Patch bug-175811-20170821230000.patch text/plain 3754 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjEwMDQpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA4LTIxICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFNwZWVkb21ldGVyIDIu MDogTWFrZSBpdCBwb3NzaWJsZSB0byBjaGFuZ2UgdGhlIGl0ZXJhdGlvbiBjb3VudCB2aWEgcXVl cnkgc3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzU4MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGRlZCB0aGUgc3VwcG9ydCBmb3Igc3BlY2lmeWluZyB0aGUgaXRlcmF0aW9uIGNvdW50IGJ5 ICJpdGVyYXRpb25Db3VudCIgcXVlcnkgcGFyYW1ldGVyLCBhbmQgcmVwbGFjZWQgIm1zIgorICAg ICAgICBxdWVyeSBwYXJhbWV0ZXIgYnkgInVuaXQ9bXMiLgorCisgICAgICAgIEZpbmFsbHksIHJl ZHVjZWQgdGhlIG51bWJlciBvZiBpdGVyYXRpb25zIGZyb20gMjAgdG8gMTAgdG8gcmVkdWNlIHRo ZSB0aW1lIG5lZWRlZCB0byBydW4gdGhlIGJlbmNobWFyaworICAgICAgICBzaW5jZSBTcGVlZG9t ZXRlciAyLjAgY29udGFpbnMgbW9yZSB0aGFuIHR3aWNlIHRoZSBudW1iZXIgb2YgbGlicmFyaWVz IGFuZCBmcmFtZXdvcmtzIHRoYW4gU3BlZWRvbWV0ZXIgMS4wLgorCisgICAgICAgICogU3BlZWRv bWV0ZXIvcmVzb3VyY2VzL21haW4uanM6CisgICAgICAgICh3aW5kb3cuYmVuY2htYXJrQ2xpZW50 LmRpZEZpbmlzaExhc3RJdGVyYXRpb24pOgorICAgICAgICAoc3RhcnRCZW5jaG1hcmspOgorCiAy MDE3LTA4LTE4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJF R1JFU1NJT04ocjIxOTY0MCk6IFNwZWVkb21ldGVyIG5vIGxvbmdlciBydW5zIG9uIFNhZmFyaSA3 CkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1NwZWVkb21ldGVyL3Jlc291cmNlcy9tYWluLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVzb3VyY2VzL21haW4u anMJKHJldmlzaW9uIDIyMTAwMSkKKysrIFBlcmZvcm1hbmNlVGVzdHMvU3BlZWRvbWV0ZXIvcmVz b3VyY2VzL21haW4uanMJKHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw2IEBACiB3aW5kb3cuYmVu Y2htYXJrQ2xpZW50ID0gewotICAgIGl0ZXJhdGlvbkNvdW50OiAyMCwKKyAgICBkaXNwbGF5VW5p dDogJ3J1bnMvbWluJywKKyAgICBpdGVyYXRpb25Db3VudDogMTAsCiAgICAgdGVzdHNDb3VudDog bnVsbCwKICAgICBzdWl0ZXNDb3VudDogbnVsbCwKICAgICBfdGltZVZhbHVlczogW10sCkBAIC0z MCw4ICszMSw3IEBAIHdpbmRvdy5iZW5jaG1hcmtDbGllbnQgPSB7CiAgICAgZGlkRmluaXNoTGFz dEl0ZXJhdGlvbjogZnVuY3Rpb24gKCkgewogICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnbG9nby1saW5rJykub25jbGljayA9IG51bGw7CiAKLSAgICAgICAgdmFyIGRpc3BsYXlVbml0 ID0gbG9jYXRpb24uc2VhcmNoID09ICc/bXMnIHx8IGxvY2F0aW9uLmhhc2ggPT0gJyNtcycgPyAn bXMnIDogJ3J1bnMvbWluJzsKLSAgICAgICAgdmFyIHJlc3VsdHMgPSB0aGlzLl9jb21wdXRlUmVz dWx0cyh0aGlzLl90aW1lVmFsdWVzLCBkaXNwbGF5VW5pdCk7CisgICAgICAgIHZhciByZXN1bHRz ID0gdGhpcy5fY29tcHV0ZVJlc3VsdHModGhpcy5fdGltZVZhbHVlcywgdGhpcy5kaXNwbGF5VW5p dCk7CiAKICAgICAgICAgdGhpcy5fdXBkYXRlR2F1Z2VOZWVkbGUocmVzdWx0cy5tZWFuKTsKICAg ICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Jlc3VsdC1udW1iZXInKS50ZXh0Q29udGVu dCA9IHJlc3VsdHMuZm9ybWF0dGVkTWVhbjsKQEAgLTQxLDcgKzQxLDcgQEAgd2luZG93LmJlbmNo bWFya0NsaWVudCA9IHsKICAgICAgICAgdGhpcy5fcG9wdWxhdGVEZXRhaWxlZFJlc3VsdHMocmVz dWx0cy5mb3JtYXR0ZWRWYWx1ZXMpOwogICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn cmVzdWx0cy13aXRoLXN0YXRpc3RpY3MnKS50ZXh0Q29udGVudCA9IHJlc3VsdHMuZm9ybWF0dGVk TWVhbkFuZERlbHRhOwogCi0gICAgICAgIGlmIChkaXNwbGF5VW5pdCA9PSAnbXMnKSB7CisgICAg ICAgIGlmICh0aGlzLmRpc3BsYXlVbml0ID09ICdtcycpIHsKICAgICAgICAgICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdzaG93LXN1bW1hcnknKS5zdHlsZS5kaXNwbGF5ID0gJ25vbmUnOwog ICAgICAgICAgICAgc2hvd1Jlc3VsdERldGFpbHMoKTsKICAgICAgICAgfSBlbHNlCkBAIC0xNTAs NiArMTUwLDMwIEBAIHdpbmRvdy5iZW5jaG1hcmtDbGllbnQgPSB7CiB9CiAKIGZ1bmN0aW9uIHN0 YXJ0QmVuY2htYXJrKCkgeworICAgIGlmIChsb2NhdGlvbi5zZWFyY2gubGVuZ3RoID4gMSkgewor ICAgICAgICB2YXIgcGFydHMgPSBsb2NhdGlvbi5zZWFyY2guc3Vic3RyaW5nKDEpLnNwbGl0KCcm Jyk7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcGFydHMubGVuZ3RoOyBpKyspIHsKKyAg ICAgICAgICAgIHZhciBrZXlWYWx1ZSA9IHBhcnRzW2ldLnNwbGl0KCc9Jyk7CisgICAgICAgICAg ICB2YXIga2V5ID0ga2V5VmFsdWVbMF07CisgICAgICAgICAgICB2YXIgdmFsdWUgPSBrZXlWYWx1 ZVsxXTsKKyAgICAgICAgICAgIHN3aXRjaCAoa2V5KSB7CisgICAgICAgICAgICBjYXNlICd1bml0 JzoKKyAgICAgICAgICAgICAgICBpZiAodmFsdWUgPT0gJ21zJykKKyAgICAgICAgICAgICAgICAg ICAgYmVuY2htYXJrQ2xpZW50LmRpc3BsYXlVbml0ID0gJ21zJzsKKyAgICAgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICAgICAgICAgIGNvbnNvbGUuZXJyb3IoJ0ludmFsaWQgdW5pdDogJyAr IHZhbHVlKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGNhc2UgJ2l0ZXJh dGlvbkNvdW50JzoKKyAgICAgICAgICAgICAgICB2YXIgcGFyc2VkVmFsdWUgPSBwYXJzZUludCh2 YWx1ZSk7CisgICAgICAgICAgICAgICAgaWYgKCFpc05hTih2YWx1ZSkpCisgICAgICAgICAgICAg ICAgICAgIGJlbmNobWFya0NsaWVudC5pdGVyYXRpb25Db3VudCA9IHBhcnNlZFZhbHVlOworICAg ICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgY29uc29sZS5lcnJvcignSW52 YWxpZCBpdGVyYXRpbiBjb3VudDogJyArIHZhbHVlKTsKKyAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgIH0KKwogICAgIHZhciBlbmFibGVkU3VpdGVz ID0gU3VpdGVzLmZpbHRlcihmdW5jdGlvbiAoc3VpdGUpIHsgcmV0dXJuICFzdWl0ZS5kaXNhYmxl ZCB9KTsKICAgICB2YXIgdG90YWxTdWJ0ZXN0Q291bnQgPSBlbmFibGVkU3VpdGVzLnJlZHVjZShm dW5jdGlvbiAodGVzdHNDb3VudCwgc3VpdGUpIHsgcmV0dXJuIHRlc3RzQ291bnQgKyBzdWl0ZS50 ZXN0cy5sZW5ndGg7IH0sIDApOwogICAgIGJlbmNobWFya0NsaWVudC50ZXN0c0NvdW50ID0gYmVu Y2htYXJrQ2xpZW50Lml0ZXJhdGlvbkNvdW50ICogdG90YWxTdWJ0ZXN0Q291bnQ7Cg==