175665 2017-08-17 02:54:41 -0700 Automation: takeScreenshot should use the visible content rect not the document rect 2017-08-28 05:34:07 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg joepeck webkit-bug-importer oldest_to_newest 1339485 0 cgarcia 2017-08-17 02:54:41 -0700 https://w3c.github.io/webdriver/webdriver-spec.html#dfn-draw-a-bounding-box-from-the-framebuffer We should take the document rectangle and draw it with the current viewport width and height. If I understand the spec correctly we should use the document rectangle coordinates, but that's not what chromium and firefox do, they take the screenshot of the visible area. 1339486 1 318346 cgarcia 2017-08-17 02:59:26 -0700 Created attachment 318346 Patch 1340172 2 318346 bburg 2017-08-18 12:13:48 -0700 Comment on attachment 318346 Patch r=me I don't think there are any Selenium tests that cover interesting screenshot corner cases. 1340393 3 cgarcia 2017-08-19 00:54:51 -0700 (In reply to Brian Burg from comment #2) > Comment on attachment 318346 [details] > Patch > > r=me > > I don't think there are any Selenium tests that cover interesting screenshot > corner cases. Right, they just check the commands return any data. I did several manual tests comparing with firefox and chrome. 1342816 4 cgarcia 2017-08-28 05:32:48 -0700 Committed r221246: <http://trac.webkit.org/changeset/221246> 1342818 5 webkit-bug-importer 2017-08-28 05:34:07 -0700 <rdar://problem/34108956> 318346 2017-08-17 02:59:26 -0700 2017-08-18 12:13:48 -0700 Patch wd-screenshot-size.diff text/plain 1907 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTE4NTFkNWIwMGMuLmRjNDIyYzc2MjRiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDE3LTA4LTE3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBBdXRvbWF0aW9uOiB0YWtlU2NyZWVuc2hvdCBzaG91bGQgdXNlIHRo ZSB2aXNpYmxlIGNvbnRlbnQgcmVjdCBub3QgdGhlIGRvY3VtZW50IHJlY3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTY2NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY29yZGluZyB0byB0aGUgc3Bl Yywgd2Ugc2hvdWxkIGdldCB0aGUgdG9wbGV2ZWwgYnJvd3NpbmcgY29udGV4dCBkb2N1bWVudCBy ZWN0YW5nbGUgYW5kIHRha2UgYSBzY3JlZW5zaG90IG9mCisgICAgICAgIGl0IHVzaW5nIHRoZSBj dXJyZW50IHZpZXdwb3J0IHdpZHRoIGFuZCBoZWlnaHQuIFdlIGFyZSBjdXJyZW50bHkgdXNpbmcg dGhlIGRvY3VtZW50IHNpemUuCisKKyAgICAgICAgMTkuIFNjcmVlbiBDYXB0dXJlLgorICAgICAg ICBodHRwczovL3czYy5naXRodWIuaW8vd2ViZHJpdmVyL3dlYmRyaXZlci1zcGVjLmh0bWwjZGZu LWRyYXctYS1ib3VuZGluZy1ib3gtZnJvbS10aGUtZnJhbWVidWZmZXIKKworICAgICAgICAqIFdl YlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvblByb3h5LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViQXV0b21hdGlvblNlc3Npb25Qcm94eTo6dGFrZVNjcmVlbnNob3QpOiBV c2UgRnJhbWVWaWV3Ojp2aXNpYmxlQ29udGVudFJlY3QoKS4KKwogMjAxNy0wOC0xNiAgQW5keSBF c3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW0FwcGxlIFBheV0gUmVuYW1lIFBh eW1lbnRSZXF1ZXN0IHRvIEFwcGxlUGF5U2Vzc2lvblBheW1lbnRSZXF1ZXN0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lv blByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9t YXRpb25TZXNzaW9uUHJveHkuY3BwCmluZGV4IDA3ZTRmZmU2OTQwLi5mMTFmNjUwODIxNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlv blNlc3Npb25Qcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRp b24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHAKQEAgLTY1MCw3ICs2NTAsNyBAQCB2b2lk IFdlYkF1dG9tYXRpb25TZXNzaW9uUHJveHk6OnRha2VTY3JlZW5zaG90KHVpbnQ2NF90IHBhZ2VJ RCwgdWludDY0X3QgY2FsbGJhYwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgV2ViQ29y ZTo6SW50UmVjdCBzbmFwc2hvdFJlY3QgPSBXZWJDb3JlOjpJbnRSZWN0KFdlYkNvcmU6OkludFBv aW50KDAsIDApLCBmcmFtZVZpZXctPmNvbnRlbnRzU2l6ZSgpKTsKKyAgICBXZWJDb3JlOjpJbnRS ZWN0IHNuYXBzaG90UmVjdCA9IGZyYW1lVmlldy0+dmlzaWJsZUNvbnRlbnRSZWN0KCk7CiAgICAg aWYgKHNuYXBzaG90UmVjdC5pc0VtcHR5KCkpIHsKICAgICAgICAgV2ViUHJvY2Vzczo6c2luZ2xl dG9uKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViQXV0b21h dGlvblNlc3Npb246OkRpZFRha2VTY3JlZW5zaG90KGNhbGxiYWNrSUQsIGhhbmRsZSwgU3RyaW5n KCkpLCAwKTsKICAgICAgICAgcmV0dXJuOwo=