175506 2017-08-11 18:27:26 -0700 The none smooth stroke applied to an SVG shape breaks its hit testing 2019-04-03 17:26:11 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196518 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue darin simon.fraser thorton webkit-bug-importer zimmermann oldest_to_newest 1338098 0 317983 sabouhallawa 2017-08-11 18:27:26 -0700 Created attachment 317983 test case Open the attached test case and try on click multiple times on the bottom right border of the two rectangles. The two rectangles are supposed to move 10px down and 10px down. Result: The red rectangle seems to respond only on its original rectangle in spite of its movement. This can be seen if you hover its border after the first click. The cursor should change to the move shape but it does not. So the only way to move it to after the first click is to keep the mouse position still and do not move it. The green rectangle works as expected. The reason is the red rectangle has the attribute stroke-linejoin="round". This makes the function RenderSVGRect::shapeDependentStrokeContains() falls back to the slow path through calling RenderSVGShape::shapeDependentStrokeContains() which uses m_path to check whether the stroke contains the point or not. The bug is m_path gets only updated in RenderSVGRect::shapeDependentStrokeContains() when it is null. When RenderSVGRect::updateShapeFromElement() changes the renderer rectangles because of changing the 'x' and the 'y' attributes, the RenderSVGShape::m_path stays as is with the old rectangle. The fix is to make RenderSVGRect::updateShapeFromElement() clear RenderSVGShape::m_path so it is recalculated by RenderSVGRect::shapeDependentStrokeContains() when it is needed. 1338105 1 317986 sabouhallawa 2017-08-11 18:52:50 -0700 Created attachment 317986 Patch 1338106 2 sabouhallawa 2017-08-11 18:53:54 -0700 <rdar://problem/33698146> 1338472 3 317986 commit-queue 2017-08-14 15:00:31 -0700 Comment on attachment 317986 Patch Clearing flags on attachment: 317986 Committed r220717: <http://trac.webkit.org/changeset/220717> 1338473 4 commit-queue 2017-08-14 15:00:33 -0700 All reviewed patches have been landed. Closing bug. 317983 2017-08-11 18:27:26 -0700 2017-08-11 18:27:26 -0700 test case test250.html text/html 1094 sabouhallawa PHN0eWxlPgogICAgcmVjdCB7CiAgICAgICAgIGN1cnNvcjogbW92ZTsKICAgICAgICAgZmlsbDog bm9uZTsKICAgICAgICAgc3Ryb2tlLXdpZHRoOiA2OwogICAgICAgICB3aWR0aDogMTAwcHg7CiAg ICAgICAgIGhlaWdodDogMTAwcHg7CiAgICB9Cjwvc3R5bGU+Cjxib2R5PgogICAgPGgyIGFsaWdu PSJjZW50ZXIiPlRlc3QgJ2NsaWNrJyBFdmVudCB3aXRoICdzdHJva2UtbGluZWpvaW4nIEF0dHJp YnV0ZTwvaDI+CiAgICA8aDQ+Q2xpY2sgb24gdGhlIGJvcmRlcnMgb2YgdGhlc2UgdHdvIHJlY3Rh bmdsZXM6PC9oND4KICAgIDxzdmcgaGVpZ2h0PSIxMDAwIiB3aWR0aD0iMTAwMCI+CiAgICAgICAg PHJlY3QgaWQ9InJlZC1yZWN0IiB4PSIxMCIgeT0iMTAiIHN0cm9rZT0icmVkIiBzdHJva2UtbGlu ZWpvaW49InJvdW5kIi8+CiAgICAgICAgPHJlY3QgaWQ9ImdyZWVuLXJlY3QiIHg9IjE0MCIgeT0i MTAiIHN0cm9rZT0iZ3JlZW4iLz4KICAgIDwvc3ZnPgogICAgPHNjcmlwdD4KICAgICAgICBmdW5j dGlvbiBtb3ZlUmVjdChyZWN0KSB7CiAgICAgICAgICAgIHZhciB4ID0gcGFyc2VGbG9hdChyZWN0 LmdldEF0dHJpYnV0ZSgieCIpKTsKICAgICAgICAgICAgdmFyIHkgPSBwYXJzZUZsb2F0KHJlY3Qu Z2V0QXR0cmlidXRlKCJ5IikpOwogICAgICAgICAgICByZWN0LnNldEF0dHJpYnV0ZSgneCcsIHgg KyAxMCk7CiAgICAgICAgICAgIHJlY3Quc2V0QXR0cmlidXRlKCd5JywgeSArIDEwKTsKICAgICAg ICB9CgogICAgICAgIChmdW5jdGlvbigpIHsKICAgICAgICAgICAgdmFyIHJlZFJlY3QgPSBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCIjcmVkLXJlY3QiKTsKICAgICAgICAgICAgdmFyIGdyZWVuUmVj dCA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIiNncmVlbi1yZWN0Iik7CgogICAgICAgICAgICBy ZWRSZWN0LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgKCkgPT4gbW92ZVJlY3QocmVkUmVjdCkp OwogICAgICAgICAgICBncmVlblJlY3QuYWRkRXZlbnRMaXN0ZW5lcigiY2xpY2siLCAoKSA9PiBt b3ZlUmVjdChncmVlblJlY3QpKTsKICAgICAgICB9KSgpOyAgICAgICAgICAgCiAgICA8L3Njcmlw dD4KPC9ib2R5Pgo= 317986 2017-08-11 18:52:50 -0700 2017-08-14 15:00:31 -0700 Patch bug-175506-20170811185250.patch text/plain 4653 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMDYyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA4LTExICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIG5vbmUg c21vb3RoIHN0cm9rZSBhcHBsaWVkIHRvIGFuIFNWRyBzaGFwZSBicmVha3MgaXRzIGhpdCB0ZXN0 aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzU1 MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVh ciBSZW5kZXJTVkdTaGFwZTo6bV9wYXRoIHdoZW4gY2FsbGluZyBSZW5kZXJTVkdSZWN0Ojp1cGRh dGVTaGFwZUZyb21FbGVtZW50KCkuCisgICAgICAgIFRoZSBtX3BhdGggd2lsbCBiZSByZWNhbGN1 bGF0ZWQgd2hlbiBSZW5kZXJTVkdTaGFwZTo6dXBkYXRlU2hhcGVGcm9tRWxlbWVudCgpCisgICAg ICAgIGlzIGNhbGxlZCBmcm9tIFJlbmRlclNWR1JlY3Q6OnNoYXBlRGVwZW5kZW50U3Ryb2tlQ29u dGFpbnMoKS4KKworICAgICAgICBUZXN0OiBzdmcvc3Ryb2tlL3N0cm9rZS1saW5lam9pbi1jbGlj ay5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1JlY3QuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHUmVjdDo6dXBkYXRlU2hhcGVGcm9tRWxlbWVudCk6Cisg ICAgICAgICogcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFwZS5oOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyU1ZHU2hhcGU6OmNsZWFyUGF0aCk6CisKIDIwMTctMDgtMTEgIERvbiBPbG1zdGVh ZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbV1RGXSBNb3ZlIFZhbHVlVG9T dHJpbmcgaW50byBXVEYKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVy U1ZHUmVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9S ZW5kZXJTVkdSZWN0LmNwcAkocmV2aXNpb24gMjIwNTYzKQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTIsNiArNTIs NyBAQCB2b2lkIFJlbmRlclNWR1JlY3Q6OnVwZGF0ZVNoYXBlRnJvbUVsZW1lCiAgICAgbV9maWxs Qm91bmRpbmdCb3ggPSBGbG9hdFJlY3QoKTsKICAgICBtX2lubmVyU3Ryb2tlUmVjdCA9IEZsb2F0 UmVjdCgpOwogICAgIG1fb3V0ZXJTdHJva2VSZWN0ID0gRmxvYXRSZWN0KCk7CisgICAgY2xlYXJQ YXRoKCk7CiAKICAgICBTVkdMZW5ndGhDb250ZXh0IGxlbmd0aENvbnRleHQoJnJlY3RFbGVtZW50 KCkpOwogICAgIEZsb2F0U2l6ZSBib3VuZGluZ0JveFNpemUobGVuZ3RoQ29udGV4dC52YWx1ZUZv ckxlbmd0aChzdHlsZSgpLndpZHRoKCksIExlbmd0aE1vZGVXaWR0aCksIGxlbmd0aENvbnRleHQu dmFsdWVGb3JMZW5ndGgoc3R5bGUoKS5oZWlnaHQoKSwgTGVuZ3RoTW9kZUhlaWdodCkpOwpJbmRl eDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdTaGFwZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHU2hhcGUuaAkocmV2 aXNpb24gMjIwNTYzKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdT aGFwZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw2ICs2Myw3IEBAIHB1YmxpYzoKICAgICAgICAg QVNTRVJUKG1fcGF0aCk7CiAgICAgICAgIHJldHVybiAqbV9wYXRoOwogICAgIH0KKyAgICB2b2lk IGNsZWFyUGF0aCgpIHsgbV9wYXRoID0gbnVsbHB0cjsgfQogCiBwcm90ZWN0ZWQ6CiAgICAgdm9p ZCBlbGVtZW50KCkgY29uc3QgPSBkZWxldGU7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjA1NjMpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor MjAxNy0wOC0xMSAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgor CisgICAgICAgIFRoZSBub25lIHNtb290aCBzdHJva2UgYXBwbGllZCB0byBhbiBTVkcgc2hhcGUg YnJlYWtzIGl0cyBoaXQgdGVzdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc1NTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBzdmcvc3Ryb2tlL3N0cm9rZS1saW5lam9pbi1jbGljay1leHBlY3Rl ZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBzdmcvc3Ryb2tlL3N0cm9rZS1saW5lam9pbi1jbGlj ay5odG1sOiBBZGRlZC4KKwogMjAxNy0wOC0xMCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2FyZGVuaW5nIGZvciBIaWdoIFNp ZXJyYS4KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9zdHJva2Uvc3Ryb2tlLWxpbmVqb2luLWNsaWNr LWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3ZnL3N0cm9rZS9zdHJv a2UtbGluZWpvaW4tY2xpY2stZXhwZWN0ZWQuaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRU ZXN0cy9zdmcvc3Ryb2tlL3N0cm9rZS1saW5lam9pbi1jbGljay1leHBlY3RlZC5odG1sCSh3b3Jr aW5nIGNvcHkpCkBAIC0wLDAgKzEsMTkgQEAKKzxzdHlsZT4KKyAgICBodG1sLCBib2R5IHsKKyAg ICAgICAgbWFyZ2luOiAwOworICAgICAgICBwYWRkaW5nOiAwOworICAgIH0KKyAgICByZWN0IHsK KyAgICAgICAgZmlsbDogbm9uZTsKKyAgICAgICAgc3Ryb2tlLXdpZHRoOiA2OworICAgICAgICBz dHJva2UtbGluZWpvaW46IHJvdW5kOworICAgICAgICBzdHJva2U6IGdyZWVuOworICAgICAgICB3 aWR0aDogMTAwcHg7CisgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgfQorPC9zdHlsZT4KKzxi b2R5PgorICAgIDxzdmc+CisgICAgICAgIDxyZWN0IHg9IjMwIiB5PSIzMCIvPgorICAgIDwvc3Zn PgorPC9ib2R5PgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL3N0cm9rZS9zdHJva2UtbGluZWpvaW4t Y2xpY2suaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvc3Ryb2tlL3N0cm9rZS1s aW5lam9pbi1jbGljay5odG1sCShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL3N2Zy9zdHJv a2Uvc3Ryb2tlLWxpbmVqb2luLWNsaWNrLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwz NyBAQAorPHN0eWxlPgorICAgIGh0bWwsIGJvZHkgeworICAgICAgICBtYXJnaW46IDA7CisgICAg ICAgIHBhZGRpbmc6IDA7CisgICAgfQorICAgIHJlY3QgeworICAgICAgICBmaWxsOiBub25lOwor ICAgICAgICBzdHJva2Utd2lkdGg6IDY7CisgICAgICAgIHN0cm9rZS1saW5lam9pbjogcm91bmQ7 CisgICAgICAgIHN0cm9rZTogZ3JlZW47CisgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAg aGVpZ2h0OiAxMDBweDsKKyAgICB9Cis8L3N0eWxlPgorPGJvZHk+CisgICAgPHN2Zz4KKyAgICAg ICAgPHJlY3QgeD0iMTAiIHk9IjEwIi8+CisgICAgPC9zdmc+CisgICAgPHNjcmlwdD4KKyAgICAg ICAgZnVuY3Rpb24gbW92ZVJlY3QocmVjdCkgeworICAgICAgICAgICAgdmFyIHggPSBwYXJzZUZs b2F0KHJlY3QuZ2V0QXR0cmlidXRlKCJ4IikpOworICAgICAgICAgICAgdmFyIHkgPSBwYXJzZUZs b2F0KHJlY3QuZ2V0QXR0cmlidXRlKCJ5IikpOworICAgICAgICAgICAgcmVjdC5zZXRBdHRyaWJ1 dGUoJ3gnLCB4ICsgMTApOworICAgICAgICAgICAgcmVjdC5zZXRBdHRyaWJ1dGUoJ3knLCB5ICsg MTApOworICAgICAgICB9CisKKyAgICAgICAgKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgdmFy IGVsZW1lbnQgPSBkb2N1bWVudC5lbGVtZW50RnJvbVBvaW50KDEwLCAxMCk7CisgICAgICAgICAg ICBpZiAoZWxlbWVudCBpbnN0YW5jZW9mIFNWR1JlY3RFbGVtZW50KQorICAgICAgICAgICAgICAg IG1vdmVSZWN0KGVsZW1lbnQpOworCisgICAgICAgICAgICBlbGVtZW50ID0gZG9jdW1lbnQuZWxl bWVudEZyb21Qb2ludCgyMCwgMjApOworICAgICAgICAgICAgaWYgKGVsZW1lbnQgaW5zdGFuY2Vv ZiBTVkdSZWN0RWxlbWVudCkKKyAgICAgICAgICAgICAgICBtb3ZlUmVjdChlbGVtZW50KTsKKyAg ICAgICAgfSkoKTsKKyAgICA8L3NjcmlwdD4KKzwvYm9keT4K