175284 2017-08-07 13:23:04 -0700 Web Inspector: allow recordings to be saved via ⌘-S in the Recording tab 2017-09-13 19:32:18 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 174484 173807 1 hi hi bburg commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1336104 0 hi 2017-08-07 13:23:04 -0700 . 1336120 1 317461 hi 2017-08-07 14:03:50 -0700 Created attachment 317461 Patch 1338112 2 317461 mattbaker 2017-08-11 20:07:52 -0700 Comment on attachment 317461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317461&action=review r-, since this duplicates code in RecordingNavigationSidebarPanel. The sidebar should probably be using the new `saveData()` getter. > Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:99 > + forceSaveAs: true, What are your thoughts on versioning? 1339902 3 hi 2017-08-17 19:11:57 -0700 (In reply to Matt Baker from comment #2) > Comment on attachment 317461 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317461&action=review > > r-, since this duplicates code in RecordingNavigationSidebarPanel. The > sidebar should probably be using the new `saveData()` getter. > > > Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:99 > > + forceSaveAs: true, > > What are your thoughts on versioning? We already have a version in the Recording protocol. I'm not sure what you mean otherwise. 1340957 4 318736 hi 2017-08-21 22:03:42 -0700 Created attachment 318736 Patch 1341696 5 webkit-bug-importer 2017-08-23 12:11:53 -0700 <rdar://problem/34040758> 1348576 6 318736 mattbaker 2017-09-13 17:02:53 -0700 Comment on attachment 318736 Patch r=me 1348587 7 318736 commit-queue 2017-09-13 17:32:07 -0700 Comment on attachment 318736 Patch Clearing flags on attachment: 318736 Committed r222003: <http://trac.webkit.org/changeset/222003> 1348588 8 commit-queue 2017-09-13 17:32:08 -0700 All reviewed patches have been landed. Closing bug. 1348612 9 318736 joepeck 2017-09-13 19:32:18 -0700 Comment on attachment 318736 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318736&action=review > Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js:171 > + WI.saveDataToFile(this.contentBrowser.currentContentView.saveData, forceSaveAs); The saveData already has `forceSaveAs: true`. I suppose its fine to be explicit here, but this means that no matter what ContentView eventually shows up in the Recording tab will always be a forceSaveAs even if the ContentView logically can re-save. I don't think that ever be likely to happen though. 317461 2017-08-07 14:03:50 -0700 2017-08-21 22:03:40 -0700 Patch bug-175284-20170807140349.patch text/plain 1685 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE1OGQxOWJkM2EyMWU1ZGM2YjRkYTY0NDc4ZDc1 YmI5NGY1YmRmYzAuLjIxNmYzMzZlNGNiOWMyYWMyYTAxZGE1ZmI1NzA3YTQ5ZTUzOTAxNzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA4LTA3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBh bGxvdyByZWNvcmRpbmdzIHRvIGJlIHNhdmVkIHZpYSDijJgtUyBpbiB0aGUgUmVjb3JkaW5nIHRh YgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc1Mjg0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL1JlY29yZGluZ0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuUmVj b3JkaW5nQ29udGVudFZpZXcucHJvdG90eXBlLmdldCBzdXBwb3J0c1NhdmUpOgorICAgICAgICAo V0kuUmVjb3JkaW5nQ29udGVudFZpZXcucHJvdG90eXBlLmdldCBzYXZlRGF0YSk6CisKIDIwMTct MDgtMDQgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IGFkZCBzb3VyY2UgdmlldyBmb3IgV2ViR0wgc2hhZGVyIHByb2dyYW1zCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNvcmRp bmdDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1JlY29yZGluZ0NvbnRlbnRWaWV3LmpzCmluZGV4IGI3MDdiOTZmMzQ5N2YxZWY1YzJmYTA1 YTExYzJiYmQzMzMxMzEwNGUuLmEyMWUxNmY4NmVjNzgwMTk1ZDIzZWU5NjdjZDg0YzhmYmQwMzA4 YWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1JlY29yZGluZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1JlY29yZGluZ0NvbnRlbnRWaWV3LmpzCkBAIC04Niw2ICs4NiwyMCBA QCBXSS5SZWNvcmRpbmdDb250ZW50VmlldyA9IGNsYXNzIFJlY29yZGluZ0NvbnRlbnRWaWV3IGV4 dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAgcmV0dXJuIHN1cHBsZW1lbnRhbFJlcHJlc2Vu dGVkT2JqZWN0czsKICAgICB9CiAKKyAgICBnZXQgc3VwcG9ydHNTYXZlKCkKKyAgICB7CisgICAg ICAgIHJldHVybiB0cnVlOworICAgIH0KKworICAgIGdldCBzYXZlRGF0YSgpCisgICAgeworICAg ICAgICByZXR1cm4geworICAgICAgICAgICAgdXJsOiAid2ViLWluc3BlY3RvcjovLy9SZWNvcmRp bmcuanNvbiIsCisgICAgICAgICAgICBjb250ZW50OiBKU09OLnN0cmluZ2lmeSh0aGlzLnJlcHJl c2VudGVkT2JqZWN0LnRvSlNPTigpKSwKKyAgICAgICAgICAgIGZvcmNlU2F2ZUFzOiB0cnVlLAor ICAgICAgICB9OworICAgIH0KKwogICAgIC8vIFByaXZhdGUKIAogICAgIF9nZW5lcmF0ZUNvbnRl bnRDYW52YXMyRChpbmRleCwgb3B0aW9ucyA9IHt9KQo= 318736 2017-08-21 22:03:42 -0700 2017-09-13 17:32:07 -0700 Patch bug-175284-20170821220341.patch text/plain 3104 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRhOTdlZDA5NjY4NzJhNThlZWNhYTI1NmIzNzgx M2UzZDIwZTc5ZjguLjUxNzM3Y2NjMTgyZWQ5ZWJjNDFkMjdlYzk3YWViNjEyMjBhNDg0ZjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE3LTA4LTIxICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFsbG93IHJlY29yZGluZ3MgdG8gYmUgc2F2ZWQgdmlhIOKMmC1TIGluIHRoZSBSZWNvcmRp bmcgdGFiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzUyODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvUmVjb3JkaW5nQ29udGVudFZpZXcuanM6CisgICAgICAgIChX SS5SZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuZ2V0IHN1cHBvcnRzU2F2ZSk6CisgICAg ICAgIChXSS5SZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuZ2V0IHNhdmVEYXRhKToKKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvUmVjb3JkaW5nTmF2aWdhdGlvblNpZGViYXJQ YW5lbC5qczoKKyAgICAgICAgKFdJLlJlY29yZGluZ05hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJv dG90eXBlLl9leHBvcnROYXZpZ2F0aW9uSXRlbUNsaWNrZWQpOgorICAgICAgICBVc2UgdGhlIGN1 cnJlbnQgY29udGVudCB2aWV3J3Mgc2F2ZURhdGEgd2hlbiBleHBvcnRpbmcuCisKKzIwMTctMDgt MjEgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNzby5jb20+CisKICAgICAgICAgV2Vi IEluc3BlY3RvcjogQ2FuJ3QgY29weSB0ZXh0IGZyb20gIlZpZXcgdmFyaWFibGUgdmFsdWUiIHBv cG92ZXIgaW4gU3R5bGVzIHNpZGViYXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3NTc1OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNvcmRpbmdDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1JlY29yZGluZ0NvbnRlbnRWaWV3Lmpz CmluZGV4IGY4YjNjZTBjMWUxNDY5OTkzZGM2ZWI1YTFiY2FlZWQ3MjAxYjkzZjMuLjViMDc1MTBj N2EyYzE0Y2ZkM2FmMDc3ODI5ZDcxNGI0NTY2N2YwNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1JlY29yZGluZ0NvbnRlbnRWaWV3LmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1JlY29yZGluZ0Nv bnRlbnRWaWV3LmpzCkBAIC0xMjYsNiArMTI2LDIwIEBAIFdJLlJlY29yZGluZ0NvbnRlbnRWaWV3 ID0gY2xhc3MgUmVjb3JkaW5nQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmlldwogICAg ICAgICByZXR1cm4gc3VwcGxlbWVudGFsUmVwcmVzZW50ZWRPYmplY3RzOwogICAgIH0KIAorICAg IGdldCBzdXBwb3J0c1NhdmUoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQor CisgICAgZ2V0IHNhdmVEYXRhKCkKKyAgICB7CisgICAgICAgIHJldHVybiB7CisgICAgICAgICAg ICB1cmw6ICJ3ZWItaW5zcGVjdG9yOi8vL1JlY29yZGluZy5qc29uIiwKKyAgICAgICAgICAgIGNv bnRlbnQ6IEpTT04uc3RyaW5naWZ5KHRoaXMucmVwcmVzZW50ZWRPYmplY3QudG9KU09OKCkpLAor ICAgICAgICAgICAgZm9yY2VTYXZlQXM6IHRydWUsCisgICAgICAgIH07CisgICAgfQorCiAgICAg Ly8gUHJpdmF0ZQogCiAgICAgX2dlbmVyYXRlQ29udGVudENhbnZhczJEKGluZGV4LCBvcHRpb25z ID0ge30pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9SZWNvcmRpbmdOYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVjb3JkaW5nTmF2aWdhdGlvblNpZGViYXJQYW5l bC5qcwppbmRleCA2YzI5OGRhYmQyMmZjYzdhNDkxZTNjYTQ4NTEyZWMzNDNiOWM3ZjNlLi4zODRm NTk2NmQwZDU1OTQzYzcxOTZiNmZiNjkzNjcyNjYyM2VkODUwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZWNvcmRpbmdOYXZpZ2F0aW9uU2lk ZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1JlY29yZGluZ05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKQEAgLTE2NCwxNCArMTY0LDEx IEBAIFdJLlJlY29yZGluZ05hdmlnYXRpb25TaWRlYmFyUGFuZWwgPSBjbGFzcyBSZWNvcmRpbmdO YXZpZ2F0aW9uU2lkZWJhclBhbmVsIGV4dGVuCiAKICAgICBfZXhwb3J0TmF2aWdhdGlvbkl0ZW1D bGlja2VkKGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKCF0aGlzLl9yZWNvcmRpbmcpCisgICAg ICAgIGlmICghdGhpcy5fcmVjb3JkaW5nIHx8ICF0aGlzLmNvbnRlbnRCcm93c2VyIHx8ICF0aGlz LmNvbnRlbnRCcm93c2VyLmN1cnJlbnRDb250ZW50VmlldyB8fCAhdGhpcy5jb250ZW50QnJvd3Nl ci5jdXJyZW50Q29udGVudFZpZXcuc3VwcG9ydHNTYXZlKQogICAgICAgICAgICAgcmV0dXJuOwog CiAgICAgICAgIGNvbnN0IGZvcmNlU2F2ZUFzID0gdHJ1ZTsKLSAgICAgICAgV0kuc2F2ZURhdGFU b0ZpbGUoewotICAgICAgICAgICAgdXJsOiAid2ViLWluc3BlY3RvcjovLy9SZWNvcmRpbmcuanNv biIsCi0gICAgICAgICAgICBjb250ZW50OiBKU09OLnN0cmluZ2lmeSh0aGlzLl9yZWNvcmRpbmcu dG9KU09OKCkpLAotICAgICAgICB9LCBmb3JjZVNhdmVBcyk7CisgICAgICAgIFdJLnNhdmVEYXRh VG9GaWxlKHRoaXMuY29udGVudEJyb3dzZXIuY3VycmVudENvbnRlbnRWaWV3LnNhdmVEYXRhLCBm b3JjZVNhdmVBcyk7CiAgICAgfQogfTsKIAo=