175078 2017-08-02 10:44:45 -0700 check-webkit-style: deleting lines in a file runs the linter on the whole file 2017-08-02 15:36:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=86142 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap buildbot commit-queue ddkilzer glenn lforschler webkit-bug-importer oldest_to_newest 1334281 0 jbedard 2017-08-02 10:44:45 -0700 If we've only removed lines from a file, we will run the linter on the entire file. This is incorrect. 1334289 1 jbedard 2017-08-02 10:50:54 -0700 This was uncovered by <https://bugs.webkit.org/show_bug.cgi?id=86142>. 1334298 2 316974 jbedard 2017-08-02 10:58:28 -0700 Created attachment 316974 Patch 1334411 3 316974 ddkilzer 2017-08-02 14:56:39 -0700 Comment on attachment 316974 Patch r=me 1334441 4 316974 commit-queue 2017-08-02 15:35:47 -0700 Comment on attachment 316974 Patch Clearing flags on attachment: 316974 Committed r220158: <http://trac.webkit.org/changeset/220158> 1334442 5 commit-queue 2017-08-02 15:35:49 -0700 All reviewed patches have been landed. Closing bug. 1334444 6 webkit-bug-importer 2017-08-02 15:36:24 -0700 <rdar://problem/33687321> 316974 2017-08-02 10:58:28 -0700 2017-08-02 15:35:47 -0700 Patch bug-175078-20170802105828.patch text/plain 5229 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMDEzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE3LTA4LTAyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6IGRlbGV0aW5nIGxpbmVzIGluIGEgZmls ZSBydW5zIHRoZSBsaW50ZXIgb24gdGhlIHdob2xlIGZpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NTA3OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERlbGV0aW5nIGxpbmVzIGluIGEgZmlsZSBzaG91 bGQgbm90IGNhdXNlIGxpbnRlciBlcnJvcnMgdG8gYmUgYmxhbWVkIG9uIHRoZSBwYXRjaC4KKyAg ICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjE0Mj4gaXMg YW4gZXhhbXBsZSBvZiB0aGlzIGhhcHBlbmluZy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvdGVzdF9leHBlY3RhdGlvbnMucHk6CisgICAgICAgIChUZXN0RXhw ZWN0YXRpb25zQ2hlY2tlci5fc2hvdWxkX2xvZ19saW50ZXJfd2FybmluZyk6IERvIG5vdCBsb2cg YSBsaW50ZXIgZXJyb3IgaWYgdGhlIGZpbGUgaXQgaXMgYXNzb2NpYXRlZCB3aXRoIG9ubHkgaGFz IGRlbGV0ZWQgbGluZXMKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL21haW5fdW5p dHRlc3QucHk6CisgICAgICAgIChFeHBlY3RhdGlvbkxpbnRlckluU3R5bGVDaGVja2VyVGVzdC50 ZXN0X2xpbnRlcl9kdXBsaWNhdGVfbGluZSk6IEFkZGVkIGZpbGVzIHNob3VsZCBoYXZlIGV2ZXJ5 IGxpbmUgbnVtYmVyIGluIHRoZSBmaWxlIHdoZW4gcHJvY2Vzc2luZy4KKyAgICAgICAgKEV4cGVj dGF0aW9uTGludGVySW5TdHlsZUNoZWNrZXJUZXN0LnRlc3RfbGludGVyX2R1cGxpY2F0ZV9saW5l X29ubHlfZGVsZXRlcyk6IFRlc3QgY2FzZSB3aGVyZSB0aGUgZmlsZSB3aXRoIHRoZSBsaW50ZXIg ZXJyb3JzIG9ubHkgY29udGFpbmVkIGRlbGV0ZXMuCisgICAgICAgIChFeHBlY3RhdGlvbkxpbnRl ckluU3R5bGVDaGVja2VyVGVzdC50ZXN0X2xpbnRlcl9hZGRlZF9maWxlX3dpdGhfZXJyb3IpOiBB ZGRlZCBmaWxlcyBzaG91bGQgaGF2ZSBldmVyeSBsaW5lIG51bWJlciBpbiB0aGUgZmlsZSB3aGVu IHByb2Nlc3NpbmcuCisKIDIwMTctMDgtMDIgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFy b0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDTWFrZV0gUmVtb3ZlIG9ic29sZXRlIGNvZGUgaW4g VGVzdFdlYktpdEFQSS9DTWFrZUxpc3RzLnR4dApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9tYWluX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvbWFpbl91bml0dGVzdC5weQkocmV2aXNpb24gMjIwMTE1KQorKysgVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9tYWluX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBA IC0xMzAsNyArMTMwLDcgQEAgY2xhc3MgRXhwZWN0YXRpb25MaW50ZXJJblN0eWxlQ2hlY2tlclRl cwogICAgICAgICBzY29wZSA9IE91dHB1dENhcHR1cmVTY29wZSgpCiAgICAgICAgIHdpdGggc2Nv cGU6CiAgICAgICAgICAgICBmaWxlX3JlYWRlciA9IHNlbGYuX2dlbmVyYXRlX2ZpbGVfcmVhZGVy KGhvc3QuZmlsZXN5c3RlbSkKLSAgICAgICAgICAgIGZpbGVfcmVhZGVyLnByb2Nlc3NfcGF0aHMo eycvbW9jay1jaGVja291dC9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zJ30pCisgICAgICAg ICAgICBmaWxlX3JlYWRlci5wcm9jZXNzX2ZpbGUoJy9tb2NrLWNoZWNrb3V0L0xheW91dFRlc3Rz L1Rlc3RFeHBlY3RhdGlvbnMnLCBsaW5lX251bWJlcnM9WzEsIDIsIDNdKQogICAgICAgICAgICAg ZmlsZV9yZWFkZXIuZG9fYXNzb2NpYXRpb25fY2hlY2soJy9tb2NrLWNoZWNrb3V0JywgaG9zdCkK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgKICAgICAgICAgICAgIHNjb3BlLmNhcHR1cmVkX291 dHB1dCwKQEAgLTE2Miw2ICsxNjIsMTkgQEAgY2xhc3MgRXhwZWN0YXRpb25MaW50ZXJJblN0eWxl Q2hlY2tlclRlcwogICAgICAgICAgICAgZmlsZV9yZWFkZXIuZG9fYXNzb2NpYXRpb25fY2hlY2so Jy9tb2NrLWNoZWNrb3V0JywgaG9zdCkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzY29wZS5j YXB0dXJlZF9vdXRwdXQsICgnJywgJycsICcnKSkKIAorICAgIGRlZiB0ZXN0X2xpbnRlcl9kdXBs aWNhdGVfbGluZV9vbmx5X2RlbGV0ZXMoc2VsZik6CisgICAgICAgIGZpbGVzID0geworICAgICAg ICAgICAgJy9tb2NrLWNoZWNrb3V0L0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMnOgorICAg ICAgICAgICAgICAgICcjIFRlc3RFeHBlY3RhdGlvbnNcbmNzczEvdGVzdC5odG1sIFsgRmFpbHVy ZSBdXG5jc3MxL3Rlc3QuaHRtbCBbIEZhaWx1cmUgXVxuJ30KKyAgICAgICAgaG9zdCA9IHNlbGYu X2dlbmVyYXRlX3Rlc3RpbmdfaG9zdChmaWxlcykKKworICAgICAgICBzY29wZSA9IE91dHB1dENh cHR1cmVTY29wZSgpCisgICAgICAgIHdpdGggc2NvcGU6CisgICAgICAgICAgICBmaWxlX3JlYWRl ciA9IHNlbGYuX2dlbmVyYXRlX2ZpbGVfcmVhZGVyKGhvc3QuZmlsZXN5c3RlbSkKKyAgICAgICAg ICAgIGZpbGVfcmVhZGVyLnByb2Nlc3NfZmlsZSgnL21vY2stY2hlY2tvdXQvTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucycpCisgICAgICAgICAgICBmaWxlX3JlYWRlci5kb19hc3NvY2lhdGlv bl9jaGVjaygnL21vY2stY2hlY2tvdXQnLCBob3N0KQorICAgICAgICBzZWxmLmFzc2VydEVxdWFs KHNjb3BlLmNhcHR1cmVkX291dHB1dCwgKCcnLCAnJywgJycpKQorCiAgICAgZGVmIHRlc3RfbGlu dGVyX2FkZGVkX2ZpbGVfd2l0aF9lcnJvcihzZWxmKToKICAgICAgICAgZmlsZXMgPSB7CiAgICAg ICAgICAgICAnL21vY2stY2hlY2tvdXQvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyc6CkBA IC0xNzEsNyArMTg0LDcgQEAgY2xhc3MgRXhwZWN0YXRpb25MaW50ZXJJblN0eWxlQ2hlY2tlclRl cwogICAgICAgICBzY29wZSA9IE91dHB1dENhcHR1cmVTY29wZSgpCiAgICAgICAgIHdpdGggc2Nv cGU6CiAgICAgICAgICAgICBmaWxlX3JlYWRlciA9IHNlbGYuX2dlbmVyYXRlX2ZpbGVfcmVhZGVy KGhvc3QuZmlsZXN5c3RlbSkKLSAgICAgICAgICAgIGZpbGVfcmVhZGVyLnByb2Nlc3NfZmlsZSgn L21vY2stY2hlY2tvdXQvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucycsIGxpbmVfbnVtYmVy cz1Ob25lKQorICAgICAgICAgICAgZmlsZV9yZWFkZXIucHJvY2Vzc19maWxlKCcvbW9jay1jaGVj a291dC9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zJywgbGluZV9udW1iZXJzPVsxLCAyLCAz XSkKICAgICAgICAgICAgIGZpbGVfcmVhZGVyLmRvX2Fzc29jaWF0aW9uX2NoZWNrKCcvbW9jay1j aGVja291dCcsIGhvc3QpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2NvcGUuY2FwdHVyZWRf b3V0cHV0LCAoJycsICcnLCAnL21vY2stY2hlY2tvdXQvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0 aW9uczozOiAgRHVwbGljYXRlIG9yIGFtYmlndW91cyBlbnRyeSBsaW5lcyBMYXlvdXRUZXN0cy9U ZXN0RXhwZWN0YXRpb25zOjIgYW5kIExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnM6My4gIFt0 ZXN0L2V4cGVjdGF0aW9uc10gWzVdXG4nKSkKIApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy90ZXN0X2V4cGVjdGF0aW9ucy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CShy ZXZpc2lvbiAyMjAxMTUpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L3Rlc3RfZXhwZWN0YXRpb25zLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsOSArMTAwLDEwIEBA IGNsYXNzIFRlc3RFeHBlY3RhdGlvbnNDaGVja2VyKG9iamVjdCk6CiAKICAgICBAc3RhdGljbWV0 aG9kCiAgICAgZGVmIF9zaG91bGRfbG9nX2xpbnRlcl93YXJuaW5nKHdhcm5pbmcsIGZpbGVzLCBj d2QsIGhvc3QpOgotICAgICAgICAjIENhc2UgMSwgdGhlIGxpbmUgdGhlIHdhcm5pbmcgd2FzIHRp ZWQgdG8gaXMgaW4gb3VyIHBhdGNoLgogICAgICAgICBhYnNfZmlsZW5hbWUgPSBob3N0LmZpbGVz eXN0ZW0uam9pbihjd2QsIHdhcm5pbmcuZmlsZW5hbWUpCi0gICAgICAgIGlmIGFic19maWxlbmFt ZSBpbiBmaWxlcyBhbmQgKGZpbGVzW2Fic19maWxlbmFtZV0gaXMgTm9uZSBvciB3YXJuaW5nLmxp bmVfbnVtYmVyIGluIGZpbGVzW2Fic19maWxlbmFtZV0pOgorCisgICAgICAgICMgQ2FzZSAxLCB0 aGUgbGluZSB0aGUgd2FybmluZyB3YXMgdGllZCB0byBpcyBpbiBvdXIgcGF0Y2guCisgICAgICAg IGlmIGFic19maWxlbmFtZSBpbiBmaWxlcyBhbmQgZmlsZXNbYWJzX2ZpbGVuYW1lXSBhbmQgd2Fy bmluZy5saW5lX251bWJlciBpbiBmaWxlc1thYnNfZmlsZW5hbWVdOgogICAgICAgICAgICAgcmV0 dXJuIFRydWUKIAogICAgICAgICBmb3IgZmlsZSwgbGluZXMgaW4gd2FybmluZy5yZWxhdGVkX2Zp bGVzLml0ZXJpdGVtcygpOgpAQCAtMTE1LDcgKzExNiw3IEBAIGNsYXNzIFRlc3RFeHBlY3RhdGlv bnNDaGVja2VyKG9iamVjdCk6CiAKICAgICAgICAgICAgICAgICAjIENhc2UgMywgYSBsaW5lIGFz c29jaWF0ZWQgd2l0aCB0aGUgd2FybmluZyBpcyBpbiBvdXIgcGF0Y2guCiAgICAgICAgICAgICAg ICAgZm9yIGxpbmUgaW4gbGluZXM6Ci0gICAgICAgICAgICAgICAgICAgIGlmIGxpbmUgaW4gZmls ZXNbYWJzX2ZpbGVuYW1lXToKKyAgICAgICAgICAgICAgICAgICAgaWYgZmlsZXNbYWJzX2ZpbGVu YW1lXSBhbmQgbGluZSBpbiBmaWxlc1thYnNfZmlsZW5hbWVdOgogICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIFRydWUKICAgICAgICAgcmV0dXJuIEZhbHNlCiAK