174920 2017-07-27 19:38:39 -0700 DirectArguments should be in the JSValue gigacage 2017-08-11 13:09:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 174919 174917 1 fpizlo fpizlo ggaren jfbastien keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1332834 0 fpizlo 2017-07-27 19:38:39 -0700 ... 1337932 1 317938 fpizlo 2017-08-11 10:58:46 -0700 Created attachment 317938 the patch 1337956 2 317938 msaboff 2017-08-11 11:52:58 -0700 Comment on attachment 317938 the patch r=me 1337977 3 fpizlo 2017-08-11 13:08:49 -0700 Landed in https://trac.webkit.org/changeset/220606/webkit 1337979 4 webkit-bug-importer 2017-08-11 13:09:37 -0700 <rdar://problem/33854395> 317938 2017-08-11 10:58:46 -0700 2017-08-11 11:52:58 -0700 the patch blah.patch text/plain 6556 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIwNjAxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE3LTA4LTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RGlyZWN0QXJndW1lbnRzIHNob3VsZCBiZSBpbiB0aGUgSlNWYWx1ZSBnaWdhY2FnZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0OTIwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBUaGlzIHB1 dHMgRGlyZWN0QXJndW1lbnRzIGluIGEgbmV3IHN1YnNwYWNlIGZvciBjZWxscyB0aGF0IHdhbnQg dG8gYmUgaW4gdGhlIEpTVmFsdWUgZ2lnYWNhZ2UuIEFsbAorICAgICAgICBpbmRleGVkIGFjY2Vz c2VzIHRvIERpcmVjdEFyZ3VtZW50cyBub3cgZG8gY2FnaW5nLiBnZXRfZnJvbV9hcmd1bWVudHMv cHV0X3RvX2FyZ3VtZW50cyBhcmUgZXhlbXB0ZWQKKyAgICAgICAgYmVjYXVzZSB0aGV5IGFsd2F5 cyBvcGVyYXRlIG9uIGEgRGlyZWN0QXJndW1lbnRzIHRoYXQgaXMgcG9pbnRlZCB0byBkaXJlY3Rs eSBmcm9tIHRoZSBzdGFjaywgdGhleSBhcmUKKyAgICAgICAgcmVxdWlyZWQgdG8gdXNlIGZpeGVk IG9mZnNldHMsIGFuZCB5b3UgY2FuIG9ubHkgc3RvcmUgSlNWYWx1ZXMuCisKKyAgICAgICAgKiBk ZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZl SklUOjpjb21waWxlR2V0QnlWYWxPbkRpcmVjdEFyZ3VtZW50cyk6CisgICAgICAgICogZnRsL0ZU TExvd2VyREZHVG9CMy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6 OmNvbXBpbGVHZXRCeVZhbCk6CisgICAgICAgICogaml0L0pJVFByb3BlcnR5QWNjZXNzLmNwcDoK KyAgICAgICAgKEpTQzo6SklUOjplbWl0RGlyZWN0QXJndW1lbnRzR2V0QnlWYWwpOgorICAgICAg ICAqIHJ1bnRpbWUvRGlyZWN0QXJndW1lbnRzLmg6CisgICAgICAgIChKU0M6OkRpcmVjdEFyZ3Vt ZW50czo6c3Vic3BhY2VGb3IpOgorICAgICAgICAoSlNDOjpEaXJlY3RBcmd1bWVudHM6OnN0b3Jh Z2UpOgorICAgICAgICAqIHJ1bnRpbWUvVk0uY3BwOgorICAgICAgICAoSlNDOjpWTTo6Vk0pOgor ICAgICAgICAqIHJ1bnRpbWUvVk0uaDoKKwogMjAxNy0wOC0xMCAgU2FtIFdlaW5pZyAgPHNhbUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFdURjo6RnVuY3Rpb24gZG9lcyBub3QgYWxsb3cgZm9yIHJl ZmVyZW5jZSAvIG5vbi1kZWZhdWx0IGNvbnN0cnVjdGlibGUgcmV0dXJuIHR5cGVzCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkocmV2 aXNpb24gMjIwNTk2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2 ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYyNDYsNiArNjI0Niw4IEBAIHZvaWQgU3BlY3Vs YXRpdmVKSVQ6OmNvbXBpbGVHZXRCeVZhbE9uRGkKICAgICAgICAgICAgIE1hY3JvQXNzZW1ibGVy OjpBYm92ZU9yRXF1YWwsIHByb3BlcnR5UmVnLAogICAgICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6 OkFkZHJlc3MoYmFzZVJlZywgRGlyZWN0QXJndW1lbnRzOjpvZmZzZXRPZkxlbmd0aCgpKSkpOwog ICAgIAorICAgIG1faml0LmNhZ2UoR2lnYWNhZ2U6OkpTVmFsdWUsIGJhc2VSZWcpOworICAgIAog ICAgIG1faml0LmxvYWRWYWx1ZSgKICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6OkJhc2VJbmRleCgK ICAgICAgICAgICAgIGJhc2VSZWcsIHByb3BlcnR5UmVnLCBNYWNyb0Fzc2VtYmxlcjo6VGltZXNF aWdodCwgRGlyZWN0QXJndW1lbnRzOjpzdG9yYWdlT2Zmc2V0KCkpLApJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAkocmV2aXNpb24gMjIwNTk2 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvQjMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNTE2LDEwICszNTE2LDggQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAg ICAgICAgaW5kZXgsCiAgICAgICAgICAgICAgICAgICAgIG1fb3V0LmxvYWQzMk5vbk5lZ2F0aXZl KGJhc2UsIG1faGVhcHMuRGlyZWN0QXJndW1lbnRzX2xlbmd0aCkpKTsKIAotICAgICAgICAgICAg Ly8gRklYTUU6IEkgZ3Vlc3Mgd2UgbmVlZCB0byBjYWdlIERpcmVjdEFyZ3VtZW50cz8KLSAgICAg ICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ5MjAK ICAgICAgICAgICAgIFR5cGVkUG9pbnRlciBhZGRyZXNzID0gbV9vdXQuYmFzZUluZGV4KAotICAg ICAgICAgICAgICAgIG1faGVhcHMuRGlyZWN0QXJndW1lbnRzX3N0b3JhZ2UsIGJhc2UsIG1fb3V0 Lnplcm9FeHRQdHIoaW5kZXgpKTsKKyAgICAgICAgICAgICAgICBtX2hlYXBzLkRpcmVjdEFyZ3Vt ZW50c19zdG9yYWdlLCBjYWdlZChHaWdhY2FnZTo6SlNWYWx1ZSwgYmFzZSksIG1fb3V0Lnplcm9F eHRQdHIoaW5kZXgpKTsKICAgICAgICAgICAgIHNldEpTVmFsdWUobV9vdXQubG9hZDY0KGFkZHJl c3MpKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAJKHJldmlzaW9uIDIyMDU5 NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNTExLDYgKzE1MTEsNyBAQCBKSVQ6Okp1bXBMaXN0IEpJVDo6ZW1p dERpcmVjdEFyZ3VtZW50c0dlCiAgICAgc2xvd0Nhc2VzLmFwcGVuZChicmFuY2hUZXN0UHRyKE5v blplcm8sIEFkZHJlc3MoYmFzZSwgRGlyZWN0QXJndW1lbnRzOjpvZmZzZXRPZk1hcHBlZEFyZ3Vt ZW50cygpKSkpOwogICAgIAogICAgIHplcm9FeHRlbmQzMlRvUHRyKHByb3BlcnR5LCBzY3JhdGNo KTsKKyAgICBjYWdlKEdpZ2FjYWdlOjpKU1ZhbHVlLCBiYXNlKTsKICAgICBsb2FkVmFsdWUoQmFz ZUluZGV4KGJhc2UsIHNjcmF0Y2gsIFRpbWVzRWlnaHQsIERpcmVjdEFyZ3VtZW50czo6c3RvcmFn ZU9mZnNldCgpKSwgcmVzdWx0KTsKICAgICAKICAgICByZXR1cm4gc2xvd0Nhc2VzOwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGlyZWN0QXJndW1lbnRzLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRGlyZWN0QXJndW1lbnRzLmgJKHJl dmlzaW9uIDIyMDU5NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RpcmVjdEFy Z3VtZW50cy5oCSh3b3JraW5nIGNvcHkpCkBAIC00Niw2ICs0NiwxMyBAQCBwcml2YXRlOgogICAg IERpcmVjdEFyZ3VtZW50cyhWTSYsIFN0cnVjdHVyZSosIHVuc2lnbmVkIGxlbmd0aCwgdW5zaWdu ZWQgY2FwYWNpdHkpOwogICAgIAogcHVibGljOgorICAgIHRlbXBsYXRlPHR5cGVuYW1lIENlbGxU eXBlPgorICAgIHN0YXRpYyBTdWJzcGFjZSogc3Vic3BhY2VGb3IoVk0mIHZtKQorICAgIHsKKyAg ICAgICAgUkVMRUFTRV9BU1NFUlQoIUNlbGxUeXBlOjpuZWVkc0Rlc3RydWN0aW9uKTsKKyAgICAg ICAgcmV0dXJuICZ2bS5qc1ZhbHVlR2lnYWNhZ2VDZWxsU3BhY2U7CisgICAgfQorCiAgICAgLy8g Q3JlYXRlcyBhbiBhcmd1bWVudHMgb2JqZWN0IGJ1dCBsZWF2ZXMgaXQgdW5pbml0aWFsaXplZC4g VGhpcyBpcyBkYW5nZXJvdXMgaWYgd2UgR0MgcmlnaHQKICAgICAvLyBhZnRlciBhbGxvY2F0aW9u LgogICAgIHN0YXRpYyBEaXJlY3RBcmd1bWVudHMqIGNyZWF0ZVVuaW5pdGlhbGl6ZWQoVk0mLCBT dHJ1Y3R1cmUqLCB1bnNpZ25lZCBsZW5ndGgsIHVuc2lnbmVkIGNhcGFjaXR5KTsKQEAgLTE1Nyw3 ICsxNjQsNyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIFdyaXRlQmFycmllcjxVbmtub3duPiog c3RvcmFnZSgpCiAgICAgewotICAgICAgICByZXR1cm4gYml0d2lzZV9jYXN0PFdyaXRlQmFycmll cjxVbmtub3duPio+KGJpdHdpc2VfY2FzdDxjaGFyKj4odGhpcykgKyBzdG9yYWdlT2Zmc2V0KCkp OworICAgICAgICByZXR1cm4gYml0d2lzZV9jYXN0PFdyaXRlQmFycmllcjxVbmtub3duPio+KGJp dHdpc2VfY2FzdDxjaGFyKj4oR2lnYWNhZ2U6OmNhZ2VkKEdpZ2FjYWdlOjpKU1ZhbHVlLCB0aGlz KSkgKyBzdG9yYWdlT2Zmc2V0KCkpOwogICAgIH0KICAgICAKICAgICB1bnNpZ25lZCBtYXBwZWRB cmd1bWVudHNTaXplKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCShy ZXZpc2lvbiAyMjA1OTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE3MSw2ICsxNzEsNyBAQCBWTTo6Vk0oVk1UeXBlIHZtVHlwZSwg SGVhcFR5cGUgaGVhcFR5cGUpCiAgICAgLCBwcmltaXRpdmVHaWdhY2FnZUF1eGlsaWFyeVNwYWNl KCJQcmltaXRpdmUgR2lnYWNhZ2UgQXV4aWxpYXJ5IiwgaGVhcCwgQWxsb2NhdG9yQXR0cmlidXRl cyhEb2VzTm90TmVlZERlc3RydWN0aW9uLCBIZWFwQ2VsbDo6QXV4aWxpYXJ5KSwgcHJpbWl0aXZl R2lnYWNhZ2VBbGxvY2F0b3IuZ2V0KCkpCiAgICAgLCBqc1ZhbHVlR2lnYWNhZ2VBdXhpbGlhcnlT cGFjZSgiSlNWYWx1ZSBHaWdhY2FnZSBBdXhpbGlhcnkiLCBoZWFwLCBBbGxvY2F0b3JBdHRyaWJ1 dGVzKERvZXNOb3ROZWVkRGVzdHJ1Y3Rpb24sIEhlYXBDZWxsOjpBdXhpbGlhcnkpLCBqc1ZhbHVl R2lnYWNhZ2VBbGxvY2F0b3IuZ2V0KCkpCiAgICAgLCBjZWxsU3BhY2UoIkpTQ2VsbCIsIGhlYXAs IEFsbG9jYXRvckF0dHJpYnV0ZXMoRG9lc05vdE5lZWREZXN0cnVjdGlvbiwgSGVhcENlbGw6OkpT Q2VsbCksIGZhc3RNYWxsb2NBbGxvY2F0b3IuZ2V0KCkpCisgICAgLCBqc1ZhbHVlR2lnYWNhZ2VD ZWxsU3BhY2UoIkpTVmFsdWUgR2lnYWNhZ2UgSlNDZWxsIiwgaGVhcCwgQWxsb2NhdG9yQXR0cmli dXRlcyhEb2VzTm90TmVlZERlc3RydWN0aW9uLCBIZWFwQ2VsbDo6SlNDZWxsKSwganNWYWx1ZUdp Z2FjYWdlQWxsb2NhdG9yLmdldCgpKQogICAgICwgZGVzdHJ1Y3RpYmxlQ2VsbFNwYWNlKCJEZXN0 cnVjdGlibGUgSlNDZWxsIiwgaGVhcCwgQWxsb2NhdG9yQXR0cmlidXRlcyhOZWVkc0Rlc3RydWN0 aW9uLCBIZWFwQ2VsbDo6SlNDZWxsKSwgZmFzdE1hbGxvY0FsbG9jYXRvci5nZXQoKSkKICAgICAs IHN0cmluZ1NwYWNlKCJKU1N0cmluZyIsIGhlYXAsIGZhc3RNYWxsb2NBbGxvY2F0b3IuZ2V0KCkp CiAgICAgLCBkZXN0cnVjdGlibGVPYmplY3RTcGFjZSgiSlNEZXN0cnVjdGlibGVPYmplY3QiLCBo ZWFwLCBmYXN0TWFsbG9jQWxsb2NhdG9yLmdldCgpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvVk0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9WTS5oCShyZXZpc2lvbiAyMjA1OTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9WTS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMTUsNiArMzE1LDcgQEAgcHVibGljOgogICAg IAogICAgIC8vIFdoZW5ldmVyIHBvc3NpYmxlLCB1c2Ugc3Vic3BhY2VGb3I8Q2VsbFR5cGU+KHZt KSB0byBnZXQgb25lIG9mIHRoZXNlIHN1YnNwYWNlcy4KICAgICBTdWJzcGFjZSBjZWxsU3BhY2U7 CisgICAgU3Vic3BhY2UganNWYWx1ZUdpZ2FjYWdlQ2VsbFNwYWNlOwogICAgIFN1YnNwYWNlIGRl c3RydWN0aWJsZUNlbGxTcGFjZTsKICAgICBKU1N0cmluZ1N1YnNwYWNlIHN0cmluZ1NwYWNlOwog ICAgIEpTRGVzdHJ1Y3RpYmxlT2JqZWN0U3Vic3BhY2UgZGVzdHJ1Y3RpYmxlT2JqZWN0U3BhY2U7 Cg==