174674 2017-07-20 07:14:09 -0700 [WPE] Implement click counting in mouse events 2023-07-06 09:45:48 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 173419 189664 216899 1 csaavedra dpino aperez bugs-noreply clopez darin lmoura zan oldest_to_newest 1330613 0 csaavedra 2017-07-20 07:14:09 -0700 WPE does not provide single-, double-, etc. click information, but this can be implemented in WebEventFactory. This missing information currently breaks fast/events/click-count.html. 1332631 1 316544 csaavedra 2017-07-27 04:08:03 -0700 Created attachment 316544 Patch 1332908 2 316544 zan 2017-07-27 23:42:49 -0700 Comment on attachment 316544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316544&action=review > Source/WebKit/Shared/wpe/WebEventFactory.cpp:89 > + static struct wpe_input_pointer_event m_lastClickEvent; This should be zero-initialized: `static struct wpe_input_pointer_event m_lastClickEvent = { 0, };` Might be the zero-init is guaranteed because the variable is static, but it's better to be explicit. > Source/WebKit/Shared/wpe/WebEventFactory.cpp:99 > + if (event->time - m_lastClickEvent.time < 1 && event->x == m_lastClickEvent.x && event->y == m_lastClickEvent.y && event->button == m_lastClickEvent.button) > + m_clickCount++; > + else > + m_clickCount = 1; Difference in time between the two events should be somehow made configurable in the future. I don't know exactly what time unit is used for the input event time, and it could differ from platform to platform anyway. Should the click count be upwards-limited? As it stands it can grow uncapped. 1332942 3 316544 csaavedra 2017-07-28 05:03:17 -0700 Comment on attachment 316544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316544&action=review >> Source/WebKit/Shared/wpe/WebEventFactory.cpp:99 >> + m_clickCount = 1; > > Difference in time between the two events should be somehow made configurable in the future. I don't know exactly what time unit is used for the input event time, and it could differ from platform to platform anyway. > > Should the click count be upwards-limited? As it stands it can grow uncapped. It only grows if it's happening in the same position and quickly enough to be counted as consecutive clicks, otherwise it is reset back to 1. WebKit uses this count to decide when it's a double or a triple click, and then again single, double, etc. As is I don't think it's a problem if it keeps growing.. As for the time between events, it seems to be a timestamp, so it's seconds. We can make it configurable at some point, not sure where would that go. 1332955 4 316637 csaavedra 2017-07-28 07:06:01 -0700 Created attachment 316637 Patch 1333338 5 316637 darin 2017-07-30 14:19:45 -0700 Comment on attachment 316637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316637&action=review > Source/WebKit/Shared/wpe/WebEventFactory.cpp:90 > + static struct wpe_input_pointer_event m_lastClickEvent = { }; > + static unsigned m_clickCount = 1; A function-private global variable should not have the prefix "m_" like this. The design pattern here is dangerous. It requires that we ask this question about each event once. If you call the function a second time or call it out of order then it does the wrong thing. I don’t see code elsewhere that guarantees or relies that this will be called exactly once for each event. > Source/WebKit/Shared/wpe/WebEventFactory.cpp:96 > + if (event->time - m_lastClickEvent.time < 1 && event->x == m_lastClickEvent.x && event->y == m_lastClickEvent.y && event->button == m_lastClickEvent.button) Typically, requiring that x and y being exactly the same is too strict a rule for double clicking. What is the unit for "time"? Typically 1 second is too long a time to define close enough in time to be a double click. 1358832 6 316637 clopez 2017-10-10 12:13:41 -0700 Comment on attachment 316637 Patch Setting r- due to Darin comments, please address them and upload a new patch. 1965055 7 dpino 2023-07-04 22:03:46 -0700 Pull request: https://github.com/webkit/webkit/pull/15555 1965371 8 ews-feeder 2023-07-06 09:45:41 -0700 Committed 265808@main (0482f3984fab): <https://commits.webkit.org/265808@main> Reviewed commits have been landed. Closing PR #15555 and removing active labels. 316544 2017-07-27 04:08:03 -0700 2017-07-28 07:05:58 -0700 Patch bug-174674-20170727140802.patch text/plain 5509 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjE5OTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI5NTcwMGRjYTFmNWViYzFj MmQ5YzUyYTc3NzZjNzQ4Y2FhZDA3OGMuLmIzNTA5ZDc5OGFmZDViZTFiZDhlYzA0MTUzMTU5M2Zj MGViZTY0MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDctMjcgIENsYXVkaW8g U2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBJbXBsZW1l bnQgY2xpY2sgY291bnRpbmcgaW4gbW91c2UgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ2NzQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXUEUgZG9lcyBub3QgcHJvdmlkZSBjbGljay9kb3Vi bGVjbGljay9ldGMgaW5mb3JtYXRpb24gaW4gaXRzCisgICAgICAgIHBvaW50ZXIgZXZlbnRzLCBi dXQgdGhlc2UgY2FuIGJlIGNvdW50ZWQgaW4gdGhlIGV2ZW50IGZhY3RvcnkuCisKKyAgICAgICAg KiBTaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkV2 ZW50RmFjdG9yeTo6Y2xpY2tDb3VudEZvckV2ZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViRXZl bnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2ZW50KToKKyAgICAgICAgKiBTaGFyZWQvd3BlL1dl YkV2ZW50RmFjdG9yeS5oOgorCiAyMDE3LTA3LTI2ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzIEFQSSB0ZXN0cyBmYWls IG9uIEVsIENhcGl0YW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC93cGUvV2Vi RXZlbnRGYWN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3Rv cnkuY3BwCmluZGV4IDU1NzFlMWFhYzk3NmQ1NzlkOWFhOTNmMGY3NWI3YzE0Y2EwZjE0NjIuLmJm N2VmODEzYzk0OTUyODAwNWVkNjE1MDc1MzIzOGY5ZDFmODAxMzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCkBAIC04NCw2ICs4NCwyNSBAQCBXZWJL ZXlib2FyZEV2ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViS2V5Ym9hcmRFdmVudChzdHJ1 Y3Qgd3BlX2lucHV0X2tleWJvYQogICAgICAgICBtb2RpZmllcnNGb3JFdmVudChldmVudCksIGV2 ZW50LT50aW1lKTsKIH0KIAordW5zaWduZWQgV2ViRXZlbnRGYWN0b3J5OjpjbGlja0NvdW50Rm9y RXZlbnQoc3RydWN0IHdwZV9pbnB1dF9wb2ludGVyX2V2ZW50KiBldmVudCkKK3sKKyAgICBzdGF0 aWMgc3RydWN0IHdwZV9pbnB1dF9wb2ludGVyX2V2ZW50IG1fbGFzdENsaWNrRXZlbnQ7CisgICAg c3RhdGljIHVuc2lnbmVkIG1fY2xpY2tDb3VudCA9IDE7CisKKyAgICAvLyBXZSBhcmUgb25seSBj b25jZXJuZWQgd2l0aCBwcmVzcyBidXR0b24gZXZlbnRzLiBPdGhlciBldmVudHMgZG8gbm90IGFs dGVyIHRoZSBjbGljayBjb3VudC4KKyAgICBpZiAoZXZlbnQtPnR5cGUgIT0gd3BlX2lucHV0X3Bv aW50ZXJfZXZlbnRfdHlwZV9idXR0b24gfHwgZXZlbnQtPnN0YXRlICE9IDEpCisgICAgICAgIHJl dHVybiBtX2NsaWNrQ291bnQ7CisKKyAgICBpZiAoZXZlbnQtPnRpbWUgLSBtX2xhc3RDbGlja0V2 ZW50LnRpbWUgPCAxICYmIGV2ZW50LT54ID09IG1fbGFzdENsaWNrRXZlbnQueCAmJiBldmVudC0+ eSA9PSBtX2xhc3RDbGlja0V2ZW50LnkgJiYgZXZlbnQtPmJ1dHRvbiA9PSBtX2xhc3RDbGlja0V2 ZW50LmJ1dHRvbikKKyAgICAgICAgbV9jbGlja0NvdW50Kys7CisgICAgZWxzZQorICAgICAgICBt X2NsaWNrQ291bnQgPSAxOworCisgICAgbV9sYXN0Q2xpY2tFdmVudCA9ICpldmVudDsKKworICAg IHJldHVybiBtX2NsaWNrQ291bnQ7Cit9CisKIFdlYk1vdXNlRXZlbnQgV2ViRXZlbnRGYWN0b3J5 OjpjcmVhdGVXZWJNb3VzZUV2ZW50KHN0cnVjdCB3cGVfaW5wdXRfcG9pbnRlcl9ldmVudCogZXZl bnQsIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKQogewogICAgIFdlYkV2ZW50OjpUeXBlIHR5cGUg PSBXZWJFdmVudDo6Tm9UeXBlOwpAQCAtMTEzLDEzICsxMzIsMTEgQEAgV2ViTW91c2VFdmVudCBX ZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYk1vdXNlRXZlbnQoc3RydWN0IHdwZV9pbnB1dF9wb2lu dGVyX2V2ZW4KICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogCi0gICAgdW5z aWduZWQgY2xpY2tDb3VudCA9ICh0eXBlID09IFdlYkV2ZW50OjpNb3VzZURvd24pID8gMSA6IDA7 Ci0KLSAgICAvLyBGSVhNRTogUHJvcGVyIGJ1dHRvbiBzdXBwb3J0LiBNb2RpZmllcnMuIGRlbHRh WC9ZL1ouIENsaWNrIGNvdW50LgorICAgIC8vIEZJWE1FOiBQcm9wZXIgYnV0dG9uIHN1cHBvcnQu IE1vZGlmaWVycy4gZGVsdGFYL1kvWi4KICAgICBXZWJDb3JlOjpJbnRQb2ludCBwb3NpdGlvbihl dmVudC0+eCwgZXZlbnQtPnkpOwogICAgIHBvc2l0aW9uLnNjYWxlKDEgLyBkZXZpY2VTY2FsZUZh Y3Rvcik7CiAgICAgcmV0dXJuIFdlYk1vdXNlRXZlbnQodHlwZSwgYnV0dG9uLCBwb3NpdGlvbiwg cG9zaXRpb24sCi0gICAgICAgIDAsIDAsIDAsIGNsaWNrQ291bnQsIHN0YXRpY19jYXN0PFdlYkV2 ZW50OjpNb2RpZmllcnM+KDApLCBldmVudC0+dGltZSk7CisgICAgICAgIDAsIDAsIDAsIGNsaWNr Q291bnRGb3JFdmVudChldmVudCksIHN0YXRpY19jYXN0PFdlYkV2ZW50OjpNb2RpZmllcnM+KDAp LCBldmVudC0+dGltZSk7CiB9CiAKIFdlYldoZWVsRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVh dGVXZWJXaGVlbEV2ZW50KHN0cnVjdCB3cGVfaW5wdXRfYXhpc19ldmVudCogZXZlbnQsIGZsb2F0 IGRldmljZVNjYWxlRmFjdG9yKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvd3Bl L1dlYkV2ZW50RmFjdG9yeS5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvd3BlL1dlYkV2ZW50RmFj dG9yeS5oCmluZGV4IGEyYWEwMzQ1MGQzOGYzNGIxMWMxMmZmY2IxZWZiNTBjYWMwZGY3OTEuLjY1 NWU0YmMxMWVhZDIxZGNiOGY0ZjY2ZWI3NTM4MGE2MzFiNDVjOTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC93cGUvV2ViRXZlbnRGYWN0b3J5LmgKQEAgLTQwLDYgKzQwLDkgQEAgcHVibGljOgog ICAgIHN0YXRpYyBXZWJNb3VzZUV2ZW50IGNyZWF0ZVdlYk1vdXNlRXZlbnQoc3RydWN0IHdwZV9p bnB1dF9wb2ludGVyX2V2ZW50KiwgZmxvYXQgZGV2aWNlU2NhbGVGYWN0b3IpOwogICAgIHN0YXRp YyBXZWJXaGVlbEV2ZW50IGNyZWF0ZVdlYldoZWVsRXZlbnQoc3RydWN0IHdwZV9pbnB1dF9heGlz X2V2ZW50KiwgZmxvYXQgZGV2aWNlU2NhbGVGYWN0b3IpOwogICAgIHN0YXRpYyBXZWJUb3VjaEV2 ZW50IGNyZWF0ZVdlYlRvdWNoRXZlbnQoc3RydWN0IHdwZV9pbnB1dF90b3VjaF9ldmVudCosIGZs b2F0IGRldmljZVNjYWxlRmFjdG9yKTsKKworcHJpdmF0ZToKKyAgICBzdGF0aWMgdW5zaWduZWQg Y2xpY2tDb3VudEZvckV2ZW50KHN0cnVjdCB3cGVfaW5wdXRfcG9pbnRlcl9ldmVudCopOwogfTsK IAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTkwZDBkMzRlMzIwYzE0MjY1MWQ3NTcw NWYzZWI3NzhmODVmZTk4Zi4uNjA0YjI2NmNmOWZjYjFjNmJiYzMwNWVhYTExZjlkYzJkYmZlODk2 OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE3LTA3LTI3ICBDbGF1ZGlvIFNhYXZlZHJhICA8 Y3NhYXZlZHJhQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW1dQRV0gSW1wbGVtZW50IGNsaWNrIGNv dW50aW5nIGluIG1vdXNlIGV2ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc0Njc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9uczogUmVtb3ZlIHRl c3RzIHRoYXQgcGFzcyBub3cuCisKKzIwMTctMDctMjcgIENsYXVkaW8gU2FhdmVkcmEgIDxjc2Fh dmVkcmFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbV1BFXSBJbXBsZW1lbnQgRXZlbnRTZW5kZXJQ cm94eSBpbiBXVFIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MzQxOQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVzdEV4 cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zCmlu ZGV4IDZjODEyMzQxZjcwYWNiZjUxZjU4N2U2OTEwMDA0ZGE0NTMyZmFiYmYuLjU4N2FkYzRjOWMx NzEzZWJmM2NmZTk1NjQ5YWIzNDZkMzViM2JhNzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dw ZS9UZXN0RXhwZWN0YXRpb25zCkBAIC0yNzgsMTMgKzI3OCw2IEBAIHdlYmtpdC5vcmcvYi8xNzQ2 NzMgZmFzdC9ldmVudHMva2V5Ym9hcmRldmVudC1rZXkuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0 Lm9yZy9iLzE3NDY3MyBmYXN0L2V2ZW50cy9rZXktZXZlbnRzLWluLWlucHV0LWJ1dHRvbi5odG1s IFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTc0NjczIGZhc3QvZXZlbnRzL2tleS1ldmVudHMt aW4taW5wdXQtdGV4dC5odG1sIFsgRmFpbHVyZSBdCiAKLSMgY2xpY2tDb3VudCByZWxhdGVkIGZh aWx1cmVzCi13ZWJraXQub3JnL2IvMTc0Njc0IGZhc3QvZXZlbnRzL2NsaWNrLWNvdW50Lmh0bWwg WyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNzQ2NzQgZmFzdC9ldmVudHMvZGJsY2xpY2stYWRk RXZlbnRMaXN0ZW5lci5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTc0Njc0IGZhc3Qv ZXZlbnRzL21vdXNlLWNsaWNrLWV2ZW50cy5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2Iv MTc0Njc0IGZhc3QvZXZlbnRzL3NlbGVjdHN0YXJ0LWJ5LWRvdWJsZS10cmlwbGUtY2xpY2tzLmh0 bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xNzQ2NzQgZmFzdC9ldmVudHMvem9vbS1kYmxj bGljay5odG1sIFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi84NDY5MiBmYXN0L2V2ZW50cy9h dHRlbXB0LXNjcm9sbC13aXRoLW5vLXNjcm9sbGJhcnMuaHRtbCBbIEZhaWx1cmUgXQogCiAjIEVO QUJMRV9QUk9YSU1JVFlfRVZFTlRTIGlzIE9GRiBpbiBXUEUuCg== 316637 2017-07-28 07:06:01 -0700 2017-10-10 12:13:41 -0700 Patch bug-174674-20170728170600.patch text/plain 7219 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjIwMDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcyM2Y1YjQwYjIwNzAxZjgy NGYwNjQ5ZGFkMGFjYWJlZjMxY2VkMDEuLmExMmM5ZDkwYWQzOGYyYjY4MmQzYmNhNWQ2MzcwZjQ2 Y2M5NjU5MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDctMjcgIENsYXVkaW8g U2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBJbXBsZW1l bnQgY2xpY2sgY291bnRpbmcgaW4gbW91c2UgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ2NzQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXUEUgZG9lcyBub3QgcHJvdmlkZSBjbGljay9kb3Vi bGVjbGljay9ldGMgaW5mb3JtYXRpb24gaW4gaXRzCisgICAgICAgIHBvaW50ZXIgZXZlbnRzLCBi dXQgdGhlc2UgY2FuIGJlIGNvdW50ZWQgaW4gdGhlIGV2ZW50IGZhY3RvcnkuCisKKyAgICAgICAg KiBTaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkV2 ZW50RmFjdG9yeTo6Y2xpY2tDb3VudEZvckV2ZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViRXZl bnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2ZW50KToKKyAgICAgICAgKiBTaGFyZWQvd3BlL1dl YkV2ZW50RmFjdG9yeS5oOgorCiAyMDE3LTA3LTI4ICBKZXJlbXkgSm9uZXMgIDxqZXJlbXlqQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgV2ViIHByZWZpeCBmcm9tIFdlYlZpZGVvRnVsbHNj cmVlbiBhbmQgV2ViUGxheWJhY2tTZXNzaW9uIGNsYXNzZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC93cGUvV2ViRXZlbnRGYWN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hh cmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCmluZGV4IDU1NzFlMWFhYzk3NmQ1NzlkOWFhOTNm MGY3NWI3YzE0Y2EwZjE0NjIuLjY3ZmViODk0ZWY1Nzc5MmM5Y2NmNWU5MzllOTY1YmIwYzk0ZjQ0 NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3Rvcnku Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCkBA IC04NCw2ICs4NCwyNSBAQCBXZWJLZXlib2FyZEV2ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRl V2ViS2V5Ym9hcmRFdmVudChzdHJ1Y3Qgd3BlX2lucHV0X2tleWJvYQogICAgICAgICBtb2RpZmll cnNGb3JFdmVudChldmVudCksIGV2ZW50LT50aW1lKTsKIH0KIAordW5zaWduZWQgV2ViRXZlbnRG YWN0b3J5OjpjbGlja0NvdW50Rm9yRXZlbnQoc3RydWN0IHdwZV9pbnB1dF9wb2ludGVyX2V2ZW50 KiBldmVudCkKK3sKKyAgICBzdGF0aWMgc3RydWN0IHdwZV9pbnB1dF9wb2ludGVyX2V2ZW50IG1f bGFzdENsaWNrRXZlbnQgPSB7IH07CisgICAgc3RhdGljIHVuc2lnbmVkIG1fY2xpY2tDb3VudCA9 IDE7CisKKyAgICAvLyBXZSBhcmUgb25seSBjb25jZXJuZWQgd2l0aCBwcmVzcyBidXR0b24gZXZl bnRzLiBPdGhlciBldmVudHMgZG8gbm90IGFsdGVyIHRoZSBjbGljayBjb3VudC4KKyAgICBpZiAo ZXZlbnQtPnR5cGUgIT0gd3BlX2lucHV0X3BvaW50ZXJfZXZlbnRfdHlwZV9idXR0b24gfHwgZXZl bnQtPnN0YXRlICE9IDEpCisgICAgICAgIHJldHVybiBtX2NsaWNrQ291bnQ7CisKKyAgICBpZiAo ZXZlbnQtPnRpbWUgLSBtX2xhc3RDbGlja0V2ZW50LnRpbWUgPCAxICYmIGV2ZW50LT54ID09IG1f bGFzdENsaWNrRXZlbnQueCAmJiBldmVudC0+eSA9PSBtX2xhc3RDbGlja0V2ZW50LnkgJiYgZXZl bnQtPmJ1dHRvbiA9PSBtX2xhc3RDbGlja0V2ZW50LmJ1dHRvbikKKyAgICAgICAgbV9jbGlja0Nv dW50Kys7CisgICAgZWxzZQorICAgICAgICBtX2NsaWNrQ291bnQgPSAxOworCisgICAgbV9sYXN0 Q2xpY2tFdmVudCA9ICpldmVudDsKKworICAgIHJldHVybiBtX2NsaWNrQ291bnQ7Cit9CisKIFdl Yk1vdXNlRXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2ZW50KHN0cnVjdCB3 cGVfaW5wdXRfcG9pbnRlcl9ldmVudCogZXZlbnQsIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKQog ewogICAgIFdlYkV2ZW50OjpUeXBlIHR5cGUgPSBXZWJFdmVudDo6Tm9UeXBlOwpAQCAtMTEzLDEz ICsxMzIsMTEgQEAgV2ViTW91c2VFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYk1vdXNl RXZlbnQoc3RydWN0IHdwZV9pbnB1dF9wb2ludGVyX2V2ZW4KICAgICAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CiAgICAgfQogCi0gICAgdW5zaWduZWQgY2xpY2tDb3VudCA9ICh0eXBlID09IFdl YkV2ZW50OjpNb3VzZURvd24pID8gMSA6IDA7Ci0KLSAgICAvLyBGSVhNRTogUHJvcGVyIGJ1dHRv biBzdXBwb3J0LiBNb2RpZmllcnMuIGRlbHRhWC9ZL1ouIENsaWNrIGNvdW50LgorICAgIC8vIEZJ WE1FOiBQcm9wZXIgYnV0dG9uIHN1cHBvcnQuIE1vZGlmaWVycy4gZGVsdGFYL1kvWi4KICAgICBX ZWJDb3JlOjpJbnRQb2ludCBwb3NpdGlvbihldmVudC0+eCwgZXZlbnQtPnkpOwogICAgIHBvc2l0 aW9uLnNjYWxlKDEgLyBkZXZpY2VTY2FsZUZhY3Rvcik7CiAgICAgcmV0dXJuIFdlYk1vdXNlRXZl bnQodHlwZSwgYnV0dG9uLCBwb3NpdGlvbiwgcG9zaXRpb24sCi0gICAgICAgIDAsIDAsIDAsIGNs aWNrQ291bnQsIHN0YXRpY19jYXN0PFdlYkV2ZW50OjpNb2RpZmllcnM+KDApLCBldmVudC0+dGlt ZSk7CisgICAgICAgIDAsIDAsIDAsIGNsaWNrQ291bnRGb3JFdmVudChldmVudCksIHN0YXRpY19j YXN0PFdlYkV2ZW50OjpNb2RpZmllcnM+KDApLCBldmVudC0+dGltZSk7CiB9CiAKIFdlYldoZWVs RXZlbnQgV2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJXaGVlbEV2ZW50KHN0cnVjdCB3cGVfaW5w dXRfYXhpc19ldmVudCogZXZlbnQsIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9TaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5oIGIvU291cmNlL1dl YktpdC9TaGFyZWQvd3BlL1dlYkV2ZW50RmFjdG9yeS5oCmluZGV4IGEyYWEwMzQ1MGQzOGYzNGIx MWMxMmZmY2IxZWZiNTBjYWMwZGY3OTEuLjY1NWU0YmMxMWVhZDIxZGNiOGY0ZjY2ZWI3NTM4MGE2 MzFiNDVjOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZh Y3RvcnkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC93cGUvV2ViRXZlbnRGYWN0b3J5LmgK QEAgLTQwLDYgKzQwLDkgQEAgcHVibGljOgogICAgIHN0YXRpYyBXZWJNb3VzZUV2ZW50IGNyZWF0 ZVdlYk1vdXNlRXZlbnQoc3RydWN0IHdwZV9pbnB1dF9wb2ludGVyX2V2ZW50KiwgZmxvYXQgZGV2 aWNlU2NhbGVGYWN0b3IpOwogICAgIHN0YXRpYyBXZWJXaGVlbEV2ZW50IGNyZWF0ZVdlYldoZWVs RXZlbnQoc3RydWN0IHdwZV9pbnB1dF9heGlzX2V2ZW50KiwgZmxvYXQgZGV2aWNlU2NhbGVGYWN0 b3IpOwogICAgIHN0YXRpYyBXZWJUb3VjaEV2ZW50IGNyZWF0ZVdlYlRvdWNoRXZlbnQoc3RydWN0 IHdwZV9pbnB1dF90b3VjaF9ldmVudCosIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKTsKKworcHJp dmF0ZToKKyAgICBzdGF0aWMgdW5zaWduZWQgY2xpY2tDb3VudEZvckV2ZW50KHN0cnVjdCB3cGVf aW5wdXRfcG9pbnRlcl9ldmVudCopOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggZmZmYzQ5ZTVhNTM1NTM2MjIzNDRiMTk1NDY5ZjhmNmRkZDkzZjk4My4uMTlkYjE3OTE3NDU4 OGEyZjVmODdiYzQyNzg1Nzk4ZTMyOGQxZjRhMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3 LTA3LTI3ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAg ICAgW1dQRV0gSW1wbGVtZW50IGNsaWNrIGNvdW50aW5nIGluIG1vdXNlIGV2ZW50cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0Njc0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93cGUv VGVzdEV4cGVjdGF0aW9uczogUmVtb3ZlIHRlc3RzIHRoYXQgcGFzcyBub3cKKyAgICAgICAgKiBw bGF0Zm9ybS93cGUvZmFzdC9ldmVudHMvdXBkYXRlTGF5b3V0Rm9ySGl0VGVzdC1leHBlY3RlZC50 eHQ6IEFkZGVkLgorCiAyMDE3LTA3LTI4ICBDbGF1ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGln YWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gSW1wbGVtZW50IEV2ZW50U2VuZGVyUHJveHkgaW4g V1RSCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9u cyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDZjODEy MzQxZjcwYWNiZjUxZjU4N2U2OTEwMDA0ZGE0NTMyZmFiYmYuLjU4N2FkYzRjOWMxNzEzZWJmM2Nm ZTk1NjQ5YWIzNDZkMzViM2JhNzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dw ZS9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhw ZWN0YXRpb25zCkBAIC0yNzgsMTMgKzI3OCw2IEBAIHdlYmtpdC5vcmcvYi8xNzQ2NzMgZmFzdC9l dmVudHMva2V5Ym9hcmRldmVudC1rZXkuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE3 NDY3MyBmYXN0L2V2ZW50cy9rZXktZXZlbnRzLWluLWlucHV0LWJ1dHRvbi5odG1sIFsgRmFpbHVy ZSBdCiB3ZWJraXQub3JnL2IvMTc0NjczIGZhc3QvZXZlbnRzL2tleS1ldmVudHMtaW4taW5wdXQt dGV4dC5odG1sIFsgRmFpbHVyZSBdCiAKLSMgY2xpY2tDb3VudCByZWxhdGVkIGZhaWx1cmVzCi13 ZWJraXQub3JnL2IvMTc0Njc0IGZhc3QvZXZlbnRzL2NsaWNrLWNvdW50Lmh0bWwgWyBGYWlsdXJl IF0KLXdlYmtpdC5vcmcvYi8xNzQ2NzQgZmFzdC9ldmVudHMvZGJsY2xpY2stYWRkRXZlbnRMaXN0 ZW5lci5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTc0Njc0IGZhc3QvZXZlbnRzL21v dXNlLWNsaWNrLWV2ZW50cy5odG1sIFsgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTc0Njc0IGZh c3QvZXZlbnRzL3NlbGVjdHN0YXJ0LWJ5LWRvdWJsZS10cmlwbGUtY2xpY2tzLmh0bWwgWyBGYWls dXJlIF0KLXdlYmtpdC5vcmcvYi8xNzQ2NzQgZmFzdC9ldmVudHMvem9vbS1kYmxjbGljay5odG1s IFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi84NDY5MiBmYXN0L2V2ZW50cy9hdHRlbXB0LXNj cm9sbC13aXRoLW5vLXNjcm9sbGJhcnMuaHRtbCBbIEZhaWx1cmUgXQogCiAjIEVOQUJMRV9QUk9Y SU1JVFlfRVZFTlRTIGlzIE9GRiBpbiBXUEUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS93cGUvZmFzdC9ldmVudHMvdXBkYXRlTGF5b3V0Rm9ySGl0VGVzdC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvZmFzdC9ldmVudHMvdXBkYXRlTGF5b3V0Rm9ySGl0 VGVzdC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYWNlZmIyNjNhZjBjODExMmI5Yjg5MjljMjdi NmRiZGViMTBhOGM5NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3dw ZS9mYXN0L2V2ZW50cy91cGRhdGVMYXlvdXRGb3JIaXRUZXN0LWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDE4IEBACitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMzY6IFR5cGVFcnJvcjogbnVsbCBpcyBu b3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICd0cmlhbmdsZVNwYW4ubmV4dFNpYmxpbmcubmV4dFNp YmxpbmcubmV4dFNpYmxpbmcubmV4dFNpYmxpbmcuc3R5bGUnKQorQ09OU09MRSBNRVNTQUdFOiBs aW5lIDQwOiBUeXBlRXJyb3I6IG51bGwgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAndHJp YW5nbGVTcGFuLm5leHRTaWJsaW5nLm5leHRTaWJsaW5nLm5leHRTaWJsaW5nLm5leHRTaWJsaW5n LnN0eWxlJykKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAzNjogVHlwZUVycm9yOiBudWxsIGlzIG5v dCBhbiBvYmplY3QgKGV2YWx1YXRpbmcgJ3RyaWFuZ2xlU3Bhbi5uZXh0U2libGluZy5uZXh0U2li bGluZy5uZXh0U2libGluZy5uZXh0U2libGluZy5zdHlsZScpCitDT05TT0xFIE1FU1NBR0U6IGxp bmUgNDA6IFR5cGVFcnJvcjogbnVsbCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICd0cmlh bmdsZVNwYW4ubmV4dFNpYmxpbmcubmV4dFNpYmxpbmcubmV4dFNpYmxpbmcubmV4dFNpYmxpbmcu c3R5bGUnKQorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAs MCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxv Y2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0 ICg4LDgpIHNpemUgNzg0eDU4NAorICAgICAgUmVuZGVyQmxvY2sgKGZsb2F0aW5nKSB7RElWfSBh dCAoNSw1KSBzaXplIDc5eDI3IFtiZ2NvbG9yPSNBREQ4RTZdCisgICAgICAgIFJlbmRlcklubGlu ZSB7U1BBTn0gYXQgKDAsMCkgc2l6ZSA4eDE3CisgICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9 IGF0ICg1LDUpIHNpemUgOHgxNworICAgICAgICAgICAgdGV4dCBydW4gYXQgKDUsNSkgd2lkdGgg ODogIlx4ezI1Qjh9IgorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDEzLDUpIHNpemUg NjF4MTcKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMTMsNSkgd2lkdGggNjE6ICIgUHJvamVjdCIK KyAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCitzZWxlY3Rpb24g c3RhcnQ6IHBvc2l0aW9uIDAgb2YgY2hpbGQgMSB7U1BBTn0gb2YgY2hpbGQgMyB7RElWfSBvZiBi b2R5CitzZWxlY3Rpb24gZW5kOiAgIHBvc2l0aW9uIDAgb2YgY2hpbGQgMSB7I3RleHR9IG9mIGNo aWxkIDMge0RJVn0gb2YgY2hpbGQgMyB7RElWfSBvZiBib2R5Cg==