174653 2017-07-19 09:43:21 -0700 [Win] Async image tests are failing. 2023-10-27 18:10:30 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 174451 1 pvollan pvollan achristensen ahmad.saleem792 bfulgham mjs sabouhallawa oldest_to_newest 1330376 0 pvollan 2017-07-19 09:43:21 -0700 fast/images/async-image-background-image-repeated.html [ Timeout ] fast/images/async-image-background-image.html [ Timeout ] fast/images/async-image-body-background-image.html [ Timeout ] fast/images/async-image-multiple-clients-repaint.html [ Timeout ] fast/images/sprite-sheet-image-draw.html [ Timeout ] 1330379 1 315925 pvollan 2017-07-19 09:45:26 -0700 Created attachment 315925 Patch 1330509 2 sabouhallawa 2017-07-19 16:02:36 -0700 Please hold on this patch. I am renaming the flag because the new name PaintBehaviorAllowAsyncImageDecoding caused too much confusion. I am returning it back to its original name PaintBehaviorSnapshotting and I am adding a new one which is named PaintBehaviorTileFirstPaint. 1330514 3 pvollan 2017-07-19 16:33:30 -0700 (In reply to Said Abou-Hallawa from comment #2) > Please hold on this patch. I am renaming the flag because the new name > PaintBehaviorAllowAsyncImageDecoding caused too much confusion. I am > returning it back to its original name PaintBehaviorSnapshotting and I am > adding a new one which is named PaintBehaviorTileFirstPaint. Ok, thanks Said! 1331771 4 pvollan 2017-07-24 15:53:27 -0700 Updated test expectations in <https://trac.webkit.org/changeset/219844/webkit>. 1340117 5 bfulgham 2017-08-18 09:49:41 -0700 Is this patch in the right state now? Can we land it, Said? 1340147 6 sabouhallawa 2017-08-18 11:07:32 -0700 (In reply to Brent Fulgham from comment #5) > Is this patch in the right state now? Can we land it, Said? No. The enum names have been changed. Please have a look at the changes of <http://trac.webkit.org/changeset/219876> in WebKitLegacy/mac/WebView/WebFrame.mm. 1657706 7 315925 mjs 2020-05-30 19:32:59 -0700 Comment on attachment 315925 Patch This patch needs to be updated to apply cleanly. 1988156 8 ahmad.saleem792 2023-10-27 18:10:30 -0700 Seems to be AppleWin port related, I think we can mark this as 'RESOLVED CONFIGURATION CHANGED'. 315925 2017-07-19 09:45:26 -0700 2020-05-30 19:32:59 -0700 Patch bug-174653-20170719184525.patch text/plain 2808 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxOTY1NikKKysrIFNv dXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE3IEBACisyMDE3LTA3LTE5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4K KworICAgICAgICBbV2luXSBBc3luYyBpbWFnZSB0ZXN0cyBhcmUgZmFpbGluZy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDY1MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHdlIGFyZSBub3QgcHJp bnRpbmcsIHdlIHNob3VsZCBhbGxvdyBhc3luYyBpbWFnZSBkZWNvZGluZy4KKworICAgICAgICAq IFdlYlZpZXcuY3BwOgorICAgICAgICAoV2ViVmlldzo6cGFpbnRJbnRvQmFja2luZ1N0b3JlKToK KyAgICAgICAgKFdlYlZpZXc6OldlYlZpZXdXbmRQcm9jKToKKyAgICAgICAgKiBXZWJWaWV3Lmg6 CisKIDIwMTctMDctMTggIE1hdHQgTGV3aXMgIDxqbGV3aXMzQGFwcGxlLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjE5NjEwLgpJbmRleDogU291cmNlL1dlYktpdExl Z2FjeS93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdExlZ2FjeS93 aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDIxOTYzNSkKKysrIFNvdXJjZS9XZWJLaXRMZWdhY3kv d2luL1dlYlZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDIxLDggKzE0MjEsMjcgQEAgdm9p ZCBXZWJWaWV3OjpwYWludEludG9CYWNraW5nU3RvcmUoRnJhbQogICAgICAgICBnYy5zYXZlKCk7 CiAgICAgICAgIGdjLnNjYWxlKEZsb2F0U2l6ZShzY2FsZUZhY3Rvciwgc2NhbGVGYWN0b3IpKTsK ICAgICAgICAgZ2MuY2xpcChsb2dpY2FsRGlydHlSZWN0KTsKKworICAgICAgICBQYWludEJlaGF2 aW9yIG9sZEJlaGF2aW9yID0gZnJhbWVWaWV3LT5wYWludEJlaGF2aW9yKCk7CisgICAgICAgIFBh aW50QmVoYXZpb3IgcGFpbnRCZWhhdmlvciA9IG9sZEJlaGF2aW9yOworCisgICAgICAgIC8vIElm IHRoaXMgbWV0aG9kIGlzIGNhbGxlZCBmcm9tIGEgZnJhbWUgb3RoZXIgdGhhbiB0aGUgbWFpbiBm cmFtZSwgd2Ugc2hvdWxkIGluaGVyaXQgcGFpbnQgYmVoYXZpb3IKKyAgICAgICAgLy8gZnJvbSB0 aGUgcGFyZW50IGZyYW1lLiBTZWUgX2RyYXdSZWN0IG1ldGhvZCBpbiBTb3VyY2VcV2ViS2l0TGVn YWN5XG1hY1xXZWJWaWV3XFdlYkZyYW1lLm1tLgorICAgICAgICBBU1NFUlQoIWZyYW1lVmlldy0+ ZnJhbWUoKS50cmVlKCkucGFyZW50KCkpOworCisgICAgICAgIGlmIChtX3ByaW50aW5nKQorICAg ICAgICAgICAgcGFpbnRCZWhhdmlvciB8PSBQYWludEJlaGF2aW9yRmxhdHRlbkNvbXBvc2l0aW5n TGF5ZXJzOworICAgICAgICBlbHNlCisgICAgICAgICAgICBwYWludEJlaGF2aW9yIHw9IFBhaW50 QmVoYXZpb3JBbGxvd0FzeW5jSW1hZ2VEZWNvZGluZzsKKworICAgICAgICBmcmFtZVZpZXctPnNl dFBhaW50QmVoYXZpb3IocGFpbnRCZWhhdmlvcik7CisKICAgICAgICAgZnJhbWVWaWV3LT5wYWlu dChnYywgbG9naWNhbERpcnR5UmVjdCk7CisKKyAgICAgICAgZnJhbWVWaWV3LT5zZXRQYWludEJl aGF2aW9yKG9sZEJlaGF2aW9yKTsKKwogICAgICAgICBnYy5yZXN0b3JlKCk7CisKICAgICAgICAg aWYgKG1fc2hvdWxkSW52ZXJ0Q29sb3JzKQogICAgICAgICAgICAgZ2MuZmlsbFJlY3QobG9naWNh bERpcnR5UmVjdCwgQ29sb3I6OndoaXRlLCBDb21wb3NpdGVEaWZmZXJlbmNlKTsKICAgICB9CkBA IC0yNTc5LDcgKzI1OTgsOSBAQCBMUkVTVUxUIENBTExCQUNLIFdlYlZpZXc6OldlYlZpZXdXbmRQ cm9jCiAgICAgICAgICAgICBsUmVzdWx0ID0gMTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICBjYXNlIFdNX1BSSU5UQ0xJRU5UOgorICAgICAgICAgICAgd2ViVmlldy0+bV9wcmludGluZyA9 IHRydWU7CiAgICAgICAgICAgICB3ZWJWaWV3LT5wYWludCgoSERDKXdQYXJhbSwgbFBhcmFtKTsK KyAgICAgICAgICAgIHdlYlZpZXctPm1fcHJpbnRpbmcgPSBmYWxzZTsKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBjYXNlIFdNX0RFU1RST1k6CiAgICAgICAgICAgICB3ZWJWaWV3LT5zZXRJ c0JlaW5nRGVzdHJveWVkKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJWaWV3 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViVmlldy5oCShyZXZp c2lvbiAyMTk2MzUpCisrKyBTb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJWaWV3LmgJKHdvcmtp bmcgY29weSkKQEAgLTcxNCw2ICs3MTQsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgYm9vbCBtX25leHRE aXNwbGF5SXNTeW5jaHJvbm91cyB7IGZhbHNlIH07CiAgICAgYm9vbCBtX3VzZXNMYXllcmVkV2lu ZG93IHsgZmFsc2UgfTsKICAgICBib29sIG1fbmVlZHNEaXNwbGF5IHsgZmFsc2UgfTsKKyAgICBi b29sIG1fcHJpbnRpbmcgeyBmYWxzZSB9OwogCiAgICAgSENVUlNPUiBtX2xhc3RTZXRDdXJzb3Ig eyBudWxscHRyIH07CiAK