174591 2017-07-17 11:28:37 -0700 Layout Test media/video-add-autoplay-user-gesture.html is flaky. 2018-07-31 09:57:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=174373 InRadar P2 Normal --- 1 jlewis3 ryanhaddad commit-queue darin eric.carlson jer.noble ryanhaddad webkit-bug-importer oldest_to_newest 1329633 0 jlewis3 2017-07-17 11:28:37 -0700 media/video-add-autoplay-user-gesture.html is a flaky failure on macOS Sierra Release WK2. It looks to have been flaky since being added. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-add-autoplay-user-gesture.html https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r219562%20(2990)/results.html Diff: --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-add-autoplay-user-gesture-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/video-add-autoplay-user-gesture-actual.txt @@ -3,6 +3,6 @@ RUN(video.src = findMediaFile("video", "content/test")) RUN(video.setAttribute("autoplay", "")) RUN(document.body.appendChild(video)) -EVENT(playing) +FAIL: did not end fast enough END OF TEST 1331626 1 jer.noble 2017-07-24 09:17:22 -0700 Looks like we should just remove the "failTestIn(1000)" call and allow the test to take the full timeout value (20s) before failing. 1446557 2 ryanhaddad 2018-07-31 08:59:54 -0700 I can easily reproduce this failure on Mojave with: run-webkit-tests media/video-add-autoplay-user-gesture.html -fg --iter 25 1446558 3 346170 ryanhaddad 2018-07-31 09:05:26 -0700 Created attachment 346170 Patch 1446559 4 ryanhaddad 2018-07-31 09:06:16 -0700 With the attached patch, the test passes 100/100 times. 1446576 5 346170 commit-queue 2018-07-31 09:52:48 -0700 Comment on attachment 346170 Patch Clearing flags on attachment: 346170 Committed r234428: <https://trac.webkit.org/changeset/234428> 1446577 6 commit-queue 2018-07-31 09:52:50 -0700 All reviewed patches have been landed. Closing bug. 1446581 7 webkit-bug-importer 2018-07-31 09:57:47 -0700 <rdar://problem/42775727> 346170 2018-07-31 09:05:26 -0700 2018-07-31 09:52:48 -0700 Patch bug-174591-20180731090525.patch text/plain 1335 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MzgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzlmZDgzZjJkNjE2ZTgzZTIyYmY2 ZWE1MDQ2OGFjODc4MTEwNTgzNC4uYjNlZDVlMzEzNWFiZTk3YWI0ZDBjNzUwMjRhZWQyMDk5NTUy ZmQzNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA3LTMxICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBUZXN0IG1lZGlhL3ZpZGVvLWFk ZC1hdXRvcGxheS11c2VyLWdlc3R1cmUuaHRtbCBpcyBmbGFreS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NDU5MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSB0aGUgMTAwMG1zIHJlc3RyaWN0 aW9uIGZvciB0aGlzIHRlc3QgdG8gY29tcGxldGUgaW4gb3JkZXIgdG8gZWxpbWluYXRlIGZsYWtp bmVzcy4KKworICAgICAgICAqIG1lZGlhL3ZpZGVvLWFkZC1hdXRvcGxheS11c2VyLWdlc3R1cmUu aHRtbDoKKwogMjAxOC0wNy0zMCAgSnVzdGluIEZhbiAgPGp1c3Rpbl9mYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtXZWJHTDJdIFN1cHBvcnQgY29tcGlsYXRpb24gb2YgR0xTTCBFUyB2ZXJzaW9u IDMwMCBzaGFkZXJzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1hZGQtYXV0 b3BsYXktdXNlci1nZXN0dXJlLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1hZGQtYXV0 b3BsYXktdXNlci1nZXN0dXJlLmh0bWwKaW5kZXggNTlkNWEzNmZmZDNjODEwM2IzZjc4NjI4YmI5 YWVhYjlhY2M0YjAzZC4uZGNhYjM3NGQ5MjhmZGE2OGQwYTJkZGUxOGZmODAzZDhlODI2YjI0MyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tYWRkLWF1dG9wbGF5LXVzZXItZ2Vz dHVyZS5odG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWFkZC1hdXRvcGxheS11c2Vy LWdlc3R1cmUuaHRtbApAQCAtMTMsNyArMTMsNiBAQAogICAgICAgICAgICAgcnVuKCd2aWRlby5z ZXRBdHRyaWJ1dGUoImF1dG9wbGF5IiwgIiIpJyk7CiAgICAgICAgICAgICBydW4oJ2RvY3VtZW50 LmJvZHkuYXBwZW5kQ2hpbGQodmlkZW8pJyk7CiAgICAgICAgICAgICB3YWl0Rm9yRXZlbnRBbmRF bmQoJ3BsYXlpbmcnKTsKLSAgICAgICAgICAgIGZhaWxUZXN0SW4oMTAwMCk7CiAgICAgICAgIH0p OwogICAgIH0KICAgICA8L3NjcmlwdD4K