174540 2017-07-15 01:13:24 -0700 [GTK] Sort inspector GResource manifest to ensure reproducible builds 2017-07-16 05:51:31 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkitbmw webkit-unassigned aperez bugs-noreply clopez commit-queue mcatanzaro zan oldest_to_newest 1329156 0 webkitbmw 2017-07-15 01:13:24 -0700 When building the webkitgtk3 package for openSUSE, it produces random variations in the resulting libwebkitgtk-3.0.so.0.22.17 because GResourceBundle.xml is generated via python's glob.glob function that returns entries in undeterministic filesystem order. 1329157 1 315536 webkitbmw 2017-07-15 01:15:32 -0700 Created attachment 315536 fixing patch 1329163 2 315536 aperez 2017-07-15 03:35:37 -0700 Comment on attachment 315536 fixing patch Informal review: I would r+ this without doubt. Also: Having reproducible builds is IMHO a noble goal, so we should help from our side merging patches upstream whenever possible :-) 1329164 3 aperez 2017-07-15 03:39:15 -0700 Bernhard: I have CC'd a few people to try and get the patch landed. If you used “webkit-patch upload”, a one nice tip for next time is passing “--suggest-reviewers --request-commit” to it, which will get reviewers CC'd automatically, and ask the automated commit-queue to land your patch. And many thanks for posting the patch! 1329180 4 mcatanzaro 2017-07-15 08:07:18 -0700 Thanks. It also needs a ChangeLog entry ('Tools/Scripts/prepare-ChangeLog -b 174540') 1329181 5 mcatanzaro 2017-07-15 08:07:59 -0700 Also note that Fedora and Debian have both removed their old/insecure webkitgtk3 packages. Now would be a good time for openSUSE to follow suit. 1329235 6 315565 webkitbmw 2017-07-15 13:15:10 -0700 Created attachment 315565 patch with changelog entry 1329245 7 mcatanzaro 2017-07-15 15:33:49 -0700 Sorry, I forgot to change the title... please change the title in the ChangeLog, then we can land this. 1329328 8 315594 webkitbmw 2017-07-15 22:24:29 -0700 Created attachment 315594 patch with updated changelog entry 1329365 9 commit-queue 2017-07-16 05:07:31 -0700 The commit-queue encountered the following flaky tests while processing attachment 315594: storage/indexeddb/modern/new-database-after-user-delete.html bug 174354 (author: beidson@apple.com) The commit-queue is continuing to process your patch. 1329366 10 commit-queue 2017-07-16 05:07:32 -0700 The commit-queue encountered the following flaky tests while processing attachment 315594: The commit-queue is continuing to process your patch. 1329367 11 315594 commit-queue 2017-07-16 05:51:30 -0700 Comment on attachment 315594 patch with updated changelog entry Clearing flags on attachment: 315594 Committed r219546: <http://trac.webkit.org/changeset/219546> 1329368 12 commit-queue 2017-07-16 05:51:31 -0700 All reviewed patches have been landed. Closing bug. 315536 2017-07-15 01:15:32 -0700 2017-07-15 01:15:32 -0700 fixing patch 0001-GTK-Sort-input-file-list.patch text/plain 1195 webkitbmw RnJvbSA5YmUzOWI2MzllNDYwNWQ2MTA1MTUzMzdjMWQyYzI5MGM5YWM2ZmEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiQmVybmhhcmQgTS4gV2llZGVtYW5uIiA8YndpZWRlbWFubkBz dXNlLmRlPgpEYXRlOiBTYXQsIDE1IEp1bCAyMDE3IDEwOjA1OjMxICswMjAwClN1YmplY3Q6IFtQ QVRDSF0gW0dUS10gU29ydCBpbnB1dCBmaWxlIGxpc3QKCmh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzQ1NDAKU29ydCBpbnB1dCBmaWxlIGxpc3QKaW4gb3JkZXIgdG8g Z2VuZXJhdGUgZmlsZXMKR1Jlc291cmNlQnVuZGxlLnhtbApHUmVzb3VyY2VCdW5kbGUuYwpsaWJ3 ZWJraXRndGstMy4wLnNvLjAuMjIuMTcKaW4gYSByZXByb2R1Y2libGUgd2F5CgpTZWUgaHR0cHM6 Ly9yZXByb2R1Y2libGUtYnVpbGRzLm9yZy8gZm9yIHdoeSB0aGlzIG1hdHRlcnMuCgpUaGlzIGlz IHJlcXVpcmVkIGJlY2F1c2Ugb2YgaHR0cDovL2J1Z3MucHl0aG9uLm9yZy9pc3N1ZTMwNDYxCi0t LQogVG9vbHMvZ3RrL2dlbmVyYXRlLWluc3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3QucHkgfCAy ICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9Ub29scy9ndGsvZ2VuZXJhdGUtaW5zcGVjdG9yLWdyZXNvdXJjZS1tYW5pZmVzdC5w eSBiL1Rvb2xzL2d0ay9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5Cmlu ZGV4IDAzMDYwY2ZhMi4uY2UyM2I2NjkzIDEwMDc1NQotLS0gYS9Ub29scy9ndGsvZ2VuZXJhdGUt aW5zcGVjdG9yLWdyZXNvdXJjZS1tYW5pZmVzdC5weQorKysgYi9Ub29scy9ndGsvZ2VuZXJhdGUt aW5zcGVjdG9yLWdyZXNvdXJjZS1tYW5pZmVzdC5weQpAQCAtMjgsNyArMjgsNyBAQCBkZWYgZ2V0 X2ZpbGVuYW1lcyhhcmdzKToKICAgICBmaWxlbmFtZXMgPSBbXQogCiAgICAgZm9yIHBhdHRlcm4g aW4gYXJnczoKLSAgICAgICAgcGF0aHMgPSBnbG9iLmdsb2IocGF0dGVybikKKyAgICAgICAgcGF0 aHMgPSBzb3J0ZWQoZ2xvYi5nbG9iKHBhdHRlcm4pKQogICAgICAgICBmb3IgZmlsZW5hbWUgaW4g cGF0aHM6CiAgICAgICAgICAgICBiYXNlX2Rpcl9pbmRleCA9IGZpbGVuYW1lLnJmaW5kKEJBU0Vf RElSKQogICAgICAgICAgICAgaWYgYmFzZV9kaXJfaW5kZXggIT0gLTE6Ci0tIAoyLjEyLjMKCg== 315565 2017-07-15 13:15:10 -0700 2017-07-15 22:24:29 -0700 patch with changelog entry webkitgtk3.patch text/plain 1101 webkitbmw ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZWQw Zjg2YjIuLmQzNGEwMjU0NSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA3LTE1ICBCZXJuaGFyZCBNLiBXaWVk ZW1hbm4gIDxid2llZGVtYW5uQHN1c2UuZGU+CisKKyAgICAgICAgd2Via2l0Z3RrMyBwYWNrYWdl IGRvZXMgbm90IGJ1aWxkIHJlcHJvZHVjaWJseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc0NTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBndGsvZ2VuZXJhdGUtaW5zcGVjdG9yLWdyZXNvdXJjZS1t YW5pZmVzdC5weToKKyAgICAgICAgKGdldF9maWxlbmFtZXMpOiBzb3J0IGxpc3Qgb2YgaW5wdXQg ZmlsZXMKKwogMjAxNy0wNy0xNCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+ CiAKICAgICAgICAgQWRkIGlPUyAxMSBTUEkKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9nZW5lcmF0 ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5IGIvVG9vbHMvZ3RrL2dlbmVyYXRlLWlu c3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3QucHkKaW5kZXggMDMwNjBjZmEyLi5jZTIzYjY2OTMg MTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlm ZXN0LnB5CisrKyBiL1Rvb2xzL2d0ay9nZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlm ZXN0LnB5CkBAIC0yOCw3ICsyOCw3IEBAIGRlZiBnZXRfZmlsZW5hbWVzKGFyZ3MpOgogICAgIGZp bGVuYW1lcyA9IFtdCiAKICAgICBmb3IgcGF0dGVybiBpbiBhcmdzOgotICAgICAgICBwYXRocyA9 IGdsb2IuZ2xvYihwYXR0ZXJuKQorICAgICAgICBwYXRocyA9IHNvcnRlZChnbG9iLmdsb2IocGF0 dGVybikpCiAgICAgICAgIGZvciBmaWxlbmFtZSBpbiBwYXRoczoKICAgICAgICAgICAgIGJhc2Vf ZGlyX2luZGV4ID0gZmlsZW5hbWUucmZpbmQoQkFTRV9ESVIpCiAgICAgICAgICAgICBpZiBiYXNl X2Rpcl9pbmRleCAhPSAtMToK 315594 2017-07-15 22:24:29 -0700 2017-07-16 05:51:30 -0700 patch with updated changelog entry webkitgtk3.patch text/plain 1124 webkitbmw ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZWQw Zjg2YjIuLjdiYjU2OTcyMiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA3LTE1ICBCZXJuaGFyZCBNLiBXaWVk ZW1hbm4gIDxid2llZGVtYW5uQHN1c2UuZGU+CisKKyAgICAgICAgW0dUS10gU29ydCBpbnNwZWN0 b3IgR1Jlc291cmNlIG1hbmlmZXN0IHRvIGVuc3VyZSByZXByb2R1Y2libGUgYnVpbGRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzQ1NDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGd0ay9nZW5lcmF0 ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5OgorICAgICAgICAoZ2V0X2ZpbGVuYW1l cyk6IHNvcnQgbGlzdCBvZiBpbnB1dCBmaWxlcworCiAyMDE3LTA3LTE0ICBKb25hdGhhbiBCZWRh cmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgaU9TIDExIFNQSQpkaWZmIC0t Z2l0IGEvVG9vbHMvZ3RrL2dlbmVyYXRlLWluc3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3QucHkg Yi9Ub29scy9ndGsvZ2VuZXJhdGUtaW5zcGVjdG9yLWdyZXNvdXJjZS1tYW5pZmVzdC5weQppbmRl eCAwMzA2MGNmYTIuLmNlMjNiNjY5MyAxMDA3NTUKLS0tIGEvVG9vbHMvZ3RrL2dlbmVyYXRlLWlu c3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3QucHkKKysrIGIvVG9vbHMvZ3RrL2dlbmVyYXRlLWlu c3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3QucHkKQEAgLTI4LDcgKzI4LDcgQEAgZGVmIGdldF9m aWxlbmFtZXMoYXJncyk6CiAgICAgZmlsZW5hbWVzID0gW10KIAogICAgIGZvciBwYXR0ZXJuIGlu IGFyZ3M6Ci0gICAgICAgIHBhdGhzID0gZ2xvYi5nbG9iKHBhdHRlcm4pCisgICAgICAgIHBhdGhz ID0gc29ydGVkKGdsb2IuZ2xvYihwYXR0ZXJuKSkKICAgICAgICAgZm9yIGZpbGVuYW1lIGluIHBh dGhzOgogICAgICAgICAgICAgYmFzZV9kaXJfaW5kZXggPSBmaWxlbmFtZS5yZmluZChCQVNFX0RJ UikKICAgICAgICAgICAgIGlmIGJhc2VfZGlyX2luZGV4ICE9IC0xOgo=